coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 SKUs
by Sumeet R Pawnikar (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: David Wu, Tim Wawrzynczak, Ren Kuo, Nick Vaccaro, Alan Huang, EricR Lai. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62466 ) Change subject: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 SKUs ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: > @Sumeet, in variant_update_power_limits not change the soc_config value, only update the dpft settin […] I feel it's fine. File src/mainboard/google/brya/variants/kano/overridetree.cb: https://review.coreboot.org/c/coreboot/+/62466/comment/ac3a009e_0c141ab5 PS3, Line 134: 20000 Lowering PL1 max power value will impact the overall system performance. https://review.coreboot.org/c/coreboot/+/62466/comment/03d6aeb9_06c96221 PS3, Line 141: 43000 Normally, we keep max and min power value the same for PL2. So, I would suggest if you are changing PL2 max from 40000mW to 43000mW, change PL2 min as well to 43000mW. File src/mainboard/google/brya/variants/kano/ramstage.c: https://review.coreboot.org/c/coreboot/+/62466/comment/1f4defef_578d6ae7 PS3, Line 10: 43000 Normally, we keep max and min value the same for PL2. So, I would suggest if you are changing PL2 max from 40000mW to 43000mW, change PL2 min as well to 43000mW. https://review.coreboot.org/c/coreboot/+/62466/comment/95d8b4a9_89871f7f PS3, Line 10: 20000 Do you mean these new values are suggested by your thermal team for this platform ? Is that the reason these values are changed here ? Can you please add me in this bug, I can't access it. I would like to understand the reason behind this change. Thanks. If you are lowering the PL1 max value from 28000mW to 20000mW, it will impact the overall system performance. Did you test with any performance benchmarks with this new value ? Did you check any impact ? -- To view, visit https://review.coreboot.org/c/coreboot/+/62466 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib82e2dbacd6cbc39390eb28f27ca9db48d6c215c Gerrit-Change-Number: 62466 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:11:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: Reduce PSysMax to 11 A
by Angel Pons (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: YH Lin, Paul Menzel, Tim Wawrzynczak, Zoey Wu, Zhuohao Lee, Raihow Shi, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62374 ) Change subject: mb/google/brask/variants/moli: Reduce PSysMax to 11 A ...................................................................... Patch Set 9: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62374/comment/5f867fd8_bc252c29 PS2, Line 9: set psys_imax_ma to 11000 mA for moli > Maybe: […] I'm pretty sure this is the rating of the power supply (AC adapter) Commit Message: https://review.coreboot.org/c/coreboot/+/62374/comment/bed4a196_92212336 PS9, Line 9: 214.5W Wow, that's a lot of power. -- To view, visit https://review.coreboot.org/c/coreboot/+/62374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f4813f3527123a590d80b4a6e49d76ebb71c99 Gerrit-Change-Number: 62374 Gerrit-PatchSet: 9 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Don't report a battery capacity higher than desig...
by Sean Rhodes (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Andy Pont. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62514 ) Change subject: ec/starlabs/merlin: Don't report a battery capacity higher than design capacity ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Out of curiosity, where does the value for B1FC come from? I guess it comes from the EC, which eithe […] Yup, from the EC via battery controller. -- To view, visit https://review.coreboot.org/c/coreboot/+/62514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3e4769c809b69e0a237b5f043e6c41c12d53752 Gerrit-Change-Number: 62514 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:05:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Don't report a battery capacity higher than desig...
by Angel Pons (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Sean Rhodes, Andy Pont. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62514 ) Change subject: ec/starlabs/merlin: Don't report a battery capacity higher than design capacity ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Out of curiosity, where does the value for B1FC come from? I guess it comes from the EC, which either calculates the value or gets it from a smart battery controller. -- To view, visit https://review.coreboot.org/c/coreboot/+/62514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3e4769c809b69e0a237b5f043e6c41c12d53752 Gerrit-Change-Number: 62514 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:04:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/nivviks: Correct GPIO S7 config
by Usha P (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Kangheui Won, Paul Menzel, Rizwan Qureshi, Reka Norman, Tim Wawrzynczak, Krishna P Bhat D. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62513 ) Change subject: mb/google/brya/var/nivviks: Correct GPIO S7 config ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62513/comment/f0192db9_1d7aac85 PS1, Line 10: configured to GPP_S6 > 1. Please add a dot/period at the end of sentences. […] GPP_S6 was configured twice instead of GPP_S7. Hence corrected it to configure GPP_S7 as per the schematics. -- To view, visit https://review.coreboot.org/c/coreboot/+/62513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67f3d3df06916f8163ff4a66f1f681d1eba27137 Gerrit-Change-Number: 62513 Gerrit-PatchSet: 2 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 10:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/nivviks: Correct GPIO S7 config
by Usha P (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Kangheui Won, Rizwan Qureshi, Reka Norman, Tim Wawrzynczak, Krishna P Bhat D, Usha P. Hello build bot (Jenkins), Kangheui Won, Rizwan Qureshi, Reka Norman, Tim Wawrzynczak, Krishna P Bhat D, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62513 to look at the new patch set (#2). Change subject: mb/google/brya/var/nivviks: Correct GPIO S7 config ...................................................................... mb/google/brya/var/nivviks: Correct GPIO S7 config Update nivviks gpio file to configure GPP_S7 as per schematics which is currently configured to GPP_S6. Signed-off-by: Usha P <usha.p(a)intel.com> Change-Id: I67f3d3df06916f8163ff4a66f1f681d1eba27137 --- M src/mainboard/google/brya/variants/nivviks/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/62513/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67f3d3df06916f8163ff4a66f1f681d1eba27137 Gerrit-Change-Number: 62513 Gerrit-PatchSet: 2 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/nivviks: Correct GPIO S7 config
by Paul Menzel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Kangheui Won, Rizwan Qureshi, Reka Norman, Tim Wawrzynczak, Krishna P Bhat D, Usha P. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62513 ) Change subject: mb/google/brya/var/nivviks: Correct GPIO S7 config ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62513/comment/bdb0d5b2_ea475ac6 PS1, Line 10: configured to GPP_S6 1. Please add a dot/period at the end of sentences. 2. Please mention the source – probably schematics. (Were they updated?) -- To view, visit https://review.coreboot.org/c/coreboot/+/62513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67f3d3df06916f8163ff4a66f1f681d1eba27137 Gerrit-Change-Number: 62513 Gerrit-PatchSet: 1 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 10:14:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/nivviks: Configure WCAM DMIC data pin
by Paul Menzel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Reka Norman, Kangheui Won, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62511 ) Change subject: mb/google/brya/var/nivviks: Configure WCAM DMIC data pin ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62511/comment/692f9c14_c199c911 PS2, Line 9: GPP_S6 was accidentally configured twice instead of configuring GPP_S7. … according to schematics. -- To view, visit https://review.coreboot.org/c/coreboot/+/62511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5de36aaa504a8856803c783564162c36416b50b7 Gerrit-Change-Number: 62511 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 10:11:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/denverton_ns/cpu: Get CPU frequencies for SMBIOS type 4
by Paul Menzel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Name of user not set #1004162, Sean Rhodes, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62270 ) Change subject: soc/intel/denverton_ns/cpu: Get CPU frequencies for SMBIOS type 4 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6249b0f74b34ec5ca73351eda00604089b7c3581 Gerrit-Change-Number: 62270 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1004162 Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Name of user not set #1004162 Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 10:10:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Don't report a battery capacity higher than desig...
by Paul Menzel (Code Review) 02 Mar '22

02 Mar '22

Attention is currently required from: Sean Rhodes, Andy Pont. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62514 ) Change subject: ec/starlabs/merlin: Don't report a battery capacity higher than design capacity ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3e4769c809b69e0a237b5f043e6c41c12d53752 Gerrit-Change-Number: 62514 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Comment-Date: Wed, 02 Mar 2022 10:10:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022