coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/brask/variants/moli: set up gpio
by Raihow Shi (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Zoey Wu, Zhuohao Lee, Felix Held. Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62314 ) Change subject: mb/google/brask/variants/moli: set up gpio ...................................................................... Patch Set 11: (1 comment) File src/mainboard/google/brya/variants/moli/gpio.c: https://review.coreboot.org/c/coreboot/+/62314/comment/d87aa6e2_11d2c48c PS10, Line 10: /* A9 : ESPI_CLK ==> ESPI_CLK */ : PAD_CFG_NF(GPP_A9, NONE, DEEP, NF1), : /* A10 : ESPI_RESET# ==> ESPI_PCH_RST_EC_L */ : PAD_CFG_NF(GPP_A10, NONE, DEEP, NF1), > I would suggest to remove these two lines and leave it as the default value. done -- To view, visit https://review.coreboot.org/c/coreboot/+/62314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ec41cb843419c32337b66f3877eda5d730cea35 Gerrit-Change-Number: 62314 Gerrit-PatchSet: 11 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:10:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Disable ACPI support last when suspending
by build bot (Jenkins) (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Andy Pont. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62335 ) Change subject: ec/starlabs/merlin: Disable ACPI support last when suspending ...................................................................... Patch Set 5: (1 comment) File src/ec/starlabs/merlin/acpi/suspend.asl: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143314): https://review.coreboot.org/c/coreboot/+/62335/comment/3938f067_509ac7aa PS5, Line 27: /* trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/62335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5705efab42d2fe0fd5abc6c17eeea46ead27db17 Gerrit-Change-Number: 62335 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:04:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Disable ACPI support last when suspending
by Sean Rhodes (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Andy Pont. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62335 ) Change subject: ec/starlabs/merlin: Disable ACPI support last when suspending ...................................................................... Patch Set 5: (1 comment) File src/ec/starlabs/merlin/acpi/suspend.asl: https://review.coreboot.org/c/coreboot/+/62335/comment/62dc1838_223524c5 PS2, Line 18: \_SB.PCI0.LPCB.EC.OSFG = 0x00 > I would add a comment in here that says "Disable ACPI support. This always has to be last because.. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5705efab42d2fe0fd5abc6c17eeea46ead27db17 Gerrit-Change-Number: 62335 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:04:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Disable ACPI support last when suspending
by build bot (Jenkins) (Code Review) 07 Mar '22

07 Mar '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62335 ) Change subject: ec/starlabs/merlin: Disable ACPI support last when suspending ...................................................................... Patch Set 3: (1 comment) File src/ec/starlabs/merlin/acpi/suspend.asl: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143312): https://review.coreboot.org/c/coreboot/+/62335/comment/19fc2673_09da8525 PS3, Line 18: /* trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/62335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5705efab42d2fe0fd5abc6c17eeea46ead27db17 Gerrit-Change-Number: 62335 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:03:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: timestamps: Rename timestamps to make names more consistent
by Yu-Ping Wu (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Damien Zammit, Jakub Czapiga, Lee Leahy, Marshall Dawson, Angel Pons, Julius Werner, Andrey Petrov, Fred Reitberger, Patrick Rudolph, Felix Held. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62019 ) Change subject: timestamps: Rename timestamps to make names more consistent ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I533e32392224d9b67c37e6a67987b09bf1cf51c6 Gerrit-Change-Number: 62019 Gerrit-PatchSet: 8 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joey Madafferi <joeymadafferi(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:03:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/labtop: Always run PTS
by Andy Pont (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Sean Rhodes. Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62421 ) Change subject: mb/starlabs/labtop: Always run PTS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96c44397d62848231039330a32de781f75bb56bb Gerrit-Change-Number: 62421 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:01:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Change RPTS method to Serialized
by Andy Pont (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Sean Rhodes. Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62417 ) Change subject: ec/starlabs/merlin: Change RPTS method to Serialized ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62417 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id64d321846dc042d4092d39ce9598d028ab15ed0 Gerrit-Change-Number: 62417 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:00:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Disable ACPI support last when suspending
by Andy Pont (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Sean Rhodes. Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62335 ) Change subject: ec/starlabs/merlin: Disable ACPI support last when suspending ...................................................................... Patch Set 2: (1 comment) File src/ec/starlabs/merlin/acpi/suspend.asl: https://review.coreboot.org/c/coreboot/+/62335/comment/06f95589_a3806db7 PS2, Line 18: \_SB.PCI0.LPCB.EC.OSFG = 0x00 I would add a comment in here that says "Disable ACPI support. This always has to be last because..." and then if anyone just looks at the code in future (without the commit message) they will know to not put anything after it. -- To view, visit https://review.coreboot.org/c/coreboot/+/62335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5705efab42d2fe0fd5abc6c17eeea46ead27db17 Gerrit-Change-Number: 62335 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 07 Mar 2022 09:00:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: intel/block/cpu: Keep flash region cached until the payload is loaded
by Arthur Heymans (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Arthur Heymans, Patrick Georgi, Maulik V Vaghela, Rizwan Qureshi, Sridhar Siricilla, Werner Zeh, Angel Pons, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62566 ) Change subject: intel/block/cpu: Keep flash region cached until the payload is loaded ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62566/comment/e4200b7d_726f0fb9 PS2, Line 15: Now, in this scenario, the SPI : flash linear address range is not registered as a resource (since the : common SPI driver in src/soc/intel/common/block/spi is shared across : multiple SPI controllers and therefore cannot distinguish where the : flash is actually located at) I don't understand this. It's in common so that means it knows about the memory mapped flash for all platforms? That is what the code in block/fast_spi seems to do. There really should be something reserving that resource range as the allocator will otherwise use to to put PCI bars there. https://review.coreboot.org/c/coreboot/+/62566/comment/f8d60506_885e4f34 PS2, Line 20: The result of this chain is : that loading the payload from flash takes much longer now (on mc_ehl1 it : takes ~12 seconds for 4.5 MB). Interesting. I checked this on OCP/Deltalake not long ago and the time loading the payload (kernel) was unaffected. For some platforms loading from UC flash to WB is actually faster than WP to WB, so maybe an extra Kconfig flag is desirable here? -- To view, visit https://review.coreboot.org/c/coreboot/+/62566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If19beaefc8fd3bbbe4b181820993abcd882bbbe1 Gerrit-Change-Number: 62566 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 07 Mar 2022 08:45:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Add new configs gelarshie
by Mars Chen (Code Review) 07 Mar '22

07 Mar '22

Mars Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62640 ) Change subject: mb/google/trogdor: Add new configs gelarshie ...................................................................... mb/google/trogdor: Add new configs gelarshie New boards introduced to trogodor family. BUG=b: BRANCH=none TEST=make Change-Id: I040575515f2ee09ec4880ea9d3cbe42086f0f089 --- M Documentation/security/vboot/list_vboot.md M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name 3 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/62640/1 diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index 75d20ee..b58cb86 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -207,6 +207,7 @@ - Bubs - Coachz - Homestar +- Gelarshie - Kingoftown - Lazor - Marzipan diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index e70bc69..f15a275 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -10,6 +10,7 @@ config TROGDOR_HAS_BRIDGE_BACKLIGHT bool default y if BOARD_GOOGLE_HOMESTAR + default y if BOARD_GOOGLE_GELARSHIE default n config TROGDOR_HAS_MIPI_PANEL @@ -74,6 +75,7 @@ default "Bubs" if BOARD_GOOGLE_BUBS default "Coachz" if BOARD_GOOGLE_COACHZ default "Homestar" if BOARD_GOOGLE_HOMESTAR + default "Gelarshie" if BOARD_GOOGLE_GELARSHIE default "Kingoftown" if BOARD_GOOGLE_KINGOFTOWN default "Lazor" if BOARD_GOOGLE_LAZOR default "Marzipan" if BOARD_GOOGLE_MARZIPAN diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name index f5bd7ad..70059e4 100644 --- a/src/mainboard/google/trogdor/Kconfig.name +++ b/src/mainboard/google/trogdor/Kconfig.name @@ -14,6 +14,10 @@ bool "-> Homestar" select BOARD_GOOGLE_TROGDOR_COMMON +config BOARD_GOOGLE_GELARSHIE + bool "-> Gelarshie" + select BOARD_GOOGLE_TROGDOR_COMMON + config BOARD_GOOGLE_KINGOFTOWN bool "-> Kingoftown" select BOARD_GOOGLE_TROGDOR_COMMON -- To view, visit https://review.coreboot.org/c/coreboot/+/62640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I040575515f2ee09ec4880ea9d3cbe42086f0f089 Gerrit-Change-Number: 62640 Gerrit-PatchSet: 1 Gerrit-Owner: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022