Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Eric Peers.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62663 )
Change subject: mb/google/guybrush/var/nipperkin: turn off WWAN DPR
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62663/comment/407d7786_9742118b
PS2, Line 14: make sure GPIO42 is low
> sorry, make sure GPIO42 is high by iotools (0x00c50000)
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0fcf27f086f98b2d42b47c8a871252b52d204ba
Gerrit-Change-Number: 62663
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:42:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Eric Peers.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62663 )
Change subject: mb/google/guybrush/var/nipperkin: turn off WWAN DPR
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62663/comment/aa36a149_e11e822b
PS2, Line 14: make sure GPIO42 is low
> Was GPIO42 high or low?
sorry, make sure GPIO42 is high by iotools (0x00c50000)
--
To view, visit https://review.coreboot.org/c/coreboot/+/62663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0fcf27f086f98b2d42b47c8a871252b52d204ba
Gerrit-Change-Number: 62663
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:42:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers.
Hello build bot (Jenkins), Bhanu Prakash Maiya, Rob Barnes, Eric Peers,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62663
to look at the new patch set (#3).
Change subject: mb/google/guybrush/var/nipperkin: turn off WWAN DPR
......................................................................
mb/google/guybrush/var/nipperkin: turn off WWAN DPR
Sets GPIO 42 to high to turn off WWAN DPR
BUG=b:216735313
BRANCH=guybrush
TEST=emerge-guybrush coreboot
make sure GPIO42 is high
Change-Id: Id0fcf27f086f98b2d42b47c8a871252b52d204ba
Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
---
M src/mainboard/google/guybrush/variants/nipperkin/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/62663/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/62663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0fcf27f086f98b2d42b47c8a871252b52d204ba
Gerrit-Change-Number: 62663
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Robert Chen.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61847 )
Change subject: mb/google/brya/var/vell: Add 5G WWAN ACPI support for vell
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/61847/comment/0d831e18_1d00b4c2
PS14, Line 159: DRIVERS_I2C_CS35L53
> Unrelated to WWAN
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61847
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d3f965b8f6b6753446f55a8bd47d3b0c1ae7be
Gerrit-Change-Number: 61847
Gerrit-PatchSet: 15
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:20:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Nick Vaccaro, Name of user not set #1004174.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Change AMP driver setting
......................................................................
Patch Set 36: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 36
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Name of user not set #1004174
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Name of user not set #1004174
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:19:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Shon Wang.
Shon Wang has uploaded a new patch set (#15) to the change originally created by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/61847 )
Change subject: mb/google/brya/var/vell: Add 5G WWAN ACPI support for vell
......................................................................
mb/google/brya/var/vell: Add 5G WWAN ACPI support for vell
Add FM350GL 5G WWAN support using drivers/wwan/fm and addtional PM
features from RTD3.
BUG=b:220084872
TEST=emerge-brya coreboot
Change-Id: If6d3f965b8f6b6753446f55a8bd47d3b0c1ae7be
Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/vell/gpio.c
M src/mainboard/google/brya/variants/vell/include/variant/gpio.h
3 files changed, 22 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/61847/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/61847
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d3f965b8f6b6753446f55a8bd47d3b0c1ae7be
Gerrit-Change-Number: 61847
Gerrit-PatchSet: 15
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Chiu, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Nick Vaccaro, Name of user not set #1004174.
Hello build bot (Jenkins), Kevin Chiu, YH Lin, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Name of user not set #1004174,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60331
to look at the new patch set (#36).
Change subject: mb/google/brya/var/vell: Change AMP driver setting
......................................................................
mb/google/brya/var/vell: Change AMP driver setting
1.Change I2S GPP_Sx (S0-S3) Native PAD Configuration from NF2 to NF4
2.Select CS35l53 AMP driver for Vell variant.
Signed-off-by: Shon.Wang <shon.wang(a)quanta.corp-partner.google.com>
Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/vell/gpio.c
M src/mainboard/google/brya/variants/vell/overridetree.cb
3 files changed, 44 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/60331/36
--
To view, visit https://review.coreboot.org/c/coreboot/+/60331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96d49bd1a2ba061c4fd52b450b31d0885f49552c
Gerrit-Change-Number: 60331
Gerrit-PatchSet: 36
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Name of user not set #1004174
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Name of user not set #1004174
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Georgi, Furquan Shaikh, Subrata Banik, Vitaly Rodionov, Paul Menzel, Nick Vaccaro, Robert Chen, Marco Chen, Shon Wang, Name of user not set #1004174, Karthik Ramasubramanian, Xiang Liu.
Shon Wang has uploaded a new patch set (#8) to the change originally created by Vitaly Rodionov. ( https://review.coreboot.org/c/coreboot/+/61448 )
Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT
......................................................................
drivers/i2c/cs35l53: Add driver for generating device in SSDT
This patch is adding support for Cirrus Logic CS35l41/CS35l53
smart amplifier. This part is now used in number of new chromebook's
HW designs by several vendors.
This driver uses the ACPI Device Property interface to generate
the required parameters into the _DSD table format expected by
the kernel. For detailed information about these properties, please
check Linux kernel documentation:
/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606
Signed-off-by: Stefan Binding <sbinding(a)opensource.cirrus.com>
Signed-off-by: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com>
---
A src/drivers/i2c/cs35l53/Kconfig
A src/drivers/i2c/cs35l53/Makefile.inc
A src/drivers/i2c/cs35l53/chip.h
A src/drivers/i2c/cs35l53/cs35l53.c
4 files changed, 291 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/61448/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/61448
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606
Gerrit-Change-Number: 61448
Gerrit-PatchSet: 8
Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Name of user not set #1004174
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Vitaly Rodionov <vitaly.rodionov(a)gmail.com>
Gerrit-CC: Xiang Liu <xiang.liu(a)cirrus.corp-partner.google.com>
Gerrit-CC: YH Lin <yueherngl(a)chromium.org>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Name of user not set #1004174
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Xiang Liu <xiang.liu(a)cirrus.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62663 )
Change subject: mb/google/guybrush/var/nipperkin: turn off WWAN DPR
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62663/comment/85d1d4ce_54018619
PS2, Line 14: make sure GPIO42 is low
Was GPIO42 high or low?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0fcf27f086f98b2d42b47c8a871252b52d204ba
Gerrit-Change-Number: 62663
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:07:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62663 )
Change subject: mb/google/guybrush/var/nipperkin: turn off WWAN DPR
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0fcf27f086f98b2d42b47c8a871252b52d204ba
Gerrit-Change-Number: 62663
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:07:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment