Attention is currently required from: Henry Sun, Super Ni, Aseda Aboagye, Simon Yang, Ivan Chen, Teddy Shih, Karthik Ramasubramanian.
Hello build bot (Jenkins), Henry Sun, Super Ni, Paul Menzel, Aseda Aboagye, Simon Yang, Ivan Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62729
to look at the new patch set (#3).
Change subject: mb/google/dedede: Update DPTF setting
......................................................................
mb/google/dedede: Update DPTF setting
Update PL1, PL2, and temperature sensor values from thermal team,
as well as, we remove unused temperature sensors according to
baseboard/devicetree.cb and mainboard schematic. After we check
DTT setting, the thermal and performance test pass.
BRANCH=dedede
BUG=b:204229229
TEST=on beadrix, run following commands:
localhost /tmp # cat /sys/class/thermal/thermal_zone*/type
x86_pkg_temp
INT3400 Thermal
TSR0
TSR1
TCPU
localhost /tmp # cat /sys/class/thermal/thermal_zone*/temp
45000
20000
32800
32800
39000
Signed-off-by: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Change-Id: Ibc59c4aa431f600158e744f5bbdc6d59a07a1ef3
---
M src/mainboard/google/dedede/variants/beadrix/overridetree.cb
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/62729/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/62729
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc59c4aa431f600158e744f5bbdc6d59a07a1ef3
Gerrit-Change-Number: 62729
Gerrit-PatchSet: 3
Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com>
Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Henry Sun, Super Ni, Aseda Aboagye, Simon Yang, Ivan Chen, Teddy Shih, Karthik Ramasubramanian.
Hello build bot (Jenkins), Henry Sun, Super Ni, Paul Menzel, Aseda Aboagye, Simon Yang, Ivan Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62729
to look at the new patch set (#2).
Change subject: mb/google/dedede: Update DPTF setting
......................................................................
mb/google/dedede: Update DPTF setting
Update PL1, PL2, and temperature sensor values from thermal team,
as well as, we remove unused temperature sensors according to
baseboard/devicetree.cb and mainboard schematic. After we check DTT setting, the thermal and
performance test pass.
BRANCH=dedede
BUG=b:204229229
TEST=on beadrix, run following commands:
localhost /tmp # cat /sys/class/thermal/thermal_zone*/type
x86_pkg_temp
INT3400 Thermal
TSR0
TSR1
TCPU
localhost /tmp # cat /sys/class/thermal/thermal_zone*/temp
45000
20000
32800
32800
39000
Signed-off-by: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Change-Id: Ibc59c4aa431f600158e744f5bbdc6d59a07a1ef3
---
M src/mainboard/google/dedede/variants/beadrix/overridetree.cb
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/62729/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62729
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc59c4aa431f600158e744f5bbdc6d59a07a1ef3
Gerrit-Change-Number: 62729
Gerrit-PatchSet: 2
Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com>
Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Nick Vaccaro, Felix Held, Zhuohao Lee.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62627 )
Change subject: mb/google/brya/var/kinox: Modify 15W SOC PL2/PL4 default setting
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62627/comment/208e68d9_5e0585ef
PS4, Line 7: Modify 15W SOC PL2/PL4 default setting
> Maybe: […]
The value is from power team and I think it is not increase.
https://review.coreboot.org/c/coreboot/+/62627/comment/100e54a7_d8ca511c
PS4, Line 9: Modify 15W SOC PL2/PL4 default setting to 39W/100W for Kinox.
> Where are the values from? Please document that.
The value is from power team and I think it is not increase.
The discuess is at https://partnerissuetracker.corp.google.com/issues/213417026
--
To view, visit https://review.coreboot.org/c/coreboot/+/62627
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2956705f7d26929c7cf2dd4e852fc61b619a83e5
Gerrit-Change-Number: 62627
Gerrit-PatchSet: 4
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 09:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Patrick Rudolph.
Curtis Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62727 )
Change subject: soc/intel/alderlake: Update ADL-P id list of th VccIn Aux Imon IccMax values
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Same as Id93d584c240a9b4841f110ad7c540d90f829c0da?
Yes, the same.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62727
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cee31ba56e0b142c50a745c453968635e86296e
Gerrit-Change-Number: 62727
Gerrit-PatchSet: 1
Gerrit-Owner: Curtis Chen <curtis.chen(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 09:55:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62560 )
Change subject: soc/intel/common: Retry MEI CSE DISABLE command
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62560/comment/bfebbe24_57f4afbd
PS5, Line 12:
> same here, mention it's from the BWG?
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/62560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id38a172d670a0cd44643744f27b85ca7e368ccdb
Gerrit-Change-Number: 62560
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sridhar Siricilla <sridhar.nest(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 09:50:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Super Ni, Aseda Aboagye, Simon Yang, Ivan Chen, Teddy Shih, Karthik Ramasubramanian.
Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62729 )
Change subject: mb/google/dedede: Update DPTF setting
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Dear All,
1. I update dptf values from ECS thermal team.
2. Remove unused tsr2 refer to comment(https://partnerissuetracker.corp.google.com/issues/204229229#commen…
Best Regards,
Teddy
--
To view, visit https://review.coreboot.org/c/coreboot/+/62729
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc59c4aa431f600158e744f5bbdc6d59a07a1ef3
Gerrit-Change-Number: 62729
Gerrit-PatchSet: 1
Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com>
Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 09:33:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Georgi.
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62666
to look at the new patch set (#2).
Change subject: Documentation: Describe our Coverity Scan integration
......................................................................
Documentation: Describe our Coverity Scan integration
Change-Id: I0a2b68a4b4b54c7345280b252d624799316641b1
Signed-off-by: Patrick Georgi <patrick(a)coreboot.org>
---
M Documentation/infrastructure/builders.md
A Documentation/infrastructure/coverity.md
M Documentation/infrastructure/index.md
3 files changed, 86 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/62666/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62666
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a2b68a4b4b54c7345280b252d624799316641b1
Gerrit-Change-Number: 62666
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62713 )
Change subject: mb/googe/skyrim/baseboard/devicetree: update USB port device ID on xhci2
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/62713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a370132960939bccec4eb69a6590d0880b04137
Gerrit-Change-Number: 62713
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 10 Mar 2022 09:29:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Marshall Dawson, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62571 )
Change subject: mb/amd/chausie/devicetree: enable GFX HDA, ACP and XHCI2 devices
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/62571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I186797a832470eb17752e06aa2fcc0b5c9db0398
Gerrit-Change-Number: 62571
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 10 Mar 2022 09:28:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment