Attention is currently required from: Anil Kumar K, Sridhar Siricilla, Patrick Rudolph.
Hello build bot (Jenkins), Anil Kumar K, Subrata Banik, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62192
to look at the new patch set (#12).
Change subject: soc/intel/common: Retry END_OF_POST command
......................................................................
soc/intel/common: Retry END_OF_POST command
The patch adds retry mechanism for EOP command as per ME BWG.
If coreboot fails to send or receive the EOP command/response, it
retries the EOP command max 3 times before triggering the error
handling flow.
BUG=b:200251277
TEST=Verify EOP retry mechanism for brya board.
Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683
---
M src/soc/intel/common/block/cse/cse_eop.c
1 file changed, 33 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/62192/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/62192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683
Gerrit-Change-Number: 62192
Gerrit-PatchSet: 12
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sridhar Siricilla <sridhar.nest(a)gmail.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph.
Hello build bot (Jenkins), Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62560
to look at the new patch set (#6).
Change subject: soc/intel/common: Retry MEI CSE DISABLE command
......................................................................
soc/intel/common: Retry MEI CSE DISABLE command
As per ME BWG, the patch retries MEI CSE DISABLE command if CSE doesn't
respond or sends the garbled response. It retries the command
additionally 2 more times.
TEST=build and boot the Brya board
Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Change-Id: Id38a172d670a0cd44643744f27b85ca7e368ccdb
---
M src/soc/intel/common/block/cse/cse_eop.c
1 file changed, 10 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/62560/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/62560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id38a172d670a0cd44643744f27b85ca7e368ccdb
Gerrit-Change-Number: 62560
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sridhar Siricilla <sridhar.nest(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62722 )
Change subject: mb/google/nissa/var/nivviks: Hook up SD host controller GL9750
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62722/comment/713239b7_ff2f8793
PS2, Line 7: Add GL9750 power sequence
> Hook up SD host controller GL9750
Done
https://review.coreboot.org/c/coreboot/+/62722/comment/a8e23ed8_6feae055
PS2, Line 9: Select GL9750 driver and add power sequence.
> … according to schematics/datasheet?
Done
https://review.coreboot.org/c/coreboot/+/62722/comment/5f58232d_b20dd1a2
PS2, Line 12: enumerate
> enumerated
Done
https://review.coreboot.org/c/coreboot/+/62722/comment/df926660_d48e49f8
PS2, Line 12: kernel
> What version?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62722
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6d461a56f6aeba30994daafe8993c36df4b309d
Gerrit-Change-Number: 62722
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 07:52:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai.
Hello build bot (Jenkins), Kangheui Won, Reka Norman, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62722
to look at the new patch set (#3).
Change subject: mb/google/nissa/var/nivviks: Hook up SD host controller GL9750
......................................................................
mb/google/nissa/var/nivviks: Hook up SD host controller GL9750
Select GL9750 driver and add power sequence according to datasheet:
GL9750S-OIY04 rev1.22.
BUG=b:223304292
TEST=check GL9750 can get enumerated by kernel 5.15.
01:00.0 SD Host controller: Genesys Logic, Inc Device 9750 (rev 01)
Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Change-Id: Ib6d461a56f6aeba30994daafe8993c36df4b309d
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/nivviks/gpio.c
2 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/62722/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/62722
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6d461a56f6aeba30994daafe8993c36df4b309d
Gerrit-Change-Number: 62722
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62722 )
Change subject: mb/google/nissa/var/nivviks: Add GL9750 power sequence
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62722/comment/ba163e09_ffdcb067
PS2, Line 7: Add GL9750 power sequence
Hook up SD host controller GL9750
https://review.coreboot.org/c/coreboot/+/62722/comment/d3123c57_3a27227c
PS2, Line 9: Select GL9750 driver and add power sequence.
… according to schematics/datasheet?
https://review.coreboot.org/c/coreboot/+/62722/comment/ef81df04_0520ab1b
PS2, Line 12: enumerate
enumerated
https://review.coreboot.org/c/coreboot/+/62722/comment/b14b0751_2e686a08
PS2, Line 12: kernel
What version?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62722
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6d461a56f6aeba30994daafe8993c36df4b309d
Gerrit-Change-Number: 62722
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 07:37:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61306 )
Change subject: console: Add loglevel prefix to interactive consoles
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
Julius, did you also send a patch to the Linux kernel for the driver/module memconsole-coreboot?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic83413475400821f8097ef1819a293ee8926bb0b
Gerrit-Change-Number: 61306
Gerrit-PatchSet: 8
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 07:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62553 )
Change subject: mb/google/brya/var/kinox: update overridetree
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/google/brya/variants/kinox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62553/comment/0a5181b7_8346ed84
PS9, Line 135: ACPI_PLD_GROUP
> Can you please look into the `custom_pld` and assocaited properties in other brya variants and use t […]
Thanks for review. I use 'custom_pld' instend of PLD group.
Once I get the M/B with chassis, will correct the parameters 'Panel' and 'Horizontal'.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62553
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc
Gerrit-Change-Number: 62553
Gerrit-PatchSet: 12
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 07:18:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Zhuohao Lee.
Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62553
to look at the new patch set (#12).
Change subject: mb/google/brya/var/kinox: update overridetree
......................................................................
mb/google/brya/var/kinox: update overridetree
1. Update override devicetree based on schematics.
2. ALC5682I-VS is for audio codec.
BUG=b:218786363, b:214025396, b:212183045
TEST=emerge-brask coreboot
Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc
---
M src/mainboard/google/brya/variants/kinox/overridetree.cb
1 file changed, 213 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/62553/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/62553
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc
Gerrit-Change-Number: 62553
Gerrit-PatchSet: 12
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-MessageType: newpatchset