Attention is currently required from: Frank Chu.
Frank Chu has uploaded a new patch set (#5). ( https://review.coreboot.org/c/coreboot/+/62704 )
Change subject: mb/google/dedede/var/galtic: update Wifi SAR for for galnat
......................................................................
mb/google/dedede/var/galtic: update Wifi SAR for for galnat
Add wifi sar for galnat/galnat360
Use SKU ID to load wifi table.
Each Project and SKU ID correspond as below
galtic (sku id:0x120000)
galith (sku id:0x130000)
galnat (sku id:0x140000)*
gallop (sku id:0x150000)
galtic360 (sku id:0x260000)
galith360 (sku id:0x270000)
galnat360 (sku id:0x2B0000)*
BUG=b:222008376
TEST=emerge-dedede coreboot chromeos-bootimage \
coreboot-private-files-baseboard-dedede
verify the SAR table is correct in each project
Signed-off-by: Frank Chu <Frank_Chu(a)pegatron.corp-partner.google.com>
Change-Id: I868a7416a002732736cabea48ce80548ea75e517
---
M src/mainboard/google/dedede/variants/galtic/variant.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/62704/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/62704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I868a7416a002732736cabea48ce80548ea75e517
Gerrit-Change-Number: 62704
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Sridhar Siricilla, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/intel/common: Add support to control coreboot and Intel SoC features
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/basecode/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/aab40ff8_a3da883e
PS14, Line 22: pre_mem_debug_init
can we try to maintain a prefix like other common code like `debug_` ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ba40926bd9ad909654f152e48cdd648b28afd62
Gerrit-Change-Number: 61380
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 10:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Frank Chu.
Frank Chu has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/62704 )
Change subject: mb/google/dedede/var/galtic: update Wifi SAR for for galnat
......................................................................
mb/google/dedede/var/galtic: update Wifi SAR for for galnat
Add wifi sar for galnat/galnat360
Use convertible mode of SKU ID to load wifi table.
Each Project and SKU ID correspond as below
galtic (sku id:0x120000)
galith (sku id:0x130000)
galnat (sku id:0x140000)*
gallop (sku id:0x150000)
galtic360 (sku id:0x260000)
galith360 (sku id:0x270000)
galnat360 (sku id:0x2B0000)*
BUG=b:222008376
TEST=emerge-dedede coreboot chromeos-bootimage \
coreboot-private-files-baseboard-dedede
verify the SAR table is correct in each project
Signed-off-by: Frank Chu <Frank_Chu(a)pegatron.corp-partner.google.com>
Change-Id: I868a7416a002732736cabea48ce80548ea75e517
---
M src/mainboard/google/dedede/variants/galtic/variant.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/62704/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/62704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I868a7416a002732736cabea48ce80548ea75e517
Gerrit-Change-Number: 62704
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62702
to look at the new patch set (#7).
Change subject: ec/starlabs/merlin: Add support for Nuvoton EC's
......................................................................
ec/starlabs/merlin: Add support for Nuvoton EC's
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Ib66baf1e88f5d548ce955dffa00c9b88255b2f95
---
M src/ec/starlabs/merlin/Kconfig
M src/ec/starlabs/merlin/Makefile.inc
M src/ec/starlabs/merlin/ec.h
A src/ec/starlabs/merlin/nuvoton.c
4 files changed, 318 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/62702/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/62702
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib66baf1e88f5d548ce955dffa00c9b88255b2f95
Gerrit-Change-Number: 62702
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Casper Chang.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62703
to look at the new patch set (#6).
Change subject: mb/google/brya/var/primus{4es}: add eMMC enable pin in ramstage
......................................................................
mb/google/brya/var/primus{4es}: add eMMC enable pin in ramstage
Program the BayHub eMMC enable pin in ramstage to prevent baseboard
override the setting leads RTD3 not able to control when enter and
exit suspend state.
BUG=b:222436260
TEST=USE="project_primus" emerge-brya coreboot chromeos-bootimage
scope enable pin while performing suspend stress and enable pin
works as expected.
test suspend stress 1000 cycles passed on primus.
Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Change-Id: I1b6f164cc326bd368addb1e143ad2cbd449bb08d
---
M src/mainboard/google/brya/variants/primus/gpio.c
M src/mainboard/google/brya/variants/primus4es/gpio.c
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/62703/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/62703
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b6f164cc326bd368addb1e143ad2cbd449bb08d
Gerrit-Change-Number: 62703
Gerrit-PatchSet: 6
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Sridhar Siricilla, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/intel/common: Add support to control coreboot and Intel SoC features
......................................................................
Patch Set 14: Code-Review+1
(3 comments)
File src/soc/intel/common/basecode/debug/Kconfig:
https://review.coreboot.org/c/coreboot/+/61380/comment/5f163338_c12b7fa6
PS14, Line 5: Driver to control run time features of Intel SoC & coreboot
can you please give some examples so user know when to select this Kconfig?
File src/soc/intel/common/basecode/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/2704186b_1c36eebe
PS14, Line 24: struct region_device desc_rdev;
suggestion:
static struct pre_mem_ft {
int reserved[64];
} pre_mem_debug;
File src/soc/intel/common/basecode/include/intelbasecode/debug_feature.h:
https://review.coreboot.org/c/coreboot/+/61380/comment/3a778ee7_f84cd1b1
PS14, Line 3: RT
do we need to specify RT?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ba40926bd9ad909654f152e48cdd648b28afd62
Gerrit-Change-Number: 61380
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 10 Mar 2022 10:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Super Ni, Paul Menzel, Aseda Aboagye, Simon Yang, Ivan Chen, Karthik Ramasubramanian.
Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62729 )
Change subject: mb/google/dedede: Update DPTF setting
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62729/comment/75bb75f0_100d62c5
PS1, Line 10: we remove unused temperature sensors according to
: mainboard schematic
> I do not see anything removed in the devicetree diff.
Hi Paul,
Thank you for your advice. I reference baseboard dptf setting (https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thi…) as my initial dptf values. After I check hardware schematic, I find out that the TEMP_SENSOR_2 is not existing. Therefore, I remove non-existing temeprature sensor. This CL is the modified result. As a result, I update commit message.
https://review.coreboot.org/c/coreboot/+/62729/comment/4bb69c8e_09a83e85
PS1, Line 17: cat /sys/class/thermal/thermal_zone*/type
> For the future you can use `grep -R . […]
Hi Paul,
Thank you for your advice. I run the command and get result with zone number:
localhost ~ # grep -R . /sys/class/thermal/thermal_zone*/type
/sys/class/thermal/thermal_zone0/type:x86_pkg_temp
/sys/class/thermal/thermal_zone1/type:INT3400 Thermal
/sys/class/thermal/thermal_zone2/type:TSR0
/sys/class/thermal/thermal_zone3/type:TSR1
/sys/class/thermal/thermal_zone4/type:TCPU
--
To view, visit https://review.coreboot.org/c/coreboot/+/62729
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc59c4aa431f600158e744f5bbdc6d59a07a1ef3
Gerrit-Change-Number: 62729
Gerrit-PatchSet: 3
Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com>
Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 10:12:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment