coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in em100[master]: makechips.sh: Build makedpfw if not present
by Paul Menzel (Code Review) 19 Mar '22

19 Mar '22

Attention is currently required from: Martin L Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/em100/+/62938 ) Change subject: makechips.sh: Build makedpfw if not present ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/em100/+/62938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If5dd121a4977126c456162de7d4328d69e741902 Gerrit-Change-Number: 62938 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sat, 19 Mar 2022 20:25:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in em100[master]: makechips.sh: Reformat script with shfmt
by Martin L Roth (Code Review) 19 Mar '22

19 Mar '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/62939 ) Change subject: makechips.sh: Reformat script with shfmt ...................................................................... makechips.sh: Reformat script with shfmt Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I92c1044f93e0322fe13ea3804371203e321293d9 --- M makechips.sh 1 file changed, 19 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/39/62939/1 diff --git a/makechips.sh b/makechips.sh index e6080f2..602eb08 100755 --- a/makechips.sh +++ b/makechips.sh @@ -14,18 +14,21 @@ URL="https://www.dediprog.com/download/save/78.msi" -if ! which curl > /dev/null; then +if ! which curl >/dev/null; then echo "Install curl to run this script." - exit 1; + exit 1 fi -if ! which msiextract > /dev/null; then +if ! which msiextract >/dev/null; then echo "Install msitools (https://wiki.gnome.org/msitools) to run this script." exit 1 fi FILE=EM100Pro.msi TEMP=$(mktemp -d /tmp/makech.XXXXXX) -WD="$(cd "$(dirname "$(eval echo "$0")")" || exit 1; pwd)" +WD="$( + cd "$(dirname "$(eval echo "$0")")" || exit 1 + pwd +)" TD="${WD}/em100_home" if [[ ! -f "${WD}/makedpfw" ]]; then @@ -41,41 +44,40 @@ curl -s $URL -o $FILE || exit 1 fi echo " Unpacking ..." -if ! msiextract $FILE > /dev/null ; then +if ! msiextract $FILE >/dev/null; then echo " Could not unpack Windows installer..." rm -rf "${TEMP}" exit 1 fi -VERSION="$( strings -e l Program\ Files/DediProg/EM100/EM100.exe | grep -A1 ProductVersion | grep EM100 )" +VERSION="$(strings -e l Program\ Files/DediProg/EM100/EM100.exe | grep -A1 ProductVersion | grep EM100)" echo " Detected SPI flash database \"$VERSION\"" echo " Creating configs..." mkdir -p "${TD}/configs" cp -a "${TEMP}"/Program\ Files/DediProg/EM100/config/EM100Pro/*.cfg "${TD}/configs" || exit 1 -echo -n "${VERSION}" > "${TD}/configs/VERSION" +echo -n "${VERSION}" >"${TD}/configs/VERSION" echo " Extract firmware files..." mkdir -p "${TD}/firmware" -for i in "${TEMP}"/Program\ Files/DediProg/EM100/firmware/EM100ProFW_* -do - firmware="$( basename "$i" )" +for i in "${TEMP}"/Program\ Files/DediProg/EM100/firmware/EM100ProFW_*; do + firmware="$(basename "$i")" tuple=${firmware#EM100ProFW_} v=${tuple: -3} voltage=${v/V/.}V - mcu_version=${tuple: 1:1}.${tuple: 2:2} - fpga_version=${tuple: 4:1}.${tuple: 5:2} + mcu_version=${tuple:1:1}.${tuple:2:2} + fpga_version=${tuple:4:1}.${tuple:5:2} "${WD}/makedpfw" -m "$i/2.bin" -M "${mcu_version}" -f "$i/1.bin" -F "${fpga_version}" \ - -o "${TD}/firmware/em100pro_fw_${mcu_version}_${fpga_version}_${voltage}.dpfw" || exit + -o "${TD}/firmware/em100pro_fw_${mcu_version}_${fpga_version}_${voltage}.dpfw" || exit done -echo -n "${VERSION}" > "${TD}/firmware/VERSION" +echo -n "${VERSION}" >"${TD}/firmware/VERSION" cd "${TD}" || exit 1 LANG=C tar cJf configs.tar.xz --sort=name configs LANG=C tar cJf firmware.tar.xz --sort=name firmware -echo -n "Time: " > VERSION -date +%s >> VERSION -echo "Version: ${VERSION}" >> VERSION +echo -n "Time: " >VERSION +date +%s >>VERSION +echo "Version: ${VERSION}" >>VERSION cd "${WD}" || exit 1 rm -rf "${TEMP}" -- To view, visit https://review.coreboot.org/c/em100/+/62939 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I92c1044f93e0322fe13ea3804371203e321293d9 Gerrit-Change-Number: 62939 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in em100[master]: makechips.sh: Build makedpfw if not present
by Martin L Roth (Code Review) 19 Mar '22

19 Mar '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/62938 ) Change subject: makechips.sh: Build makedpfw if not present ...................................................................... makechips.sh: Build makedpfw if not present Check for makedpfw and build it if it hasn't been built yet. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: If5dd121a4977126c456162de7d4328d69e741902 --- M makechips.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/38/62938/1 diff --git a/makechips.sh b/makechips.sh index ddf1953..e6080f2 100755 --- a/makechips.sh +++ b/makechips.sh @@ -28,6 +28,10 @@ WD="$(cd "$(dirname "$(eval echo "$0")")" || exit 1; pwd)" TD="${WD}/em100_home" +if [[ ! -f "${WD}/makedpfw" ]]; then + make makedpfw +fi + cd "${TEMP}" || exit 1 if [ -r "${WD}/${FILE}" ]; then echo " Copying $FILE..." -- To view, visit https://review.coreboot.org/c/em100/+/62938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: If5dd121a4977126c456162de7d4328d69e741902 Gerrit-Change-Number: 62938 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in em100[master]: makechips.sh: Clean up shellcheck errors and formatting
by Martin L Roth (Code Review) 19 Mar '22

19 Mar '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/62937 ) Change subject: makechips.sh: Clean up shellcheck errors and formatting ...................................................................... makechips.sh: Clean up shellcheck errors and formatting Clean up shellcheck errors Add braces around variable names > 1 character Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ia756d67d0a0464971e395189027b01787b6b19bd --- M makechips.sh 1 file changed, 19 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/37/62937/1 diff --git a/makechips.sh b/makechips.sh index b4c43d0..ddf1953 100755 --- a/makechips.sh +++ b/makechips.sh @@ -25,53 +25,53 @@ FILE=EM100Pro.msi TEMP=$(mktemp -d /tmp/makech.XXXXXX) -WD=$(cd "$(dirname `eval echo "$0"`)"; pwd) -TD=$WD/em100_home +WD="$(cd "$(dirname "$(eval echo "$0")")" || exit 1; pwd)" +TD="${WD}/em100_home" -cd $TEMP -if [ -r $WD/$FILE ]; then +cd "${TEMP}" || exit 1 +if [ -r "${WD}/${FILE}" ]; then echo " Copying $FILE..." - cp $WD/$FILE . + cp "${WD}/${FILE}" . || exit 1 else echo " Downloading $FILE..." - curl -s $URL -o $FILE || exit + curl -s $URL -o $FILE || exit 1 fi echo " Unpacking ..." if ! msiextract $FILE > /dev/null ; then echo " Could not unpack Windows installer..." - rm -rf $TEMP + rm -rf "${TEMP}" exit 1 fi VERSION="$( strings -e l Program\ Files/DediProg/EM100/EM100.exe | grep -A1 ProductVersion | grep EM100 )" echo " Detected SPI flash database \"$VERSION\"" echo " Creating configs..." -mkdir -p $TD/configs -cp -a $TEMP/Program\ Files/DediProg/EM100/config/EM100Pro/*.cfg $TD/configs -echo -n "${VERSION}" > $TD/configs/VERSION +mkdir -p "${TD}/configs" +cp -a "${TEMP}"/Program\ Files/DediProg/EM100/config/EM100Pro/*.cfg "${TD}/configs" || exit 1 +echo -n "${VERSION}" > "${TD}/configs/VERSION" echo " Extract firmware files..." -mkdir -p $TD/firmware -for i in $TEMP/Program\ Files/DediProg/EM100/firmware/EM100ProFW_* +mkdir -p "${TD}/firmware" +for i in "${TEMP}"/Program\ Files/DediProg/EM100/firmware/EM100ProFW_* do - firmware=$( basename "$i" ) + firmware="$( basename "$i" )" tuple=${firmware#EM100ProFW_} v=${tuple: -3} voltage=${v/V/.}V mcu_version=${tuple: 1:1}.${tuple: 2:2} fpga_version=${tuple: 4:1}.${tuple: 5:2} - $WD/makedpfw -m "$i/2.bin" -M $mcu_version -f "$i/1.bin" -F $fpga_version \ - -o $TD/firmware/em100pro_fw_${mcu_version}_${fpga_version}_${voltage}.dpfw + "${WD}/makedpfw" -m "$i/2.bin" -M "${mcu_version}" -f "$i/1.bin" -F "${fpga_version}" \ + -o "${TD}/firmware/em100pro_fw_${mcu_version}_${fpga_version}_${voltage}.dpfw" || exit done -echo -n "${VERSION}" > $TD/firmware/VERSION +echo -n "${VERSION}" > "${TD}/firmware/VERSION" -cd $TD +cd "${TD}" || exit 1 LANG=C tar cJf configs.tar.xz --sort=name configs LANG=C tar cJf firmware.tar.xz --sort=name firmware echo -n "Time: " > VERSION date +%s >> VERSION echo "Version: ${VERSION}" >> VERSION -cd $WD +cd "${WD}" || exit 1 -rm -rf $TEMP +rm -rf "${TEMP}" -- To view, visit https://review.coreboot.org/c/em100/+/62937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: Ia756d67d0a0464971e395189027b01787b6b19bd Gerrit-Change-Number: 62937 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/skyrim/devicetree: set PSPP policy to DXIO_PSPP_DISABLED
by Felix Held (Code Review) 19 Mar '22

19 Mar '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62924 ) Change subject: mb/google/skyrim/devicetree: set PSPP policy to DXIO_PSPP_DISABLED ...................................................................... mb/google/skyrim/devicetree: set PSPP policy to DXIO_PSPP_DISABLED Right now, the PSPP policy that controls if the PCIe lanes can be dynamically downgraded to a lower speed to save some power needs to be disabled in order for the link training to be successful. Once this feature is working, PSPP will be reenabled. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I6ea602596acb8e5ea92076386e80102c3bc757af Reviewed-on: https://review.coreboot.org/c/coreboot/+/62924 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> Reviewed-by: Jon Murphy <jpmurphy(a)google.com> --- M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Jon Murphy: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb index 7d4fb7f..03bb55e 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb @@ -47,6 +47,8 @@ register "i2c_pad[2].rx_level" = "I2C_PAD_RX_1_8V" # Audio/SAR register "i2c_pad[3].rx_level" = "I2C_PAD_RX_1_8V" # GSC + register "pspp_policy" = "DXIO_PSPP_DISABLED" # TODO: reenable when PSPP works + device domain 0 on device ref lpc_bridge on chip ec/google/chromeec 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/62924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ea602596acb8e5ea92076386e80102c3bc757af Gerrit-Change-Number: 62924 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/amd/chausie/devicetree: set PSPP policy to DXIO_PSPP_DISABLED
by Felix Held (Code Review) 19 Mar '22

19 Mar '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62923 ) Change subject: mb/amd/chausie/devicetree: set PSPP policy to DXIO_PSPP_DISABLED ...................................................................... mb/amd/chausie/devicetree: set PSPP policy to DXIO_PSPP_DISABLED Right now, the PSPP policy that controls if the PCIe lanes can be dynamically downgraded to a lower speed to save some power needs to be disabled in order for the link training to be successful. Once this feature is working, the PSPP policy will be switched to balanced again. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I85a06f322c4ddff25c3a858e2b79c84b36c48932 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62923 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> --- M src/mainboard/amd/chausie/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Fred Reitberger: Looks good to me, but someone else must approve diff --git a/src/mainboard/amd/chausie/devicetree.cb b/src/mainboard/amd/chausie/devicetree.cb index f3a84f3..7f37be2 100644 --- a/src/mainboard/amd/chausie/devicetree.cb +++ b/src/mainboard/amd/chausie/devicetree.cb @@ -24,7 +24,7 @@ register "s0ix_enable" = "true" - register "pspp_policy" = "DXIO_PSPP_BALANCED" + register "pspp_policy" = "DXIO_PSPP_DISABLED" # TODO: reenable when PSPP works device domain 0 on device ref iommu on end 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/62923 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85a06f322c4ddff25c3a858e2b79c84b36c48932 Gerrit-Change-Number: 62923 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Xue Yao (Code Review) 19 Mar '22

19 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens. Xue Yao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 15: (1 comment) Patchset: PS13: > I'm new to gerrit, should the author be changed and should I amend the commit message? I've changed […] Apologies about the author. I've reverted it back in patch set 15 and also fixed the extra newline. This should be good to merge into master. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 15 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: MartiniMoe Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: Xue Yao <xueyao(a)xyte.ch> Gerrit-CC: clayton craft Gerrit-CC: nullmark <nullmark(a)googlemail.com> Gerrit-CC: slact Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kilian Neuner <cb(a)9-r.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 19 Mar 2022 15:29:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Xue Yao <xueyao(a)xyte.ch> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Xue Yao (Code Review) 19 Mar '22

19 Mar '22

Attention is currently required from: Nico Huber, Xue Yao, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens. Xue Yao has uploaded a new patch set (#15) to the change originally created by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... lenovo/x230: introduce FHD variant There is a modification for the x230 which uses the 2nd DP from the dock as the integrated panel's connection, which allows using a Full HD (FHD) eDP panel instead of the stock LVDS display. To make this work with coreboot, the internal LVDS connector should be disabled in libgfxinit. The VBT has been modified as well, which allows brightness controls to work out of the box. The modifications done to the VBT are: - Remove the LVDS port entry. - Move the DP-3 (which is the 2nd DP on the dock) entry to the first position on the list. - Set the DP-3 as internally connected. This has been reported to work with panel LP125WF2 SPB4. Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name M src/mainboard/lenovo/x230/Makefile.inc A src/mainboard/lenovo/x230/variants/x230_edp/board_info.txt A src/mainboard/lenovo/x230/variants/x230_edp/data.vbt A src/mainboard/lenovo/x230/variants/x230_edp/gma-mainboard.ads 6 files changed, 72 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 15 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: MartiniMoe Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: nullmark <nullmark(a)googlemail.com> Gerrit-CC: slact Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Xue Yao <xueyao(a)xyte.ch> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kilian Neuner <cb(a)9-r.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Xue Yao (Code Review) 19 Mar '22

19 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens. Xue Yao has uploaded a new patch set (#14) to the change originally created by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... lenovo/x230: introduce FHD variant There is a modification for the x230 which uses the 2nd DP from the dock as the integrated panel's connection, which allows using a Full HD (FHD) eDP panel instead of the stock LVDS display. To make this work with coreboot, the internal LVDS connector should be disabled in libgfxinit. The VBT has been modified as well, which allows brightness controls to work out of the box. The modifications done to the VBT are: - Remove the LVDS port entry. - Move the DP-3 (which is the 2nd DP on the dock) entry to the first position on the list. - Set the DP-3 as internally connected. This has been reported to work with panel LP125WF2 SPB4. Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x230/Kconfig.name M src/mainboard/lenovo/x230/Makefile.inc A src/mainboard/lenovo/x230/variants/x230_edp/board_info.txt A src/mainboard/lenovo/x230/variants/x230_edp/data.vbt A src/mainboard/lenovo/x230/variants/x230_edp/gma-mainboard.ads 6 files changed, 73 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28950/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 14 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: MartiniMoe Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: clayton craft Gerrit-CC: nullmark <nullmark(a)googlemail.com> Gerrit-CC: slact Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kilian Neuner <cb(a)9-r.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Xue Yao (Code Review) 19 Mar '22

19 Mar '22

Attention is currently required from: Nico Huber, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens. Xue Yao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 13: (2 comments) File src/mainboard/lenovo/x230/variants/x230_fhd/gma-mainboard.ads: PS10: > Please use SPDX: […] Amended. File src/mainboard/lenovo/x230/variants/x230_fhd/gpio.c: PS12: > You can treat the X230_FHD like the regular X230 (same variant dir), but with a different gma-mainbo […] Is this implementation better now? -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 13 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: MartiniMoe Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: Xue Yao <xueyao(a)xyte.ch> Gerrit-CC: clayton craft Gerrit-CC: nullmark <nullmark(a)googlemail.com> Gerrit-CC: slact Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kilian Neuner <cb(a)9-r.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 19 Mar 2022 14:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kilian Neuner <cb(a)9-r.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022