coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: src/driver/wifi: Add _DSM method for DDRRFIM
by Varshit B Pandya (Code Review) 20 Mar '22

20 Mar '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Maulik V Vaghela, Paul Menzel, Sugnan Prabhu S, Tim Wawrzynczak. Hello build bot (Jenkins), Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Rizwan Qureshi, Sugnan Prabhu S, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61020 to look at the new patch set (#21). Change subject: src/driver/wifi: Add _DSM method for DDRRFIM ...................................................................... src/driver/wifi: Add _DSM method for DDRRFIM coreboot needs to propagate the CnviDdrRfim value info of the feature enable/disable state into the CNVi via the WiFi DSM ACPI object. This patch adds _DSM method for that. Add support for following 2 function in _DSM method - Function 0: Function Support Query Returns a bitmask of functions supported. - Function 3: RFI enablement 0 Feature Enable 1 Feature Disable BUG=b:201724512 TEST=Build, boot brya0 and dump SSDT entries Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method { ToBuffer (Arg0, Local0) If ((Local0 == ToUUID ("7266172c-220b-4b29-814f-75e4dd26b5fd"))) { ToInteger (Arg2, Local1) If ((Local1 == Zero)) { Return (Buffer (One) { 0x09 }) } If ((Local1 == One)){} If ((Local1 == 0x02)){} If ((Local1 == 0x03)) { Return (Zero) } Return (Buffer (One) { 0x00 }) } Return (Buffer (One) { 0x00 }) } Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: I217b736df3d4224a6732d1941a160abcddbd8f37 --- M src/drivers/wifi/generic/acpi.c 1 file changed, 67 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/61020/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/61020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I217b736df3d4224a6732d1941a160abcddbd8f37 Gerrit-Change-Number: 61020 Gerrit-PatchSet: 21 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [TEST]mb/google/brya/var/taeko: Improve factory process to avoid mess...
by Kevin Chang (Code Review) 20 Mar '22

20 Mar '22

Attention is currently required from: Tim Wawrzynczak. Hello Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62941 to look at the new patch set (#2). Change subject: [TEST]mb/google/brya/var/taeko: Improve factory process to avoid mess up eMMC and SSD when first boot. ...................................................................... [TEST]mb/google/brya/var/taeko: Improve factory process to avoid mess up eMMC and SSD when first boot. Using GPP_F19 as eMMC detect pin when first boot with default FW ID. BUG=b:224884408 TEST=Build FW and test on rework MB also test on original MB pass. Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Change-Id: I6eb29680518ba5ba447ac16aef5eaaf0262437e0 --- M src/mainboard/google/brya/romstage.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/brya/variants/taeko/Makefile.inc M src/mainboard/google/brya/variants/taeko/gpio.c A src/mainboard/google/brya/variants/taeko/runtimestorage.c 5 files changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/62941/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6eb29680518ba5ba447ac16aef5eaaf0262437e0 Gerrit-Change-Number: 62941 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/taeko: Improve factory process to avoid mess up eM...
by build bot (Jenkins) (Code Review) 20 Mar '22

20 Mar '22

Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62941 ) Change subject: mb/google/brya/var/taeko: Improve factory process to avoid mess up eMMC and SSD when first boot. ...................................................................... Patch Set 1: (6 comments) File src/mainboard/google/brya/variants/taeko/runtimestorage.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/87e00f9a_fe903e41 PS1, Line 15: if(fw_config_probe(FW_CONFIG(BOOT_NVME_MASK, BOOT_NVME_ENABLED)) && trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/be218b3a_87af9ae1 PS1, Line 15: if(fw_config_probe(FW_CONFIG(BOOT_NVME_MASK, BOOT_NVME_ENABLED)) && space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/47e74195_a49ffa1f PS1, Line 16: fw_config_probe(FW_CONFIG(BOOT_EMMC_MASK, BOOT_EMMC_ENABLED))){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/820797a0_f3d3d31b PS1, Line 23: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/48e7508c_110776a6 PS1, Line 24: if(!gpio_get(GPP_F19)){ space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144317): https://review.coreboot.org/c/coreboot/+/62941/comment/50d52886_24a5ebb0 PS1, Line 24: if(!gpio_get(GPP_F19)){ space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/62941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6eb29680518ba5ba447ac16aef5eaaf0262437e0 Gerrit-Change-Number: 62941 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Sun, 20 Mar 2022 10:31:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/taeko: Improve factory process to avoid mess up eM...
by Kevin Chang (Code Review) 20 Mar '22

20 Mar '22

Kevin Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62941 ) Change subject: mb/google/brya/var/taeko: Improve factory process to avoid mess up eMMC and SSD when first boot. ...................................................................... mb/google/brya/var/taeko: Improve factory process to avoid mess up eMMC and SSD when first boot. Using GPP_F19 as eMMC detect pin when first boot with default FW ID. BUG=b:224884408 TEST=Build FW and test on rework MB also test on original MB pass. Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Change-Id: I6eb29680518ba5ba447ac16aef5eaaf0262437e0 --- M src/mainboard/google/brya/romstage.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/brya/variants/taeko/Makefile.inc M src/mainboard/google/brya/variants/taeko/gpio.c A src/mainboard/google/brya/variants/taeko/runtimestorage.c 5 files changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/62941/1 diff --git a/src/mainboard/google/brya/romstage.c b/src/mainboard/google/brya/romstage.c index 4e88eca..e43e7d4 100644 --- a/src/mainboard/google/brya/romstage.c +++ b/src/mainboard/google/brya/romstage.c @@ -23,4 +23,9 @@ pads = variant_romstage_gpio_table(&pads_num); gpio_configure_pads(pads, pads_num); + pcieclk_override(memupd); +} + +__weak void pcieclk_override(FSPM_UPD *memupd) +{ } diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h index 9accc08..d065c96 100644 --- a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h @@ -17,6 +17,7 @@ const struct pad_config *variant_early_gpio_table(size_t *num); const struct cros_gpio *variant_cros_gpios(size_t *num); const struct pad_config *variant_romstage_gpio_table(size_t *num); +const struct pad_config *variant_special_gpio_table(size_t *num); const struct mb_cfg *variant_memory_params(void); void variant_get_spd_info(struct mem_spd *spd_info); @@ -24,6 +25,7 @@ bool variant_is_half_populated(void); void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config); void variant_fill_ssdt(const struct device *dev); +void pcieclk_override(FSPM_UPD *memupd); enum s0ix_entry { S0IX_EXIT, diff --git a/src/mainboard/google/brya/variants/taeko/Makefile.inc b/src/mainboard/google/brya/variants/taeko/Makefile.inc index 396e5be..f3b1239 100644 --- a/src/mainboard/google/brya/variants/taeko/Makefile.inc +++ b/src/mainboard/google/brya/variants/taeko/Makefile.inc @@ -4,6 +4,8 @@ romstage-y += memory.c +romstage-y += runtimestorage.c + ramstage-y += gpio.c ramstage-$(CONFIG_FW_CONFIG) += fw_config.c diff --git a/src/mainboard/google/brya/variants/taeko/gpio.c b/src/mainboard/google/brya/variants/taeko/gpio.c index 2005760..69bf47a 100644 --- a/src/mainboard/google/brya/variants/taeko/gpio.c +++ b/src/mainboard/google/brya/variants/taeko/gpio.c @@ -206,6 +206,11 @@ PAD_CFG_GPO(GPP_B4, 1, DEEP), }; +static const struct pad_config special_gpio_table[] = { + /* F19 : SRCCLKREQ6# ==> eMMC_detect */ + PAD_CFG_GPI(GPP_F19, NONE, DEEP), +}; + const struct pad_config *variant_gpio_override_table(size_t *num) { *num = ARRAY_SIZE(override_gpio_table); @@ -223,3 +228,9 @@ *num = ARRAY_SIZE(romstage_gpio_table); return romstage_gpio_table; } + +const struct pad_config *variant_special_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(special_gpio_table); + return special_gpio_table; +} diff --git a/src/mainboard/google/brya/variants/taeko/runtimestorage.c b/src/mainboard/google/brya/variants/taeko/runtimestorage.c new file mode 100644 index 0000000..3f470d5 --- /dev/null +++ b/src/mainboard/google/brya/variants/taeko/runtimestorage.c @@ -0,0 +1,29 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <soc/romstage.h> +#include <fw_config.h> +#include <gpio.h> +#include <console/console.h> +#include <baseboard/variants.h> +#include <soc/pcie.h> + +void pcieclk_override(FSPM_UPD *memupd) +{ + FSP_M_CONFIG *m_cfg = &memupd->FspmConfig; + printk(BIOS_INFO, "Kevin_Say hello.\n"); + printk(BIOS_INFO, "Kevin_GPIOF19: %x.\n", gpio_get(GPP_F19)); + if(fw_config_probe(FW_CONFIG(BOOT_NVME_MASK, BOOT_NVME_ENABLED)) && + fw_config_probe(FW_CONFIG(BOOT_EMMC_MASK, BOOT_EMMC_ENABLED))){ + printk(BIOS_INFO, "Kevin_7035.\n"); + const struct pad_config *pads; + size_t pads_num; + + pads = variant_special_gpio_table(&pads_num); + gpio_configure_pads(pads, pads_num); + + if(!gpio_get(GPP_F19)){ + m_cfg->PcieClkSrcUsage[0] = 8; + m_cfg->PcieClkSrcClkReq[0] = 0; + } + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/62941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6eb29680518ba5ba447ac16aef5eaaf0262437e0 Gerrit-Change-Number: 62941 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common: Retry END_OF_POST command
by Sridhar Siricilla (Code Review) 20 Mar '22

20 Mar '22

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62192 ) Change subject: soc/intel/common: Retry END_OF_POST command ...................................................................... Patch Set 14: (2 comments) Patchset: PS14: > Result from a test: applying CB:62272 on TGL also resolved the issue without having to retry Thanks for verifying the patch. File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/62192/comment/067ad372_ad04fc64 PS12, Line 14: #define CSE_MAX_RETRY_CMD 3 > I don't think we need a macro for this, do we? sorry, I didn't notice the comment. Since the retry is specific purpose, so do you suggest the macro is not needed here? or any other reason? -- To view, visit https://review.coreboot.org/c/coreboot/+/62192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683 Gerrit-Change-Number: 62192 Gerrit-PatchSet: 14 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.nest(a)gmail.com> Gerrit-Comment-Date: Sun, 20 Mar 2022 06:47:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Move documentation license to main menu
by Felix Singer (Code Review) 20 Mar '22

20 Mar '22

Attention is currently required from: Nico Huber, Patrick Georgi, Paul Menzel, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Paul Menzel, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62767 to look at the new patch set (#4). Change subject: Documentation: Move documentation license to main menu ...................................................................... Documentation: Move documentation license to main menu The "Getting started" section is not an appropriate place for the documentation license. It should rather be listed in the main menu. Thus, move it there. Change-Id: I8bfc4f52da8a93d78a62e3a68fd6f1dc8ae4d335 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- R Documentation/documentation_license.md M Documentation/getting_started/index.md M Documentation/index.md 3 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/62767/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8bfc4f52da8a93d78a62e3a68fd6f1dc8ae4d335 Gerrit-Change-Number: 62767 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation: Move documentation license to main menu
by Felix Singer (Code Review) 20 Mar '22

20 Mar '22

Attention is currently required from: Nico Huber, Patrick Georgi, Paul Menzel, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62767 ) Change subject: Documentation: Move documentation license to main menu ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/62767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8bfc4f52da8a93d78a62e3a68fd6f1dc8ae4d335 Gerrit-Change-Number: 62767 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 20 Mar 2022 02:55:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/mtl: Do initial SoC commit till bootblock
by Ravishankar Sarawadi (Code Review) 20 Mar '22

20 Mar '22

Attention is currently required from: Felix Singer, Jamie Ryu, Ethan Tsao, Ravishankar Sarawadi, Raj Astekar. Hello build bot (Jenkins), Jamie Ryu, Wonkyu Kim, Ethan Tsao, Raj Astekar, Ravishankar Sarawadi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62772 to look at the new patch set (#4). Change subject: soc/intel/mtl: Do initial SoC commit till bootblock ...................................................................... soc/intel/mtl: Do initial SoC commit till bootblock List of changes: 1. Add required SoC programming till bootblock 2. Include only required headers into include/soc 3. Include MTL-P related DID, BDF 4. Ref: Processor EDS documents vol1 #621483, vol2 #640858 Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Change-Id: I26479fcc3a3f9c6f8ebf5f198ab0809f0b4a2cc4 --- A src/soc/intel/meteorlake/Kconfig A src/soc/intel/meteorlake/Makefile.inc A src/soc/intel/meteorlake/bootblock/bootblock.c A src/soc/intel/meteorlake/bootblock/pch.c A src/soc/intel/meteorlake/bootblock/report_platform.c A src/soc/intel/meteorlake/include/soc/bootblock.h A src/soc/intel/meteorlake/include/soc/espi.h A src/soc/intel/meteorlake/include/soc/iomap.h A src/soc/intel/meteorlake/include/soc/p2sb.h A src/soc/intel/meteorlake/include/soc/pci_devs.h A src/soc/intel/meteorlake/include/soc/pcr_ids.h A src/soc/intel/meteorlake/include/soc/pm.h A src/soc/intel/meteorlake/include/soc/smbus.h 13 files changed, 1,036 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/62772/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62772 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26479fcc3a3f9c6f8ebf5f198ab0809f0b4a2cc4 Gerrit-Change-Number: 62772 Gerrit-PatchSet: 4 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in em100[master]: makechips.sh: Reformat script with shfmt
by Paul Menzel (Code Review) 19 Mar '22

19 Mar '22

Attention is currently required from: Martin L Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/em100/+/62939 ) Change subject: makechips.sh: Reformat script with shfmt ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/em100/+/62939/comment/cf11c826_bde36e99 PS1, Line 8: Maybe add the shfmt version. -- To view, visit https://review.coreboot.org/c/em100/+/62939 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I92c1044f93e0322fe13ea3804371203e321293d9 Gerrit-Change-Number: 62939 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sat, 19 Mar 2022 20:26:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in em100[master]: makechips.sh: Clean up shellcheck errors and formatting
by Paul Menzel (Code Review) 19 Mar '22

19 Mar '22

Attention is currently required from: Martin L Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/em100/+/62937 ) Change subject: makechips.sh: Clean up shellcheck errors and formatting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/em100/+/62937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: Ia756d67d0a0464971e395189027b01787b6b19bd Gerrit-Change-Number: 62937 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Comment-Date: Sat, 19 Mar 2022 20:25:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022