coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update telemetry value
by Rob Barnes (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Kenneth Chan, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63136 ) Change subject: mb/google/guybrush/var/dewatt: Update telemetry value ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Gerrit-Change-Number: 63136 Gerrit-PatchSet: 4 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:43:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt
by Karthik Ramasubramanian (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Robert Zieba, Chris Wang, Rob Barnes, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63132 ) Change subject: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc: https://review.coreboot.org/c/coreboot/+/63132/comment/ef5d6b10_6d2d12ff PS4, Line 16: SPD_SOURCES += $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memory/K4U6E3S4AB-MGCL.hex # ID = 9(0b1001) Parts = K4U6E3S4AB-MGCL > +1. As is, this will get overwritten every time part_id_gen is run. We could modify apcb_v3_edit. […] Sigh this is needing more one-off. For parts that need exclusive IDs, we can support part specific SPDs through update to part_id_gen. -- To view, visit https://review.coreboot.org/c/coreboot/+/63132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia54726ce8c1bae46dcd4fed3df509ef184914e94 Gerrit-Change-Number: 63132 Gerrit-PatchSet: 4 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:37:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robert Zieba <robertzieba(a)google.com> Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: add new board L14xMU
by Michael Niewöhner (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel, Tim Wawrzynczak, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 ) Change subject: mb/clevo/tgl-u: add new board L14xMU ...................................................................... Patch Set 14: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59548/comment/12e7b89c_a752dae7 PS14, Line 56: - WLAN/BT (PCIe) - gets detected but can't be enabled > Could it be related to rfkill stuff? yes, bc of the missing EC driver File src/mainboard/clevo/tgl-u/Kconfig: https://review.coreboot.org/c/coreboot/+/59548/comment/7c04602c_845eb4a7 PS13, Line 12: select MAINBOARD_HAS_LPC_TPM > What if someone wants to use fTPM? well, we have no means making that selectable for the user atm. We'll need to resolve that issue with fTPM when using recent vendor csme-regions, where we can add some Kconfig/cmos option for making it choosable for the user. File src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb: https://review.coreboot.org/c/coreboot/+/59548/comment/514e0b3d_febe1a3b PS13, Line 147: device ref i2c1 on > What is this used for? TBT ROM, I'll add a comment File src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb: https://review.coreboot.org/c/coreboot/+/59548/comment/8d012fff_1c9fd8f3 PS14, Line 191: device ref peg on > nit: I'd move this before `tbt_pcie_rp0` why? it's a SSD slot like pcie_rp9, so grouping them makes more sense to me -- To view, visit https://review.coreboot.org/c/coreboot/+/59548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Gerrit-Change-Number: 59548 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:34:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Docs/project_ideas: Implement the ARM BBR spec in coreboot
by Arthur Heymans (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Arthur Heymans, Felix Singer, Angel Pons, Julius Werner, ron minnich. Arthur Heymans has uploaded a new patch set (#3) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/63034 ) Change subject: Docs/project_ideas: Implement the ARM BBR spec in coreboot ...................................................................... Docs/project_ideas: Implement the ARM BBR spec in coreboot Change-Id: I0f5f1f0a613ed0ed3f8ecdf3c1330a0d78efe399 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Documentation/contributing/project_ideas.md 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/63034/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63034 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f5f1f0a613ed0ed3f8ecdf3c1330a0d78efe399 Gerrit-Change-Number: 63034 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Docs/project_ideas: Make coreboot ARM BBR compliant
by Arthur Heymans (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Arthur Heymans, Felix Singer, Angel Pons, Julius Werner, ron minnich. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63034 ) Change subject: Docs/project_ideas: Make coreboot ARM BBR compliant ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63034/comment/c177b9ea_ae839c06 PS2, Line 7: Make coreboot ARM BBR compliant > Please update accordingly as per Julius' comment Thanks. I only changed the actual file. -- To view, visit https://review.coreboot.org/c/coreboot/+/63034 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f5f1f0a613ed0ed3f8ecdf3c1330a0d78efe399 Gerrit-Change-Number: 63034 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:32:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Disable EN_SPKR on init
by Yu-hsuan Hsu (Code Review) 28 Mar '22

28 Mar '22

Yu-hsuan Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63145 ) Change subject: mb/google/guybrush: Disable EN_SPKR on init ...................................................................... mb/google/guybrush: Disable EN_SPKR on init We don't want to enable the speaker on init. It will be enabled while using GPIO AMP codec in depthcharge. BUG=b:223289882 TEST=boot guybrush and verify the devbeep and gpio value in kernel Change-Id: Ic949cc95556913a2afef4a683a49eaa1e07e6147 Signed-off-by: Yu-Hsuan Hsu <yuhsuan(a)google.com> --- M src/mainboard/google/guybrush/variants/guybrush/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/63145/1 diff --git a/src/mainboard/google/guybrush/variants/guybrush/gpio.c b/src/mainboard/google/guybrush/variants/guybrush/gpio.c index cea1f42..f3ed09f 100644 --- a/src/mainboard/google/guybrush/variants/guybrush/gpio.c +++ b/src/mainboard/google/guybrush/variants/guybrush/gpio.c @@ -35,7 +35,7 @@ /* EN_PWR_FP */ PAD_GPO(GPIO_32, LOW), /* EN_SPKR */ - PAD_GPO(GPIO_31, HIGH), + PAD_GPO(GPIO_31, LOW), /* Unused TP27 */ PAD_NC(GPIO_70), }; -- To view, visit https://review.coreboot.org/c/coreboot/+/63145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic949cc95556913a2afef4a683a49eaa1e07e6147 Gerrit-Change-Number: 63145 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/console/Kconfig: Add option to disable loglevel prefix
by Igor Bagnucki (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Igor Bagnucki. Hello Igor Bagnucki, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/63144 to review the following change. Change subject: src/console/Kconfig: Add option to disable loglevel prefix ...................................................................... src/console/Kconfig: Add option to disable loglevel prefix Signed-off-by: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Change-Id: I911bb601cf1933a4c6498b2ae1e4cb4d4bc85621 --- M src/console/Kconfig M src/console/printk.c 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/63144/1 diff --git a/src/console/Kconfig b/src/console/Kconfig index 37d8fef..6152592 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -395,6 +395,15 @@ endif +config CONSOLE_USE_LOGLEVEL_PREFIX + bool "Use loglevel prefix to indicate line loglevel" + default y + help + When enabled, if the code contains a: + `printk(BIOS_DEBUG, "This is a debug message!\n")`, + it will show up as: + `[DEBUG] This is a debug message!` + config CONSOLE_USE_ANSI_ESCAPES bool "Use ANSI escape sequences for console highlighting" default y diff --git a/src/console/printk.c b/src/console/printk.c index eb35c53..1ce2fad 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -96,7 +96,8 @@ and potentially an escape sequence for highlighting. */ if (CONFIG(CONSOLE_USE_ANSI_ESCAPES)) wrap_interactive_printf(BIOS_LOG_ESCAPE_PATTERN, bios_log_escape[state.level]); - wrap_interactive_printf(BIOS_LOG_PREFIX_PATTERN, bios_log_prefix[state.level]); + if (CONFIG(CONSOLE_USE_LOGLEVEL_PREFIX)) + wrap_interactive_printf(BIOS_LOG_PREFIX_PATTERN, bios_log_prefix[state.level]); } static void line_end(union log_state state) -- To view, visit https://review.coreboot.org/c/coreboot/+/63144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I911bb601cf1933a4c6498b2ae1e4cb4d4bc85621 Gerrit-Change-Number: 63144 Gerrit-PatchSet: 1 Gerrit-Owner: Igor Bagnucki Gerrit-Reviewer: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-Attention: Igor Bagnucki <igor.bagnucki(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/clevo/tgl-u: add new board L14xMU
by Angel Pons (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel, Tim Wawrzynczak, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 ) Change subject: mb/clevo/tgl-u: add new board L14xMU ...................................................................... Patch Set 14: Code-Review+1 (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59548/comment/c0d4f064_da58bd3c PS14, Line 56: - WLAN/BT (PCIe) - gets detected but can't be enabled Could it be related to rfkill stuff? File src/mainboard/clevo/tgl-u/Kconfig: https://review.coreboot.org/c/coreboot/+/59548/comment/e37d525d_9d84d7f0 PS13, Line 12: select MAINBOARD_HAS_LPC_TPM What if someone wants to use fTPM? File src/mainboard/clevo/tgl-u/cmos.layout: https://review.coreboot.org/c/coreboot/+/59548/comment/690d4341_b0e5682f PS13, Line 20: 400 1 e 2 hyper_threading Doesn't this conflict with century byte? File src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb: https://review.coreboot.org/c/coreboot/+/59548/comment/24f001a6_949736d2 PS13, Line 26: DdiPortAConfig Looks like this should use an enum https://review.coreboot.org/c/coreboot/+/59548/comment/18f99b7e_a7a3ab52 PS13, Line 147: device ref i2c1 on What is this used for? File src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb: https://review.coreboot.org/c/coreboot/+/59548/comment/88ea0aae_898eed65 PS14, Line 191: device ref peg on nit: I'd move this before `tbt_pcie_rp0` -- To view, visit https://review.coreboot.org/c/coreboot/+/59548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Gerrit-Change-Number: 59548 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: add new board L14xMU
by Michael Niewöhner (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel, Tim Wawrzynczak. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 ) Change subject: mb/clevo/tgl-u: add new board L14xMU ...................................................................... Patch Set 14: (1 comment) File src/mainboard/clevo/cml-u/Kconfig: PS13: > ugh, this wasn't planned o. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Gerrit-Change-Number: 59548 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:07:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: add new board L14xMU
by build bot (Jenkins) (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 ) Change subject: mb/clevo/tgl-u: add new board L14xMU ...................................................................... Patch Set 14: (6 comments) File src/mainboard/clevo/tgl-u/variants/l140mu/gpio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/ff4d424f_5a83b86d PS14, Line 94: PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), /* I2C1_SDA / PCH_I2C_SDA (retimer rom) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/c7f64b87_df26fb54 PS14, Line 95: PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), /* I2C1_SCL / PCH_I2C_SCL (retimer rom) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/ab6cc145_57557364 PS14, Line 99: PAD_NC(GPP_C23, UP_20K), /* GPP_C23 / PCH_GPP_C23 (WLAN_WAKEUP#) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/99a23afe_304d4aad PS14, Line 104: PAD_NC(GPP_D2, NONE), /* LEDKB_DET# (unused; not sold w/o KBLED) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/047ca0e3_ed248ae1 PS14, Line 107: PAD_CFG_NF(GPP_D5, NONE, DEEP, NF1), /* SRCCLKREQ0# / SSD1_CLKREQ# (for SSD2!) */ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144878): https://review.coreboot.org/c/coreboot/+/59548/comment/258f39f4_a1c049ba PS14, Line 110: PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* SRCCLKREQ3# / SSD2_CLKREQ# (for SSD1!) */ line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/59548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620 Gerrit-Change-Number: 59548 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 28 Mar 2022 16:07:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022