coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: util/amdfwtool: use ISH support for Sabrina SoC
by Felix Held (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Felix Held. Hello build bot (Jenkins), Raul Rangel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63186 to look at the new patch set (#2). Change subject: util/amdfwtool: use ISH support for Sabrina SoC ...................................................................... util/amdfwtool: use ISH support for Sabrina SoC The PSP in the Sabrina SoC uses the image slot header to find the second level PSP directory table, so it needs the ISH to be generated. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I9e6308854147c9f6f72d722215c833ee86ee4f94 --- M util/amdfwtool/amdfwtool.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/63186/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e6308854147c9f6f72d722215c833ee86ee4f94 Gerrit-Change-Number: 63186 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/amdfwtool: select A/B recovery when ISH is used
by Felix Held (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Raul Rangel. Hello build bot (Jenkins), Raul Rangel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63184 to look at the new patch set (#2). Change subject: util/amdfwtool: select A/B recovery when ISH is used ...................................................................... util/amdfwtool: select A/B recovery when ISH is used In newer AMD SoCs, the image slot header is used in the AMD A/B recovery scheme, so set recovery_ab to true when need_ish is true. Also move the block of code before the process_config call, since that call will already use the recovery_ab field of the cb_config struct. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I65903765514f215bf5cc9b949d0b95aff781eb34 --- M util/amdfwtool/amdfwtool.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/63184/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65903765514f215bf5cc9b949d0b95aff781eb34 Gerrit-Change-Number: 63184 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/amdfwtool: select A/B recovery when ISH is used
by Felix Held (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Raul Rangel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63184 ) Change subject: util/amdfwtool: select A/B recovery when ISH is used ...................................................................... Patch Set 1: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/63184/comment/d9f26ba2_0203a09d PS1, Line 1687: if (cb_config.need_ish) { > > braces {} are not necessary for single statement blocks […] i still consider leaving out the braces bad practice, but if you want me to, i'll change that in this patch -- To view, visit https://review.coreboot.org/c/coreboot/+/63184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65903765514f215bf5cc9b949d0b95aff781eb34 Gerrit-Change-Number: 63184 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Tue, 29 Mar 2022 23:13:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/sabrina/makefile: use Sabrina as SoC name in amdfwtool call
by Felix Held (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63189 ) Change subject: soc/amd/sabrina/makefile: use Sabrina as SoC name in amdfwtool call ...................................................................... soc/amd/sabrina/makefile: use Sabrina as SoC name in amdfwtool call Now that the amdfwtool support for Sabrina is in place, change the SoC name parameter passed to amdfwtool from Cezanne to Sabrina. The fw.cfg file still points to the Cezanne binaries, but since commit 9cb0a05dfb308323a5b3df1a25fa66b35ecfcdd6 (soc/amd/sabrina: Add prompt for AMDFW_CONFIG_FILE) this can be overridden via the Kconfig config file in the build. As soon as the Sabrina PSP binaries are available in 3rparty/amd_blobs, the fw.cfg file will be updated to use the correct ones for Sabrina. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I53a8de222e39bd2b92c07661b6c52a02fb651609 --- M src/soc/amd/sabrina/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/63189/1 diff --git a/src/soc/amd/sabrina/Makefile.inc b/src/soc/amd/sabrina/Makefile.inc index deffc15..be6a7d1 100644 --- a/src/soc/amd/sabrina/Makefile.inc +++ b/src/soc/amd/sabrina/Makefile.inc @@ -210,7 +210,7 @@ $(OPT_EFS_SPI_SPEED) \ $(OPT_EFS_SPI_MICRON_FLAG) \ --config $(CONFIG_AMDFW_CONFIG_FILE) \ - --soc-name "Cezanne" \ + --soc-name "Sabrina" \ --flashsize $(CONFIG_ROM_SIZE) $(obj)/amdfw.rom: $(call strip_quotes, $(PSP_BIOSBIN_FILE)) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/63189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53a8de222e39bd2b92c07661b6c52a02fb651609 Gerrit-Change-Number: 63189 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/sabrina/makefile: drop PSP_S0I3_RESUME_VERSTAGE handling
by Felix Held (Code Review) 30 Mar '22

30 Mar '22

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63188 ) Change subject: soc/amd/sabrina/makefile: drop PSP_S0I3_RESUME_VERSTAGE handling ...................................................................... soc/amd/sabrina/makefile: drop PSP_S0I3_RESUME_VERSTAGE handling The PSP_S0I3_RESUME_VERSTAGE Kconfig symbol is only defined in the Cezanne Kconfig, so drop this from the Sabrina makefile. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I9571a302d427981cdf750a1cb3b7f4db9d61a87c --- M src/soc/amd/sabrina/Makefile.inc 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/63188/1 diff --git a/src/soc/amd/sabrina/Makefile.inc b/src/soc/amd/sabrina/Makefile.inc index b180156..deffc15 100644 --- a/src/soc/amd/sabrina/Makefile.inc +++ b/src/soc/amd/sabrina/Makefile.inc @@ -110,10 +110,6 @@ PSP_SOFTFUSE_BITS += 29 endif -ifeq ($(CONFIG_PSP_S0I3_RESUME_VERSTAGE),y) -PSP_SOFTFUSE_BITS += 58 -endif - # Use additional Soft Fuse bits specified in Kconfig PSP_SOFTFUSE_BITS += $(call strip_quotes, $(CONFIG_PSP_SOFTFUSE_BITS)) -- To view, visit https://review.coreboot.org/c/coreboot/+/63188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9571a302d427981cdf750a1cb3b7f4db9d61a87c Gerrit-Change-Number: 63188 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Makefile.inc: Explicitly delete coreboot.pre
by Raul Rangel (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Nico Huber, Martin Roth, Paul Menzel. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62922 ) Change subject: Makefile.inc: Explicitly delete coreboot.pre ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62922/comment/fdfd8b83_fd52cf8a PS1, Line 13: > If you have a reproducer, it’d be great if you could add it. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5fa3f0b8d314369a044658e452bd75bc7709397 Gerrit-Change-Number: 62922 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 29 Mar 2022 22:44:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile.inc: Explicitly delete coreboot.pre
by Raul Rangel (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Nico Huber, Raul Rangel, Martin Roth. Hello build bot (Jenkins), Nico Huber, Martin Roth, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62922 to look at the new patch set (#2). Change subject: Makefile.inc: Explicitly delete coreboot.pre ...................................................................... Makefile.inc: Explicitly delete coreboot.pre coreboot.pre doesn't follow the standard Make conventions. It gets modified by multiple rules, and thus we can't compute the dependencies correctly. This means we need to manually delete it before starting the dependency calculations. i.e., Building firmware with the seabios payload now works correctly. Fixes: dd6efce934f ("Makefile: Add .SECONDARY") Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: If5fa3f0b8d314369a044658e452bd75bc7709397 --- M Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/62922/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5fa3f0b8d314369a044658e452bd75bc7709397 Gerrit-Change-Number: 62922 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbmem: Add FlameGraph-compatible timestamps output
by Julius Werner (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak, Paul Menzel, Alex Levin, Jan Dabros. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62474 ) Change subject: util/cbmem: Add FlameGraph-compatible timestamps output ...................................................................... Patch Set 15: (5 comments) File src/commonlib/include/commonlib/timestamp_serialized.h: https://review.coreboot.org/c/coreboot/+/62474/comment/8d87183a_ef5db206 PS7, Line 454: uint32_t id_end; > > Hmm... okay, that's an odd case. […] I think the zeroes are fine. However, you still need to remove this other array now, right? (timestamp_start_end_pairs) File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/62474/comment/d91aa8da_ba8a1ed0 PS8, Line 629: :: > I had some problems with spaces before, but I tested it again and it seems to work correctly. […] Ah cool. I think in that case, `TS_ROMSTAGE_START -> TS_ROMSTAGE_END` would probably look best. But up to you. File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/62474/comment/3fc5831e_8c05508b PS15, Line 601: possible_match = timestamp_ids[i].id_end; This should also have a break; https://review.coreboot.org/c/coreboot/+/62474/comment/b0f530d3_2f7f5669 PS15, Line 643: = 0, nit: this enum doesn't really need explicitly assigned values. (As a rule of thumb enums should only have that if a) they get serialized, b) they represent a bit pattern actually written to hardware, or c) they're likely to get printed into logs where you may want to be able to easily cross-reference them.) https://review.coreboot.org/c/coreboot/+/62474/comment/0c747b56_06d2097e PS15, Line 1580: timestamp_type != TIMESTAMPS_PRINT_NONE : ? timestamp_type : : TIMESTAMPS_PRINT_NORMAL Oh, right, I didn't consider how ugly this would get with that... Maybe would look a bit better to just do if (print_defaults) timestamp_type = TIMESTAMPS_PRINT_NORMAL; on a separate line before this? -- To view, visit https://review.coreboot.org/c/coreboot/+/62474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33 Gerrit-Change-Number: 62474 Gerrit-PatchSet: 15 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Alex Levin <levinale(a)google.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex Levin <levinale(a)google.com> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 22:39:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Call espi_switch_to_spi1_pads
by Felix Held (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63096 ) Change subject: mb/google/skyrim: Call espi_switch_to_spi1_pads ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43713d7376a28ced2be635668836464ceec46392 Gerrit-Change-Number: 63096 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 22:38:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/sabrina: Add espi_switch_to_spi1_pads
by Felix Held (Code Review) 30 Mar '22

30 Mar '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63095 ) Change subject: soc/amd/sabrina: Add espi_switch_to_spi1_pads ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96baf6b9c169ed61d221352b29ac676bca40da21 Gerrit-Change-Number: 63095 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 22:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022