coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/brya/var/agah: Replace amp max98309 with max98360
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

Attention is currently required from: Tony Huang, Wisley Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63196 ) Change subject: mb/google/brya/var/agah: Replace amp max98309 with max98360 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63196/comment/1736e08e_c020a7df PS1, Line 9: Based on the latest schematic, replace amp max98390 with max98360. suggestion: ``` Based on the latest schematic, agah will replace the Maxim 98390 speaker amps with Maxim max98360. This patch updates the devicetree entries to reflect that. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/63196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ea36d276f7ffeae1510483027092e2bc59690fc Gerrit-Change-Number: 63196 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 22:00:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/agah: Add GL9750 SD card reader support
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

Attention is currently required from: Tony Huang, Wisley Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63194 ) Change subject: mb/google/brya/var/agah: Add GL9750 SD card reader support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I881c2c1ad7b0d10b7ae38fcd9814f757cf56feb5 Gerrit-Change-Number: 63194 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 21:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kinox: set GPP_D0 to NC
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

Attention is currently required from: Dtrain Hsu, Nick Vaccaro, Zhuohao Lee, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63195 ) Change subject: mb/google/brya/var/kinox: set GPP_D0 to NC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38b9eb2df83cfbdb58d95cb178c1d767299aa4da Gerrit-Change-Number: 63195 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 21:58:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kinox: set GPP_D0 to NC
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

Attention is currently required from: Dtrain Hsu, Nick Vaccaro, Zhuohao Lee, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63195 ) Change subject: mb/google/brya/var/kinox: set GPP_D0 to NC ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63195/comment/e71f1396_41b55925 PS1, Line 9: CB:63090 `commit b0769db4` should also work here, some folks prefer the commit hash instead -- To view, visit https://review.coreboot.org/c/coreboot/+/63195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38b9eb2df83cfbdb58d95cb178c1d767299aa4da Gerrit-Change-Number: 63195 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 21:58:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus: Set touchpad/screen IRQ to LEVEL vs EDGE
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

Attention is currently required from: Matt DeVillier. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63213 ) Change subject: mb/google/octopus: Set touchpad/screen IRQ to LEVEL vs EDGE ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: this seems to be so mixed; pretty much all google mainboards use a mix of EDGE and LEVEL for TS and TP... -- To view, visit https://review.coreboot.org/c/coreboot/+/63213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13bc6920a0dfaf769091b1764a7584902d1f85d6 Gerrit-Change-Number: 63213 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 21:56:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus: Implement touchscreen,digitizer power sequencing
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

Attention is currently required from: Matt DeVillier, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63212 ) Change subject: mb/google/octopus: Implement touchscreen,digitizer power sequencing ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63212/comment/447e653b_cd4ffd56 PS1, Line 9: ocotpus octopus -- To view, visit https://review.coreboot.org/c/coreboot/+/63212 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia725b4054069c0a4f60afd7e0bca6e2fd5fdcbba Gerrit-Change-Number: 63212 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 21:53:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/generic: Add support for i2c device detection
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

Attention is currently required from: Raul Rangel, Matt DeVillier, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63211 ) Change subject: drivers/i2c/generic: Add support for i2c device detection ...................................................................... Patch Set 1: (3 comments) File src/drivers/i2c/generic/generic.c: https://review.coreboot.org/c/coreboot/+/63211/comment/5df78ad7_ba74aa97 PS1, Line 70: (struct device *) Oops I think we constified i2c_busdev, so this cast shouldn't be necessary right? https://review.coreboot.org/c/coreboot/+/63211/comment/38069023_273b8aa3 PS1, Line 73: if (!detected) I would add a message here, saying that no ACPI entry is being created for this device b/c it was not detected https://review.coreboot.org/c/coreboot/+/63211/comment/4e524af4_72df0585 PS1, Line 71: bool detected = busdev->ops->ops_i2c_bus->detect(busdev, : dev->path.i2c.device); : if (!detected) : return; make sure to check `busdev` and the `detect` fn pointer aren't NULL, too, (maybe more prints too) e.g. ``` struct device *const busdev = i2c_busdev((struct device *)dev); if (busdev && busdev->ops->ops_i2c_bus->detect) { printk(BIOS_INFO, "Attempting I2C detection of %s\n", dev_path(dev)); if (!busdev->ops->ops_i2c_bus->detect(busdev, dev->path.i2c.device)) { printk(BIOS_INFO, "Device %s was not detected; no ACPI entry will be created\n", dev_path(dev)); return; } } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/63211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a4169ed6416d544773a37d29cdcc154d3c28519 Gerrit-Change-Number: 63211 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 30 Mar 2022 21:51:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ChromeoS: Retain ACPI CNVS contents on S3 resume
by Kyösti Mälkki (Code Review) 31 Mar '22

31 Mar '22

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61619 ) Change subject: ChromeoS: Retain ACPI CNVS contents on S3 resume ...................................................................... ChromeoS: Retain ACPI CNVS contents on S3 resume For platforms without EC_GOOGLE_CHROMEEC S3 resume path always reported ACTIVE_ECFW_RO because acpi_fill_cnvs() and mainboard_chromeos_acpi_generate() were not called. Change-Id: Iea71a51aba7ab1b6966389c17a1e06ccc96ae0e9 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61619 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/vendorcode/google/chromeos/gnvs.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/vendorcode/google/chromeos/gnvs.c b/src/vendorcode/google/chromeos/gnvs.c index 7236662..7821786 100644 --- a/src/vendorcode/google/chromeos/gnvs.c +++ b/src/vendorcode/google/chromeos/gnvs.c @@ -40,6 +40,10 @@ if (!chromeos_acpi) return; + /* Retain CNVS contents on S3 resume path. */ + if (acpi_is_wakeup_s3()) + return; + vpd_size = chromeos_vpd_region("RO_VPD", &vpd_base); if (vpd_size && vpd_base) { chromeos_acpi->vpd_ro_base = vpd_base; -- To view, visit https://review.coreboot.org/c/coreboot/+/61619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea71a51aba7ab1b6966389c17a1e06ccc96ae0e9 Gerrit-Change-Number: 61619 Gerrit-PatchSet: 6 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: device/i2c_bus: Add probe function pointer in i2c_bus_ops
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

1 0

Change in coreboot[master]: device/i2c_bus: Constify i2c_busdev and i2c_link
by Tim Wawrzynczak (Code Review) 31 Mar '22

31 Mar '22

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022