coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7066 discussions

Change in coreboot[master]: mb/google/{octopus,reef}: correct SMMSTORE alignment in default FMAP
by Matt DeVillier (Code Review) 02 Feb '22

02 Feb '22

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61564 ) Change subject: mb/google/{octopus,reef}: correct SMMSTORE alignment in default FMAP ...................................................................... mb/google/{octopus,reef}: correct SMMSTORE alignment in default FMAP SMMSTORE needs to be 64k-aligned (for cases where erase block size is 64k). Fix start address to correct alignment. Test: build google/octopus, google/reef without assert error due to SMMSTORE alignment Change-Id: I9087089c1416f16c4f824b6dfaa8431e36efe485 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/octopus/default.fmd M src/mainboard/google/reef/default.fmd 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/61564/1 diff --git a/src/mainboard/google/octopus/default.fmd b/src/mainboard/google/octopus/default.fmd index 79b2a6a..cdcdc99 100644 --- a/src/mainboard/google/octopus/default.fmd +++ b/src/mainboard/google/octopus/default.fmd @@ -3,7 +3,7 @@ SI_BIOS@0x1000 0xf7e000 { IFWI@0x0 0x1ff000 # SMMSTORE requires 64k alignment - SMMSTORE@0xa5e000 0x40000 + SMMSTORE@0xa5f000 0x40000 UNIFIED_MRC_CACHE 0x21000 { RECOVERY_MRC_CACHE 0x10000 RW_MRC_CACHE 0x10000 diff --git a/src/mainboard/google/reef/default.fmd b/src/mainboard/google/reef/default.fmd index ff8f8ef..dae84b0 100644 --- a/src/mainboard/google/reef/default.fmd +++ b/src/mainboard/google/reef/default.fmd @@ -3,7 +3,7 @@ SI_BIOS@0x1000 0xf7e000 { IFWI@0x0 0x1ff000 # SMMSTORE requires 64k alignment - SMMSTORE@0xa5e000 0x40000 + SMMSTORE@0xa5f000 0x40000 UNIFIED_MRC_CACHE 0x21000 { RECOVERY_MRC_CACHE@0x0 0x10000 RW_MRC_CACHE 0x10000 -- To view, visit https://review.coreboot.org/c/coreboot/+/61564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9087089c1416f16c4f824b6dfaa8431e36efe485 Gerrit-Change-Number: 61564 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/smmstore/store.c: Add static assertion based on fmap
by Arthur Heymans (Code Review) 02 Feb '22

02 Feb '22

Attention is currently required from: Arthur Heymans, Matt DeVillier, MrChromebox. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61562 ) Change subject: drivers/smmstore/store.c: Add static assertion based on fmap ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > correctly flags google/octopus/default.fmd as not having 64k-aligned SMMSTORE region Fixed in https://review.coreboot.org/c/coreboot/+/61563/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5b511142d93d5799565a8936e9a087117044b3 Gerrit-Change-Number: 61562 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Feb 2022 20:28:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus,reef: Align SMMSTORE region in default.fmd
by Arthur Heymans (Code Review) 02 Feb '22

02 Feb '22

Attention is currently required from: Arthur Heymans. Hello Arthur Heymans, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/61563 to review the following change. Change subject: mb/google/octopus,reef: Align SMMSTORE region in default.fmd ...................................................................... mb/google/octopus,reef: Align SMMSTORE region in default.fmd The SMMSTORE region needs to be 64K aligned or error will be thrown. Change-Id: I5d4f71f80c3219ac2c7000e1fa95fd04100d9cfe Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/google/octopus/default.fmd M src/mainboard/google/reef/default.fmd 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/61563/1 diff --git a/src/mainboard/google/octopus/default.fmd b/src/mainboard/google/octopus/default.fmd index 79b2a6a..dec6b48 100644 --- a/src/mainboard/google/octopus/default.fmd +++ b/src/mainboard/google/octopus/default.fmd @@ -3,7 +3,7 @@ SI_BIOS@0x1000 0xf7e000 { IFWI@0x0 0x1ff000 # SMMSTORE requires 64k alignment - SMMSTORE@0xa5e000 0x40000 + SMMSTORE@0xa4f000 0x40000 UNIFIED_MRC_CACHE 0x21000 { RECOVERY_MRC_CACHE 0x10000 RW_MRC_CACHE 0x10000 diff --git a/src/mainboard/google/reef/default.fmd b/src/mainboard/google/reef/default.fmd index ff8f8ef..79a7736 100644 --- a/src/mainboard/google/reef/default.fmd +++ b/src/mainboard/google/reef/default.fmd @@ -3,7 +3,7 @@ SI_BIOS@0x1000 0xf7e000 { IFWI@0x0 0x1ff000 # SMMSTORE requires 64k alignment - SMMSTORE@0xa5e000 0x40000 + SMMSTORE@0xa4f000 0x40000 UNIFIED_MRC_CACHE 0x21000 { RECOVERY_MRC_CACHE@0x0 0x10000 RW_MRC_CACHE 0x10000 -- To view, visit https://review.coreboot.org/c/coreboot/+/61563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d4f71f80c3219ac2c7000e1fa95fd04100d9cfe Gerrit-Change-Number: 61563 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/smmstore/store.c: Add static assertion based on fmap
by Matt DeVillier (Code Review) 02 Feb '22

02 Feb '22

Attention is currently required from: Arthur Heymans, MrChromebox. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61562 ) Change subject: drivers/smmstore/store.c: Add static assertion based on fmap ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: correctly flags google/octopus/default.fmd as not having 64k-aligned SMMSTORE region -- To view, visit https://review.coreboot.org/c/coreboot/+/61562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5b511142d93d5799565a8936e9a087117044b3 Gerrit-Change-Number: 61562 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Feb 2022 20:26:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payload/external/iPXE/Makefile: Clean up the repo before checking out
by Michał Żygowski (Code Review) 02 Feb '22

02 Feb '22

Attention is currently required from: Felix Singer, Martin Roth, Stefan Reinauer. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60007 ) Change subject: payload/external/iPXE/Makefile: Clean up the repo before checking out ...................................................................... Patch Set 2: (1 comment) File payloads/external/iPXE/Makefile: https://review.coreboot.org/c/coreboot/+/60007/comment/7d4634be_b64761a8 PS2, Line 32: git checkout maste > This line should do the same thing, I'd think. […] Force would probably do the trick if this is acceptable. Will check it -- To view, visit https://review.coreboot.org/c/coreboot/+/60007 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3cfbb4c74c6397b00463087aeac58efb2777bbe Gerrit-Change-Number: 60007 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Feb 2022 20:23:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Lock PCH WP pin in brask and brya baseboards
by Nick Vaccaro (Code Review) 02 Feb '22

02 Feb '22

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61501 ) Change subject: mb/google/brya: Lock PCH WP pin in brask and brya baseboards ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia125c513c09ecbb1047100e72f8540369646988e Gerrit-Change-Number: 61501 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Feb 2022 20:10:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Remove `mb_gpio_lock_config()` override function
by Subrata Banik (Code Review) 02 Feb '22

02 Feb '22

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61503 ) Change subject: mb/google/brya: Remove `mb_gpio_lock_config()` override function ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Are you going to follow this up with a change to src/soc/intel/common/block/smm/smihandler. […] Thanks for the pointer, yes, we should. Also, I believe Eric will pick the Soc lock config clean up sooner so we can remove soc_lock_gpios() as well. Thoughts ? -- To view, visit https://review.coreboot.org/c/coreboot/+/61503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7354f2ae3817459b5494d572c603eba48ec66a Gerrit-Change-Number: 61503 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Feb 2022 20:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Lock FPMCU pins in brask and brya baseboards
by Nick Vaccaro (Code Review) 02 Feb '22

02 Feb '22

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61502 ) Change subject: mb/google/brya: Lock FPMCU pins in brask and brya baseboards ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d0b8a5aed6ea54bcfaa267cae5ca78595396ce5 Gerrit-Change-Number: 61502 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Feb 2022 20:04:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Remove used build option
by Matt DeVillier (Code Review) 02 Feb '22

02 Feb '22

Attention is currently required from: Sean Rhodes, Martin Roth, Stefan Reinauer. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61550 ) Change subject: payloads/tianocore: Remove used build option ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: since we do offer the ability to build from upstream edk2 master (or any commit really), we probably want to correct rather than remove the param, or at the least make it a Kconfig option for the payload when the 'upstream' option is selected -- To view, visit https://review.coreboot.org/c/coreboot/+/61550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic52e0afa7744f4a902274c41aed59ca23fd9f5fc Gerrit-Change-Number: 61550 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Feb 2022 20:04:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Remove `mb_gpio_lock_config()` override function
by Nick Vaccaro (Code Review) 02 Feb '22

02 Feb '22

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61503 ) Change subject: mb/google/brya: Remove `mb_gpio_lock_config()` override function ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: Are you going to follow this up with a change to src/soc/intel/common/block/smm/smihandler.c to remove -- To view, visit https://review.coreboot.org/c/coreboot/+/61503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc7354f2ae3817459b5494d572c603eba48ec66a Gerrit-Change-Number: 61503 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Feb 2022 20:02:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022