coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7065 discussions

Change in coreboot[master]: soc/apollolake: Make IO decode / enable register configurable
by build bot (Jenkins) (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Andy Pont, Angel Pons, Andrey Petrov, Patrick Rudolph, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61195 ) Change subject: soc/apollolake: Make IO decode / enable register configurable ...................................................................... Patch Set 5: (2 comments) File src/soc/intel/apollolake/bootblock/bootblock.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139991): https://review.coreboot.org/c/coreboot/+/61195/comment/9e36083d_f697cc88 PS5, Line 78: uint16_t io_enables = LPC_IOE_SUPERIO_2E_2F | LPC_IOE_KBC_60_64 | 'SUPERIO' may be misspelled - perhaps ''? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139991): https://review.coreboot.org/c/coreboot/+/61195/comment/2b190ea4_02cb8276 PS5, Line 95: LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F; 'SUPERIO' may be misspelled - perhaps ''? -- To view, visit https://review.coreboot.org/c/coreboot/+/61195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I598baca0f31b5350a4e6fdb7b7356fa6fb2d71ed Gerrit-Change-Number: 61195 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 04 Feb 2022 09:12:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/apollolake: Make IO decode / enable register configurable
by Sean Rhodes (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Andy Pont, Angel Pons, Andrey Petrov, Patrick Rudolph, Felix Held. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61195 ) Change subject: soc/apollolake: Make IO decode / enable register configurable ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/apollolake/bootblock/bootblock.c: https://review.coreboot.org/c/coreboot/+/61195/comment/5594d94e_cbe2bd02 PS3, Line 106: lpc_enable_fixed_io_ranges(io_enables); > Probably would - I was copying TGL. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/61195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I598baca0f31b5350a4e6fdb7b7356fa6fb2d71ed Gerrit-Change-Number: 61195 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 04 Feb 2022 09:12:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tigerlake: Don't override lpc_io_setup_comm_a_b()
by Sean Rhodes (Code Review) 04 Feb '22

04 Feb '22

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61552 ) Change subject: soc/intel/tigerlake: Don't override lpc_io_setup_comm_a_b() ...................................................................... Abandoned Not needed -- To view, visit https://review.coreboot.org/c/coreboot/+/61552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c28e8dcc1813740b2862b340c95bb80dab9d91e Gerrit-Change-Number: 61552 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: payloads/tianocore: Set project_dir based on repo and branch
by Sean Rhodes (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Martin Roth, Matt DeVillier, Stefan Reinauer. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61620 ) Change subject: payloads/tianocore: Set project_dir based on repo and branch ...................................................................... Patch Set 7: (1 comment) File payloads/external/tianocore/Makefile: https://review.coreboot.org/c/coreboot/+/61620/comment/8986501f_f7361e06 PS7, Line 139: mv $(project_dir)/Build/$(bootloader)*/*/FV/UEFIPAYLOAD.fd $(project_dir)/../output/UEFIPAYLOAD.fd; \ Is there a better way to do this? $(obj)/UEFIPAYLOAD.fd would be nice, but that would be a big change! -- To view, visit https://review.coreboot.org/c/coreboot/+/61620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3cc274e7385dd71c2aae315162cc48444b7eaa5f Gerrit-Change-Number: 61620 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 04 Feb 2022 08:48:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Set project_dir based on repo and branch
by Sean Rhodes (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Martin Roth, Matt DeVillier, Stefan Reinauer. Hello build bot (Jenkins), Martin Roth, Matt DeVillier, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61620 to look at the new patch set (#7). Change subject: payloads/tianocore: Set project_dir based on repo and branch ...................................................................... payloads/tianocore: Set project_dir based on repo and branch Set the project directory based on the git repository name and branch. i.e. mrchromebox+uefipayload_202107 This allows switching between repositories without deleting anything. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I3cc274e7385dd71c2aae315162cc48444b7eaa5f --- M payloads/external/tianocore/Kconfig M payloads/external/tianocore/Makefile 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/61620/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/61620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3cc274e7385dd71c2aae315162cc48444b7eaa5f Gerrit-Change-Number: 61620 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/apollolake: Convert to ASL 2.0
by Subrata Banik (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph, HAOUAS Elyes. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61243 ) Change subject: soc/intel/apollolake: Convert to ASL 2.0 ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb362b5be05421b6ad2b2a3126c2943b7d55d135 Gerrit-Change-Number: 61243 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 04 Feb 2022 08:40:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apollolake: Convert to ASL 2.0
by Subrata Banik (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph, HAOUAS Elyes. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61243 ) Change subject: soc/intel/apollolake: Convert to ASL 2.0 ...................................................................... Patch Set 6: (1 comment) File src/soc/intel/apollolake/acpi/gpiolib.asl: https://review.coreboot.org/c/coreboot/+/61243/comment/314dc73c_adb21833 PS4, Line 61: (Arg0 << 16) | CONFIG_PCR_BASE_ADDRESS > I'm not sure to understand […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/61243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb362b5be05421b6ad2b2a3126c2943b7d55d135 Gerrit-Change-Number: 61243 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 04 Feb 2022 08:39:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Set project_dir based on repo and branch
by Sean Rhodes (Code Review) 04 Feb '22

04 Feb '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61620 ) Change subject: payloads/tianocore: Set project_dir based on repo and branch ...................................................................... payloads/tianocore: Set project_dir based on repo and branch Set the project directory based on the git repository name and branch. i.e. mrchromebox+uefipayload_202107 This allows switching between repositories without deleting anything. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I3cc274e7385dd71c2aae315162cc48444b7eaa5f --- M payloads/external/tianocore/Makefile 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/61620/1 diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 07c236a..8926739 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -4,7 +4,7 @@ export SHELL := env bash project_name = Tianocore -project_dir = $(CURDIR)/tianocore +project_dir = $(CURDIR)/$(word 3,$(subst /, ,$(CONFIG_TIANOCORE_REPOSITORY)))+$(CONFIG_TIANOCORE_TAG_OR_REV) BUILD_STR = -q BUILD_STR += -a IA32 -a X64 -t COREBOOT @@ -84,8 +84,7 @@ cd $(project_dir); update: $(project_dir) - if ! git remote get-url origin | grep -i $(CONFIG_TIANOCORE_REPOSITORY); then \ - rm -rf $(project_dir); \ + if ! -d $(project_dir); then \ git clone --branch $(CONFIG_TIANOCORE_TAG_OR_REV) $(CONFIG_TIANOCORE_REPOSITORY) $(project_dir); \ fi cd $(project_dir); \ -- To view, visit https://review.coreboot.org/c/coreboot/+/61620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3cc274e7385dd71c2aae315162cc48444b7eaa5f Gerrit-Change-Number: 61620 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Hoglin: Switch to using i2c TPM
by Shelley Chen (Code Review) 04 Feb '22

04 Feb '22

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61604 ) Change subject: Hoglin: Switch to using i2c TPM ...................................................................... Hoglin: Switch to using i2c TPM Redefine Hoglin to be used for Qualcomm's CRD 3.0 board, which uses i2c for TPM instead of SPI. From now on, the Piglin board will be used for all the Qualcomm reference boards that use SPI for TPM. BUG=b:206581077 BRANCH=None TEST=hacked an 8MB image and make sure boots on herobrine board Change-Id: Ie1d71ec8b01f305c1c8fa815a0fb9b7ee022cc19 Signed-off-by: Shelley Chen <shchen(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61604 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/herobrine/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved diff --git a/src/mainboard/google/herobrine/Kconfig b/src/mainboard/google/herobrine/Kconfig index 511e4cb..c6dfaab 100644 --- a/src/mainboard/google/herobrine/Kconfig +++ b/src/mainboard/google/herobrine/Kconfig @@ -24,8 +24,8 @@ select SPI_FLASH_WINBOND select SPI_FLASH_MACRONIX select MAINBOARD_HAS_CHROMEOS - select MAINBOARD_HAS_SPI_TPM_CR50 if BOARD_GOOGLE_PIGLIN || BOARD_GOOGLE_HOGLIN - select MAINBOARD_HAS_I2C_TPM_CR50 if BOARD_GOOGLE_HEROBRINE_REV0 || BOARD_GOOGLE_HEROBRINE + select MAINBOARD_HAS_SPI_TPM_CR50 if BOARD_GOOGLE_PIGLIN + select MAINBOARD_HAS_I2C_TPM_CR50 if BOARD_GOOGLE_HEROBRINE_REV0 || BOARD_GOOGLE_HEROBRINE || BOARD_GOOGLE_HOGLIN select MAINBOARD_HAS_TPM2 if !BOARD_GOOGLE_SENOR config VBOOT -- To view, visit https://review.coreboot.org/c/coreboot/+/61604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1d71ec8b01f305c1c8fa815a0fb9b7ee022cc19 Gerrit-Change-Number: 61604 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/apollolake: Convert to ASL 2.0
by HAOUAS Elyes (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Subrata Banik, Andrey Petrov, Patrick Rudolph. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61243 ) Change subject: soc/intel/apollolake: Convert to ASL 2.0 ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/apollolake/acpi/gpiolib.asl: https://review.coreboot.org/c/coreboot/+/61243/comment/c9e89666_55ac4d35 PS4, Line 61: (Arg0 << 16) | CONFIG_PCR_BASE_ADDRESS > Wondering why do have used braces around the expression in one case and not in other line #61 vs #62 […] I'm not sure to understand here we we do not have braces because we have only "or" operation , however, in line #62 we have "+" operation. https://review.coreboot.org/c/coreboot/+/61243/comment/7649b7ab_b86951ae PS4, Line 82: Local1 > Can't we replace Local1 with `CHSA(Arg1)` Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/61243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb362b5be05421b6ad2b2a3126c2943b7d55d135 Gerrit-Change-Number: 61243 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 04 Feb 2022 07:31:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022