Attention is currently required from: Tim Wawrzynczak, Won Chung, Nick Vaccaro, Benson Leung, Prashant Malani.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61571 )
Change subject: mb/google/brya: Add custom PLD fields to devicetree for brya variants
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
> Since there is a lot of redundancy in these custom PLD, and we are following a standard template, […]
Exactly this is in my TODO list, I will pick this up as soon as this CL lands.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51
Gerrit-Change-Number: 61571
Gerrit-PatchSet: 6
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Won Chung <wonchung(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Benson Leung <bleung(a)chromium.org>
Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Comment-Date: Tue, 08 Feb 2022 16:41:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Anson Tseng, Frank Chu, Isaac Lee, Nick Vaccaro, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60415 )
Change subject: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60415/comment/0d358643_f2641c26
PS8, Line 18: TEST=ALC5682-VD/ALC5682I-VS audio codec can work
> Can you also add […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6089441dc1ba04c3f7427dda065b85bd295af0d
Gerrit-Change-Number: 60415
Gerrit-PatchSet: 9
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Anson Tseng <ansontseng(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 08 Feb 2022 16:41:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Raul Rangel has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61612 )
Change subject: mb/google/guybrush: Enable CONSOLE_CBMEM_DUMP_TO_UART
......................................................................
mb/google/guybrush: Enable CONSOLE_CBMEM_DUMP_TO_UART
This will make debugging boot failures with a non-serial firmware
easier. If we encounter an error that requires a reboot, this will dump
the entire CBMEM contents onto the UART. This is especially helpful
during S0i3 resume because the PSP verstage console logs are not
exposed anywhere.
BUG=b:215599230
TEST=Cause verstage error in S0i3 with non-serial firmware and see that
the verstage logs were dumped to the UART before rebooting.
Entering PSP verstage S0i3 resume
tpm_setup failed rv:1
VB2:vb2api_fail() Need recovery, reason: 0x3f / 0xcc
Saving nvdata
Signed-off-by: Raul E Rangel <rrangel(a)chromium.org>
Change-Id: I908037527206cc7bed2302fab60b2912d6dabc73
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61612
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
---
M src/mainboard/google/guybrush/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig
index 43cbdde..b2fce84 100644
--- a/src/mainboard/google/guybrush/Kconfig
+++ b/src/mainboard/google/guybrush/Kconfig
@@ -12,6 +12,7 @@
def_bool y
select AMD_SOC_CONSOLE_UART
select BOARD_ROMSIZE_KB_16384
+ select CONSOLE_CBMEM_DUMP_TO_UART if !CONSOLE_SERIAL
select DISABLE_KEYBOARD_RESET_PIN
select DISABLE_SPI_FLASH_ROM_SHARING
select DRIVERS_ACPI_THERMAL_ZONE
--
To view, visit https://review.coreboot.org/c/coreboot/+/61612
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I908037527206cc7bed2302fab60b2912d6dabc73
Gerrit-Change-Number: 61612
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Subrata Banik, Won Chung, Nick Vaccaro, Benson Leung, Prashant Malani.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61571 )
Change subject: mb/google/brya: Add custom PLD fields to devicetree for brya variants
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Since there is a lot of redundancy in these custom PLD, and we are following a standard template,
we could simplify this by adding new macros to define a PLD group.
e.g., I could see a Type-A and Type-C macros being useful
```
#define ACPI_PLD_TYPE_A(panel,horiz,grp) \
{ .visible = true, \
.panel = PLD_PANEL##_panel, \
.shape = PLD_SHAPE_HORIZONTAL_RECTANGLE, \
.horizontal_position = PLD_HORIZONTAL_POSITION#_horiz, \
.group = grp, }
#define ACPI_PLD_TYPE_C(panel,horiz,grp) \
{ .visible = true, \
.panel = PLD_PANEL##_panel, \
.shape = PLD_SHAPE_OVAL, \
.horizontal_position = PLD_HORIZONTAL_POSITION#_horiz, \
.group = grp, }
```
and then use this instead like, e.g.
```
register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))"
```
WDYT?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51
Gerrit-Change-Number: 61571
Gerrit-PatchSet: 6
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Won Chung <wonchung(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Benson Leung <bleung(a)chromium.org>
Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Comment-Date: Tue, 08 Feb 2022 16:26:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Rob Barnes, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61612 )
Change subject: mb/google/guybrush: Enable CONSOLE_CBMEM_DUMP_TO_UART
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
PTAL
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/61612/comment/5e23a5bb_2032ba8b
PS1, Line 15: !CONSOLE_SERIAL
> IS this needed? I see CBMEM_DUMP_TO_UART already depends on !CONSOLE_SERIAL.
It's not absolutely required, but I wanted it to be clear that this only applies to non-serial firmware.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61612
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I908037527206cc7bed2302fab60b2912d6dabc73
Gerrit-Change-Number: 61612
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 08 Feb 2022 16:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Frank Chu, Nick Vaccaro, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61675 )
Change subject: mb/google/volteer/var/drobit: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61675/comment/95df03bc_d10d5d45
PS2, Line 9: hid
`_HID`
--
To view, visit https://review.coreboot.org/c/coreboot/+/61675
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c1c9819af1e0bc2278dadeffb6b19c3f9068f30
Gerrit-Change-Number: 61675
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Tue, 08 Feb 2022 16:19:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment