Attention is currently required from: Nico Huber, Michał Żygowski.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61682 )
Change subject: nb/amd/common: Move RAM calcualtion to common code
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/amd/common/ram_calc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140305):
https://review.coreboot.org/c/coreboot/+/61682/comment/56ab4439_0d6c529b
PS3, Line 45: /* [N-1:40] at [N-1-40:0] addres_smask will clear unused high bits */
'addres' may be misspelled - perhaps 'address'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61682
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d222f6cbd26fe78d968d2883984f25e8b62ab5c
Gerrit-Change-Number: 61682
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 08 Feb 2022 13:34:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Michał Żygowski.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61682
to look at the new patch set (#3).
Change subject: nb/amd/common: Move RAM calcualtion to common code
......................................................................
nb/amd/common: Move RAM calcualtion to common code
This patch addresses post-merge comments from CB:52922. This change
only unifies the code used by AMD northbirdges.
TEST=Boot PC Engines apu1 and see that RAM resources did not change.
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Change-Id: I3d222f6cbd26fe78d968d2883984f25e8b62ab5c
---
M src/northbridge/amd/agesa/family14/Makefile.inc
M src/northbridge/amd/agesa/family14/northbridge.c
M src/northbridge/amd/agesa/family15tn/Makefile.inc
M src/northbridge/amd/agesa/family15tn/northbridge.c
M src/northbridge/amd/agesa/family16kb/Makefile.inc
M src/northbridge/amd/agesa/family16kb/northbridge.c
A src/northbridge/amd/common/ram_calc.c
M src/northbridge/amd/nb_common.h
M src/northbridge/amd/pi/00730F01/Makefile.inc
M src/northbridge/amd/pi/00730F01/northbridge.c
10 files changed, 99 insertions(+), 137 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/61682/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61682
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d222f6cbd26fe78d968d2883984f25e8b62ab5c
Gerrit-Change-Number: 61682
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59400 )
Change subject: crossgcc: Upgrade LLVM/clang from 12.0.0 to 13.0.1
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59400/comment/14fc5408_44011d52
PS3, Line 7: crossgcc: Upgrade llvm to 13.0.0 version
> Maybe: […]
Ack
https://review.coreboot.org/c/coreboot/+/59400/comment/1c965745_68132206
PS3, Line 8:
> Did you build/run test one board?
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/59400
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c550d3528a5b1c891b318c08ecfba3a9255e69c
Gerrit-Change-Number: 59400
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 08 Feb 2022 12:07:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: HAOUAS Elyes.
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59400
to look at the new patch set (#8).
Change subject: crossgcc: Upgrade LLVM/clang from 12.0.0 to 13.0.1
......................................................................
crossgcc: Upgrade LLVM/clang from 12.0.0 to 13.0.1
Build/run not tested on board.
Change-Id: I8c550d3528a5b1c891b318c08ecfba3a9255e69c
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/clang-12.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-13.0.1.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-12.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-13.0.1.src.tar.xz.cksum
D util/crossgcc/sum/compiler-rt-12.0.0.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-13.0.1.src.tar.xz.cksum
D util/crossgcc/sum/llvm-12.0.0.src.tar.xz.cksum
A util/crossgcc/sum/llvm-13.0.1.src.tar.xz.cksum
9 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/59400/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/59400
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c550d3528a5b1c891b318c08ecfba3a9255e69c
Gerrit-Change-Number: 59400
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: HAOUAS Elyes.
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59400
to look at the new patch set (#7).
Change subject: crossgcc: Upgrade llvm to 13.0.1 version
......................................................................
crossgcc: Upgrade llvm to 13.0.1 version
Build/run not tested on board.
Change-Id: I8c550d3528a5b1c891b318c08ecfba3a9255e69c
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/clang-12.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-13.0.1.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-12.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-13.0.1.src.tar.xz.cksum
D util/crossgcc/sum/compiler-rt-12.0.0.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-13.0.1.src.tar.xz.cksum
D util/crossgcc/sum/llvm-12.0.0.src.tar.xz.cksum
A util/crossgcc/sum/llvm-13.0.1.src.tar.xz.cksum
9 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/59400/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/59400
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c550d3528a5b1c891b318c08ecfba3a9255e69c
Gerrit-Change-Number: 59400
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Ravindra, Sridhar Siricilla, Mark Hsieh, Patrick Rudolph.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61586 )
Change subject: mb/google/brya: Use USB2_PORT_MAX_TYPE_C for Type-C USB2 port
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If54faa63a983c859bf26a6a779751a6c3c85c43d
Gerrit-Change-Number: 61586
Gerrit-PatchSet: 10
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravindra <ravindra(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 08 Feb 2022 12:02:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment