Attention is currently required from: David Wu, Ren Kuo, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61712 )
Change subject: mb/google/brya/var/volmar: enable RTD3 for PCIe-eMMC bridge
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61712
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9ef372fa963b040c5196aaf13f2ffde27c168d6
Gerrit-Change-Number: 61712
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 15:43:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Varshit B Pandya, Subrata Banik, Maulik V Vaghela, Rizwan Qureshi, Sugnan Prabhu S, Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61020 )
Change subject: src/driver/wifi: Add _DSM method for DDRRFIM
......................................................................
Patch Set 12:
(2 comments)
File src/drivers/wifi/generic/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140422):
https://review.coreboot.org/c/coreboot/+/61020/comment/9fa02f0b_89ff1ff6
PS12, Line 493: union wifi_sar_limits sar_limits = {{NULL, NULL, NULL, NULL, NULL}};
space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140422):
https://review.coreboot.org/c/coreboot/+/61020/comment/f0b1c5f8_d665d932
PS12, Line 515: if (sar_limits.dsm != NULL) {
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/61020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I217b736df3d4224a6732d1941a160abcddbd8f37
Gerrit-Change-Number: 61020
Gerrit-PatchSet: 12
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 15:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth - Personal, Igor Bagnucki, Stefan Reinauer, Krystian Hebel, Timothy Pearson.
Hello build bot (Jenkins), Martin Roth - Personal, Igor Bagnucki, Stefan Reinauer, Krystian Hebel, Timothy Pearson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58656
to look at the new patch set (#14).
Change subject: payloads/external: add skiboot (for QEMU/Power9)
......................................................................
payloads/external: add skiboot (for QEMU/Power9)
Add an option to build skiboot as a payload. This makes QEMU Power9
board simpler to use as skiboot is necessary anyway.
Change-Id: I0b49ea7464c97cc2ff0d5030629deed549851372
Signed-off-by: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M Documentation/mainboard/emulation/qemu-power9.md
M payloads/Makefile.inc
M payloads/external/.gitignore
M payloads/external/Makefile.inc
A payloads/external/skiboot/Kconfig
A payloads/external/skiboot/Kconfig.name
A payloads/external/skiboot/Makefile
M src/mainboard/emulation/qemu-power9/Kconfig
8 files changed, 105 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/58656/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/58656
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b49ea7464c97cc2ff0d5030629deed549851372
Gerrit-Change-Number: 58656
Gerrit-PatchSet: 14
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Attention: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Ron Minnich, Timothy Pearson.
Hello build bot (Jenkins), Arthur Heymans, Ron Minnich, Timothy Pearson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57079
to look at the new patch set (#17).
Change subject: src/mainboard/emulation/qemu-power9/*: add QEMU POWER9 mainboard
......................................................................
src/mainboard/emulation/qemu-power9/*: add QEMU POWER9 mainboard
Add initial implementation for booting on QEMU POWER9 emulation.
Change-Id: I079c5b9ad564024dd13296ef75c263bdc40c9d39
Signed-off-by: Yaroslav Kurlaev <yaroslav.kurlaev(a)3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
A Documentation/mainboard/emulation/qemu-power9.md
A configs/config.emulation_qemu_power9
A src/mainboard/emulation/qemu-power9/Kconfig
A src/mainboard/emulation/qemu-power9/Kconfig.name
A src/mainboard/emulation/qemu-power9/Makefile.inc
A src/mainboard/emulation/qemu-power9/board_info.txt
A src/mainboard/emulation/qemu-power9/cbmem.c
A src/mainboard/emulation/qemu-power9/devicetree.cb
A src/mainboard/emulation/qemu-power9/mainboard.c
A src/mainboard/emulation/qemu-power9/memlayout.ld
A src/mainboard/emulation/qemu-power9/romstage.c
11 files changed, 146 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/57079/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/57079
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I079c5b9ad564024dd13296ef75c263bdc40c9d39
Gerrit-Change-Number: 57079
Gerrit-PatchSet: 17
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Timothy Pearson, Ron Minnich.
Hello build bot (Jenkins), Arthur Heymans, Krystian Hebel, Timothy Pearson, Ron Minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57084
to look at the new patch set (#24).
Change subject: src/arch/ppc64/*: pass FDT address to payload
......................................................................
src/arch/ppc64/*: pass FDT address to payload
It's available in %r3 in bootblock and needs to be passed to payload in
%r27. We use one of two hypervisor's special registers as a buffer,
which aren't used for anything by the code.
Change-Id: I0911f4b534c6f8cacfa057a5bad7576fec711637
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/arch/ppc64/bootblock_crt0.S
M src/include/cpu/power/spr.h
M src/mainboard/emulation/qemu-power9/Makefile.inc
A src/mainboard/emulation/qemu-power9/ramstage.c
4 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/57084/24
--
To view, visit https://review.coreboot.org/c/coreboot/+/57084
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0911f4b534c6f8cacfa057a5bad7576fec711637
Gerrit-Change-Number: 57084
Gerrit-PatchSet: 24
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Krystian Hebel, Timothy Pearson, Ron Minnich.
Hello build bot (Jenkins), Arthur Heymans, Timothy Pearson, Ron Minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57082
to look at the new patch set (#19).
Change subject: src/mainboard/emulation/qemu-power9: require hb-mode=on
......................................................................
src/mainboard/emulation/qemu-power9: require hb-mode=on
"hb-mode" is a -machine flag for QEMU. "hb" stands for Hostboot, which
is OpenPower firmware created by IBM.
QEMU for PPC64 can run initial program in two different modes:
* hb-mode=off with load address 0x00000000
* hb-mode=on with load address 0x08000000
Real hardware always loads firmware at 0x08000000 and coreboot shouldn't
require a special build to be run on QEMU.
Memory layout is updated to reflect change of load address.
Change-Id: I1bdc97a095bd46fccc862985b3bd24f4fa5bc054
Signed-off-by: Yaroslav Kurlaev <yaroslav.kurlaev(a)3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/arch/ppc64/include/arch/io.h
M src/arch/ppc64/rom_media.c
M src/arch/ppc64/stages.c
M src/mainboard/emulation/qemu-power9/memlayout.ld
4 files changed, 36 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/57082/19
--
To view, visit https://review.coreboot.org/c/coreboot/+/57082
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bdc97a095bd46fccc862985b3bd24f4fa5bc054
Gerrit-Change-Number: 57082
Gerrit-PatchSet: 19
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Timothy Pearson.
Hello build bot (Jenkins), Arthur Heymans, Krystian Hebel, Timothy Pearson, Ron Minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57076
to look at the new patch set (#14).
Change subject: ppc64/bootblock_crt0.S: minimal implementation for bootblock C environment
......................................................................
ppc64/bootblock_crt0.S: minimal implementation for bootblock C environment
BSS is loaded as part of the bootblock, it is zeroed in the file so it
doesn't have to be cleared explicitly by the code.
Code for clearing is left as a comment along with a warning about alignment
requirements.
Vector operations are sometimes generated for code such as
'uint8_t x[32] = {0}', this results in an exception when vector registers
(VR) are not enabled. VSR (vector-scalar register) operations are also
enabled, there is no reason not to.
Change-Id: I878ef61619eb4a191805c8911d001312a0d717a0
Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com>
---
M src/arch/ppc64/Makefile.inc
D src/arch/ppc64/bootblock.S
A src/arch/ppc64/bootblock_crt0.S
3 files changed, 94 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/57076/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/57076
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I878ef61619eb4a191805c8911d001312a0d717a0
Gerrit-Change-Number: 57076
Gerrit-PatchSet: 14
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Timothy Pearson, Ron Minnich.
Hello build bot (Jenkins), Arthur Heymans, Krystian Hebel, Timothy Pearson, Ron Minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57083
to look at the new patch set (#19).
Change subject: arch/ppc64/boot.c: handle non-OPD entry point
......................................................................
arch/ppc64/boot.c: handle non-OPD entry point
Change-Id: I309be370d66a808b355241fcee880883631f38ce
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/arch/ppc64/boot.c
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/57083/19
--
To view, visit https://review.coreboot.org/c/coreboot/+/57083
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I309be370d66a808b355241fcee880883631f38ce
Gerrit-Change-Number: 57083
Gerrit-PatchSet: 19
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ron Minnich, Timothy Pearson.
Hello build bot (Jenkins), Ron Minnich, Timothy Pearson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57081
to look at the new patch set (#17).
Change subject: src/mainboard/emulation/qemu-power9: add RAM detection
......................................................................
src/mainboard/emulation/qemu-power9: add RAM detection
Change-Id: Ie333294c7a311f6d47bdfbd1fc3cec0128cf63e7
Signed-off-by: Yaroslav Kurlaev <yaroslav.kurlaev(a)3mdeb.com>
---
M src/mainboard/emulation/qemu-power9/cbmem.c
M src/mainboard/emulation/qemu-power9/mainboard.c
M src/mainboard/emulation/qemu-power9/memlayout.ld
M src/mainboard/emulation/qemu-power9/romstage.c
4 files changed, 13 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/57081/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/57081
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie333294c7a311f6d47bdfbd1fc3cec0128cf63e7
Gerrit-Change-Number: 57081
Gerrit-PatchSet: 17
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-MessageType: newpatchset