Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61800 )
Change subject: soc/mediatek: Fix printing SPM version
......................................................................
soc/mediatek: Fix printing SPM version
Currently the SPM version string is stored at the end of the blob,
possibly without a trailing '\0'. Therefore, we should be careful not to
print characters beyond the blob size.
BUG=b:211944565
TEST=emerge-corsola coreboot
TEST=SPM version looked good in AP console
BRANCH=none
Change-Id: Icfeb686539dc20cf5b78de77c27bdbb137b5d624
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
---
M src/soc/mediatek/common/spm.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/61800/1
diff --git a/src/soc/mediatek/common/spm.c b/src/soc/mediatek/common/spm.c
index c4eabd0..a17fba5 100644
--- a/src/soc/mediatek/common/spm.c
+++ b/src/soc/mediatek/common/spm.c
@@ -50,5 +50,7 @@
/* Version */
offset += copy_size;
assert(offset < file_size);
- printk(BIOS_INFO, "SPM: spmfw (version %s)\n", (u8 *)mcu->load_buffer + offset);
+ printk(BIOS_INFO, "SPM: spmfw (version %.*s)\n",
+ (int)(file_size - offset),
+ (u8 *)mcu->load_buffer + offset);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/61800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfeb686539dc20cf5b78de77c27bdbb137b5d624
Gerrit-Change-Number: 61800
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Martin Roth, Igor Bagnucki, Stefan Reinauer, Krystian Hebel, Sergii Dmytruk, Timothy Pearson.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58656 )
Change subject: payloads/external: add skiboot (for QEMU/Power9)
......................................................................
Patch Set 14:
(2 comments)
File payloads/external/skiboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/58656/comment/36a15a28_f2143ed3
PS14, Line 10: default "https://gitlab.com/qemu-project/skiboot.git" if BOARD_EMULATION_QEMU_POWER9
Does it have to be a special QEMU repo? I would rather want to avoid specifying repo address.
File src/mainboard/emulation/qemu-power9/Kconfig:
https://review.coreboot.org/c/coreboot/+/58656/comment/0a4c1d28_3ef56714
PS14, Line 11: select BOARD_ROMSIZE_KB_1024
Is it a sane value when skiboot is included?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58656
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b49ea7464c97cc2ff0d5030629deed549851372
Gerrit-Change-Number: 58656
Gerrit-PatchSet: 14
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Igor Bagnucki <igor.bagnucki(a)3mdeb.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Attention: Timothy Pearson <tpearson(a)raptorengineering.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 09:29:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment