Attention is currently required from: Lance Zhao, Tarun Tuli, Kapil Porwal, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70063 )
Change subject: acpi: Helper functions to add certain _DSD properties
......................................................................
Patch Set 9:
(1 comment)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/70063/comment/18376b5e_4c1ee00b
PS9, Line 1236:
move into new line?
same for other functions as well?
--
To view, visit https://review.coreboot.org/c/coreboot/+/70063
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bb432dd4e8f320d2c0d7f378dc2d7b3a770b541
Gerrit-Change-Number: 70063
Gerrit-PatchSet: 9
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 10:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Tarun Tuli, Subrata Banik, Tim Wawrzynczak.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70063 )
Change subject: acpi: Helper functions to add certain _DSD properties
......................................................................
Patch Set 9:
(1 comment)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/70063/comment/f7aa428c_aa416dac
PS8, Line 1209: acpi_device_add_integer_property_with_uuid
> do u see anyone calling into this func directly ? if not then consider to make it static ?
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/70063
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bb432dd4e8f320d2c0d7f378dc2d7b3a770b541
Gerrit-Change-Number: 70063
Gerrit-PatchSet: 9
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 10:16:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Tarun Tuli, Kapil Porwal, Tim Wawrzynczak.
Hello Lance Zhao, build bot (Jenkins), Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70063
to look at the new patch set (#9).
Change subject: acpi: Helper functions to add certain _DSD properties
......................................................................
acpi: Helper functions to add certain _DSD properties
BUG=b:259716145
TEST=Verified SSDT on google/rex.
Signed-off-by: Kapil Porwal <kapilporwal(a)google.com>
Change-Id: I5bb432dd4e8f320d2c0d7f378dc2d7b3a770b541
---
M src/acpi/device.c
M src/include/acpi/acpi_device.h
2 files changed, 84 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/70063/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/70063
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bb432dd4e8f320d2c0d7f378dc2d7b3a770b541
Gerrit-Change-Number: 70063
Gerrit-PatchSet: 9
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Frank Chu.
Hello Tarun Tuli,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70232
to look at the new patch set (#2).
Change subject: mb/google/brya/var/marasov: Configure I2C high and low time
......................................................................
mb/google/brya/var/marasov: Configure I2C high and low time
Adjust I2C speed for codec, TPM, touchpad, touchscreen.
BUG=b:260565911
TEST=Built and verified adjusted I2C speed
Signed-off-by: Frank Chu <Frank_Chu(a)pegatron.corp-partner.google.com>
Change-Id: Idcec6e401992d30dff01940c50473cba48cffc19
---
M src/mainboard/google/brya/variants/marasov/overridetree.cb
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/70232/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70232
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcec6e401992d30dff01940c50473cba48cffc19
Gerrit-Change-Number: 70232
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Shun-min Yang <shunminyang(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Eran Mitrani.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/common, alderlake: provide a list of D-states to enter LPM
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/695bb6cf_ec5cf6a6
PS7, Line 495: return;
I think you need to create a default entry here like what `soc_lpi_get_constraints()` does in `src/soc/intel/common/block/acpi/pep.c`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45eded3868a4987cb5eb0676c50378ac52ec3752
Gerrit-Change-Number: 70166
Gerrit-PatchSet: 7
Gerrit-Owner: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 10:03:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Jason Nien, Matt DeVillier, Paul Menzel, Eric Lai, Martin Roth, Tim Van Patten, Eric Peers, LeilaCY Lin, Jason Glenesk, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 )
Change subject: soc/amd/common/acpi: Implement DTTS Proposal
......................................................................
Patch Set 78:
(1 comment)
File src/mainboard/google/skyrim/variants/winterhold/include/variant/acpi/dtts.asl:
PS76:
> Ah, sorry I missed this. Split the skyrim changes into their own CL.
Hi Raul,
Would you please guide me what the action I should do on this comment?
BR,
Eric KY Cheng
--
To view, visit https://review.coreboot.org/c/coreboot/+/68471
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I866e5e497e2936984e713029b5f0b6d54cbc9622
Gerrit-Change-Number: 68471
Gerrit-PatchSet: 78
Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 02 Dec 2022 09:53:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Tarun Tuli, Ren Kuo, Nick Vaccaro, Peter Ou.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70238 )
Change subject: mb/google/brya: Set power limit values for kano and zydron
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/70238
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I369c5d7a9a3db0c3e7184a23b0f159ed715b5a50
Gerrit-Change-Number: 70238
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 09:44:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment