coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Update Skuid to support pro/non-pro
by Paul Menzel (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Venkat Thogaru, Sudheer Amrabadi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68385 ) Change subject: soc/qualcomm/sc7280: Update Skuid to support pro/non-pro ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/herobrine/boardid.c: https://review.coreboot.org/c/coreboot/+/68385/comment/817d4d36_2a77ad1d PS10, Line 47: /* Update modem status in 9th bit of sku id */ Please factor this out into a separate commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/68385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec392c03c2e2c79d20b1fcb79236ca9e048bfd07 Gerrit-Change-Number: 68385 Gerrit-PatchSet: 10 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 16:04:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot
by Paul Menzel (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Julius Werner, Sudheer Amrabadi. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 ) Change subject: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot ...................................................................... Patch Set 9: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68384/comment/1e7338bb_0dfa9207 PS9, Line 7: Please use one space. https://review.coreboot.org/c/coreboot/+/68384/comment/74ee7b34_8d8d4b29 PS9, Line 7: Add socinfo_pro_part() function in : coreboot Maybe: Add function to differentiate between PRO and NON_PRO SKUs https://review.coreboot.org/c/coreboot/+/68384/comment/ab9f558c_0b093dca PS9, Line 8: coreboot Please just use one line for the summary [1]. [1]: https://cbea.ms/git-commit/ https://review.coreboot.org/c/coreboot/+/68384/comment/3b9caa28_8aa36273 PS9, Line 10: Please use exactly one space. https://review.coreboot.org/c/coreboot/+/68384/comment/9f6fcd8e_354db989 PS9, Line 10: The API socinfo_pro_part is added to help to differentiate : between PRO and NON_PRO SKUs. Returns 1 for Pro : and 0 for NON_PRO SKUs. Please reflow for 72 characters per line. https://review.coreboot.org/c/coreboot/+/68384/comment/141fef69_fdece0e8 PS9, Line 15: Validate boards are detected correctly on PRO : and NON_PRO SKUs Ditto. Patchset: PS9: The commit seems to do more changes than documented in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/68384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca Gerrit-Change-Number: 68384 Gerrit-PatchSet: 9 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Taniya Das <tdas(a)qualcomm.corp-partner.google.com> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 16:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cbfstool/lz4: Fix compilation issue
by Paul Menzel (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Julius Werner, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69091 ) Change subject: cbfstool/lz4: Fix compilation issue ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69091/comment/052c98a6_a28d6044 PS1, Line 9: This patch fixes the below compilation issue as below. What compiler does this fail with? -- To view, visit https://review.coreboot.org/c/coreboot/+/69091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82110085c39d001afbdf777481fd7fb1553d731d Gerrit-Change-Number: 69091 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 01 Nov 2022 15:59:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src/arch/x86/smbios.c: Add SMBIOS Type 39
by Paul Menzel (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Jonathan Zhang, lichenchen.carl, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68443 ) Change subject: src/arch/x86/smbios.c: Add SMBIOS Type 39 ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68443/comment/6bdfacbc_f7c4390c PS1, Line 7: src/arch/x86/smbios.c arch/x86/smbios: https://review.coreboot.org/c/coreboot/+/68443/comment/8ba6ff4b_96a423d2 PS1, Line 16: Please remove the blank line. -- To view, visit https://review.coreboot.org/c/coreboot/+/68443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18d056cba1a79b0775c8a42b3a879e819887adca Gerrit-Change-Number: 68443 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 15:58:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: inc/dev:Add some pcie definitions
by Paul Menzel (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Jonathan Zhang, Johnny Lin, Jingle Hsu, Shuming Chu (Shuming), Tim Chu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69106 ) Change subject: inc/dev:Add some pcie definitions ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69106/comment/d38b9eb8_2b1f46d9 PS1, Line 7: inc/dev:Add some pcie definitions Maybe: Add some PCIe DPC/AER definitions https://review.coreboot.org/c/coreboot/+/69106/comment/296c4d19_5b546c7c PS1, Line 7: inc/dev:Add Please add a space after the colon. https://review.coreboot.org/c/coreboot/+/69106/comment/c0732b59_70f8d0e7 PS1, Line 11: Please mention, what document you got this from. -- To view, visit https://review.coreboot.org/c/coreboot/+/69106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb6722c326ef69ef1bf3b1c2c1d5bc0cb29d7c12 Gerrit-Change-Number: 69106 Gerrit-PatchSet: 1 Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 15:57:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Select GOOGLE_SMBIOS_MAINBOARD_VERSION
by Amanda Hwang (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Jason Nien, Isaac Lee, Jon Murphy, Martin Roth. Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69087 ) Change subject: mb/google/skyrim: Select GOOGLE_SMBIOS_MAINBOARD_VERSION ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69087/comment/87958bf7_ba29b6fe PS1, Line 7: mb/google/skyrim:select GOOGLE_SMBIOS_MAINBOARD_VERSION > Nit: Add a space between ':' and "select". Also update "select" to "Select" i.e. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97295083dbca1c285ef7359d86abac7315c654c9 Gerrit-Change-Number: 69087 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 15:50:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Select GOOGLE_SMBIOS_MAINBOARD_VERSION
by Amanda Hwang (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Jason Nien, Isaac Lee, Jon Murphy, Martin Roth, Amanda Hwang. Hello Frank Wu, build bot (Jenkins), Jason Nien, Isaac Lee, Jon Murphy, Martin Roth, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69087 to look at the new patch set (#2). Change subject: mb/google/skyrim: Select GOOGLE_SMBIOS_MAINBOARD_VERSION ...................................................................... mb/google/skyrim: Select GOOGLE_SMBIOS_MAINBOARD_VERSION Select GOOGLE_SMBIOS_MAINBOARD_VERSION allows querying board revision from the EC. BUG=b:256723358 TEST=1. emerge-skyrim coreboot chromeos-bootimage 2. flash the image to the device and check board rev by using command `dmidecode -t 1 | grep Version` Change-Id: I97295083dbca1c285ef7359d86abac7315c654c9 Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com> --- M src/mainboard/google/skyrim/Kconfig 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/69087/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97295083dbca1c285ef7359d86abac7315c654c9 Gerrit-Change-Number: 69087 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/brask/variants/moli: remove fan setting
by Subrata Banik (Code Review) 01 Nov '22

01 Nov '22

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69094 ) Change subject: mb/google/brask/variants/moli: remove fan setting ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > > Hi Subrata. Just +2'd so we should have x3 now. > > Thanks I have landed this CL into chromium https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/…. Please let me know if you need me to land this CL into FW branch ? -- To view, visit https://review.coreboot.org/c/coreboot/+/69094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8851800d30ebf4d948d6eaadda2387c8afe52d8 Gerrit-Change-Number: 69094 Gerrit-PatchSet: 3 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 15:34:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brask/variants/moli: remove fan setting
by Subrata Banik (Code Review) 01 Nov '22

01 Nov '22

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69094 ) Change subject: mb/google/brask/variants/moli: remove fan setting ...................................................................... mb/google/brask/variants/moli: remove fan setting Disable Active Policy and remove fan setting to let ec control fan indenpendently. BUG=b:236294162 TEST=emerge-brask coreboot Signed-off-by: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Change-Id: Ie8851800d30ebf4d948d6eaadda2387c8afe52d8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69094 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Zhuohao Lee <zhuohao(a)google.com> Reviewed-by: Tarun Tuli <taruntuli(a)google.com> --- M src/mainboard/google/brya/variants/moli/overridetree.cb 1 file changed, 21 insertions(+), 30 deletions(-) Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, approved Raihow Shi: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved Tarun Tuli: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/moli/overridetree.cb b/src/mainboard/google/brya/variants/moli/overridetree.cb index 2d35e14..8f1bf8e 100644 --- a/src/mainboard/google/brya/variants/moli/overridetree.cb +++ b/src/mainboard/google/brya/variants/moli/overridetree.cb @@ -48,18 +48,6 @@ register "options.tsr[1].desc" = ""CPU_VR"" register "options.tsr[2].desc" = ""DIMM"" - # TODO: below values are initial reference values only - ## Active Policy - register "policies.active" = "{ - [0] = { - .target = DPTF_CPU, - .thresholds = { - TEMP_PCT(85, 90), - TEMP_PCT(80, 80), - TEMP_PCT(75, 70), - } - } - }" ## Passive Policy register "policies.passive" = "{ @@ -98,24 +86,6 @@ [0] = 0x1 }" - ## Fan Performance Control (Percent, Speed, Noise, Power) - register "controls.fan_perf" = "{ - [0] = { 90, 6700, 220, 2200, }, - [1] = { 80, 5800, 180, 1800, }, - [2] = { 70, 5000, 145, 1450, }, - [3] = { 60, 4900, 115, 1150, }, - [4] = { 50, 3838, 90, 900, }, - [5] = { 40, 2904, 55, 550, }, - [6] = { 30, 2337, 30, 300, }, - [7] = { 20, 1608, 15, 150, }, - [8] = { 10, 800, 10, 100, }, - [9] = { 0, 0, 0, 50, } - }" - - ## Fan options - register "options.fan.fine_grained_control" = "1" - register "options.fan.step_size" = "2" - device generic 0 alias dptf_policy on end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/69094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8851800d30ebf4d948d6eaadda2387c8afe52d8 Gerrit-Change-Number: 69094 Gerrit-PatchSet: 3 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/brask/variants/moli: remove fan setting
by Subrata Banik (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: YH Lin, Nick Vaccaro, Casper Chang, Raihow Shi. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69094 ) Change subject: mb/google/brask/variants/moli: remove fan setting ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hi Subrata. Just +2'd so we should have x3 now. Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/69094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8851800d30ebf4d948d6eaadda2387c8afe52d8 Gerrit-Change-Number: 69094 Gerrit-PatchSet: 2 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 15:23:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022