coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/amd/picasso: add mb_pre_fspm() definition and weak implementation
by Matt DeVillier (Code Review) 11 Nov '22

11 Nov '22

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69452 ) Change subject: soc/amd/picasso: add mb_pre_fspm() definition and weak implementation ...................................................................... soc/amd/picasso: add mb_pre_fspm() definition and weak implementation On newer AMD platforms, mb_pre_fspm() is used to set GPIOs in romstage for PCIe reset (currently set in bootblock; will be moved in a subsequent commit) and touchscreen power sequencing (not yet implemented, but will be later in the patch train). Change-Id: Ia422aaa9e80355f9a9f8f850368441e5c8ff6598 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/soc/amd/picasso/fsp_m_params.c M src/soc/amd/picasso/include/soc/platform_descriptors.h 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/69452/1 diff --git a/src/soc/amd/picasso/fsp_m_params.c b/src/soc/amd/picasso/fsp_m_params.c index 6483394..0be815e 100644 --- a/src/soc/amd/picasso/fsp_m_params.c +++ b/src/soc/amd/picasso/fsp_m_params.c @@ -5,6 +5,7 @@ #include <console/uart.h> #include <device/device.h> #include <fsp/api.h> +#include <soc/platform_descriptors.h> #include <soc/pci_devs.h> #include <soc/fsp.h> #include <types.h> @@ -12,6 +13,8 @@ void __weak mainboard_updm_update(FSP_M_CONFIG *mupd) {} +void __weak mb_pre_fspm(void) {} + void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) { FSP_M_CONFIG *mcfg = &mupd->FspmConfig; @@ -69,4 +72,5 @@ mcfg->pspp_policy = config->pspp_policy; mainboard_updm_update(mcfg); + mb_pre_fspm(); } diff --git a/src/soc/amd/picasso/include/soc/platform_descriptors.h b/src/soc/amd/picasso/include/soc/platform_descriptors.h index 2ea35a9..00cd42f 100644 --- a/src/soc/amd/picasso/include/soc/platform_descriptors.h +++ b/src/soc/amd/picasso/include/soc/platform_descriptors.h @@ -27,4 +27,6 @@ const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num, const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num); +void mb_pre_fspm(void); + #endif /* AMD_PICASSO_PLATFORM_DESCRIPTORS_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/69452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia422aaa9e80355f9a9f8f850368441e5c8ff6598 Gerrit-Change-Number: 69452 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: cpu/intel/socket_*: Clean up Kconfig files
by Elyes Haouas (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Stefan Ott, Nico Huber, Angel Pons, Arthur Heymans, Kyösti Mälkki, Alexander Couzens. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69447 ) Change subject: cpu/intel/socket_*: Clean up Kconfig files ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Would be a good idea, especially if the extensions are supported on most platforms. What is the socket select more than 1 CPU and only one of those CPUs doesn't support SSE? -- To view, visit https://review.coreboot.org/c/coreboot/+/69447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2265ac716e90720e7ccc550239737d40c2f7a0a Gerrit-Change-Number: 69447 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Nov 2022 20:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/socket_*: Clean up Kconfig files
by Elyes Haouas (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Stefan Ott, Nico Huber, Angel Pons, Arthur Heymans, Kyösti Mälkki, Alexander Couzens. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69447 ) Change subject: cpu/intel/socket_*: Clean up Kconfig files ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69447/comment/136843e4_f9bd3ab5 PS3, Line 10: Move MAX_CPUS to mainboards. > Um, this reverts what was done in https://review.coreboot. […] Set the max CPUs in socket Kconfig doesn't make sense! Each socket can support only one CPU , however, a mainboard can have more than 1 socket (when the northbridge support it). -- To view, visit https://review.coreboot.org/c/coreboot/+/69447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2265ac716e90720e7ccc550239737d40c2f7a0a Gerrit-Change-Number: 69447 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Nov 2022 20:47:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality
by Angel Pons (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Kyösti Mälkki, Nicholas Chin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69450 ) Change subject: util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4dd36edb0c36d7679896fde6f84e8471589d83a1 Gerrit-Change-Number: 69450 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Nov 2022 20:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality
by build bot (Jenkins) (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Martin L Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69450 ) Change subject: util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163328): https://review.coreboot.org/c/coreboot/+/69450/comment/81cfd76d_d106650d PS1, Line 8: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7eb03cb6574e ("util/kconfig: Uprev to Linux 5.17's kconfig")' -- To view, visit https://review.coreboot.org/c/coreboot/+/69450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4dd36edb0c36d7679896fde6f84e8471589d83a1 Gerrit-Change-Number: 69450 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Nov 2022 20:34:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality
by Nicholas Chin (Code Review) 11 Nov '22

11 Nov '22

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69450 ) Change subject: util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality ...................................................................... util/kconfig: Re-add KCONFIG_SPLITCONFIG functionality After commit 7eb03cb657 (util/kconfig: Uprev to Linux 5.17's kconfig) kconfig creates many empty files in build/ that have the same name as enabled configs. Previously these were created in build/config. It seems like this commit removed KCONFIG_SPLITHEADER functionality, which set the directory these files should be output to. Upon further investigation it seems like this was never in upstream kconfig and likely was coreboot specific. Moving this functionality to a patch should prevent it from being lost during uprevs to Linux's kconfig. Change-Id: I4dd36edb0c36d7679896fde6f84e8471589d83a1 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/kconfig/confdata.c A util/kconfig/patches/0014-util-kconfig-Add-KCONFIG_SPLITCONFIG-functionality.patch M util/kconfig/patches/series 3 files changed, 85 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/69450/1 diff --git a/util/kconfig/confdata.c b/util/kconfig/confdata.c index 95fb960..ae8d66a 100644 --- a/util/kconfig/confdata.c +++ b/util/kconfig/confdata.c @@ -230,6 +230,12 @@ return name ? name : "include/generated/autoconf.h"; } +static const char *conf_get_autobase_name(void) +{ + char *name = getenv("KCONFIG_SPLITCONFIG"); + return name ? name : "include/config/"; +} + static int conf_set_sym_val(struct symbol *sym, int def, int def_flags, char *p) { char *p2; @@ -1028,14 +1034,15 @@ struct symbol *sym; int res, i; - name = conf_get_autoconfig_name(); - tmp = strrchr(name, '/'); - depfile_prefix_len = tmp ? tmp - name + 1 : 0; - if (depfile_prefix_len + 1 > sizeof(depfile_path)) - return -1; + /* + * Upstream kconfig sets depfile_path based on the directory prefix + * of the autoconfig path, but coreboot overrides this using the + * KCONFIG_SPLITCONFIG environment variable + */ + strncpy(depfile_path, conf_get_autobase_name(), sizeof(depfile_path) - 1); + depfile_prefix_len = strlen(depfile_path); - strncpy(depfile_path, name, depfile_prefix_len); - depfile_path[depfile_prefix_len] = 0; + name = conf_get_autoconfig_name(); conf_read_simple(name, S_DEF_AUTO); sym_calc_value(modules_sym); diff --git a/util/kconfig/patches/0014-util-kconfig-Add-KCONFIG_SPLITCONFIG-functionality.patch b/util/kconfig/patches/0014-util-kconfig-Add-KCONFIG_SPLITCONFIG-functionality.patch new file mode 100644 index 0000000..d31db1d --- /dev/null +++ b/util/kconfig/patches/0014-util-kconfig-Add-KCONFIG_SPLITCONFIG-functionality.patch @@ -0,0 +1,51 @@ +From 13c4c77ea3334c2c4bcffd0f5e3605a272babc5e Mon Sep 17 00:00:00 2001 +From: Nicholas Chin <nic.c3.14(a)gmail.com> +Date: Fri, 11 Nov 2022 12:40:35 -0700 +Subject: [PATCH] util/kconfig: Add KCONFIG_SPLITCONFIG functionality + +Change-Id: I4dd36edb0c36d7679896fde6f84e8471589d83a1 +Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> +--- + util/kconfig/confdata.c | 21 ++++++++++++++------- + 1 file changed, 14 insertions(+), 7 deletions(-) + +Index: kconfig/confdata.c +=================================================================== +--- kconfig.orig/confdata.c ++++ kconfig/confdata.c +@@ -230,6 +230,12 @@ static const char *conf_get_autoheader_n + return name ? name : "include/generated/autoconf.h"; + } + ++static const char *conf_get_autobase_name(void) ++{ ++ char *name = getenv("KCONFIG_SPLITCONFIG"); ++ return name ? name : "include/config/"; ++} ++ + static int conf_set_sym_val(struct symbol *sym, int def, int def_flags, char *p) + { + char *p2; +@@ -1028,14 +1034,15 @@ static int conf_touch_deps(void) + struct symbol *sym; + int res, i; + +- name = conf_get_autoconfig_name(); +- tmp = strrchr(name, '/'); +- depfile_prefix_len = tmp ? tmp - name + 1 : 0; +- if (depfile_prefix_len + 1 > sizeof(depfile_path)) +- return -1; ++ /* ++ * Upstream kconfig sets depfile_path based on the directory prefix ++ * of the autoconfig path, but coreboot overrides this using the ++ * KCONFIG_SPLITCONFIG environment variable ++ */ ++ strncpy(depfile_path, conf_get_autobase_name(), sizeof(depfile_path) - 1); ++ depfile_prefix_len = strlen(depfile_path); + +- strncpy(depfile_path, name, depfile_prefix_len); +- depfile_path[depfile_prefix_len] = 0; ++ name = conf_get_autoconfig_name(); + + conf_read_simple(name, S_DEF_AUTO); + sym_calc_value(modules_sym); diff --git a/util/kconfig/patches/series b/util/kconfig/patches/series index 13b684b..1812285 100644 --- a/util/kconfig/patches/series +++ b/util/kconfig/patches/series @@ -9,3 +9,4 @@ 0009-util-kconfig-Allow-emitting-false-booleans-into-kconfig-output.patch 0010-reenable-source-in-choice.patch 0013-util-kconfig-detect-ncurses-on-FreeBSD.patch +0014-util-kconfig-Add-KCONFIG_SPLITCONFIG-functionality.patch -- To view, visit https://review.coreboot.org/c/coreboot/+/69450 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4dd36edb0c36d7679896fde6f84e8471589d83a1 Gerrit-Change-Number: 69450 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
by build bot (Jenkins) (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 ) Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB ...................................................................... Patch Set 4: (4 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163327): https://review.coreboot.org/c/coreboot/+/62830/comment/affaf73b_bf12d3a6 PS4, Line 17: In function 'write_ble8', Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163327): https://review.coreboot.org/c/coreboot/+/62830/comment/4ed90959_dca96710 PS4, Line 20: inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2, Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163327): https://review.coreboot.org/c/coreboot/+/62830/comment/567da568_b3dc7c77 PS4, Line 21: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2: Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163327): https://review.coreboot.org/c/coreboot/+/62830/comment/124df3a4_76963bd5 PS4, Line 30: pointer arithmetics from NULL while addresses equal or larger than that Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/62830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0 Gerrit-Change-Number: 62830 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 20:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
by Paul Menzel (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Paul Menzel. Hello build bot (Jenkins), Nico Huber, Martin L Roth, Angel Pons, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62830 to look at the new patch set (#4). Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB ...................................................................... Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB GCC 12 incorrectly warns about an array out of bounds issue: ``` $ make V=1 # emulation/qemu-i440fx […] CC ramstage/arch/x86/ebda.o x86_64-linux-gnu-gcc-12 -MMD -Isrc -Isrc/include -Isrc/commonlib/include -Isrc/commonlib/bsd/include -Ibuild -I3rdparty/vboot/firmware/include -include src/include/kconfig.h -include src/include/rules.h -include src/commonlib/bsd/include/commonlib/bsd/compiler.h -I3rdparty -D__BUILD_DIR__=\"build\" -Isrc/arch/x86/include -D__ARCH_x86_32__ -pipe -g -nostdinc -std=gnu11 -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -Wshadow -Wdate-time -Wtype-limits -Wvla -Wdangling-else -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie -Wno-packed-not-aligned -fconserve-stack -Wnull-dereference -Wreturn-type -Wlogical-op -Wduplicated-cond -Wno-unused-but-set-variable -Werror -Os -Wno-address-of-packed-member -m32 -Wl,-b,elf32-i386 -Wl,-melf_i386 -m32 -fuse-ld=bfd -fno-stack-protector -Wl,--build-id=none -fno-delete-null-pointer-checks -Wlogical-op -march=i686 -mno-mmx -MT build/ramstage/arch/x86/ebda.o -D__RAMSTAGE__ -c -o build/ramstage/arch/x86/ebda.o src/arch/x86/ebda.c In file included from src/arch/x86/ebda.c:6: In function 'write_ble8', inlined from 'write_le8' at src/commonlib/include/commonlib/endian.h:155:2, inlined from 'write_le16' at src/commonlib/include/commonlib/endian.h:178:2, inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2, inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2: src/commonlib/include/commonlib/endian.h:27:26: error: array subscript 0 is outside array bounds of 'void[0]' [-Werror=array-bounds] 27 | *(uint8_t *)dest = val; | ~~~~~~~~~~~~~~~~~^~~~~ […] ``` [In GCC 12 the new parameter `min-pagesize` is added and defaults 4 kB.][1] It treats INTEGER_CST addresses smaller than that as assumed results of pointer arithmetics from NULL while addresses equal or larger than that as expected user constant addresses. For GCC 13 we can represent results from pointer arithmetics on NULL using &MEM[(void*)0 + offset] instead of (void*)offset INTEGER_CSTs. [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578#c36 TEST=No compile error with gcc (Debian 12.2.0-3) 12.2.0 Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M util/xcompile/xcompile 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/62830/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0 Gerrit-Change-Number: 62830 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/[glinda|morgana]: Enable override of MAINBOARD_BLOBS_DIR
by Fred Reitberger (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Jason Glenesk, Matt DeVillier, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69410 ) Change subject: soc/amd/[glinda|morgana]: Enable override of MAINBOARD_BLOBS_DIR ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/glinda/Makefile.inc: https://review.coreboot.org/c/coreboot/+/69410/comment/2cd3f0af_925a366d PS1, Line 61: MAINBOARD_BLOBS_DIR:=$ > we already do this for MDN which is fine, but it seems a little odd to me that we define the MAINBOA […] Good idea - looks like I could move it from SoC-specific Makefile to the amd common makefile. However, I'm starting to wonder if it would make more sense to just change this to a Kconfig option with a default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)" and let users/config override it for site-local or other locations? -- To view, visit https://review.coreboot.org/c/coreboot/+/69410 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0702fdb97fbc2c73d97994ab4d5161ff0f467518 Gerrit-Change-Number: 69410 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 19:03:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: configs: Add 64bit buildtest for prodrive/hermes
by Angel Pons (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69236 ) Change subject: configs: Add 64bit buildtest for prodrive/hermes ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic62a33f8d8c3fdaa8182e797b2bf6fbed6b55731 Gerrit-Change-Number: 69236 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 11 Nov 2022 18:27:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022