coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Michael Niewöhner (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Arthur Heymans, Michael Niewöhner. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68791 to look at the new patch set (#14). Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... ec/clevo/it5570e: add driver for EC used on various Clevo laptops This adds a driver for the ITE IT5570E EC in combination with Clevo vendor EC firmware. The interface is mostly identical on various laptop models. Thus, we have implemented one common driver to support them all. The following features were implemented: - Basics like battery, ac, etc. - Suspend/hibernate support: S0ix, S3*, S4/S5 - Save/restore of keyboard backlight level during S0ix without the need for Clevo vendor software (ControlCenter) - Flexicharger - Fn keys (backlight, volume, airplane etc.) - Various configuration options via Kconfig / CMOS options * Note: S3 support works at least on L140CU (Cometlake), but it's not enabled for this board because S0ix is used. Not implemented, yet: - Type-C UCSI: the EC firmware seems to be buggy (with vendor fw, too) - dGPU support is WIP An example of how this driver can be hooked up by a board can be seen in in change CB:59850, where support for the L140MU is added. Known issues: - Touchpad toggle: The touchpad toggle (Fn-F1) has two modes, Ctrl-Alt-F9 mode and keycodes 0xf7/0xf8 mode. Ctrl-Alt-F9 is the native touchpad toggle shortcut on Windows. On Linux this would switch to virtual console 9, if enabled. Thus, one should use the keycodes mode and add udev rules as specified in [1]. If VT9 is disabled, Ctrl-Alt-F9 mode could be used to set up a keyboard shortcut command toggling the touchpad. - Multi-fan systems The Clevo NV41MZ (w/o dGPU) has two fans that should be in-sync. However, the second fan does not spin. This needs further investigation. [1] https://docs.dasharo.com/variants/clevo_nv41/post_install/ Testing the various functionalities of this EC driver was done in the changes hooking up this driver for the boards. Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Co-authored-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Co-authored-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Co-authored-by: Michael Niewöhner <foss(a)mniewoehner.de> Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- A src/ec/clevo/it5570e/Kconfig A src/ec/clevo/it5570e/Makefile.inc A src/ec/clevo/it5570e/acpi/ac.asl A src/ec/clevo/it5570e/acpi/battery.asl A src/ec/clevo/it5570e/acpi/buttons.asl A src/ec/clevo/it5570e/acpi/common.asl A src/ec/clevo/it5570e/acpi/ec.asl A src/ec/clevo/it5570e/acpi/ec_queries.asl A src/ec/clevo/it5570e/acpi/ec_ram.asl A src/ec/clevo/it5570e/acpi/hid.asl A src/ec/clevo/it5570e/acpi/lid.asl A src/ec/clevo/it5570e/chip.h A src/ec/clevo/it5570e/commands.c A src/ec/clevo/it5570e/commands.h A src/ec/clevo/it5570e/early_init.c A src/ec/clevo/it5570e/early_init.h A src/ec/clevo/it5570e/ec.c A src/ec/clevo/it5570e/ec.h A src/ec/clevo/it5570e/i2ec.c A src/ec/clevo/it5570e/i2ec.h A src/ec/clevo/it5570e/smbios.c A src/ec/clevo/it5570e/smihandler.c A src/ec/clevo/it5570e/smm.h A src/ec/clevo/it5570e/ssdt.c 24 files changed, 2,070 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/68791/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/superiotool: Add SMSC MEC5035
by Nicholas Chin (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Felix Held. Hello Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69481 to look at the new patch set (#2). Change subject: util/superiotool: Add SMSC MEC5035 ...................................................................... util/superiotool: Add SMSC MEC5035 Also comment out the SMSC FDC37M602 which has a conflicting ID and was never had the LDN/register layout anyway. Tested on a Dell Latitude E6400 Change-Id: I5b1900e6ef599c422a1d6eca7a2ac4691d56d874 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/superiotool/smsc.c 1 file changed, 86 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/69481/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b1900e6ef599c422a1d6eca7a2ac4691d56d874 Gerrit-Change-Number: 69481 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: cpu/intel/socket_*: Clean up Kconfig files
by Angel Pons (Code Review) 11 Nov '22

11 Nov '22

1 0

[M] Change in coreboot[master]: util/superiotool: Add MEC5035
by Nicholas Chin (Code Review) 11 Nov '22

11 Nov '22

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69481 ) Change subject: util/superiotool: Add MEC5035 ...................................................................... util/superiotool: Add MEC5035 Also comment out the SMSC FDC37M602 which has a conflicting ID and was never had the LDN/register layout anyway. Tested on a Dell Latitude E6400 Change-Id: I5b1900e6ef599c422a1d6eca7a2ac4691d56d874 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/superiotool/smsc.c 1 file changed, 86 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/69481/1 diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c index 4175d3e..8d90e76 100644 --- a/util/superiotool/smsc.c +++ b/util/superiotool/smsc.c @@ -345,8 +345,10 @@ {0x30,0x60,0x61,0x70,0xf0,EOT}, {0x00,0x00,0x00,NANA,NANA,EOT}}, {EOT}}}, - {0x46, "FDC37M602", { /* Found in Biostar M6TLD. */ + /* FIXME: Conflicting ID with MEC5035 + {0x46, "FDC37M602", { Found in Biostar M6TLD. {EOT}}}, + */ {0x47, "FDC37M60x", { /* TODO: Not yet in sensors-detect */ {EOT}}}, {0x4c, "FDC37B72x", { @@ -987,6 +989,74 @@ EOT}, {EOT}}, {EOT}}}, + {0x46, "MEC5035", { + {NOLDN, NULL, + {0x07, 0x20, 0x21, 0x24, EOT}, + {0x00, 0x46, 0x00, 0x00, EOT}}, + {0x1, "Keyboard Controller", + {0x30, EOT}, + {0x00, EOT}}, + {0x6, "UART", + {0x30, 0xF0, EOT}, + {0x00, 0x00, EOT}}, + {0xC, "LPC Interface", + {0x30, + /* IRQ Config */ + 0x40, 0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48, + 0x49, 0x4a, 0x4b, 0x4c, 0x4d, 0x4e, 0x4f, + /* DMA Channel 0 - 7 */ + 0x50, 0x51, 0x52, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, + 0x59, 0x5a, 0x5b, 0x5c, 0x5d, 0x5e, 0x5f, + /* BAR configuration Port */ + 0x60, 0x61, 0x62, 0x63, + /* BAR Mailbox Registers */ + 0x64, 0x65, 0x66, 0x67, + /* BAR 8042 Keyboard Interface */ + 0x68, 0x69, 0x6a, 0x6b, + /* BAR ACPI EC Interface 1 */ + 0x6c, 0x6d, 0x6e, 0x6f, + /* BAR ACPI EC Interface 2 */ + 0x70, 0x71, 0x72, 0x73, + /* BAR ACPI EC Interface 3 */ + 0x74, 0x75, 0x76, 0x77, + /* BAR ACPI PM1 Interface */ + 0x78, 0x79, 0x7a, 0x7b, + /* BAR UART */ + 0x7c, 0x7d, 0x7e, 0x7f, + /* BAR Legacy (Fast Keyboard) Interface */ + 0x80, 0x81, 0x82, 0x83, + /* BAR Embedded Flash Interface */ + 0x84, 0x85, 0x86, 0x87, + EOT}, + {0x00, + /* IRQ Config */ + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, + /* DMA Channel 0 - 7 */ + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + /* BAR configuration Port */ + 0x01, 0x0C, 0x2e, 0x00, + /* BAR Mailbox Registers */ + 0x01, 0x00, 0x00, 0x00, + /* BAR 8042 Keyboard Interface */ + 0x04, 0x01, 0x60, 0x00, + /* BAR ACPI EC Interface 1 */ + 0x04, 0x02, 0x62, 0x00, + /* BAR ACPI EC Interface 2 */ + 0x07, 0x03, 0x62, 0x00, + /* BAR ACPI EC Interface 3 */ + 0x07, 0x04, 0x62, 0x00, + /* BAR ACPI PM1 Interface */ + 0x07, 0x05, 0x00, 0x00, + /* BAR UART */ + 0x07, 0x06, 0x00, 0x00, + /* BAR Legacy (Fast Keyboard) Interface */ + 0x00, 0x07, 0x92, 0x00, + /* BAR Embedded Flash Interface */ + 0x04, 0x0e, 0x00, 0x00, + EOT}}, + {EOT}}}, {EOT} }; -- To view, visit https://review.coreboot.org/c/coreboot/+/69481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b1900e6ef599c422a1d6eca7a2ac4691d56d874 Gerrit-Change-Number: 69481 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: util/superiotool: Add Nuvoton NCT6685D/NCT6686D
by Nicholas Chin (Code Review) 11 Nov '22

11 Nov '22

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69480 ) Change subject: util/superiotool: Add Nuvoton NCT6685D/NCT6686D ...................................................................... util/superiotool: Add Nuvoton NCT6685D/NCT6686D There doesn't seem to be a datasheet available for the NCT6685D, but there is one for the NCT6686D. The 85D seems to return the same ID as the 86D, and the registers do seem to be returning valid data other than LDN 0xf which returns all 1s. The LDN and register layout appears to be identical to the NCT6687D-W. Tested on a Lenovo ThinkCentre M900 with a NCT6685D. Change-Id: I4de0e7b86422a14ab9ccb15b7571597611d755d5 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/superiotool/nuvoton.c 1 file changed, 85 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/69480/1 diff --git a/util/superiotool/nuvoton.c b/util/superiotool/nuvoton.c index ea11393..21d77fd 100644 --- a/util/superiotool/nuvoton.c +++ b/util/superiotool/nuvoton.c @@ -82,6 +82,73 @@ {EOT}}}, {0x1a, "WPCM450", { {EOT}}}, + {0xc73a, "NCT6685D/NCT6686D", { + {NOLDN, "Global Configuration", + {0x10,0x11,0x13,0x14,0x15,0x1a,0x1b,0x1d,0x1e, + 0x1f,0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27, + 0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2f,EOT}, + {0xff,0xff,0x00,0x00,0x00,0x00,0x10,0x00,0x00, + 0x00,0xc7,0x3a,0x00,0x80,0x67,0x01,0x00,0x3e, + 0x00,0x03,0x0f,0x00,0x00,0x00,MISC,EOT}}, + {0x01, "Parallel Port", + {0x30,0x60,0x61,0x70,0x74,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x3f,EOT}}, + {0x02, "UART A", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x03, "UART B, IR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x05, "Keyboard Controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}}, + {0x06, "CIR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,0xf3,EOT}, + {0x00,0x00,0x00,0x00,0x08,0x09,0x32,0x00,EOT}}, + {0x07, "GPIO0-7", + {0x30,0x60,0x61,0x70,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5, + 0xe6,0xe7,0xe8,0xe9,0xeb,0xec,0xed,0xee,0xef,0xf0, + 0xf1,EOT}, + {0x00,0x00,0x00,0x00,NANA,NANA,NANA,NANA,NANA,NANA, + NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA, + 0x01,EOT}}, + {0x08, "PORT80 UART", + {0xe0,0xe1,0xe2,0xe3,0xe4,EOT}, + {0x80,0x00,0x00,0x10,0x00,EOT}}, + {0x09, "GPIO8-9, GPIO1-8 Alternate Function", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8, + 0xe9,0xea,0xeb,0xec,0xed,0xee,0xef,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x0a, "ACPI", + {0x30,0x60,0x61,0x70,0xe0,0xe1,0xe2,0xe3,0xe4,0xe6, + 0xe7,0xe8,0xea,0xeb,0xec,0xee,0xf0,0xf1,0xf2,0xf3, + 0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb,0xfc,EOT}, + {0x00,0x00,0x00,0x00,0x01,0x00,0x00,0x00,0x00,0x00, + 0xef,0x80,0x2e,0x00,0x01,0x00,0x00,0x00,0x00,0x00, + 0x0d,0x0d,0x01,0x00,0x04,0x00,0x00,0x00,0x04,EOT}}, + {0x0b, "EC", + {0x30,0x60,0x61,0x70,0xe0,0xe3,0xe4,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x0c, "RTC", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8, + 0xe9,0xea,0xeb,0xec,0xed,0xee,0xef,0xf0,EOT}, + {0x00,NANA,NANA,NANA,NANA,NANA,NANA,NANA,0x00,0x00, + 0x00,0x00,0x00,0x07,0x00,0x00,0x00,0x80,EOT}}, + {0x0d, "Deep Sleep, Power Fault", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8, + 0xf0,0xf1,0xf3,EOT}, + {0xa0,0x20,0x04,0x05,0x6e,0x00,0x00,0x00,0x88,0x77, + 0x70,0xaa,0x01,EOT}}, + {0x0e, "TACHIN/PWMOUT Assignment", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,0xe9, + 0xea,0xeb,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, + 0x00,0x00,EOT}}, + {0x0f, "Function Register", + {0xe3,0xe4,0xe5,0xe8,0xe9,0xea,EOT}, + {0x80,0x01,0x00,0x00,0x00,0x00,EOT}}, + {EOT}}}, {0xd592, "NCT6687D-W", { {NOLDN, "Global Configuration", {0x10,0x11,0x13,0x14,0x15,0x1a,0x1b,0x1d,0x1e, -- To view, visit https://review.coreboot.org/c/coreboot/+/69480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4de0e7b86422a14ab9ccb15b7571597611d755d5 Gerrit-Change-Number: 69480 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: cpu/intel/socket_*: Clean up Kconfig files
by Angel Pons (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Stefan Ott, Nico Huber, Arthur Heymans, Kyösti Mälkki, Alexander Couzens, Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69447 ) Change subject: cpu/intel/socket_*: Clean up Kconfig files ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69447/comment/2e97396c_4b4832b1 PS3, Line 10: Move MAX_CPUS to mainboards. > Set the max CPUs in socket Kconfig doesn't make sense! Why? The sockets you changed in this patch are well-defined: * BGA956 is for low-power soldered-down Core 2 CPUs, which are paired with a GS45 northbridge (low-power variant of GM45). There are no quad-core CPUs in this package, so MAX_CPUS=2 * FCBGA559 is Pineview, but the CPU model is shared with Diamondville. These CPUs are dual-core with HyperThreading, so MAX_CPUS=4 * Socket P supports Core 2 Duo and (sometimes) Core 2 Quad CPUs, so MAX_CPUS=4 For sockets like LGA775, the northbridges specify MAX_CPUS. Ironically enough, MAX_CPUS=4 for both of them. > Each socket can support only one CPU , however, a mainboard can have more than 1 socket (when the northbridge support it). Mainboards with more than 1 socket? None of the platforms affected by this change support more than 1 socket. It's also that can be addressed with a MAX_SOCKET Kconfig. -- To view, visit https://review.coreboot.org/c/coreboot/+/69447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2265ac716e90720e7ccc550239737d40c2f7a0a Gerrit-Change-Number: 69447 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: libpayload: Enable LTO by default
by Angel Pons (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Nico Huber, Stefan Reinauer, Paul Menzel, Julius Werner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51177 ) Change subject: libpayload: Enable LTO by default ...................................................................... Patch Set 12: Code-Review+1 (2 comments) Patchset: PS12: > Angel, at last weeks meeting you said something about adding a build config for LTO. […] If it's enabled by default, no config to test LTO is needed, but then the problem is that things may break. PS12: > How has this been tested? There might be breakage in individual drivers by enabling LTO. […] +1 to this concern. -- To view, visit https://review.coreboot.org/c/coreboot/+/51177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bc58034ea8a9510ddc08d61d19e75a7c6f9cbc7 Gerrit-Change-Number: 51177 Gerrit-PatchSet: 12 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:19:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347
by Angel Pons (Code Review) 11 Nov '22

11 Nov '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68264 ) Change subject: drivers/usb/gadget.c: Add support for EHCI debug using the WCH CH347 ...................................................................... Patch Set 5: (1 comment) File src/drivers/usb/gadget.c: https://review.coreboot.org/c/coreboot/+/68264/comment/1100ddc6_b824f860 PS4, Line 215: } __packed; > Ack Concern would be that `baudrate` bytes could be sent differently on big-endian systems. -- To view, visit https://review.coreboot.org/c/coreboot/+/68264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd4ad17b7369948003fff7e825b46fe852bc7eb9 Gerrit-Change-Number: 68264 Gerrit-PatchSet: 5 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
by Angel Pons (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 ) Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0 Gerrit-Change-Number: 62830 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:16:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Michael Niewöhner (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Arthur Heymans, Michael Niewöhner. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 ) Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... Patch Set 13: (1 comment) File src/ec/clevo/it5570e/acpi/hid.asl: https://review.coreboot.org/c/coreboot/+/68791/comment/cc4e1e96_820abd3d PS12, Line 13: /* : * Workaround: : * There is a bug in Linux' HID driver, making evaluation of function 2 fail. : * The driver falls back to legacy mode (evaluation of integers instead of _DSM), : * so let's add that until the fix gets merged. : */ actually, this was already merged. we probably still should keep it for some time. https://www.spinics.net/lists/platform-driver-x86/msg32730.html -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:07:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022