coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Angel Pons (Code Review) 12 Nov '22

12 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Arthur Heymans, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 ) Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... Patch Set 13: Code-Review+2 (4 comments) File src/ec/clevo/it5570e/ec.c: https://review.coreboot.org/c/coreboot/+/68791/comment/40bed4f2_6239958c PS4, Line 34: 0x2e > no, it's always the same as it's the standard superio port From another comment: Clevo doesn't seem to use any other port. For now it should be OK. File src/ec/clevo/it5570e/ec.c: https://review.coreboot.org/c/coreboot/+/68791/comment/1ffc29d0_a8352ab1 PS13, Line 120: dev->ops = &ec_ops; Future idea: use the shiny new `ops` devicetree syntax File src/ec/clevo/it5570e/i2ec.h: https://review.coreboot.org/c/coreboot/+/68791/comment/da3cfdda_e4fe5892 PS4, Line 10: #define D2ADR 0x2e > hopefully clearer now Certainly clearer, yes. Thanks! File src/ec/clevo/it5570e/i2ec.c: https://review.coreboot.org/c/coreboot/+/68791/comment/fce5df2c_3984b289 PS4, Line 11: 0x2e > reworked and successfully tested (by setting the cmos option for the keyboard backlight boot effect to enable/disable and read the ec register through the debugger interface). Nice, thank you. > I decided to hardcode the PNP device, since no Clevo board uses 0x4e/0x4f anyways But it's easy to change the `SIO_DEV` macro if need be, so it works for us. Thanks 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:05:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Michael Niewöhner (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 ) Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... Patch Set 12: (3 comments) File src/ec/clevo/it5570e/i2ec.h: https://review.coreboot.org/c/coreboot/+/68791/comment/a470aac2_2bbaea2e PS4, Line 10: #define D2ADR 0x2e > that's what the comment on line 13 tried to do ;) I'll make it clearer hopefully clearer now File src/ec/clevo/it5570e/i2ec.c: https://review.coreboot.org/c/coreboot/+/68791/comment/bd1bc022_95319314 PS4, Line 11: 0x2e > > OK, so it's not the same thing. […] reworked and successfully tested (by setting the cmos option for the keyboard backlight boot effect to enable/disable and read the ec register through the debugger interface). I decided to hardcode the PNP device, since no Clevo board uses 0x4e/0x4f anyways File src/ec/clevo/it5570e/i2ec.c: https://review.coreboot.org/c/coreboot/+/68791/comment/c892e80e_a1df6385 PS12, Line 17: I2EC_ADDR_H > good catch. I'm completely confused now... I had tested the backlight effect switch and it worked... […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:59:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Michael Niewöhner (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68791 to look at the new patch set (#13). Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... ec/clevo/it5570e: add driver for EC used on various Clevo laptops This adds a driver for the ITE IT5570E EC in combination with Clevo vendor EC firmware. The interface is mostly identical on various laptop models. Thus, we have implemented one common driver to support them all. The following features were implemented: - Basics like battery, ac, etc. - Suspend/hibernate support: S0ix, S3*, S4/S5 - Save/restore of keyboard backlight level during S0ix without the need for Clevo vendor software (ControlCenter) - Flexicharger - Fn keys (backlight, volume, airplane etc.) - Various configuration options via Kconfig / CMOS options * Note: S3 support works at least on L140CU (Cometlake), but it's not enabled for this board because S0ix is used. Not implemented, yet: - Type-C UCSI: the EC firmware seems to be buggy (with vendor fw, too) - dGPU support is WIP An example of how this driver can be hooked up by a board can be seen in in change CB:59850, where support for the L140MU is added. Known issues: - Touchpad toggle: The touchpad toggle (Fn-F1) has two modes, Ctrl-Alt-F9 mode and keycodes 0xf7/0xf8 mode. Ctrl-Alt-F9 is the native touchpad toggle shortcut on Windows. On Linux this would switch to virtual console 9, if enabled. Thus, one should use the keycodes mode and add udev rules as specified in [1]. If VT9 is disabled, Ctrl-Alt-F9 mode could be used to set up a keyboard shortcut command toggling the touchpad. - Multi-fan systems The Clevo NV41MZ (w/o dGPU) has two fans that should be in-sync. However, the second fan does not spin. This needs further investigation. [1] https://docs.dasharo.com/variants/clevo_nv41/post_install/ Testing the various functionalities of this EC driver was done in the changes hooking up this driver for the boards. Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Co-authored-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Co-authored-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Co-authored-by: Michael Niewöhner <foss(a)mniewoehner.de> Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- A src/ec/clevo/it5570e/Kconfig A src/ec/clevo/it5570e/Makefile.inc A src/ec/clevo/it5570e/acpi/ac.asl A src/ec/clevo/it5570e/acpi/battery.asl A src/ec/clevo/it5570e/acpi/buttons.asl A src/ec/clevo/it5570e/acpi/common.asl A src/ec/clevo/it5570e/acpi/ec.asl A src/ec/clevo/it5570e/acpi/ec_queries.asl A src/ec/clevo/it5570e/acpi/ec_ram.asl A src/ec/clevo/it5570e/acpi/hid.asl A src/ec/clevo/it5570e/acpi/lid.asl A src/ec/clevo/it5570e/chip.h A src/ec/clevo/it5570e/commands.c A src/ec/clevo/it5570e/commands.h A src/ec/clevo/it5570e/early_init.c A src/ec/clevo/it5570e/early_init.h A src/ec/clevo/it5570e/ec.c A src/ec/clevo/it5570e/ec.h A src/ec/clevo/it5570e/i2ec.c A src/ec/clevo/it5570e/i2ec.h A src/ec/clevo/it5570e/smbios.c A src/ec/clevo/it5570e/smihandler.c A src/ec/clevo/it5570e/smm.h A src/ec/clevo/it5570e/ssdt.c 24 files changed, 2,068 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/68791/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/kconfig/README.md: Add notes about adding a new quilt patch
by Nicholas Chin (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Patrick Georgi, Martin L Roth, Angel Pons. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69458 ) Change subject: util/kconfig/README.md: Add notes about adding a new quilt patch ...................................................................... Patch Set 2: (1 comment) File util/kconfig/README.md: https://review.coreboot.org/c/coreboot/+/69458/comment/fbae6966_0b379dc1 PS1, Line 79: updates > update*d*? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a8bbe41e0864be1d28116742b6b8b3fc440cc31 Gerrit-Change-Number: 69458 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:51:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/kconfig/README.md: Add notes about adding a new quilt patch
by Nicholas Chin (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Patrick Georgi, Martin L Roth, Nicholas Chin. Hello Patrick Georgi, Martin L Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69458 to look at the new patch set (#2). Change subject: util/kconfig/README.md: Add notes about adding a new quilt patch ...................................................................... util/kconfig/README.md: Add notes about adding a new quilt patch The patches for kconfig need to be in a format compatible with the quilt tool, and usually also contain a header with some additional info like the git commit. This header is in the same format as patches produced by `git format-patch`, but the diff style git uses is incompatible with quilt and there does not seem to be a straightforward way to format the diff section to work. Add some documentation for a method I found to go from a git commit to a quilt compatible patch with git headers. Change-Id: I7a8bbe41e0864be1d28116742b6b8b3fc440cc31 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/kconfig/README.md 1 file changed, 61 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/69458/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a8bbe41e0864be1d28116742b6b8b3fc440cc31 Gerrit-Change-Number: 69458 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/kconfig/README.md: Add notes about adding a new quilt patch
by Angel Pons (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Patrick Georgi, Martin L Roth, Nicholas Chin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69458 ) Change subject: util/kconfig/README.md: Add notes about adding a new quilt patch ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File util/kconfig/README.md: https://review.coreboot.org/c/coreboot/+/69458/comment/d261369e_0ff5c18f PS1, Line 79: updates update*d*? -- To view, visit https://review.coreboot.org/c/coreboot/+/69458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a8bbe41e0864be1d28116742b6b8b3fc440cc31 Gerrit-Change-Number: 69458 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:45:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Rename pcie_gpio_table to romstage_gpio_table
by Martin Roth (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Matt DeVillier. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67810 ) Change subject: mb/google/skyrim: Rename pcie_gpio_table to romstage_gpio_table ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/67810/comment/9ac5561f_6acf0ced PS2, Line 196: PAD_GPO(GPIO_7, HIGH), We'll need to make sure the power-on timings for all of the WLAN devices are still met after this was moved. -- To view, visit https://review.coreboot.org/c/coreboot/+/67810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I285602209072247895c2cb0830f3faf675328757 Gerrit-Change-Number: 67810 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:44:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/kconfig/README.md: Add notes about adding a new quilt patch
by Nicholas Chin (Code Review) 11 Nov '22

11 Nov '22

Attention is currently required from: Patrick Georgi, Martin L Roth. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69458 ) Change subject: util/kconfig/README.md: Add notes about adding a new quilt patch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This might not be the cleanest way to do this, but it does work. If anyone knows a better way I'm open to hear it. -- To view, visit https://review.coreboot.org/c/coreboot/+/69458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a8bbe41e0864be1d28116742b6b8b3fc440cc31 Gerrit-Change-Number: 69458 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Nov 2022 21:43:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Create crystaldrift variant
by Chao Gui (Code Review) 11 Nov '22

11 Nov '22

Chao Gui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69479 ) Change subject: mb/google/skyrim: Create crystaldrift variant ...................................................................... mb/google/skyrim: Create crystaldrift variant Create the crystaldrift variant of the skyrim reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:240970782 BRANCH=None TEST=util/abuild/abuild -p none -t google/skyrim -x -a make sure the build includes GOOGLE_CRYSTALDRIFT Signed-off-by: Chao Gui <chaogui(a)google.com> Change-Id: Ibb3ebaa7e4af1a03173b93b8c4fbd342f7cd7100 --- M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/skyrim/Kconfig.name A src/mainboard/google/skyrim/variants/crystaldrift/include/variant/ec.h A src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb 4 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/69479/1 diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index e545ba5..ff80c26 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -80,6 +80,7 @@ default "Winterhold" if BOARD_GOOGLE_WINTERHOLD default "Morthal" if BOARD_GOOGLE_MORTHAL default "Frostflow" if BOARD_GOOGLE_FROSTFLOW + default "Crystaldrift" if BOARD_GOOGLE_CRYSTALDRIFT config OVERRIDE_DEVICETREE string @@ -91,6 +92,7 @@ default "winterhold" if BOARD_GOOGLE_WINTERHOLD default "morthal" if BOARD_GOOGLE_MORTHAL default "frostflow" if BOARD_GOOGLE_FROSTFLOW + default "crystaldrift" if BOARD_GOOGLE_CRYSTALDRIFT config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/skyrim/Kconfig.name b/src/mainboard/google/skyrim/Kconfig.name index f7f8d7c..3146819 100644 --- a/src/mainboard/google/skyrim/Kconfig.name +++ b/src/mainboard/google/skyrim/Kconfig.name @@ -18,3 +18,7 @@ bool "-> Frostflow" select BOARD_GOOGLE_BASEBOARD_SKYRIM select DRIVERS_GENESYSLOGIC_GL9755 + +config BOARD_GOOGLE_CRYSTALDRIFT + bool "-> Crystaldrift" + select BOARD_GOOGLE_BASEBOARD_SKYRIM diff --git a/src/mainboard/google/skyrim/variants/crystaldrift/include/variant/ec.h b/src/mainboard/google/skyrim/variants/crystaldrift/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/skyrim/variants/crystaldrift/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb b/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb new file mode 100644 index 0000000..7a56f93 --- /dev/null +++ b/src/mainboard/google/skyrim/variants/crystaldrift/overridetree.cb @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/mendocino + device domain 0 on end +end # chip soc/amd/mendocino -- To view, visit https://review.coreboot.org/c/coreboot/+/69479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb3ebaa7e4af1a03173b93b8c4fbd342f7cd7100 Gerrit-Change-Number: 69479 Gerrit-PatchSet: 1 Gerrit-Owner: Chao Gui <chaogui(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: util/kconfig/README.md: Add notes about adding a new quilt patch
by Nicholas Chin (Code Review) 11 Nov '22

11 Nov '22

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69458 ) Change subject: util/kconfig/README.md: Add notes about adding a new quilt patch ...................................................................... util/kconfig/README.md: Add notes about adding a new quilt patch The patches for kconfig need to be in a format compatible with the quilt tool, and usually also contain a header with some additional info like the git commit. This header is in the same format as patches produced by `git format-patch`, but the diff style git uses is incompatible with quilt and there does not seem to be a straightforward way to format the diff section to work. Add some documentation for a method I found to go from a git commit to a quilt compatible patch with git headers. Change-Id: I7a8bbe41e0864be1d28116742b6b8b3fc440cc31 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/kconfig/README.md 1 file changed, 61 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/69458/1 diff --git a/util/kconfig/README.md b/util/kconfig/README.md index 1350e04..1448c05 100644 --- a/util/kconfig/README.md +++ b/util/kconfig/README.md @@ -37,3 +37,44 @@ Check that kconfig still works, `git add` and `git commit` the changes and write a meaningful commit message that documents what Linux kconfig version the tree has been upreved to. + +## Adding a new patch +The format of the patches to kconfig is a mix of the headers produced by `git +format-patch` and the patch format of quilt. However neither git nor quilt +seems to have any functionality to directly produce a file in such a format + +To add a patch in this format: +1. Add your changes to the sources and `git commit` them +2. Generate a git patch for the commit: + + $ git format-patch HEAD~ + +3. Reverse apply the newly created patch file to restore the tree back to the + state quilt thinks it is in: + + $ git apply -R <the patch file> + +4. Import the patch info quilt: + + $ quilt import <the patch file> + +5. Force push the change so quilt changes the top to the patch (quilt won't + like the git diff style): + + $ quilt push -f <the patch file> + +6. Add the changed files to be tracked against the quilt: + + $ quilt add <the files you changed> + +7. Re-apply your changes from the patch file + + $ git apply <the patch file> + +8. Add the changes to quilt to regenerate the patch file in a quilt compatible + format: + + $ quilt refresh + +9. The new patch file and updates patches/series files can not be added to the + git commit -- To view, visit https://review.coreboot.org/c/coreboot/+/69458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a8bbe41e0864be1d28116742b6b8b3fc440cc31 Gerrit-Change-Number: 69458 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022