Attention is currently required from: Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68892 )
Change subject: cpu/mp_init.c: Only enable CPUs once they execute code
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS8:
> the original implementation of the functionality of add_cpu_device was added in https://review. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c8042b4d6127239175924f996f735bf9c83c6e8
Gerrit-Change-Number: 68892
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 13 Nov 2022 17:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Hello Arthur Heymans, build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64802
to look at the new patch set (#17).
Change subject: cpu/smm_module_loader.c: Fix up CPU index locally
......................................................................
cpu/smm_module_loader.c: Fix up CPU index locally
Don't pass the stub params to the mp_init code.
Change-Id: I070bc00ae5e5bceb6c5b90ea833cc057dd41f6cc
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/x86/mp_init.c
M src/cpu/x86/smm/smm_module_loader.c
M src/include/cpu/x86/smm.h
3 files changed, 28 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/64802/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/64802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I070bc00ae5e5bceb6c5b90ea833cc057dd41f6cc
Gerrit-Change-Number: 64802
Gerrit-PatchSet: 17
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69224 )
Change subject: cpu/x86/smm_module_loader: Use struct device instead of cpu index
......................................................................
Abandoned
Not needed anymore
--
To view, visit https://review.coreboot.org/c/coreboot/+/69224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1c2a889efe54589cf036cd1c3afb36e48d15720
Gerrit-Change-Number: 69224
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Angel Pons, Alexander Couzens, Evgeny Zinoviev.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69502 )
Change subject: mb/*: Replace SNB PCI devices with references from chipset.cb
......................................................................
Patch Set 2: Verified+1
(8 comments)
File src/mainboard/apple/macbookair4_2/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163511):
https://review.coreboot.org/c/coreboot/+/69502/comment/25438225_36101fb5
PS2, Line 43: device ref hda on # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/asrock/b75pro3-m/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163511):
https://review.coreboot.org/c/coreboot/+/69502/comment/dcd56ccb_88769f6e
PS2, Line 60: device ref hda on # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163511):
https://review.coreboot.org/c/coreboot/+/69502/comment/80a0d980_933eb988
PS2, Line 33: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/hp/z220_series/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163511):
https://review.coreboot.org/c/coreboot/+/69502/comment/653fba29_06bb4e3a
PS2, Line 37: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/lenovo/l520/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163511):
https://review.coreboot.org/c/coreboot/+/69502/comment/e1000218_a4b4ac9e
PS2, Line 44: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/lenovo/s230u/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163511):
https://review.coreboot.org/c/coreboot/+/69502/comment/564a938d_54d6136b
PS2, Line 48: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/lenovo/t430/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163511):
https://review.coreboot.org/c/coreboot/+/69502/comment/4a8d78a8_b9984761
PS2, Line 46: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/lenovo/x131e/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163511):
https://review.coreboot.org/c/coreboot/+/69502/comment/766e74ec_534db489
PS2, Line 58: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
--
To view, visit https://review.coreboot.org/c/coreboot/+/69502
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74c34a97ea4340fb11a0db422a48e1418221627e
Gerrit-Change-Number: 69502
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Comment-Date: Sun, 13 Nov 2022 17:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Raul Rangel, Tristan Corrick, Tim Wawrzynczak, Angel Pons, Alexander Couzens, Patrick Rudolph.
Arthur Heymans has uploaded a new patch set (#14) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/59314 )
Change subject: cpu/intel/haswell: Move chip_ops to cpu cluster
......................................................................
cpu/intel/haswell: Move chip_ops to cpu cluster
The cpu cluster is always present and it's the proper device to contain
the settings that need to be applied to all cpus. This makes it possible
to remove the fake lapic from devicetrees.
Change-Id: Ic449b2df8036e8c02b5559cca6b2e7479a70a786
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/intel/haswell/acpi.c
M src/cpu/intel/haswell/chip.h
M src/cpu/intel/haswell/haswell_init.c
M src/mainboard/asrock/b85m_pro4/devicetree.cb
M src/mainboard/asrock/h81m-hds/devicetree.cb
M src/mainboard/google/auron/devicetree.cb
M src/mainboard/google/auron/variants/buddy/overridetree.cb
M src/mainboard/google/auron/variants/samus/overridetree.cb
M src/mainboard/google/beltino/devicetree.cb
M src/mainboard/google/jecht/devicetree.cb
M src/mainboard/google/slippy/devicetree.cb
M src/mainboard/hp/folio_9480m/devicetree.cb
M src/mainboard/intel/baskingridge/devicetree.cb
M src/mainboard/intel/wtm2/devicetree.cb
M src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
M src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
M src/mainboard/msi/h81m-p33/devicetree.cb
M src/mainboard/purism/librem_bdw/devicetree.cb
M src/mainboard/supermicro/x10slm-f/devicetree.cb
M src/northbridge/intel/haswell/northbridge.c
M src/soc/intel/broadwell/northbridge.c
21 files changed, 72 insertions(+), 138 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59314/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/59314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic449b2df8036e8c02b5559cca6b2e7479a70a786
Gerrit-Change-Number: 59314
Gerrit-PatchSet: 14
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Johnny Lin, Christian Walter, Arthur Heymans, Andrey Petrov, Tim Chu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69509 )
Change subject: Revert "src/arch/x86: Use core apic id to get cpu_index()"
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Let me test this CL tomorrow
--
To view, visit https://review.coreboot.org/c/coreboot/+/69509
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a40156ba275b572d7d1913d8c17c24b4c8f6d78
Gerrit-Change-Number: 69509
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sun, 13 Nov 2022 17:10:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Michał Żygowski, Christian Walter, Tim Wawrzynczak, Julius Werner, Krystian Hebel, Yu-Ping Wu.
Hello Lance Zhao, Michał Żygowski, Tim Wawrzynczak, Christian Walter, Julius Werner, Krystian Hebel, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69161
to look at the new patch set (#4).
Change subject: security/tpm: replace CONFIG(TPMx) checks with runtime check
......................................................................
security/tpm: replace CONFIG(TPMx) checks with runtime check
This prepares the code to enabling both CONFIG_TPM1 and CONFIT_TPM2
during compilation, in which case actual TPM family in use will be
determined at runtime.
Change-Id: Id9cc25aad8d1d7bfad12b7a92059b1b3641bbfa9
Ticket: https://ticket.coreboot.org/issues/433
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/acpi/acpi.c
M src/drivers/crb/tis.c
M src/drivers/pc80/tpm/tis.c
M src/drivers/tpm/ppi.c
M src/security/tpm/tspi/crtm.h
M src/security/tpm/tspi/tspi.c
M src/security/tpm/tss.h
M src/security/tpm/tss/tss.c
M src/security/vboot/secdata_tpm.c
M src/security/vboot/tpm_common.c
M src/vendorcode/google/chromeos/cse_board_reset.c
M src/vendorcode/google/chromeos/tpm2.c
12 files changed, 123 insertions(+), 64 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/69161/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/69161
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9cc25aad8d1d7bfad12b7a92059b1b3641bbfa9
Gerrit-Change-Number: 69161
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset