coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: superio/acpi/pnp_generic.asl: Add _PRS for each device
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth, Tristan Corrick, Angel Pons, Arthur Heymans, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64218 ) Change subject: superio/acpi/pnp_generic.asl: Add _PRS for each device ...................................................................... Patch Set 6: Code-Review-1 (1 comment) Patchset: PS6: Please see https://qa.coreboot.org/job/coreboot-toolchain/1274/ -- To view, visit https://review.coreboot.org/c/coreboot/+/64218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Gerrit-Change-Number: 64218 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 13 Nov 2022 18:03:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: IASL: Ignore IASL's "Missing dependency" warning
by Elyes Haouas (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Michał Żygowski, Michał Kopeć, Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68936 ) Change subject: IASL: Ignore IASL's "Missing dependency" warning ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Instead of working around warnings it's best to fix them: CB:64218 https://review.coreboot.org/64218 will not fix the issue please see https://qa.coreboot.org/job/coreboot-toolchain/1274/ -- To view, visit https://review.coreboot.org/c/coreboot/+/68936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17d4f7ad4e3a9cb7d94263080d9d14fe6c9380d9 Gerrit-Change-Number: 68936 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 13 Nov 2022 18:01:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in qc_blobs[master]: sc7280/boot/shrm: Update qclib blobs binaries from 35 to 40
by Sudheer Amrabadi (Code Review) 13 Nov '22

13 Nov '22

Sudheer Amrabadi has uploaded this change for review. ( https://review.coreboot.org/c/qc_blobs/+/69512 ) Change subject: sc7280/boot/shrm: Update qclib blobs binaries from 35 to 40 ...................................................................... sc7280/boot/shrm: Update qclib blobs binaries from 35 to 40 TEST=Validated on qualcomm sc7280 development board Signed-off-by: Sudheer Kumar Amrabadi <samrabad(a)codeaurora.org> Change-Id: Ib692a27f3bd30ef4065efaf1276c8c089e3a6f76 --- M sc7280/boot/Pmic.bin M sc7280/boot/QcLib.elf M sc7280/boot/Release_Notes.txt M sc7280/boot/dcb.bin M sc7280/shrm/Release_Notes.txt M sc7280/shrm/shrm.elf 6 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/12/69512/1 diff --git a/sc7280/boot/Pmic.bin b/sc7280/boot/Pmic.bin index a3944f6..b04563f 100644 --- a/sc7280/boot/Pmic.bin +++ b/sc7280/boot/Pmic.bin Binary files differ diff --git a/sc7280/boot/QcLib.elf b/sc7280/boot/QcLib.elf index 4bae3f8..edd30a9 100644 --- a/sc7280/boot/QcLib.elf +++ b/sc7280/boot/QcLib.elf Binary files differ diff --git a/sc7280/boot/Release_Notes.txt b/sc7280/boot/Release_Notes.txt index 0e85da9..5017d91 100644 --- a/sc7280/boot/Release_Notes.txt +++ b/sc7280/boot/Release_Notes.txt @@ -1,3 +1,25 @@ +================== Release 00040 ================================ +This Release Notes file covers these blobs: + * dcb.bin + * Pmic.bin + * QcLib.elf + +Version : 00040 + +Release Date : Nov,2022 + +Supported Silicon : SC7280 + +Changes since last version: + * LLVM upgrade to support chroot building + +Above Bins were used to generate coreboot image. + +No special instructions, requirements or dependencies, files must be +present in this folder to be pulled in during coreboot build + +Errata : Nothing to report + ================== Release 00035 ================================ This Release Notes file covers these blobs: * dcb.bin diff --git a/sc7280/boot/dcb.bin b/sc7280/boot/dcb.bin index 1456dab..275cf0c 100644 --- a/sc7280/boot/dcb.bin +++ b/sc7280/boot/dcb.bin Binary files differ diff --git a/sc7280/shrm/Release_Notes.txt b/sc7280/shrm/Release_Notes.txt index ff18e62..6114355 100644 --- a/sc7280/shrm/Release_Notes.txt +++ b/sc7280/shrm/Release_Notes.txt @@ -1,3 +1,23 @@ +================== Release 00040 ================================ +This Release Notes file covers these blobs: + * shrm.elf + +Version : 00040 + +Release Date : Nov,2022 + +Supported Silicon : SC7280 + +Changes since last version: + * LLVM upgrade to support chroot building + +Above Bins were used to generate coreboot image. + +No special instructions, requirements or dependencies, files must be +present in this folder to be pulled in during coreboot build + +Errata : Nothing to report + ================== Release 00035 ================================ This Release Notes file covers these blobs: * shrm.elf diff --git a/sc7280/shrm/shrm.elf b/sc7280/shrm/shrm.elf index a8fc013..a47c20a 100644 --- a/sc7280/shrm/shrm.elf +++ b/sc7280/shrm/shrm.elf Binary files differ -- To view, visit https://review.coreboot.org/c/qc_blobs/+/69512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: Ib692a27f3bd30ef4065efaf1276c8c089e3a6f76 Gerrit-Change-Number: 69512 Gerrit-PatchSet: 1 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/testing: Allow jenkins builders to skip testing areas
by build bot (Jenkins) (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69495 ) Change subject: util/testing: Allow jenkins builders to skip testing areas ...................................................................... Patch Set 2: (1 comment) File util/testing/Makefile.inc: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163519): https://review.coreboot.org/c/coreboot/+/69495/comment/0e19b05a_41a0158c PS2, Line 9: @echo ' test-basic - Run stardard build tests. All expected to pass.' 'stardard' may be misspelled - perhaps 'standard'? -- To view, visit https://review.coreboot.org/c/coreboot/+/69495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 Gerrit-Change-Number: 69495 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 17:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/testing: Move check of intel-sec-tool to separate target
by Martin L Roth (Code Review) 13 Nov '22

13 Nov '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69519 ) Change subject: util/testing: Move check of intel-sec-tool to separate target ...................................................................... util/testing: Move check of intel-sec-tool to separate target Testing for the presence of intel-sec-tools doesn't need to happen inside the what-jenkins-does target. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I6faa5bd5292ac5cceba9a64fe81939c0e25b9f3e --- M util/testing/Makefile.inc 1 file changed, 22 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/69519/1 diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index ad01ac1..ffd3e08 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -81,18 +81,20 @@ COREBOOT_BUILD_DIR?=coreboot-builds -what-jenkins-does: - rm -rf $(COREBOOT_BUILD_DIR)/chromeos $(COREBOOT_BUILD_DIR)/default - rm -rf $(COREBOOT_BUILD_DIR)/chromeos-clang $(COREBOOT_BUILD_DIR)/default-clang -ifneq ($(JENKINS_SKIP_LINT_TESTS),y) - util/lint/lint lint-stable --junit - util/lint/lint lint-extended --junit -endif +validate_sec_tools: if [ ! -f 3rdparty/intel-sec-tools/go.mod ]; then \ echo "Please download 3rdparty/intel-sec-tools/:"; \ echo "git submodule update --init 3rdparty/intel-sec-tools"; \ exit 1; \ fi + +what-jenkins-does: validate_sec_tools + rm -rf $(COREBOOT_BUILD_DIR)/chromeos $(COREBOOT_BUILD_DIR)/default + rm -rf $(COREBOOT_BUILD_DIR)/chromeos-clang $(COREBOOT_BUILD_DIR)/default-clang +ifneq ($(JENKINS_SKIP_UNIT_TESTS),y) + util/lint/lint lint-stable --junit + util/lint/lint lint-extended --junit +endif cd 3rdparty/intel-sec-tools/ ; go mod vendor cd util/goswid ; go mod vendor util/abuild/abuild -o $(COREBOOT_BUILD_DIR)/chromeos $(ABUILD_OPTIONS) -x -X $(top)/abuild-chromeos.xml -- To view, visit https://review.coreboot.org/c/coreboot/+/69519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6faa5bd5292ac5cceba9a64fe81939c0e25b9f3e Gerrit-Change-Number: 69519 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/testing: Allow jenkins builders to skip testing areas
by Martin L Roth (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth. Hello Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69495 to look at the new patch set (#2). Change subject: util/testing: Allow jenkins builders to skip testing areas ...................................................................... util/testing: Allow jenkins builders to skip testing areas With the addition of the clang tests, the jenkins builds are taking a really long time to run the tests. This change allows the "what-jenkins-does" build to be split into separate builds on jenkins. Additionally, some jenkins builds like coverity don't need (or want) to build clang or even the linters. Update help with the variables. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 --- M util/testing/Makefile.inc 1 file changed, 38 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/69495/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f8ac68c1bc8f8ff9be62d80db850355e742ee74 Gerrit-Change-Number: 69495 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: superio/acpi/pnp_generic.asl: Add _PRS for each device
by Nico Huber (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Martin L Roth, Tristan Corrick, Angel Pons, Arthur Heymans, Elyes Haouas, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64218 ) Change subject: superio/acpi/pnp_generic.asl: Add _PRS for each device ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/64218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Gerrit-Change-Number: 64218 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 13 Nov 2022 17:30:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [WIP]cpu/mp_init: Detect the number of CPUs are runtime
by build bot (Jenkins) (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Arthur Heymans, Kyösti Mälkki. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68893 ) Change subject: [WIP]cpu/mp_init: Detect the number of CPUs are runtime ...................................................................... Patch Set 15: Verified+1 (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163518): https://review.coreboot.org/c/coreboot/+/68893/comment/4f415166_6b1ce3b3 PS15, Line 8: Possible repeated word: 'are' File src/cpu/x86/mp_init.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163518): https://review.coreboot.org/c/coreboot/+/68893/comment/036183b4_3fd4c099 PS15, Line 494: if (!cpu->enabled) { braces {} are not necessary for any arm of this statement -- To view, visit https://review.coreboot.org/c/coreboot/+/68893 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafe9d3d4838dad46cd0c7b6d30b905cbd258f17f Gerrit-Change-Number: 68893 Gerrit-PatchSet: 15 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Nov 2022 17:29:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/x86/topology: Add code to fill in topology on struct path
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Jonathan Zhang, Angel Pons, Shuming Chu (Shuming), TangYiwei. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 ) Change subject: cpu/x86/topology: Add code to fill in topology on struct path ...................................................................... Patch Set 5: (2 comments) File src/cpu/x86/topology.c: https://review.coreboot.org/c/coreboot/+/69222/comment/edf8a5a6_9059b52d PS2, Line 83: > nit: 2 spaces Done File src/include/cpu/x86/topology.h: https://review.coreboot.org/c/coreboot/+/69222/comment/22d3b736_3316d795 PS1, Line 5: > It would be good to add a comment here to explain what this function does. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2210eb9b663dd90941a64132aa7154440dc7e5a9 Gerrit-Change-Number: 69222 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: TangYiwei Gerrit-Comment-Date: Sun, 13 Nov 2022 17:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/x86/topology: Add code to fill in topology on struct path
by Arthur Heymans (Code Review) 13 Nov '22

13 Nov '22

Attention is currently required from: Arthur Heymans, Shuming Chu (Shuming), TangYiwei. Hello build bot (Jenkins), Jonathan Zhang, Angel Pons, Shuming Chu (Shuming), TangYiwei, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69222 to look at the new patch set (#6). Change subject: cpu/x86/topology: Add code to fill in topology on struct path ...................................................................... cpu/x86/topology: Add code to fill in topology on struct path This is needed to generate MADT and SRAT where lapicid for threads need to be added last. Change-Id: I2210eb9b663dd90941a64132aa7154440dc7e5a9 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/Makefile.inc M src/cpu/x86/mp_init.c A src/cpu/x86/topology.c A src/include/cpu/x86/topology.h 4 files changed, 115 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/69222/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/69222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2210eb9b663dd90941a64132aa7154440dc7e5a9 Gerrit-Change-Number: 69222 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: TangYiwei Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022