Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak, Eric Lai.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68593 )
Change subject: acpi/Kconfig: Remove unused ACPI_EINJ config option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> This is default n and not the static value, maybe can keep it?
Indeed the default is n and there is no a single line …
[View More]of code behind it.
ACPI_EINJ is used upstream (see Jonathan's msg), and honestly I don't have a strong opinion about it....
--
To view, visit https://review.coreboot.org/c/coreboot/+/68593
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99
Gerrit-Change-Number: 68593
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 09:13:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Tarun Tuli, Subrata Banik.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69612 )
Change subject: mb/google/rex: Add `disable_gpio_export_in_crs` for rex
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69612/comment/80102109_91e2563b
PS1, Line 9: None of the touchscreens used in the rex program …
[View More]should require
: exporting of GPIOs in the ACPI _CRS method for any i2c
: device.
Sentence rephrase is required. You may use "Since Rex designs doesn't use touch screens, exporting GPIOs in the ACPI _CRS method for any i2c device".
--
To view, visit https://review.coreboot.org/c/coreboot/+/69612
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I578a60eff27f94d6dc94b900604bc7560337d60b
Gerrit-Change-Number: 69612
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 09:02:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Christian Walter, Angel Pons, David Milosevic.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68632 )
Change subject: mb/prodrive/atlas: add unique DIMM locators in smbios type17
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68632
To unsubscribe, or for help writing mail filters, visit https://…
[View More]review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8aef79faa43f2475485f581c675ee152e580f678
Gerrit-Change-Number: 68632
Gerrit-PatchSet: 4
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 08:58:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Johnny Lin, Angel Pons, Arthur Heymans.
Shuming Chu (Shuming) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69198 )
Change subject: include/cper.h: Add CPER Memory Error Section definitions
......................................................................
Patch Set 4:
(2 comments)
File src/include/cper.h:
https://review.coreboot.org/c/coreboot/+/69198/comment/88422d73_f31896b9
PS3, Line 400: enum cper_err_code …
[View More]mem_err_type;
> > Will this work properly? Not sure if the size of enum types is well-defined. […]
Done
https://review.coreboot.org/c/coreboot/+/69198/comment/c8fafa4b_7865a8ee
PS3, Line 405: __packed
> This is not needed. All entries seem aligned.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a165350a16a4cbe4033a3e7c43fa23a5b27c44b
Gerrit-Change-Number: 69198
Gerrit-PatchSet: 4
Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 16 Nov 2022 08:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Johnny Lin, Angel Pons, Shuming Chu (Shuming).
Hello build bot (Jenkins), Jonathan Zhang, Johnny Lin, Angel Pons, Arthur Heymans, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69198
to look at the new patch set (#4).
Change subject: include/cper.h: Add CPER Memory Error Section definitions
......................................................................
include/cper.h: Add CPER Memory …
[View More]Error Section definitions
Add Memory Error Section definitions from UEFI Specification rev 2.10
appendix N.2.5. The structure defined here may be used for machine
check handling.
Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com>
Change-Id: I0a165350a16a4cbe4033a3e7c43fa23a5b27c44b
---
M src/include/cper.h
1 file changed, 46 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/69198/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/69198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a165350a16a4cbe4033a3e7c43fa23a5b27c44b
Gerrit-Change-Number: 69198
Gerrit-PatchSet: 4
Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: Tarun Tuli, Krishna P Bhat D.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69683 )
Change subject: mb/google/nissa: Modify FMD to redistribute buffer
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/chromeos-nissa-32MiB.fmd:
https://review.coreboot.org/c/coreboot/+/69683/comment/59b1585c_b14fa34f
PS1, Line 27: 7056K
7120K ?
-…
[View More]-
To view, visit https://review.coreboot.org/c/coreboot/+/69683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ead2f81850a2aa79e677c7f271db672e235750a
Gerrit-Change-Number: 69683
Gerrit-PatchSet: 1
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Comment-Date: Wed, 16 Nov 2022 08:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]