coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[XL] Change in coreboot[master]: vc/intel/fsp/mtl: Update header files from 2364_00 to 2404_00
by Kapil Porwal (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Vikrant Jadeja, Tarun Tuli, Jamie Ryu, Subrata Banik, Ravishankar Sarawadi, Sridhar Siricilla. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69182 ) Change subject: vc/intel/fsp/mtl: Update header files from 2364_00 to 2404_00 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63ef4ecb6569141542a3b9bf4ee8cbcd2946582e Gerrit-Change-Number: 69182 Gerrit-PatchSet: 4 Gerrit-Owner: Vikrant Jadeja Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Vikrant Jadeja Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 07:53:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Implement report_cache_info() function
by Kapil Porwal (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69681 ) Change subject: soc/intel/meteorlake: Implement report_cache_info() function ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I561658c8da0136d6c3d9578f22f5d320e542457d Gerrit-Change-Number: 69681 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 07:50:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Use index 0x10 instead of 0 for IOE P2SB
by Kapil Porwal (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Ivy Jian. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69041 ) Change subject: soc/intel/meteorlake: Use index 0x10 instead of 0 for IOE P2SB ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44caac73e245f536f3a22baafa1a6a0370e1dd37 Gerrit-Change-Number: 69041 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 07:49:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: soc/mediatek/mt8188: Update SSPM firmware from v1.88.00 to v1.88.01
by Yu-Ping Wu (Code Review) 15 Nov '22

15 Nov '22

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/blobs/+/69562 ) Change subject: soc/mediatek/mt8188: Update SSPM firmware from v1.88.00 to v1.88.01 ...................................................................... soc/mediatek/mt8188: Update SSPM firmware from v1.88.00 to v1.88.01 The last_emi is unsupported in ChromeOS project, so EMI driver would get a NULL address because no memory is reserved for last_emi. Add error checking for last_emi to avoid null pointer issue. BUG=b:233720142 TEST=Test of suspend resume passes. Change-Id: I7ceb048fc8e393607cab5096e6be626b9e0de135 Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com> --- M soc/mediatek/mt8188/sspm.bin M soc/mediatek/mt8188/sspm.bin.md5 M soc/mediatek/mt8188/sspm_release_notes.txt 3 files changed, 20 insertions(+), 1 deletion(-) Approvals: Rex-BC Chen: Looks good to me, but someone else must approve Yidi Lin: Looks good to me, but someone else must approve Yu-Ping Wu: Verified; Looks good to me, approved diff --git a/soc/mediatek/mt8188/sspm.bin b/soc/mediatek/mt8188/sspm.bin index c08fa30..a5b8469 100644 --- a/soc/mediatek/mt8188/sspm.bin +++ b/soc/mediatek/mt8188/sspm.bin Binary files differ diff --git a/soc/mediatek/mt8188/sspm.bin.md5 b/soc/mediatek/mt8188/sspm.bin.md5 index 5970431..e4450c6 100644 --- a/soc/mediatek/mt8188/sspm.bin.md5 +++ b/soc/mediatek/mt8188/sspm.bin.md5 @@ -1 +1 @@ -94ffbfa7722185a133aea8d4c7f09386 *sspm.bin +e5b2c28a74bbb4bf93f8cb04a88a1a72 *sspm.bin diff --git a/soc/mediatek/mt8188/sspm_release_notes.txt b/soc/mediatek/mt8188/sspm_release_notes.txt index 2b99d07..6a59ab7 100644 --- a/soc/mediatek/mt8188/sspm_release_notes.txt +++ b/soc/mediatek/mt8188/sspm_release_notes.txt @@ -1,4 +1,6 @@ ** Build from MediaTek Internal ** +# 1.88.01 +1. Add error checking for last_emi to avoid null pointer issue. # 1.88.00 1. Add sspm.bin v1.88.00. -- To view, visit https://review.coreboot.org/c/blobs/+/69562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I7ceb048fc8e393607cab5096e6be626b9e0de135 Gerrit-Change-Number: 69562 Gerrit-PatchSet: 1 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Implement report_cache_info() function
by Dinesh Gehlot (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69681 ) Change subject: soc/intel/meteorlake: Implement report_cache_info() function ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69681/comment/97954cfd_aac8341e PS1, Line 11: > > Possible unwrapped commit description (prefer a maximum 72 chars per line) […] Ack https://review.coreboot.org/c/coreboot/+/69681/comment/aa5865d7_bcb4fd5d PS1, Line 12: Cache: Level 3: Associativity = 12 Partitions = 1 Line Size = 64 Sets = 32768 > Please follow the comment style from https://review.coreboot.org/c/coreboot/+/69680/1//COMMIT_MSG […] Ack https://review.coreboot.org/c/coreboot/+/69681/comment/a9c28f13_1c0262b4 PS1, Line 16: > signoff is missing Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/69681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I561658c8da0136d6c3d9578f22f5d320e542457d Gerrit-Change-Number: 69681 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 07:47:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: soc/mediatek/mt8188: Update SSPM firmware from v1.88.00 to v1.88.01
by Rex-BC Chen (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Liju-Clr Chen. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/69562 ) Change subject: soc/mediatek/mt8188: Update SSPM firmware from v1.88.00 to v1.88.01 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @yuping, could you help to merge this patch? thanks -- To view, visit https://review.coreboot.org/c/blobs/+/69562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I7ceb048fc8e393607cab5096e6be626b9e0de135 Gerrit-Change-Number: 69562 Gerrit-PatchSet: 1 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 07:46:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Implement report_cache_info() function
by Dinesh Gehlot (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Kapil Porwal. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69681 to look at the new patch set (#2). Change subject: soc/intel/meteorlake: Implement report_cache_info() function ...................................................................... soc/intel/meteorlake: Implement report_cache_info() function Make use of deterministic cache helper functions from Meteor Lake SoC code to print useful information during boot as below: Cache: Level 3: Associativity = 12 Partitions = 1 Line Size = 64 Sets = 32768 Cache size = 24 MiB Port of commit 55f5410fcd78 ("soc/intel/alderlake: Implement report_cache_info() function") BUG=none TEST=Build and Boot verified on google/rex Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I561658c8da0136d6c3d9578f22f5d320e542457d --- M src/soc/intel/meteorlake/bootblock/report_platform.c 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/69681/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I561658c8da0136d6c3d9578f22f5d320e542457d Gerrit-Change-Number: 69681 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Use index 0x10 instead of 0 for IOE P2SB
by Eric Lai (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69041 ) Change subject: soc/intel/meteorlake: Use index 0x10 instead of 0 for IOE P2SB ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44caac73e245f536f3a22baafa1a6a0370e1dd37 Gerrit-Change-Number: 69041 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 07:38:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Use index 0x10 instead of 0 for IOE P2SB
by Subrata Banik (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69041 ) Change subject: soc/intel/meteorlake: Use index 0x10 instead of 0 for IOE P2SB ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Ping! -- To view, visit https://review.coreboot.org/c/coreboot/+/69041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44caac73e245f536f3a22baafa1a6a0370e1dd37 Gerrit-Change-Number: 69041 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 07:35:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Skip setting D0I3 bit for HECI devices
by Subrata Banik (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli, Kapil Porwal, Sridhar Siricilla. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69680 ) Change subject: soc/intel/meteorlake: Skip setting D0I3 bit for HECI devices ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69680/comment/b294929a_0e9bca60 PS1, Line 9: This patch skips setting D0I3 bit for all HECI devices by FSP. > Can you please add reason for it? @Sridhar, this is the backporting of the ADL CL, please take a look into the original CL for the reasoning. TL;DR: This is to ensure FSP can skip setting D0i3 bit for CSE and coreboot is able to sent EOP and put the HECI devices into the D0i3. -- To view, visit https://review.coreboot.org/c/coreboot/+/69680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c3765ce41f192ab5f5ff176e0a2b49b312d18d2 Gerrit-Change-Number: 69680 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 07:30:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022