coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: libpayload: Fix compiler warning
by Thomas Heijligen (Code Review) 17 Nov '22

17 Nov '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69764 ) Change subject: libpayload: Fix compiler warning ...................................................................... libpayload: Fix compiler warning drivers/serial/8250.c:75: [-Werror=unused-variable] Move variable declaration inside the `#if !CONFIG(LP_PL011_SERIAL_CONSOLE)` block drivers/udc/dwc2.c:505: [-Werror=format=] use `%zd` to match type `size_t` Change-Id: Id285c24cba790f181fa203f3117e5df35bed27c4 Signed-off-by: Thomas Heijligen <src(a)posteo.de> --- M payloads/libpayload/drivers/serial/8250.c M payloads/libpayload/drivers/udc/dwc2.c 2 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/69764/1 diff --git a/payloads/libpayload/drivers/serial/8250.c b/payloads/libpayload/drivers/serial/8250.c index 1df34c4..f3d98a9 100644 --- a/payloads/libpayload/drivers/serial/8250.c +++ b/payloads/libpayload/drivers/serial/8250.c @@ -72,9 +72,9 @@ static void serial_hardware_init(int speed, int word_bits, int parity, int stop_bits) { +#if !CONFIG(LP_PL011_SERIAL_CONSOLE) unsigned char reg; -#if !CONFIG(LP_PL011_SERIAL_CONSOLE) /* Disable interrupts. */ serial_write_reg(0, 0x01); diff --git a/payloads/libpayload/drivers/udc/dwc2.c b/payloads/libpayload/drivers/udc/dwc2.c index 6541308..6c72fba 100644 --- a/payloads/libpayload/drivers/udc/dwc2.c +++ b/payloads/libpayload/drivers/udc/dwc2.c @@ -502,7 +502,7 @@ } SIMPLEQ_REMOVE_HEAD(&p->eps[endpoint][in_dir].job_queue, queue); - usb_debug("%d-%d: scheduled %zd, now %d bytes\n", endpoint, in_dir, + usb_debug("%d-%d: scheduled %zd, now %zd bytes\n", endpoint, in_dir, job->length, job->xfered_length); if (this->current_config && -- To view, visit https://review.coreboot.org/c/coreboot/+/69764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id285c24cba790f181fa203f3117e5df35bed27c4 Gerrit-Change-Number: 69764 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Remove EC_HOST_EVENT_USB_CHARGER
by Jon Murphy (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Tarun Tuli, Jason Nien, Caveh Jalali, Kapil Porwal, Nick Vaccaro, Martin Roth, Boris Mittelberg. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69374 ) Change subject: ec/google/chromeec: Remove EC_HOST_EVENT_USB_CHARGER ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e3e0e9b45385766343489ae2d8fc43fb0954923 Gerrit-Change-Number: 69374 Gerrit-PatchSet: 4 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:23:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Remove EC_HOST_EVENT_USB_CHARGER
by Stefan Reinauer (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Tarun Tuli, Jason Nien, Caveh Jalali, Kapil Porwal, Nick Vaccaro, Martin Roth, Boris Mittelberg. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69374 ) Change subject: ec/google/chromeec: Remove EC_HOST_EVENT_USB_CHARGER ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e3e0e9b45385766343489ae2d8fc43fb0954923 Gerrit-Change-Number: 69374 Gerrit-PatchSet: 4 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:21:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented
by Martin Roth (Code Review) 17 Nov '22

17 Nov '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69513 ) Change subject: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented ...................................................................... {ec/superio}/acpi: Remove _PRS if no _SRS is implemented _PRS only makes sense if _SRS is implemented. Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69513 Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> --- M src/ec/google/wilco/acpi/ec_dev.asl M src/ec/google/wilco/acpi/superio.asl M src/ec/quanta/ene_kb3940q/acpi/superio.asl M src/ec/quanta/it8518/acpi/superio.asl M src/superio/ite/it8772f/acpi/superio.asl M src/superio/smsc/sio1007/acpi/superio.asl 6 files changed, 16 insertions(+), 161 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Martin Roth: Looks good to me, approved diff --git a/src/ec/google/wilco/acpi/ec_dev.asl b/src/ec/google/wilco/acpi/ec_dev.asl index 9ac3cfc..4b8ae30 100644 --- a/src/ec/google/wilco/acpi/ec_dev.asl +++ b/src/ec/google/wilco/acpi/ec_dev.asl @@ -29,25 +29,6 @@ CONFIG_EC_BASE_PACKET, 16, 16) }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, - CONFIG_EC_BASE_HOST_DATA, - CONFIG_EC_BASE_HOST_DATA, - 4, 4) - IO (Decode16, - CONFIG_EC_BASE_HOST_COMMAND, - CONFIG_EC_BASE_HOST_COMMAND, - 4, 4) - IO (Decode16, - CONFIG_EC_BASE_PACKET, - CONFIG_EC_BASE_PACKET, - 16, 16) - } - EndDependentFn () - }) } Device (WEVT) diff --git a/src/ec/google/wilco/acpi/superio.asl b/src/ec/google/wilco/acpi/superio.asl index b2737c3..3cec006 100644 --- a/src/ec/google/wilco/acpi/superio.asl +++ b/src/ec/google/wilco/acpi/superio.asl @@ -26,15 +26,6 @@ IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) - IRQNoFlags () {4} - } - EndDependentFn () - }) } } @@ -61,16 +52,6 @@ IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQ (Edge, ActiveHigh, Exclusive) {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQ (Edge, ActiveHigh, Exclusive) {1} - } - EndDependentFn () - }) } Device (PS2M) @@ -91,13 +72,5 @@ { IRQ (Edge, ActiveHigh, Exclusive) {12} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IRQ (Edge, ActiveHigh, Exclusive) {12} - } - EndDependentFn () - }) } } diff --git a/src/ec/quanta/ene_kb3940q/acpi/superio.asl b/src/ec/quanta/ene_kb3940q/acpi/superio.asl index 008f573f..b5962f0 100644 --- a/src/ec/quanta/ene_kb3940q/acpi/superio.asl +++ b/src/ec/quanta/ene_kb3940q/acpi/superio.asl @@ -24,16 +24,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {1} - } - EndDependentFn () - }) } #endif } diff --git a/src/ec/quanta/it8518/acpi/superio.asl b/src/ec/quanta/it8518/acpi/superio.asl index 9cdf265..b91324d 100644 --- a/src/ec/quanta/it8518/acpi/superio.asl +++ b/src/ec/quanta/it8518/acpi/superio.asl @@ -25,17 +25,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) - { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {1} - } - EndDependentFn () - }) } #endif @@ -55,17 +44,6 @@ FixedIO (0x64, 0x01) IRQNoFlags () {12} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) - { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {12} - } - EndDependentFn () - }) } #endif diff --git a/src/superio/ite/it8772f/acpi/superio.asl b/src/superio/ite/it8772f/acpi/superio.asl index 5132df0..809d0fc 100644 --- a/src/superio/ite/it8772f/acpi/superio.asl +++ b/src/superio/ite/it8772f/acpi/superio.asl @@ -108,12 +108,6 @@ IO (Decode16, SIO_ENVC_IO1, SIO_ENVC_IO1, 0x04, 0x04) }) - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_ENVC_IO0, SIO_ENVC_IO0, 0x08, 0x08) - IO (Decode16, SIO_ENVC_IO1, SIO_ENVC_IO1, 0x04, 0x04) - }) - OperationRegion (ECAP, SystemIO, SIO_ENVC_IO0, 0x07) Field (ECAP, ByteAcc, NoLock, Preserve) { @@ -151,12 +145,6 @@ IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) - IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) - }) } #endif @@ -175,11 +163,6 @@ IRQNoFlags () {4} }) - Name (_PRS, ResourceTemplate () - { - IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) - IRQNoFlags () {4} - }) } #endif @@ -200,12 +183,6 @@ IRQNoFlags () {1} }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif @@ -223,10 +200,6 @@ IRQNoFlags () {12} }) - Name (_PRS, ResourceTemplate() - { - IRQNoFlags () {12} - }) } #endif @@ -247,13 +220,6 @@ DMA (Compatibility, NotBusMaster, Transfer8) {2} }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) } #endif @@ -272,11 +238,6 @@ IRQNoFlags () { SIO_INFR_IRQ } }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) - IRQNoFlags () { SIO_INFR_IRQ } - }) } #endif } diff --git a/src/superio/smsc/sio1007/acpi/superio.asl b/src/superio/smsc/sio1007/acpi/superio.asl index 5132df0..35d9ba1 100644 --- a/src/superio/smsc/sio1007/acpi/superio.asl +++ b/src/superio/smsc/sio1007/acpi/superio.asl @@ -108,12 +108,6 @@ IO (Decode16, SIO_ENVC_IO1, SIO_ENVC_IO1, 0x04, 0x04) }) - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_ENVC_IO0, SIO_ENVC_IO0, 0x08, 0x08) - IO (Decode16, SIO_ENVC_IO1, SIO_ENVC_IO1, 0x04, 0x04) - }) - OperationRegion (ECAP, SystemIO, SIO_ENVC_IO0, 0x07) Field (ECAP, ByteAcc, NoLock, Preserve) { @@ -151,12 +145,6 @@ IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) - IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) - }) } #endif @@ -174,12 +162,6 @@ IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) - IRQNoFlags () {4} - }) } #endif @@ -199,13 +181,6 @@ IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif @@ -222,11 +197,6 @@ { IRQNoFlags () {12} }) - - Name (_PRS, ResourceTemplate() - { - IRQNoFlags () {12} - }) } #endif @@ -246,14 +216,6 @@ IRQNoFlags () {6} DMA (Compatibility, NotBusMaster, Transfer8) {2} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) } #endif @@ -271,12 +233,6 @@ IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) IRQNoFlags () { SIO_INFR_IRQ } }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) - IRQNoFlags () { SIO_INFR_IRQ } - }) } #endif } -- To view, visit https://review.coreboot.org/c/coreboot/+/69513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Gerrit-Change-Number: 69513 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented
by Martin Roth (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Caveh Jalali, Arthur Heymans, Elyes Haouas, Boris Mittelberg, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69513 ) Change subject: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Gerrit-Change-Number: 69513 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:20:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: superio/acpi/pnp_generic.asl: Add _PRS for each device
by Martin Roth (Code Review) 17 Nov '22

17 Nov '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/64218 ) Change subject: superio/acpi/pnp_generic.asl: Add _PRS for each device ...................................................................... superio/acpi/pnp_generic.asl: Add _PRS for each device Simply return the current resource settings in the _PRS method. This means that coreboot has to correctly set up the resources on the device. This won't result in any regression as without _PRS the ACPI OS would not know what resources settings are valid, so it would never use _SRS. Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/64218 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> --- M src/superio/acpi/pnp_generic.asl 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Elyes Haouas: Looks good to me, approved Martin Roth: Looks good to me, approved diff --git a/src/superio/acpi/pnp_generic.asl b/src/superio/acpi/pnp_generic.asl index d0d9a2d..2bcc139 100644 --- a/src/superio/acpi/pnp_generic.asl +++ b/src/superio/acpi/pnp_generic.asl @@ -171,4 +171,12 @@ Store (One, PNP_DEVICE_ACTIVE) EXIT_CONFIG_MODE () } + + /* This is used for _SRS. Since _DIS only disables the device + * without changing the resources this works. + */ + Method (_PRS, 0) + { + return (_CRS) + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/64218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Gerrit-Change-Number: 64218 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: superio/acpi/pnp_generic.asl: Add _PRS for each device
by Martin Roth (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Martin L Roth, Tristan Corrick, Angel Pons, Arthur Heymans, Elyes Haouas, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64218 ) Change subject: superio/acpi/pnp_generic.asl: Add _PRS for each device ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/64218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Gerrit-Change-Number: 64218 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:19:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: arch/x86/smbios: Add SMBIOS Type 39
by Martin Roth (Code Review) 17 Nov '22

17 Nov '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68443 ) Change subject: arch/x86/smbios: Add SMBIOS Type 39 ...................................................................... arch/x86/smbios: Add SMBIOS Type 39 Read FRU product info of PSU to get Type 39 required information. Further development needed if multi-record info of PSU FRU is required. For now, the read_fru_areas() only read product chassis and board info. Signed-off-by: lichenchen.carl <lichenchen.carl(a)bytedance.com> Signed-off-by: ziang <ziang.wang(a)intel.com> Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com> Change-Id: I18d056cba1a79b0775c8a42b3a879e819887adca Reviewed-on: https://review.coreboot.org/c/coreboot/+/68443 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Shuming Chu (Shuming) <s1218944(a)gmail.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Christian Walter <christian.walter(a)9elements.com> --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 135 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve Christian Walter: Looks good to me, approved Shuming Chu (Shuming): Looks good to me, but someone else must approve diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 24b18f2..5b8df5bc 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -1116,6 +1116,55 @@ return len; } +int smbios_write_type39(unsigned long *current, int *handle, + u8 unit_group, const char *loc, const char *dev_name, + const char *man, const char *serial_num, + const char *tag_num, const char *part_num, + const char *rev_lvl, u16 max_pow_cap, + const struct power_supply_ch *ps_ch) +{ + struct smbios_type39 *t = smbios_carve_table(*current, + SMBIOS_SYSTEM_POWER_SUPPLY, + sizeof(*t), *handle); + + uint16_t val = 0; + uint16_t ps_type, ps_status, vol_switch, ps_unplug, ps_present, hot_rep; + + t->power_unit_group = unit_group; + t->location = smbios_add_string(t->eos, loc); + t->device_name = smbios_add_string(t->eos, dev_name); + t->manufacturer = smbios_add_string(t->eos, man); + t->serial_number = smbios_add_string(t->eos, serial_num); + t->asset_tag_number = smbios_add_string(t->eos, tag_num); + t->model_part_number = smbios_add_string(t->eos, part_num); + t->revision_level = smbios_add_string(t->eos, rev_lvl); + t->max_power_capacity = max_pow_cap; + + ps_type = ps_ch->power_supply_type & 0xF; + ps_status = ps_ch->power_supply_status & 0x7; + vol_switch = ps_ch->input_voltage_range_switch & 0xF; + ps_unplug = ps_ch->power_supply_unplugged & 0x1; + ps_present = ps_ch->power_supply_present & 0x1; + hot_rep = ps_ch->power_supply_hot_replaceble & 0x1; + + val |= (ps_type << 10); + val |= (ps_status << 7); + val |= (vol_switch << 3); + val |= (ps_unplug << 2); + val |= (ps_present << 1); + val |= hot_rep; + t->power_supply_characteristics = val; + + t->input_voltage_probe_handle = 0xFFFF; + t->cooling_device_handle = 0xFFFF; + t->input_current_probe_handle = 0xFFFF; + + const int len = smbios_full_table_len(&t->header, t->eos); + *current += len; + *handle += 1; + return len; +} + int smbios_write_type41(unsigned long *current, int *handle, const char *name, u8 instance, u16 segment, u8 bus, u8 device, u8 function, u8 device_type) diff --git a/src/include/smbios.h b/src/include/smbios.h index cb317b0..9217f5e 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -270,6 +270,7 @@ SMBIOS_TEMPERATURE_PROBE = 28, SMBIOS_SYSTEM_BOOT_INFORMATION = 32, SMBIOS_IPMI_DEVICE_INFORMATION = 38, + SMBIOS_SYSTEM_POWER_SUPPLY = 39, SMBIOS_ONBOARD_DEVICES_EXTENDED_INFORMATION = 41, SMBIOS_TPM_DEVICE = 43, SMBIOS_END_OF_TABLE = 127, @@ -1013,6 +1014,69 @@ }; typedef enum { + PowerSupplyTypeOther = 1, + PowerSupplyTypeUnknown = 2, + PowerSupplyTypeLinear = 3, + PowerSupplyTypeSwitching = 4, + PowerSupplyTypeBattery = 5, + PowerSupplyTypeUps = 6, + PowerSupplyTypeConverter = 7, + PowerSupplyTypeRegulator = 8 +} power_supply_type; + +typedef enum { + PowerSupplyStatusOther = 1, + PowerSupplyStatusUnknown = 2, + PowerSupplyStatusOk = 3, + PowerSupplyStatusNonCritical = 4, + PowerSupplyStatusCritical = 5 +} power_supply_status; + +typedef enum { + PowerSupplyInputVoltageRangeSwitchingOther = 1, + PowerSupplyInputVoltageRangeSwitchingUnknown = 2, + PowerSupplyInputVoltageRangeSwitchingManual = 3, + PowerSupplyInputVoltageRangeSwitchingAutoSwitch = 4, + PowerSupplyInputVoltageRangeSwitchingWideRange = 5, + PowerSupplyInputVoltageRangeSwitchingNotApplicable = 6 +} power_supply_input_voltage_range_switching; + +struct power_supply_ch { + u16 reserved :2; + u16 power_supply_type :4; + u16 power_supply_status :3; + u16 input_voltage_range_switch :4; + u16 power_supply_unplugged :1; + u16 power_supply_present :1; + u16 power_supply_hot_replaceble :1; +}; + +struct smbios_type39 { + struct smbios_header header; + u8 power_unit_group; + u8 location; + u8 device_name; + u8 manufacturer; + u8 serial_number; + u8 asset_tag_number; + u8 model_part_number; + u8 revision_level; + u16 max_power_capacity; + u16 power_supply_characteristics; + u16 input_voltage_probe_handle; + u16 cooling_device_handle; + u16 input_current_probe_handle; + u8 eos[2]; +} __packed; + +int smbios_write_type39(unsigned long *current, int *handle, + u8 unit_group, const char *loc, const char *dev_name, + const char *man, const char *serial_num, + const char *tag_num, const char *part_num, + const char *rev_lvl, u16 max_pow_cap, + const struct power_supply_ch *ps_ch); + +typedef enum { SMBIOS_DEVICE_TYPE_OTHER = 0x01, SMBIOS_DEVICE_TYPE_UNKNOWN, SMBIOS_DEVICE_TYPE_VIDEO, -- To view, visit https://review.coreboot.org/c/coreboot/+/68443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18d056cba1a79b0775c8a42b3a879e819887adca Gerrit-Change-Number: 68443 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: util/kconfig: Add patch to move Kconfig deps to build/config
by Fred Reitberger (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Martin L Roth, Elyes Haouas. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69535 ) Change subject: util/kconfig: Add patch to move Kconfig deps to build/config ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4b48831705c3206e7c2e09f01d072d1cde9c9c4 Gerrit-Change-Number: 69535 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:07:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/kconfig: Move Kconfig deps back into build/config
by Fred Reitberger (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Martin L Roth, Patrick Georgi. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69536 ) Change subject: util/kconfig: Move Kconfig deps back into build/config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69536 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2904f69a5d85337ad0a6b48590ccd4b4a6e38b70 Gerrit-Change-Number: 69536 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:05:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022