coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[XL] Change in coreboot[master]: [WIP]zstd support
by Arthur Heymans (Code Review) 18 Nov '22

18 Nov '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69753 ) Change subject: [WIP]zstd support ...................................................................... [WIP]zstd support This works and is able to load files in ramstage and in the payload. However it is much slower than LZMA. 500+ms vs ~30ms to load a payload. It also consume a big stack. Using a predefined context did not work for now... TODO: move zstd to commonlib and use from both cbfstool and coreboot. Change-Id: I34508268f8767008ef25cb9e466d201345881232 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile.inc M src/Kconfig M src/commonlib/Makefile.inc M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h A src/commonlib/zstd-1.5.2/lib/.gitignore A src/commonlib/zstd-1.5.2/lib/BUCK A src/commonlib/zstd-1.5.2/lib/Makefile A src/commonlib/zstd-1.5.2/lib/README.md A src/commonlib/zstd-1.5.2/lib/common/bitstream.h A src/commonlib/zstd-1.5.2/lib/common/compiler.h A src/commonlib/zstd-1.5.2/lib/common/cpu.h A src/commonlib/zstd-1.5.2/lib/common/debug.c A src/commonlib/zstd-1.5.2/lib/common/debug.h A src/commonlib/zstd-1.5.2/lib/common/entropy_common.c A src/commonlib/zstd-1.5.2/lib/common/error_private.c A src/commonlib/zstd-1.5.2/lib/common/error_private.h A src/commonlib/zstd-1.5.2/lib/common/fse.h A src/commonlib/zstd-1.5.2/lib/common/fse_decompress.c A src/commonlib/zstd-1.5.2/lib/common/huf.h A src/commonlib/zstd-1.5.2/lib/common/mem.h A src/commonlib/zstd-1.5.2/lib/common/pool.c A src/commonlib/zstd-1.5.2/lib/common/pool.h A src/commonlib/zstd-1.5.2/lib/common/portability_macros.h A src/commonlib/zstd-1.5.2/lib/common/threading.c A src/commonlib/zstd-1.5.2/lib/common/threading.h A src/commonlib/zstd-1.5.2/lib/common/xxhash.c A src/commonlib/zstd-1.5.2/lib/common/xxhash.h A src/commonlib/zstd-1.5.2/lib/common/xxhash_zstd.c A src/commonlib/zstd-1.5.2/lib/common/zstd_common.c A src/commonlib/zstd-1.5.2/lib/common/zstd_deps.h A src/commonlib/zstd-1.5.2/lib/common/zstd_internal.h A src/commonlib/zstd-1.5.2/lib/common/zstd_trace.h A src/commonlib/zstd-1.5.2/lib/compress/clevels.h A src/commonlib/zstd-1.5.2/lib/compress/fse_compress.c A src/commonlib/zstd-1.5.2/lib/compress/hist.c A src/commonlib/zstd-1.5.2/lib/compress/hist.h A src/commonlib/zstd-1.5.2/lib/compress/huf_compress.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_compress.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_compress_internal.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_compress_literals.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_compress_literals.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_compress_sequences.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_compress_sequences.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_compress_superblock.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_compress_superblock.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_cwksp.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_double_fast.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_double_fast.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_fast.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_fast.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_lazy.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_lazy.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_ldm.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_ldm.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_ldm_geartab.h A src/commonlib/zstd-1.5.2/lib/compress/zstd_opt.c A src/commonlib/zstd-1.5.2/lib/compress/zstd_opt.h A src/commonlib/zstd-1.5.2/lib/compress/zstdmt_compress.c A src/commonlib/zstd-1.5.2/lib/compress/zstdmt_compress.h A src/commonlib/zstd-1.5.2/lib/decompress/huf_decompress.c A src/commonlib/zstd-1.5.2/lib/decompress/huf_decompress_amd64.S A src/commonlib/zstd-1.5.2/lib/decompress/zstd_ddict.c A src/commonlib/zstd-1.5.2/lib/decompress/zstd_ddict.h A src/commonlib/zstd-1.5.2/lib/decompress/zstd_decompress.c A src/commonlib/zstd-1.5.2/lib/decompress/zstd_decompress_block.c A src/commonlib/zstd-1.5.2/lib/decompress/zstd_decompress_block.h A src/commonlib/zstd-1.5.2/lib/decompress/zstd_decompress_internal.h A src/commonlib/zstd-1.5.2/lib/deprecated/zbuff.h A src/commonlib/zstd-1.5.2/lib/deprecated/zbuff_common.c A src/commonlib/zstd-1.5.2/lib/deprecated/zbuff_compress.c A src/commonlib/zstd-1.5.2/lib/deprecated/zbuff_decompress.c A src/commonlib/zstd-1.5.2/lib/dictBuilder/cover.c A src/commonlib/zstd-1.5.2/lib/dictBuilder/cover.h A src/commonlib/zstd-1.5.2/lib/dictBuilder/divsufsort.c A src/commonlib/zstd-1.5.2/lib/dictBuilder/divsufsort.h A src/commonlib/zstd-1.5.2/lib/dictBuilder/fastcover.c A src/commonlib/zstd-1.5.2/lib/dictBuilder/zdict.c A src/commonlib/zstd-1.5.2/lib/dll/example/Makefile A src/commonlib/zstd-1.5.2/lib/dll/example/README.md A src/commonlib/zstd-1.5.2/lib/dll/example/build_package.bat A src/commonlib/zstd-1.5.2/lib/dll/example/fullbench-dll.sln A src/commonlib/zstd-1.5.2/lib/dll/example/fullbench-dll.vcxproj A src/commonlib/zstd-1.5.2/lib/legacy/zstd_legacy.h A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v01.c A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v01.h A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v02.c A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v02.h A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v03.c A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v03.h A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v04.c A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v04.h A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v05.c A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v05.h A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v06.c A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v06.h A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v07.c A src/commonlib/zstd-1.5.2/lib/legacy/zstd_v07.h A src/commonlib/zstd-1.5.2/lib/libzstd.mk A src/commonlib/zstd-1.5.2/lib/libzstd.pc.in A src/commonlib/zstd-1.5.2/lib/module.modulemap A src/commonlib/zstd-1.5.2/lib/zdict.h A src/commonlib/zstd-1.5.2/lib/zstd.h A src/commonlib/zstd-1.5.2/lib/zstd_errors.h M src/lib/cbfs.c M src/lib/selfboot.c M util/cbfstool/Makefile.inc M util/cbfstool/cbfs.h M util/cbfstool/compress.c A util/cbfstool/zstd-1.5.2/lib/.gitignore A util/cbfstool/zstd-1.5.2/lib/BUCK A util/cbfstool/zstd-1.5.2/lib/Makefile A util/cbfstool/zstd-1.5.2/lib/README.md A util/cbfstool/zstd-1.5.2/lib/common/bitstream.h A util/cbfstool/zstd-1.5.2/lib/common/compiler.h A util/cbfstool/zstd-1.5.2/lib/common/cpu.h A util/cbfstool/zstd-1.5.2/lib/common/debug.c A util/cbfstool/zstd-1.5.2/lib/common/debug.h A util/cbfstool/zstd-1.5.2/lib/common/entropy_common.c A util/cbfstool/zstd-1.5.2/lib/common/error_private.c A util/cbfstool/zstd-1.5.2/lib/common/error_private.h A util/cbfstool/zstd-1.5.2/lib/common/fse.h A util/cbfstool/zstd-1.5.2/lib/common/fse_decompress.c A util/cbfstool/zstd-1.5.2/lib/common/huf.h A util/cbfstool/zstd-1.5.2/lib/common/mem.h A util/cbfstool/zstd-1.5.2/lib/common/pool.c A util/cbfstool/zstd-1.5.2/lib/common/pool.h A util/cbfstool/zstd-1.5.2/lib/common/portability_macros.h A util/cbfstool/zstd-1.5.2/lib/common/threading.c A util/cbfstool/zstd-1.5.2/lib/common/threading.h A util/cbfstool/zstd-1.5.2/lib/common/xxhash.h A util/cbfstool/zstd-1.5.2/lib/common/xxhash_zstd.c A util/cbfstool/zstd-1.5.2/lib/common/zstd_common.c A util/cbfstool/zstd-1.5.2/lib/common/zstd_deps.h A util/cbfstool/zstd-1.5.2/lib/common/zstd_internal.h A util/cbfstool/zstd-1.5.2/lib/common/zstd_trace.h A util/cbfstool/zstd-1.5.2/lib/compress/clevels.h A util/cbfstool/zstd-1.5.2/lib/compress/fse_compress.c A util/cbfstool/zstd-1.5.2/lib/compress/hist.c A util/cbfstool/zstd-1.5.2/lib/compress/hist.h A util/cbfstool/zstd-1.5.2/lib/compress/huf_compress.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_compress.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_compress_internal.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_compress_literals.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_compress_literals.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_compress_sequences.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_compress_sequences.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_compress_superblock.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_compress_superblock.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_cwksp.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_double_fast.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_double_fast.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_fast.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_fast.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_lazy.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_lazy.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_ldm.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_ldm.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_ldm_geartab.h A util/cbfstool/zstd-1.5.2/lib/compress/zstd_opt.c A util/cbfstool/zstd-1.5.2/lib/compress/zstd_opt.h A util/cbfstool/zstd-1.5.2/lib/compress/zstdmt_compress.c A util/cbfstool/zstd-1.5.2/lib/compress/zstdmt_compress.h A util/cbfstool/zstd-1.5.2/lib/decompress/huf_decompress.c A util/cbfstool/zstd-1.5.2/lib/decompress/huf_decompress_amd64.S A util/cbfstool/zstd-1.5.2/lib/decompress/zstd_ddict.c A util/cbfstool/zstd-1.5.2/lib/decompress/zstd_ddict.h A util/cbfstool/zstd-1.5.2/lib/decompress/zstd_decompress.c A util/cbfstool/zstd-1.5.2/lib/decompress/zstd_decompress_block.c A util/cbfstool/zstd-1.5.2/lib/decompress/zstd_decompress_block.h A util/cbfstool/zstd-1.5.2/lib/decompress/zstd_decompress_internal.h A util/cbfstool/zstd-1.5.2/lib/deprecated/zbuff.h A util/cbfstool/zstd-1.5.2/lib/deprecated/zbuff_common.c A util/cbfstool/zstd-1.5.2/lib/deprecated/zbuff_compress.c A util/cbfstool/zstd-1.5.2/lib/deprecated/zbuff_decompress.c A util/cbfstool/zstd-1.5.2/lib/dictBuilder/cover.c A util/cbfstool/zstd-1.5.2/lib/dictBuilder/cover.h A util/cbfstool/zstd-1.5.2/lib/dictBuilder/divsufsort.c A util/cbfstool/zstd-1.5.2/lib/dictBuilder/divsufsort.h A util/cbfstool/zstd-1.5.2/lib/dictBuilder/fastcover.c A util/cbfstool/zstd-1.5.2/lib/dictBuilder/zdict.c A util/cbfstool/zstd-1.5.2/lib/dll/example/Makefile A util/cbfstool/zstd-1.5.2/lib/dll/example/README.md A util/cbfstool/zstd-1.5.2/lib/dll/example/build_package.bat A util/cbfstool/zstd-1.5.2/lib/dll/example/fullbench-dll.sln A util/cbfstool/zstd-1.5.2/lib/dll/example/fullbench-dll.vcxproj A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_legacy.h A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v01.c A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v01.h A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v02.c A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v02.h A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v03.c A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v03.h A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v04.c A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v04.h A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v05.c A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v05.h A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v06.c A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v06.h A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v07.c A util/cbfstool/zstd-1.5.2/lib/legacy/zstd_v07.h A util/cbfstool/zstd-1.5.2/lib/libzstd.mk A util/cbfstool/zstd-1.5.2/lib/libzstd.pc.in A util/cbfstool/zstd-1.5.2/lib/module.modulemap A util/cbfstool/zstd-1.5.2/lib/zdict.h A util/cbfstool/zstd-1.5.2/lib/zstd.h A util/cbfstool/zstd-1.5.2/lib/zstd_errors.h 206 files changed, 151,650 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/69753/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34508268f8767008ef25cb9e466d201345881232 Gerrit-Change-Number: 69753 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/amd: Use ioapic helper functions
by Felix Held (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Kyösti Mälkki, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55571 ) Change subject: soc/amd: Use ioapic helper functions ...................................................................... Patch Set 11: Code-Review+2 (1 comment) Patchset: PS1: > i'll try to run a test today ran a test a few days ago, but looks like i forgot to mark this as done -- To view, visit https://review.coreboot.org/c/coreboot/+/55571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdacc61b72f461ec6bea334fa06651c09a9695d6 Gerrit-Change-Number: 55571 Gerrit-PatchSet: 11 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 23:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craask: Disable gpio export in crs for G2 touchsc...
by Reka Norman (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Tarun Tuli, Kangheui Won, Tyler Wang, Nick Vaccaro. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69749 ) Change subject: mb/google/nissa/var/craask: Disable gpio export in crs for G2 touchscreen ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21a47adde48555098d041b94d483cad308bdb717 Gerrit-Change-Number: 69749 Gerrit-PatchSet: 2 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 23:05:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Enable STB Spill-to-DRAM by default
by Karthik Ramasubramanian (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Martin L Roth, Jason Nien, Martin Roth, Tim Van Patten. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69707 ) Change subject: mb/google/skyrim: Enable STB Spill-to-DRAM by default ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib60b7fc2ba85c7a8025c9f8c6495e94049499f56 Gerrit-Change-Number: 69707 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 22:04:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: [NOTFORMERGE] squashed intel pmutil ops
by build bot (Jenkins) (Code Review) 17 Nov '22

17 Nov '22

1 0

[XL] Change in coreboot[master]: [NOTFORMERGE] squashed intel pmutil ops
by Kyösti Mälkki (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Jeff Daly, Jonathan Zhang, Angel Pons, Arthur Heymans, Kyösti Mälkki, Tarun Tuli, Sean Rhodes, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Tim Chu. Hello build bot (Jenkins), Jeff Daly, Jonathan Zhang, Angel Pons, Arthur Heymans, Tarun Tuli, Sean Rhodes, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Tim Chu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69760 to look at the new patch set (#2). Change subject: [NOTFORMERGE] squashed intel pmutil ops ...................................................................... [NOTFORMERGE] squashed intel pmutil ops Change-Id: I6b4db32888a6a979eee0cbcdbace97bc188ae71b Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- A src/arch/x86/include/arch/io_bitops.h M src/mainboard/acer/aspire_vn7_572g/mainboard.c M src/mainboard/asus/p2b/variants/p3b-f/romstage.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/link/smihandler.c M src/mainboard/google/parrot/smihandler.c M src/mainboard/google/rambi/smihandler.c M src/mainboard/google/slippy/smihandler.c M src/mainboard/google/stout/ec.c M src/mainboard/google/stout/smihandler.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/samsung/lumpy/smihandler.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/ironlake/gma.c M src/northbridge/intel/ironlake/raminit.c M src/northbridge/intel/sandybridge/gma.c M src/security/intel/txt/romstage.c M src/soc/intel/alderlake/acpi.c M src/soc/intel/alderlake/include/soc/pm.h M src/soc/intel/alderlake/pmutil.c M src/soc/intel/apollolake/acpi.c M src/soc/intel/apollolake/include/soc/pm.h M src/soc/intel/apollolake/pmutil.c M src/soc/intel/baytrail/bootblock/bootblock.c M src/soc/intel/baytrail/fadt.c M src/soc/intel/baytrail/include/soc/pm.h M src/soc/intel/baytrail/pmutil.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/smihandler.c M src/soc/intel/baytrail/smm.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/fadt.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/include/soc/pm.h M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/pmutil.c M src/soc/intel/braswell/romstage/romstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/braswell/smm.c M src/soc/intel/broadwell/include/soc/pm.h M src/soc/intel/broadwell/pch/bootblock.c M src/soc/intel/broadwell/pch/lpc.c M src/soc/intel/broadwell/pch/pmutil.c M src/soc/intel/broadwell/pch/power_state.c M src/soc/intel/broadwell/pch/smi.c M src/soc/intel/broadwell/pch/smihandler.c M src/soc/intel/cannonlake/acpi.c M src/soc/intel/cannonlake/include/soc/pm.h M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/include/intelblocks/tco.h M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/common/block/smbus/tco.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/denverton_ns/include/soc/soc_util.h M src/soc/intel/denverton_ns/pmutil.c M src/soc/intel/denverton_ns/romstage.c M src/soc/intel/denverton_ns/smihandler.c M src/soc/intel/denverton_ns/smm.c M src/soc/intel/denverton_ns/soc_util.c M src/soc/intel/elkhartlake/acpi.c M src/soc/intel/elkhartlake/bootblock/bootblock.c M src/soc/intel/elkhartlake/include/soc/pm.h M src/soc/intel/elkhartlake/pmutil.c M src/soc/intel/icelake/acpi.c M src/soc/intel/icelake/include/soc/pm.h M src/soc/intel/icelake/pmutil.c M src/soc/intel/jasperlake/acpi.c M src/soc/intel/jasperlake/include/soc/pm.h M src/soc/intel/jasperlake/pmutil.c M src/soc/intel/meteorlake/acpi.c M src/soc/intel/meteorlake/include/soc/pm.h M src/soc/intel/meteorlake/pmutil.c M src/soc/intel/quark/acpi.c M src/soc/intel/quark/include/soc/pm.h M src/soc/intel/quark/reg_access.c M src/soc/intel/skylake/fadt.c M src/soc/intel/skylake/include/soc/pm.h M src/soc/intel/skylake/pmc.c M src/soc/intel/skylake/pmutil.c M src/soc/intel/tigerlake/acpi.c M src/soc/intel/tigerlake/include/soc/pm.h M src/soc/intel/tigerlake/pmutil.c M src/soc/intel/xeon_sp/include/soc/pm.h M src/soc/intel/xeon_sp/pmutil.c M src/soc/intel/xeon_sp/skx/soc_acpi.c M src/southbridge/intel/bd82x6x/early_pch.c M src/southbridge/intel/bd82x6x/early_usb.c M src/southbridge/intel/bd82x6x/elog.c M src/southbridge/intel/bd82x6x/fadt.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/bd82x6x/pch.h M src/southbridge/intel/common/finalize.c M src/southbridge/intel/common/pmbase.c M src/southbridge/intel/common/pmbase.h M src/southbridge/intel/common/pmclib.c M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smi.c M src/southbridge/intel/common/smihandler.c A src/southbridge/intel/common/tco.c M src/southbridge/intel/common/tco.h M src/southbridge/intel/common/watchdog.c M src/southbridge/intel/i82371eb/acpi/i82371eb.asl M src/southbridge/intel/i82371eb/fadt.c M src/southbridge/intel/i82371eb/i82371eb.h M src/southbridge/intel/i82371eb/smbus.c M src/southbridge/intel/i82371eb/wakeup.c M src/southbridge/intel/i82801dx/fadt.c M src/southbridge/intel/i82801dx/i82801dx.h M src/southbridge/intel/i82801dx/lpc.c M src/southbridge/intel/i82801gx/early_init.c M src/southbridge/intel/i82801gx/fadt.c M src/southbridge/intel/i82801gx/i82801gx.h M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/early_init.c M src/southbridge/intel/i82801ix/fadt.c M src/southbridge/intel/i82801ix/i82801ix.c M src/southbridge/intel/i82801ix/i82801ix.h M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/early_init.c M src/southbridge/intel/i82801jx/fadt.c M src/southbridge/intel/i82801jx/i82801jx.c M src/southbridge/intel/i82801jx/i82801jx.h M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/early_pch.c M src/southbridge/intel/ibexpeak/early_usb.c M src/southbridge/intel/ibexpeak/fadt.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/ibexpeak/pch.h M src/southbridge/intel/lynxpoint/early_pch.c M src/southbridge/intel/lynxpoint/elog.c M src/southbridge/intel/lynxpoint/lp_gpio.c M src/southbridge/intel/lynxpoint/lpc.c M src/southbridge/intel/lynxpoint/pch.c M src/southbridge/intel/lynxpoint/pch.h M src/southbridge/intel/lynxpoint/pmutil.c M src/southbridge/intel/lynxpoint/smi.c M src/southbridge/intel/lynxpoint/smihandler.c 142 files changed, 950 insertions(+), 1,144 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/69760/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b4db32888a6a979eee0cbcdbace97bc188ae71b Gerrit-Change-Number: 69760 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Enable STB Spill-to-DRAM by default
by Jon Murphy (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Martin L Roth, Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69707 ) Change subject: mb/google/skyrim: Enable STB Spill-to-DRAM by default ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib60b7fc2ba85c7a8025c9f8c6495e94049499f56 Gerrit-Change-Number: 69707 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:40:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/zork: Select VBOOT by default
by Matt DeVillier (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Jason Nien, Martin Roth. Hello Jason Nien, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69763 to look at the new patch set (#2). Change subject: mb/google/zork: Select VBOOT by default ...................................................................... mb/google/zork: Select VBOOT by default Zork boards will not boot without PSP verstage/VBOOT, so select it by default. Change-Id: I2447bf69baefd5560a0153dcd3d9b87b0a91a3f9 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/mainboard/google/zork/Kconfig 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/69763/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2447bf69baefd5560a0153dcd3d9b87b0a91a3f9 Gerrit-Change-Number: 69763 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/kconfig: Add patch to move Kconfig deps to build/config
by Elyes Haouas (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69535 ) Change subject: util/kconfig: Add patch to move Kconfig deps to build/config ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4b48831705c3206e7c2e09f01d072d1cde9c9c4 Gerrit-Change-Number: 69535 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:37:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/kconfig: Move Kconfig deps back into build/config
by Elyes Haouas (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Martin L Roth, Patrick Georgi. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69536 ) Change subject: util/kconfig: Move Kconfig deps back into build/config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69536 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2904f69a5d85337ad0a6b48590ccd4b4a6e38b70 Gerrit-Change-Number: 69536 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Nov 2022 21:37:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022