coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: vboot: Fix hash digest size, padding and comparison
by Jakub Czapiga (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Caveh Jalali, Yu-Ping Wu, Boris Mittelberg. Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69762 to look at the new patch set (#2). Change subject: vboot: Fix hash digest size, padding and comparison ...................................................................... vboot: Fix hash digest size, padding and comparison Make vboot_save_hash() pad too short data with zeros. Do the same when comparing hash at resume (eliminate possible prefix-only comparison). Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: If6d46e0b58dbca86af56221b7ff2606ab2d1799a --- M src/ec/google/chromeec/vboot_storage.c M src/security/vboot/vboot_logic.c 2 files changed, 25 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/69762/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6d46e0b58dbca86af56221b7ff2606ab2d1799a Gerrit-Change-Number: 69762 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: vboot/vboot_common: Fix vboot_save_data() code exclusion guard
by Jakub Czapiga (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Julius Werner, Yu-Ping Wu. Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69761 to look at the new patch set (#3). Change subject: vboot/vboot_common: Fix vboot_save_data() code exclusion guard ...................................................................... vboot/vboot_common: Fix vboot_save_data() code exclusion guard Compilers are not optimizing-out code correctly. This patch fixes incorrect behavior by splitting if statement and extracting code to another function, this allowing for better code size optimization and reduction of undefined references. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: Ia5330efeeb4cfd7477cf8f7f64c6abed68281e30 --- M src/security/vboot/vboot_common.c 1 file changed, 32 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/69761/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5330efeeb4cfd7477cf8f7f64c6abed68281e30 Gerrit-Change-Number: 69761 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade MPFR from 4.1.0 to 4.1.1
by Elyes Haouas (Code Review) 18 Nov '22

18 Nov '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69778 ) Change subject: crossgcc: Upgrade MPFR from 4.1.0 to 4.1.1 ...................................................................... crossgcc: Upgrade MPFR from 4.1.0 to 4.1.1 Change-Id: I7679c6751fb02ab670ade923b365c6410a6dc118 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/sum/mpfr-4.1.0.tar.xz.cksum A util/crossgcc/sum/mpfr-4.1.1.tar.xz.cksum 3 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/69778/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 9b7fc1c..aa25a92 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -33,7 +33,7 @@ # GCC toolchain version numbers GMP_VERSION=6.2.1 -MPFR_VERSION=4.1.0 +MPFR_VERSION=4.1.1 MPC_VERSION=1.2.1 GCC_VERSION=11.2.0 BINUTILS_VERSION=2.37 diff --git a/util/crossgcc/sum/mpfr-4.1.0.tar.xz.cksum b/util/crossgcc/sum/mpfr-4.1.0.tar.xz.cksum deleted file mode 100644 index b4fcdf7..0000000 --- a/util/crossgcc/sum/mpfr-4.1.0.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -159c3a58705662bfde4dc93f2617f3660855ead6 tarballs/mpfr-4.1.0.tar.xz diff --git a/util/crossgcc/sum/mpfr-4.1.1.tar.xz.cksum b/util/crossgcc/sum/mpfr-4.1.1.tar.xz.cksum new file mode 100644 index 0000000..d4e2411 --- /dev/null +++ b/util/crossgcc/sum/mpfr-4.1.1.tar.xz.cksum @@ -0,0 +1 @@ +2355e921d6c97c898cfe7a57dd7e72725f1fded4 tarballs/mpfr-4.1.1.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/69778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7679c6751fb02ab670ade923b365c6410a6dc118 Gerrit-Change-Number: 69778 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: ACPI: Flag boards with ACPI_NO_MADT
by Arthur Heymans (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69777 ) Change subject: ACPI: Flag boards with ACPI_NO_MADT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69777 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie61e4e4b03c9b7fcd70aba7a2bd71eadd6f4dab1 Gerrit-Change-Number: 69777 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 12:41:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ACPI MADT: Add LINT1 as NMI source
by Arthur Heymans (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69528 ) Change subject: ACPI MADT: Add LINT1 as NMI source ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65044125562bda363b3a0d92da6137c77a28b587 Gerrit-Change-Number: 69528 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 12:40:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ACPI: Use common code for MADT LAPIC NMIs
by Arthur Heymans (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Lance Zhao, Jason Glenesk, Raul Rangel, Matt DeVillier, Tim Wawrzynczak, Kyösti Mälkki, Fred Reitberger. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69527 ) Change subject: ACPI: Use common code for MADT LAPIC NMIs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf714d8c2aabd16c59c3bcebc4a207406fc85ca9 Gerrit-Change-Number: 69527 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 12:40:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/Kconfig: Don't show FIT payload option on x86
by Arthur Heymans (Code Review) 18 Nov '22

18 Nov '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69792 ) Change subject: payloads/Kconfig: Don't show FIT payload option on x86 ...................................................................... payloads/Kconfig: Don't show FIT payload option on x86 On AMD systems where the verstage selects ARCH_ARM the bogus option to add a FIT payload will be show. Therefore be more specific about the arch of the stage loading the payload (ramstage). Change-Id: I7afc3b94c5ab8044af0920c87cc8d190467c2a88 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M payloads/Kconfig 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/69792/1 diff --git a/payloads/Kconfig b/payloads/Kconfig index 2a2773a..677e78c 100644 --- a/payloads/Kconfig +++ b/payloads/Kconfig @@ -28,7 +28,7 @@ config PAYLOAD_FIT bool "A FIT payload" - depends on ARCH_ARM64 || ARCH_RISCV || ARCH_ARM + depends on ARCH_RAMSTAGE_ARM || ARCH_RAMSTAGE_ARM64 || ARCH_RAMSTAGE_RISCV select PAYLOAD_FIT_SUPPORT help Select this option if you have a payload image (a FIT file) which @@ -94,8 +94,8 @@ config PAYLOAD_FIT_SUPPORT bool "FIT support" default n - default y if PAYLOAD_LINUX && (ARCH_ARM || ARCH_ARM64 || ARCH_RISCV) - depends on ARCH_ARM64 || ARCH_RISCV || ARCH_ARM + default y if PAYLOAD_LINUX && (ARCH_RAMSTAGE_ARM || ARCH_RAMSTAGE_ARM64 || ARCH_RAMSTAGE_RISCV) + depends on ARCH_RAMSTAGE_ARM || ARCH_RAMSTAGE_ARM64 || ARCH_RAMSTAGE_RISCV select FLATTENED_DEVICE_TREE help Select this option if your payload is of type FIT. -- To view, visit https://review.coreboot.org/c/coreboot/+/69792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7afc3b94c5ab8044af0920c87cc8d190467c2a88 Gerrit-Change-Number: 69792 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: cpu/intel/sandybridge: Add `hyper_threading` option
by Angel Pons (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Nico Huber, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29669 ) Change subject: cpu/intel/sandybridge: Add `hyper_threading` option ...................................................................... Patch Set 16: Code-Review+1 (1 comment) File src/cpu/intel/model_206ax/bootblock.c: https://review.coreboot.org/c/coreboot/+/29669/comment/4ddca9ba_0e900c7a PS2, Line 132: outb(0x2, 0xcf9); : outb(0x6, 0xcf9); : halt(); > system_reset() writes 0x2 then 0x6, we don't need it i think? It should be clearer than writing to I/O ports -- To view, visit https://review.coreboot.org/c/coreboot/+/29669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b73e32ff5af8ea64a47e8aa706e27648aaf0993 Gerrit-Change-Number: 29669 Gerrit-PatchSet: 16 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-CC: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Fri, 18 Nov 2022 12:04:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] Pull ligfxinit in romstage
by Angel Pons (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Tarun Tuli, Martin L Roth, Jérémy Compostella, Andrey Petrov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 ) Change subject: [RFC] Pull ligfxinit in romstage ...................................................................... Patch Set 1: (3 comments) File src/arch/x86/car.ld: https://review.coreboot.org/c/coreboot/+/69757/comment/579bd242_86264c34 PS1, Line 122: This "illegal globals" check is because global variables in these sections don't get initialized in CAR stages. In particular, CB:56189 should patch one of the reasons why you have troubles with this. It'd be nice to try flipping the boolean so that it starts as False. If memory serves right, https://review.coreboot.org/q/topic:ada-in-romstage deals with this differently, but it doesn't pull in that much code (no libgfxinit, just libhwbase). File src/drivers/intel/fsp2_0/memory_init.c: https://review.coreboot.org/c/coreboot/+/69757/comment/88674f19_7674a3dc PS1, Line 47: static void save_memory_training_data(uint32_t fsp_version) : : static uint8_t temp_ram[CONFIG_FSP_TEMP_RAM_SIZE] __aligned(sizeof(uint64_t)); Something funky happened here https://review.coreboot.org/c/coreboot/+/69757/comment/64e85d46_31a32046 PS1, Line 348: gma_gfxinit(&lightup_ok); We might need to make this more flexible, so that you can initialize a VGA textmode framebuffer in romstage and a linear "high-resolution" framebuffer in ramstage. -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 12:02:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] Pull ligfxinit in romstage
by Subrata Banik (Code Review) 18 Nov '22

18 Nov '22

Attention is currently required from: Tarun Tuli, Martin L Roth, Jérémy Compostella, Andrey Petrov. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 ) Change subject: [RFC] Pull ligfxinit in romstage ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69757/comment/b8acde5c_eb328296 PS1, Line 7: romstage early romstage (before FSP-M) to make it more relevant 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Nov 2022 12:02:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022