coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/nissa/var/craask: Disable SAR Proximity Sensor GPIO pin
by Felix Held (Code Review) 22 Nov '22

22 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69790 ) Change subject: mb/google/nissa/var/craask: Disable SAR Proximity Sensor GPIO pin ...................................................................... mb/google/nissa/var/craask: Disable SAR Proximity Sensor GPIO pin BUG=b:253387689 Test:Boot to OS on craask and check SAR Proximity Sensor GPIO pin Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Change-Id: I2b2a2516890b68036e96d1a542e6a10a098cb6a7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69790 Reviewed-by: Reka Norman <rekanorman(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/craask/fw_config.c M src/mainboard/google/brya/variants/craask/gpio.c 2 files changed, 18 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified David Wu: Looks good to me, approved Reka Norman: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/craask/fw_config.c b/src/mainboard/google/brya/variants/craask/fw_config.c index 5b8f058..139f3eb 100644 --- a/src/mainboard/google/brya/variants/craask/fw_config.c +++ b/src/mainboard/google/brya/variants/craask/fw_config.c @@ -12,8 +12,6 @@ PAD_NC(GPP_D6, NONE), /* F12 : WWAN_RST_L */ PAD_NC_LOCK(GPP_F12, NONE, LOCK_CONFIG), - /* H19 : SOC_I2C_SUB_INT_ODL */ - PAD_NC(GPP_H19, NONE), /* H23 : WWAN_SAR_DETECT_ODL */ PAD_NC(GPP_H23, NONE), }; diff --git a/src/mainboard/google/brya/variants/craask/gpio.c b/src/mainboard/google/brya/variants/craask/gpio.c index f075ba0..980b0bf 100644 --- a/src/mainboard/google/brya/variants/craask/gpio.c +++ b/src/mainboard/google/brya/variants/craask/gpio.c @@ -17,8 +17,6 @@ PAD_CFG_GPO_LOCK(GPP_F12, 1, LOCK_CONFIG), /* H3 : WLAN_PCIE_WAKE_ODL */ PAD_NC_LOCK(GPP_H3, NONE, LOCK_CONFIG), - /* H19 : SOC_I2C_SUB_INT_ODL */ - PAD_CFG_GPI_APIC(GPP_H19, NONE, PLTRST, LEVEL, NONE), /* H23 : WWAN_SAR_DETECT_ODL */ PAD_CFG_GPO(GPP_H23, 1, DEEP), -- To view, visit https://review.coreboot.org/c/coreboot/+/69790 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b2a2516890b68036e96d1a542e6a10a098cb6a7 Gerrit-Change-Number: 69790 Gerrit-PatchSet: 5 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-CC: Victor Ding <victording(a)google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: security/tpm: support compiling in multiple TPM drivers
by Michał Żygowski (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Christian Walter, Julius Werner, Krystian Hebel, Fred Reitberger, Sergii Dmytruk, Felix Held. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162 ) Change subject: security/tpm: support compiling in multiple TPM drivers ...................................................................... Patch Set 8: (1 comment) File src/lib/program.ld: https://review.coreboot.org/c/coreboot/+/69162/comment/e25d07c1_c54171f8 PS7, Line 42: . = ALIGN(ARCH_POINTER_ALIGN_SIZE); : _tis_drivers = .; : KEEP(*(.rodata.tis_driver)); : _etis_drivers = .; : RECORD_SIZE(tis_drivers) > To make compile-time array of probe functions, like it's done for PCI drivers and others. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/69162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44c5a1d825afe414c2f5c2c90f4cfe41ba9bef5f Gerrit-Change-Number: 69162 Gerrit-PatchSet: 8 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 12:51:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/ocp/dmi: move smbios_ec_revision to ocp folder
by Felix Held (Code Review) 22 Nov '22

22 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68785 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/ocp/dmi: move smbios_ec_revision to ocp folder ...................................................................... drivers/ocp/dmi: move smbios_ec_revision to ocp folder Move smbios_ec_revision to ocp folder so that all ocp boards share the same function without implementing again. TESTED=Execute "dmidecode -t 0" to check corresponding field. Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Signed-off-by: Jonzhang Zhang <jonzhang(a)meta.com> Change-Id: I898662b78d3dbab1861cee6f1b6e148297a5d11b Reviewed-on: https://review.coreboot.org/c/coreboot/+/68785 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Marc Jones <marc(a)marcjonesconsulting.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/ocp/dmi/smbios.c M src/mainboard/ocp/deltalake/ramstage.c 2 files changed, 36 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Marc Jones: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index 51c008d..0ac3334 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -22,6 +22,21 @@ msr_t xeon_sp_ppin[2] = {0}; static bool remote_ppin_done = false; +/* + * Update SMBIOS type 0 ec version. + * For OCP platforms, BMC version is used to represent ec version. + * Refer to IPMI v2.0 spec, minor revision is defined as BCD encoded, + * format it accordingly. + */ +void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision) +{ + uint8_t bmc_major_revision, bmc_minor_revision; + + ipmi_bmc_version(&bmc_major_revision, &bmc_minor_revision); + *ec_major_revision = bmc_major_revision & 0x7f; /* bit[6:0] Major Firmware Revision */ + *ec_minor_revision = ((bmc_minor_revision / 16) * 10) + (bmc_minor_revision % 16); +} + /* Override SMBIOS type 1 data. */ const char *smbios_system_manufacturer(void) { diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 0fca920..d553392 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -30,21 +30,6 @@ extern struct fru_info_str fru_strings; static char slot_id_str[SLOT_ID_LEN]; -/* - * Update SMBIOS type 0 ec version. - * In deltalake, BMC version is used to represent ec version. - * In current version of OpenBMC, it follows IPMI v2.0 to define minor revision as BCD - * encoded, so the format of it must be transferred before send to SMBIOS. - */ -void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision) -{ - uint8_t bmc_major_revision, bmc_minor_revision; - - ipmi_bmc_version(&bmc_major_revision, &bmc_minor_revision); - *ec_major_revision = bmc_major_revision & 0x7f; /* bit[6:0] Major Firmware Revision */ - *ec_minor_revision = ((bmc_minor_revision / 16) * 10) + (bmc_minor_revision % 16); -} - /* Override SMBIOS 2 Location In Chassis from BMC */ const char *smbios_mainboard_location_in_chassis(void) { -- To view, visit https://review.coreboot.org/c/coreboot/+/68785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I898662b78d3dbab1861cee6f1b6e148297a5d11b Gerrit-Change-Number: 68785 Gerrit-PatchSet: 4 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: include/spd.h: Fix comment module type information
by Felix Held (Code Review) 22 Nov '22

22 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69271 ) Change subject: include/spd.h: Fix comment module type information ...................................................................... include/spd.h: Fix comment module type information Change-Id: I7af61404d11f7e0ff5f30c42958c4dd9318538fa Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69271 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/include/spd.h 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/include/spd.h b/src/include/spd.h index ca78d9c..7a6e5ab 100644 --- a/src/include/spd.h +++ b/src/include/spd.h @@ -201,7 +201,7 @@ #define SPD_ECC_8BIT (1<<3) #define SPD_ECC_8BIT_LP5_DDR5 (1<<4) -/* Byte 3: Module type information */ +/* Byte 20 [5:0]: DDR2 Module type information */ enum ddr2_module_type { DDR2_SPD_RDIMM = 0x01, DDR2_SPD_UDIMM = 0x02, @@ -213,6 +213,7 @@ DDR2_SPD_MINI_UDIMM = 0x20, }; +/* Byte 3 [3:0]: DDR3 Module type information */ enum ddr3_module_type { DDR3_SPD_RDIMM = 0x01, DDR3_SPD_UDIMM = 0x02, @@ -229,6 +230,7 @@ DDR3_SPD_32B_SO_RDIMM = 0x0d, }; +/* Byte 3 [3:0]: DDR4 Module type information */ enum ddr4_module_type { DDR4_SPD_RDIMM = 0x01, DDR4_SPD_UDIMM = 0x02, -- To view, visit https://review.coreboot.org/c/coreboot/+/69271 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7af61404d11f7e0ff5f30c42958c4dd9318538fa Gerrit-Change-Number: 69271 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: util: Add SPDX license headers to Makefiles
by Felix Held (Code Review) 22 Nov '22

22 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68983 ) Change subject: util: Add SPDX license headers to Makefiles ...................................................................... util: Add SPDX license headers to Makefiles Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I7cf35132df0bc23f7b6f78014ddd72d58ea2ab8a Reviewed-on: https://review.coreboot.org/c/coreboot/+/68983 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M util/archive/Makefile M util/bincfg/Makefile M util/bincfg/Makefile.inc M util/bucts/Makefile M util/cbfstool/Makefile.inc M util/cbfstool/bpdt_formats/Makefile.inc M util/cbfstool/fpt_formats/Makefile.inc M util/cbfstool/lz4/Makefile M util/cbfstool/lz4/lib/Makefile M util/crossgcc/Makefile M util/futility/Makefile M util/futility/Makefile.inc M util/fuzz-tests/Makefile M util/intelp2m/Makefile M util/kbc1126/Makefile M util/lint/Makefile M util/marvell/Makefile.inc M util/marvell/doimage_mv/Makefile.inc M util/msrtool/Makefile.in M util/nvidia/Makefile.inc M util/post/Makefile M util/sconfig/Makefile.inc M util/spd_tools/Makefile M util/supermicro/Makefile.inc 24 files changed, 39 insertions(+), 54 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Eric Lai: Looks good to me, approved Matt DeVillier: Looks good to me, approved diff --git a/util/archive/Makefile b/util/archive/Makefile index d4b58f7..2de6a62 100644 --- a/util/archive/Makefile +++ b/util/archive/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only PROGRAM = archive HOSTCC ?= gcc WERROR=-Werror diff --git a/util/bincfg/Makefile b/util/bincfg/Makefile index ca375a5..dbcbc77 100644 --- a/util/bincfg/Makefile +++ b/util/bincfg/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only CC = gcc YACC = bison LEX = flex diff --git a/util/bincfg/Makefile.inc b/util/bincfg/Makefile.inc index 81c6af6..0f5f442 100644 --- a/util/bincfg/Makefile.inc +++ b/util/bincfg/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only bincfg_obj := bincfg.lex.o bincfg.tab.o BINCFG_FLAGS += -I$(top)/util/bincfg -I$(objutil)/bincfg diff --git a/util/bucts/Makefile b/util/bucts/Makefile index 98f7314..d32258d 100644 --- a/util/bucts/Makefile +++ b/util/bucts/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only CC:=gcc OBJ:=bucts.o TARGET=bucts diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index a60cee1..8428f8a 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only compressionobj := compressionobj += compress.o # LZ4 diff --git a/util/cbfstool/bpdt_formats/Makefile.inc b/util/cbfstool/bpdt_formats/Makefile.inc index c676489..a3be46b 100644 --- a/util/cbfstool/bpdt_formats/Makefile.inc +++ b/util/cbfstool/bpdt_formats/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only bpdt_formats_obj += bpdt_1_6.o bpdt_formats_obj += bpdt_1_7.o diff --git a/util/cbfstool/fpt_formats/Makefile.inc b/util/cbfstool/fpt_formats/Makefile.inc index 865eaed..11cb30d 100644 --- a/util/cbfstool/fpt_formats/Makefile.inc +++ b/util/cbfstool/fpt_formats/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only fpt_formats_obj += fpt_hdr_20.o fpt_formats_obj += fpt_hdr_21.o diff --git a/util/cbfstool/lz4/Makefile b/util/cbfstool/lz4/Makefile index 931da35..4506267 100644 --- a/util/cbfstool/lz4/Makefile +++ b/util/cbfstool/lz4/Makefile @@ -1,30 +1,9 @@ +## SPDX-License-Identifier: BSD-2-Clause # ################################################################ # LZ4 - Makefile # Copyright (C) Yann Collet 2011-2015 # All rights reserved. # -# BSD license -# Redistribution and use in source and binary forms, with or without modification, -# are permitted provided that the following conditions are met: -# -# * Redistributions of source code must retain the above copyright notice, this -# list of conditions and the following disclaimer. -# -# * Redistributions in binary form must reproduce the above copyright notice, this -# list of conditions and the following disclaimer in the documentation and/or -# other materials provided with the distribution. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND -# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED -# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE -# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR -# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES -# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; -# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON -# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS -# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -# # You can contact the author at : # - LZ4 source repository : https://github.com/Cyan4973/lz4 # - LZ4 forum froup : https://groups.google.com/forum/#!forum/lz4c diff --git a/util/cbfstool/lz4/lib/Makefile b/util/cbfstool/lz4/lib/Makefile index 12a741d..ed59577 100644 --- a/util/cbfstool/lz4/lib/Makefile +++ b/util/cbfstool/lz4/lib/Makefile @@ -1,30 +1,9 @@ +## SPDX-License-Identifier: BSD-2-Clause # ################################################################ # LZ4 library - Makefile # Copyright (C) Yann Collet 2011-2015 # All rights reserved. # -# BSD license -# Redistribution and use in source and binary forms, with or without modification, -# are permitted provided that the following conditions are met: -# -# * Redistributions of source code must retain the above copyright notice, this -# list of conditions and the following disclaimer. -# -# * Redistributions in binary form must reproduce the above copyright notice, this -# list of conditions and the following disclaimer in the documentation and/or -# other materials provided with the distribution. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND -# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED -# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE -# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR -# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES -# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; -# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON -# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS -# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -# # You can contact the author at : # - LZ4 source repository : https://github.com/Cyan4973/lz4 # - LZ4 forum froup : https://groups.google.com/forum/#!forum/lz4c diff --git a/util/crossgcc/Makefile b/util/crossgcc/Makefile index cb552dd..06ec91c 100644 --- a/util/crossgcc/Makefile +++ b/util/crossgcc/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only # if no architecture is specified, set a default BUILD_PLATFORM ?= i386-elf DEST ?= $(CURDIR)/xgcc diff --git a/util/futility/Makefile b/util/futility/Makefile index 2eaab3e..6901948 100644 --- a/util/futility/Makefile +++ b/util/futility/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only top ?= $(abspath ../..) objutil ?= $(top)/util RM ?= rm diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc index 1033fc5..a7bcee5 100644 --- a/util/futility/Makefile.inc +++ b/util/futility/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only additional-dirs += $(objutil)/futility VBOOT_FUTILITY = $(VBOOT_HOST_BUILD)/futility/futility diff --git a/util/fuzz-tests/Makefile b/util/fuzz-tests/Makefile index e97643f..641f0f4 100644 --- a/util/fuzz-tests/Makefile +++ b/util/fuzz-tests/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only all: afl-gcc -g -m32 -I ../../src/lib -o jpeg-test jpeg-test.c ../../src/lib/jpeg.c diff --git a/util/intelp2m/Makefile b/util/intelp2m/Makefile index 1d9ba70..2731bc7 100644 --- a/util/intelp2m/Makefile +++ b/util/intelp2m/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only # simple makefile for the project OUTPUT_DIR = generate diff --git a/util/kbc1126/Makefile b/util/kbc1126/Makefile index 4826874..5b62878 100644 --- a/util/kbc1126/Makefile +++ b/util/kbc1126/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only obj = kbc1126_ec_dump kbc1126_ec_insert HOSTCC := $(if $(shell type gcc 2>/dev/null),gcc,cc) diff --git a/util/lint/Makefile b/util/lint/Makefile index 1a4fec8..29f6683 100644 --- a/util/lint/Makefile +++ b/util/lint/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only sort: sort-spelling.txt sort-%: % diff --git a/util/marvell/Makefile.inc b/util/marvell/Makefile.inc index 08dbf72..d58c9d8 100644 --- a/util/marvell/Makefile.inc +++ b/util/marvell/Makefile.inc @@ -1 +1,2 @@ +## SPDX-License-Identifier: GPL-2.0-only subdirs-$(CONFIG_SOC_MARVELL_ARMADA38X) += doimage_mv diff --git a/util/marvell/doimage_mv/Makefile.inc b/util/marvell/doimage_mv/Makefile.inc index 83665df..4020166 100644 --- a/util/marvell/doimage_mv/Makefile.inc +++ b/util/marvell/doimage_mv/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only DOIMAGE_FOLDER = marvell/doimage_mv DOIMAGE_BINARY = doimage diff --git a/util/msrtool/Makefile.in b/util/msrtool/Makefile.in index 7c5966c..326dda3 100644 --- a/util/msrtool/Makefile.in +++ b/util/msrtool/Makefile.in @@ -1,15 +1,6 @@ +## SPDX-License-Identifier: GPL-2.0-only # Makefile for msrtool # -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License version 2 as -# published by the Free Software Foundation. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# PROGRAM = msrtool diff --git a/util/nvidia/Makefile.inc b/util/nvidia/Makefile.inc index 1894fad..04199d0 100644 --- a/util/nvidia/Makefile.inc +++ b/util/nvidia/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only # copied from cbootimage/src/Makefile.am CBOOTIMAGE_RAW_SRCS:= \ cbootimage.c \ diff --git a/util/post/Makefile b/util/post/Makefile index 0941cde..e292a73 100644 --- a/util/post/Makefile +++ b/util/post/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only all: $(CC) post.c -o post clean: diff --git a/util/sconfig/Makefile.inc b/util/sconfig/Makefile.inc index b821f06..c3da29d 100644 --- a/util/sconfig/Makefile.inc +++ b/util/sconfig/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only sconfigobj := sconfigobj += lex.yy.o sconfigobj += sconfig.tab.o diff --git a/util/spd_tools/Makefile b/util/spd_tools/Makefile index 3aad91c..5b23c32 100644 --- a/util/spd_tools/Makefile +++ b/util/spd_tools/Makefile @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only SPD_GEN = bin/spd_gen PART_ID_GEN = bin/part_id_gen diff --git a/util/supermicro/Makefile.inc b/util/supermicro/Makefile.inc index 316cb48..7d295a0 100644 --- a/util/supermicro/Makefile.inc +++ b/util/supermicro/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only TOOLCPPFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h SMCBIOSINFOTOOL:= $(objutil)/supermicro/smcbiosinfo -- To view, visit https://review.coreboot.org/c/coreboot/+/68983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cf35132df0bc23f7b6f78014ddd72d58ea2ab8a Gerrit-Change-Number: 68983 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: ec: Add SPDX license headers to Makefiles
by Felix Held (Code Review) 22 Nov '22

22 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68981 ) Change subject: ec: Add SPDX license headers to Makefiles ...................................................................... ec: Add SPDX license headers to Makefiles Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ie5355e05982b372ef69515cfa081e2afbc7b09fe Reviewed-on: https://review.coreboot.org/c/coreboot/+/68981 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Caveh Jalali <caveh(a)chromium.org> Reviewed-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/ec/acpi/Makefile.inc M src/ec/compal/ene932/Makefile.inc M src/ec/google/chromeec/Makefile.inc M src/ec/google/chromeec/audio_codec/Makefile.inc M src/ec/google/chromeec/i2c_tunnel/Makefile.inc M src/ec/google/chromeec/mux/Makefile.inc M src/ec/google/chromeec/mux/conn/Makefile.inc M src/ec/google/common/Makefile.inc M src/ec/google/wilco/Makefile.inc M src/ec/kontron/it8516e/Makefile.inc M src/ec/kontron/kempld/Makefile.inc M src/ec/lenovo/h8/Makefile.inc M src/ec/lenovo/pmh7/Makefile.inc M src/ec/purism/librem-ec/Makefile.inc M src/ec/quanta/ene_kb3940q/Makefile.inc M src/ec/quanta/it8518/Makefile.inc M src/ec/smsc/mec1308/Makefile.inc M src/ec/system76/ec/Makefile.inc 18 files changed, 34 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Caveh Jalali: Looks good to me, but someone else must approve Eric Lai: Looks good to me, approved Matt DeVillier: Looks good to me, approved diff --git a/src/ec/acpi/Makefile.inc b/src/ec/acpi/Makefile.inc index 34c113b..b3eb103 100644 --- a/src/ec/acpi/Makefile.inc +++ b/src/ec/acpi/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_ACPI),y) bootblock-y += ec.c diff --git a/src/ec/compal/ene932/Makefile.inc b/src/ec/compal/ene932/Makefile.inc index effe34c..6af2a1c 100644 --- a/src/ec/compal/ene932/Makefile.inc +++ b/src/ec/compal/ene932/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_COMPAL_ENE932),y) ramstage-y += ec.c diff --git a/src/ec/google/chromeec/Makefile.inc b/src/ec/google/chromeec/Makefile.inc index f6c53d3..1cf88f2 100644 --- a/src/ec/google/chromeec/Makefile.inc +++ b/src/ec/google/chromeec/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_GOOGLE_CHROMEEC),y) subdirs-y += audio_codec diff --git a/src/ec/google/chromeec/audio_codec/Makefile.inc b/src/ec/google/chromeec/audio_codec/Makefile.inc index 8726b92..0152935 100644 --- a/src/ec/google/chromeec/audio_codec/Makefile.inc +++ b/src/ec/google/chromeec/audio_codec/Makefile.inc @@ -1 +1,2 @@ +## SPDX-License-Identifier: GPL-2.0-only ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC_AUDIO_CODEC) += audio_codec.c diff --git a/src/ec/google/chromeec/i2c_tunnel/Makefile.inc b/src/ec/google/chromeec/i2c_tunnel/Makefile.inc index 85e0fba..81b91af 100644 --- a/src/ec/google/chromeec/i2c_tunnel/Makefile.inc +++ b/src/ec/google/chromeec/i2c_tunnel/Makefile.inc @@ -1 +1,2 @@ +## SPDX-License-Identifier: GPL-2.0-only ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC_I2C_TUNNEL) += i2c_tunnel.c diff --git a/src/ec/google/chromeec/mux/Makefile.inc b/src/ec/google/chromeec/mux/Makefile.inc index c4cef75..58529aeb 100644 --- a/src/ec/google/chromeec/mux/Makefile.inc +++ b/src/ec/google/chromeec/mux/Makefile.inc @@ -1,2 +1,3 @@ +## SPDX-License-Identifier: GPL-2.0-only subdirs-y += conn ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC_MUX) += mux.c diff --git a/src/ec/google/chromeec/mux/conn/Makefile.inc b/src/ec/google/chromeec/mux/conn/Makefile.inc index 1f837ca..795baa9 100644 --- a/src/ec/google/chromeec/mux/conn/Makefile.inc +++ b/src/ec/google/chromeec/mux/conn/Makefile.inc @@ -1 +1,2 @@ +## SPDX-License-Identifier: GPL-2.0-only ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC_MUX) += conn.c diff --git a/src/ec/google/common/Makefile.inc b/src/ec/google/common/Makefile.inc index 7ab2285..e1e5dfc 100644 --- a/src/ec/google/common/Makefile.inc +++ b/src/ec/google/common/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only bootblock-$(CONFIG_EC_GOOGLE_COMMON_MEC) += mec.c verstage-$(CONFIG_EC_GOOGLE_COMMON_MEC) += mec.c romstage-$(CONFIG_EC_GOOGLE_COMMON_MEC) += mec.c diff --git a/src/ec/google/wilco/Makefile.inc b/src/ec/google/wilco/Makefile.inc index f17869e..77eab67 100644 --- a/src/ec/google/wilco/Makefile.inc +++ b/src/ec/google/wilco/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_GOOGLE_WILCO),y) bootblock-y += bootblock.c commands.c mailbox.c diff --git a/src/ec/kontron/it8516e/Makefile.inc b/src/ec/kontron/it8516e/Makefile.inc index 6ef87cd..0d61b59 100644 --- a/src/ec/kontron/it8516e/Makefile.inc +++ b/src/ec/kontron/it8516e/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_KONTRON_IT8516E),y) ramstage-y += ec.c diff --git a/src/ec/kontron/kempld/Makefile.inc b/src/ec/kontron/kempld/Makefile.inc index e7bafa3..e4cdde4 100644 --- a/src/ec/kontron/kempld/Makefile.inc +++ b/src/ec/kontron/kempld/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only bootblock-$(CONFIG_EC_KONTRON_KEMPLD) += early_kempld.c ramstage-$(CONFIG_EC_KONTRON_KEMPLD) += early_kempld.c ramstage-$(CONFIG_EC_KONTRON_KEMPLD) += kempld.c diff --git a/src/ec/lenovo/h8/Makefile.inc b/src/ec/lenovo/h8/Makefile.inc index 51c11be..3ac9941 100644 --- a/src/ec/lenovo/h8/Makefile.inc +++ b/src/ec/lenovo/h8/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_LENOVO_H8),y) ramstage-y += sense.c diff --git a/src/ec/lenovo/pmh7/Makefile.inc b/src/ec/lenovo/pmh7/Makefile.inc index c7c95c0..4f8c99f 100644 --- a/src/ec/lenovo/pmh7/Makefile.inc +++ b/src/ec/lenovo/pmh7/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_LENOVO_PMH7),y) bootblock-y += pmh7.c diff --git a/src/ec/purism/librem-ec/Makefile.inc b/src/ec/purism/librem-ec/Makefile.inc index a3d5553..5e2b2df 100644 --- a/src/ec/purism/librem-ec/Makefile.inc +++ b/src/ec/purism/librem-ec/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_LIBREM_EC),y) all-y += ../../system76/ec/system76_ec.c diff --git a/src/ec/quanta/ene_kb3940q/Makefile.inc b/src/ec/quanta/ene_kb3940q/Makefile.inc index a1ae764..8a6c865 100644 --- a/src/ec/quanta/ene_kb3940q/Makefile.inc +++ b/src/ec/quanta/ene_kb3940q/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_QUANTA_ENE_KB3940Q),y) ramstage-y += ec.c diff --git a/src/ec/quanta/it8518/Makefile.inc b/src/ec/quanta/it8518/Makefile.inc index daf75ef..b05db06 100644 --- a/src/ec/quanta/it8518/Makefile.inc +++ b/src/ec/quanta/it8518/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_QUANTA_IT8518),y) romstage-y += ec.c diff --git a/src/ec/smsc/mec1308/Makefile.inc b/src/ec/smsc/mec1308/Makefile.inc index c45f65d..199742c 100644 --- a/src/ec/smsc/mec1308/Makefile.inc +++ b/src/ec/smsc/mec1308/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_SMSC_MEC1308),y) ramstage-y += ec.c diff --git a/src/ec/system76/ec/Makefile.inc b/src/ec/system76/ec/Makefile.inc index 382daa6..110b997 100644 --- a/src/ec/system76/ec/Makefile.inc +++ b/src/ec/system76/ec/Makefile.inc @@ -1,3 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_EC_SYSTEM76_EC),y) all-y += system76_ec.c -- To view, visit https://review.coreboot.org/c/coreboot/+/68981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5355e05982b372ef69515cfa081e2afbc7b09fe Gerrit-Change-Number: 68981 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: libpayload: Fix compiler warnings
by Felix Held (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Thomas Heijligen. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69764 ) Change subject: libpayload: Fix compiler warnings ...................................................................... Patch Set 4: (1 comment) File payloads/libpayload/drivers/serial/8250.c: https://review.coreboot.org/c/coreboot/+/69764/comment/e947d13d_6ca78af4 PS4, Line 75: #if !CONFIG(LP_PL011_SERIAL_CONSOLE) i wonder if a if (CONFIG(LP_PL011_SERIAL_CONSOLE)) return; would be an alternative to using the preprocessor here -- To view, visit https://review.coreboot.org/c/coreboot/+/69764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id285c24cba790f181fa203f3117e5df35bed27c4 Gerrit-Change-Number: 69764 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 12:36:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device/mdio: Provide helper functions for read and write
by Angel Pons (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Mario Scheithauer, Arthur Heymans, Werner Zeh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69611 ) Change subject: device/mdio: Provide helper functions for read and write ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File src/device/mdio.c: https://review.coreboot.org/c/coreboot/+/69611/comment/309cfe2e_e7501d21 PS4, Line 27: 0 > > Do you know if the MDIO spec specifies a default value when attempting to read from a non-existing […] There's the error print in `dev_get_mdio_ops()` which should suffice. -- To view, visit https://review.coreboot.org/c/coreboot/+/69611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I293d93435d27269a071b4b9b94a1b55307c575a7 Gerrit-Change-Number: 69611 Gerrit-PatchSet: 5 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 12:31:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: src/device + util/sconfig: Introduce new device 'mdio'
by Arthur Heymans (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Martin L Roth, Subrata Banik, Paul Menzel, Mario Scheithauer. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 ) Change subject: src/device + util/sconfig: Introduce new device 'mdio' ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6691f92c4233bc30afc9029840b06f74bb1eb4b2 Gerrit-Change-Number: 69382 Gerrit-PatchSet: 8 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 12:29:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl2: Enable downshift for Marvell PHYs
by Arthur Heymans (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Mario Scheithauer, Werner Zeh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69887 ) Change subject: mb/siemens/mc_ehl2: Enable downshift for Marvell PHYs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32b5f25a3e1e0f962dff3110143e236992ef8e7d Gerrit-Change-Number: 69887 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 12:29:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022