coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: Makefile.inc: fix multiple jobs build issue
by Nico Huber (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Michał Żygowski, Martin L Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69819 ) Change subject: Makefile.inc: fix multiple jobs build issue ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File Makefile.inc: https://review.coreboot.org/c/coreboot/+/69819/comment/ddd33e4d_0d6951d9 PS2, Line 655: smm-c-deps+=$(obj)/fmap_config.h Just wondering, does smm need it? Wouldn't hurt if not. -- To view, visit https://review.coreboot.org/c/coreboot/+/69819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a70beedf2eb1c018c5ff98163904253f9a87a61 Gerrit-Change-Number: 69819 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 12:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/pc80/tpm: probe for TPM family of a device
by Michał Żygowski (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Christian Walter, Julius Werner, Krystian Hebel, Sergii Dmytruk. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69023 ) Change subject: drivers/pc80/tpm: probe for TPM family of a device ...................................................................... Patch Set 5: (2 comments) File src/drivers/pc80/tpm/tis.c: https://review.coreboot.org/c/coreboot/+/69023/comment/b0753c69_ebd44e4f PS5, Line 432: family = TPM_2; If intf_id == 1 that means CRB interface is active which is not compatible with pc80 TIS driver. We should also check for value 0 which will be TPM2 FIFO interface compatible with this driver, otherwise return TPM_DRIVER_ERR. https://review.coreboot.org/c/coreboot/+/69023/comment/c3b94c20_1a3e9f34 PS5, Line 458: family_str = (family == TPM_1 ? "TPM1" : "TPM2"); family_str = (family == TPM_1 ? "TPM 1.2" : "TPM 2.0"); -- To view, visit https://review.coreboot.org/c/coreboot/+/69023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5464771836c66bcc441efb7189ded416b8f53827 Gerrit-Change-Number: 69023 Gerrit-PatchSet: 5 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 12:20:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake/include/soc/pmc.h: Add file
by Sean Rhodes (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Michał Żygowski. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69900 ) Change subject: soc/intel/apollolake/include/soc/pmc.h: Add file ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726aaae1ce60d15a3944dadcf793def2dcb3a1c Gerrit-Change-Number: 69900 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 12:09:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Hook up the OC watchdog
by Michał Żygowski (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Michał Kopeć. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68945 to look at the new patch set (#7). Change subject: soc/intel/alderlake: Hook up the OC watchdog ...................................................................... soc/intel/alderlake: Hook up the OC watchdog Hook up the OC watchdog common block and initialize it if requested. TEST=Enable watchdog on MSI PRO Z690-A and see the platform resets after some time. Enable the watchdog in driverless mode and see the platform no longer resets and periodic SMI keeps feeding the watchdog. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I1c2c640d48b7e03ad8cd8d6cdf6aac447e93cd86 --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/acpi.c M src/soc/intel/alderlake/romstage/romstage.c 3 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/68945/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/68945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c2c640d48b7e03ad8cd8d6cdf6aac447e93cd86 Gerrit-Change-Number: 68945 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: soc/intel/common/block/oc_wdt: Add OC watchdog common block
by Michał Żygowski (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Hello build bot (Jenkins), Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68944 to look at the new patch set (#7). Change subject: soc/intel/common/block/oc_wdt: Add OC watchdog common block ...................................................................... soc/intel/common/block/oc_wdt: Add OC watchdog common block Add new block for handling overcloking watchdog. The watchdog is present since Skylake or maybe even earlier so it is safe to use with most of the micrarchitectures utilizing intelblocks. Some FSPs are also utilizing OC watchdog so care must be taken when initializing it. Example integration provided in subsequent patch. The goal is to provide coreboot with additional reliability settings. The patch adds the common block for initializing and feeding the watchdog. Timeout is configurable via Kconfig and cannot be set to less than 60 seconds to avoid reset loops when full memory training is needed. The patch also adds support for feeding watchdog in driveless mode, i.e. it utilizies periodic SMI to reload the timeout value and restart the watchdog timer. This is optional and selectable by Kconfig option as well. If the option is not enabled, payload and/or software must ensure to keep feeding the watchdog, otherwise the platform will reset. Common SMM drivers have also been extended with new APM command to reset/reboot platform and additionally allow known reset for reboot and shutdown in SMI handlers. Platforms should use the new APM command in FADT as reboot value via SMI if watchdog is enabled. This however assumes that no software writes directly to 0xcf9 port to reset platform, otherwise the reset will be treated as unexpected one. Example is added in subsequent patch for Alder Lake. TEST=Enable watchdog on MSI PRO Z690-A and see the platform resets after some time. Enable the watchdog in driverless mode and see the platform no longer resets and periodic SMI keeps feeding the watchdog. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ib494aa0c7581351abca8b496fc5895b2c7cbc5bc --- M src/arch/x86/Makefile.inc M src/include/cpu/x86/smm.h A src/soc/intel/common/block/include/intelblocks/oc_wdt.h A src/soc/intel/common/block/oc_wdt/Kconfig A src/soc/intel/common/block/oc_wdt/Makefile.inc A src/soc/intel/common/block/oc_wdt/oc_wdt.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smm.c 8 files changed, 368 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/68944/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/68944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib494aa0c7581351abca8b496fc5895b2c7cbc5bc Gerrit-Change-Number: 68944 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/apollolake/include/soc/pmc.h: Add file
by Michał Żygowski (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Sean Rhodes. Hello Sean Rhodes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69900 to look at the new patch set (#2). Change subject: soc/intel/apollolake/include/soc/pmc.h: Add file ...................................................................... soc/intel/apollolake/include/soc/pmc.h: Add file Add a file which is needed for OC watchdog compilation. Currently the file is empty as all PMC definitions are in pm.h file. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I2726aaae1ce60d15a3944dadcf793def2dcb3a1c --- A src/soc/intel/apollolake/include/soc/pmc.h 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69900/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726aaae1ce60d15a3944dadcf793def2dcb3a1c Gerrit-Change-Number: 69900 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/apollolake/include/soc/pmc.h: Add file
by Michał Żygowski (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Sean Rhodes. Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69900 ) Change subject: soc/intel/apollolake/include/soc/pmc.h: Add file ...................................................................... soc/intel/apollolake/include/soc/pmc.h: Add file Add afile which is needed for OC watchdog compilation. Currently the file is empty as all PMC definitions are in pm.h file. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I2726aaae1ce60d15a3944dadcf793def2dcb3a1c --- A src/soc/intel/apollolake/include/soc/pmc.h 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69900/1 diff --git a/src/soc/intel/apollolake/include/soc/pmc.h b/src/soc/intel/apollolake/include/soc/pmc.h new file mode 100644 index 0000000..81c4229 --- /dev/null +++ b/src/soc/intel/apollolake/include/soc/pmc.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef _SOC_APOLLOLAKE_PMC_H_ +#define _SOC_APOLLOLAKE_PMC_H_ + +#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/69900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2726aaae1ce60d15a3944dadcf793def2dcb3a1c Gerrit-Change-Number: 69900 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: soc/intel/common/block/oc_wdt: Add OC watchdog common block
by Michał Żygowski (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Hello build bot (Jenkins), Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68944 to look at the new patch set (#6). Change subject: soc/intel/common/block/oc_wdt: Add OC watchdog common block ...................................................................... soc/intel/common/block/oc_wdt: Add OC watchdog common block Add new block for handling overcloking watchdog. The watchdog is present since Skylake or maybe even earlier so it is safe to use with most of the micrarchitectures utilizing intelblocks. Some FSPs are also utilizing OC watchdog so care must be taken when initializing it. Example integration provided in subsequent patch. The goal is to provide coreboot with additional reliability settings. The patch adds the common block for initializing and feeding the watchdog. Timeout is configurable via Kconfig and cannot be set to less than 60 seconds to avoid reset loops when full memory training is needed. The patch also adds support for feeding watchdog in driveless mode, i.e. it utilizies periodic SMI to reload the timeout value and restart the watchdog timer. This is optional and selectable by Kconfig option as well. If the option is not enabled, payload and/or software must ensure to keep feeding the watchdog, otherwise the platform will reset. Common SMM drivers have also been extended with new APM command to reset/reboot platform and additionally allow known reset for reboot and shutdown in SMI handlers. Platforms should use the new APM command in FADT as reboot value via SMI if watchdog is enabled. This however assumes that no software writes directly to 0xcf9 port to reset platform, otherwise the reset will be treated as unexpected one. Example is added in subsequent patch for Alder Lake. TEST=Enable watchdog on MSI PRO Z690-A and see the platform resets after some time. Enable the watchdog in driverless mode and see the platform no longer resets and periodic SMI keeps feeding the watchdog. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ib494aa0c7581351abca8b496fc5895b2c7cbc5bc --- M src/arch/x86/Makefile.inc M src/include/cpu/x86/smm.h A src/soc/intel/common/block/include/intelblocks/oc_wdt.h A src/soc/intel/common/block/oc_wdt/Kconfig A src/soc/intel/common/block/oc_wdt/Makefile.inc A src/soc/intel/common/block/oc_wdt/oc_wdt.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smm.c 8 files changed, 368 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/68944/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/68944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib494aa0c7581351abca8b496fc5895b2c7cbc5bc Gerrit-Change-Number: 68944 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: vc/intel/fsp/mtl: Remove deprecated header FirmwareVersionInfoHob.h
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69884 to look at the new patch set (#6). Change subject: vc/intel/fsp/mtl: Remove deprecated header FirmwareVersionInfoHob.h ...................................................................... vc/intel/fsp/mtl: Remove deprecated header FirmwareVersionInfoHob.h Changes include: - FirmwareVersionInfoHob.h is removed to use new header file FirmwareVersionInfo.h. BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: I06fd89f201e9e4100524e58033086327ad4ffc7b --- D src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfoHob.h 1 file changed, 19 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/69884/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/69884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06fd89f201e9e4100524e58033086327ad4ffc7b Gerrit-Change-Number: 69884 Gerrit-PatchSet: 6 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: drivers/net/phy/m88e1512: Provide functionality to customize LED status
by build bot (Jenkins) (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Arthur Heymans, Werner Zeh. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 ) Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status ...................................................................... Patch Set 17: Verified+1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164250): https://review.coreboot.org/c/coreboot/+/69386/comment/8e34cff3_28b5c98f PS17, Line 14: https://web.archive.org/web/20221109080111/https://www.marvell.com/content/… Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/69386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Gerrit-Change-Number: 69386 Gerrit-PatchSet: 17 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 11:54:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022