coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Fix acpica filename
by Felix Singer (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), Angel Pons, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70021 to look at the new patch set (#4). Change subject: util/crossgcc/buildgcc: Fix acpica filename ...................................................................... util/crossgcc/buildgcc: Fix acpica filename The download links from acpica.org [1] are not stable, and for some reason they named the release tarballs with .tar_0.gz. Thus, use the tarballs from their GitHub repository generated out of the release tags. Tested locally and also IASL patch applies. [1] https://www.acpica.org/downloads Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-R10_20_22_iasl.patch A util/crossgcc/sum/R10_20_22.tar.gz.cksum D util/crossgcc/sum/acpica-unix2-20221020.tar.gz.cksum 4 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/70021/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Fix acpica filename
by Felix Singer (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), Angel Pons, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70021 to look at the new patch set (#3). Change subject: util/crossgcc/buildgcc: Fix acpica filename ...................................................................... util/crossgcc/buildgcc: Fix acpica filename The download links from acpica.org [1] are not stable, and for some reason they named the release tarballs with .tar_0.gz. Thus, use the tarballs from their GitHub repository generated out of the release tags. [1] https://www.acpica.org/downloads Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix-20221020_iasl.patch A util/crossgcc/sum/R10_20_22.tar.gz.cksum D util/crossgcc/sum/acpica-unix2-20221020.tar.gz.cksum 4 files changed, 19 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/70021/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Fix acpica filename
by Felix Singer (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70021 ) Change subject: util/crossgcc/buildgcc: Fix acpica filename ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Really weird. […] People on IRC are having problems with building the toolchain. We should do something. The issue is open for nearly 3 weeks now and they wasn't able to fix this. How about we switch over to the GitHub release archives [1]? We already use the LLVM ones from there. At least the GitHub download links are stable. I will adjust the patch for this. [1] https://github.com/acpica/acpica/tags -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 27 Nov 2022 07:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Fix acpica filename
by Felix Singer (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70021 ) Change subject: util/crossgcc/buildgcc: Fix acpica filename ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > The link is broken and the issue is already reported upstream […] Really weird. It must have worked at least once since the coreboot-toolchain builder reported success when you worked on it. https://review.coreboot.org/c/coreboot/+/68929/12#message-a64b32665ebecdb87… -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 27 Nov 2022 07:09:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/common: Rename TCO timeout
by Elyes Haouas (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70045 ) Change subject: sb/intel/common: Rename TCO timeout ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib136e9b2d0006eb4ceceb298b557644760d1185c Gerrit-Change-Number: 70045 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 05:45:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: sb,soc/intel: Address TCO SECOND_TO_STS name collision
by Elyes Haouas (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Tarun Tuli, Sean Rhodes, Subrata Banik, Jonathan Zhang, Johnny Lin, Kapil Porwal, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70044 ) Change subject: sb,soc/intel: Address TCO SECOND_TO_STS name collision ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07cc46a9d600b2bf2f23588b26891268e9ce4de0 Gerrit-Change-Number: 70044 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 05:43:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: sb,soc/intel: Apply transitional flag TCO_SPACE_NOT_YET_SPLIT
by Elyes Haouas (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70043 ) Change subject: sb,soc/intel: Apply transitional flag TCO_SPACE_NOT_YET_SPLIT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16213cdb13f98fccb261004b31e81a9a44cb6e3b Gerrit-Change-Number: 70043 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 05:10:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros"
by Elyes Haouas (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70042 ) Change subject: Revert "sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70042 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827558a0e0ef1c4d1f866756df51cd1b2abfc7a0 Gerrit-Change-Number: 70042 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 05:07:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/quark: Fix out() parameter order
by Elyes Haouas (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70051 ) Change subject: soc/intel/quark: Fix out() parameter order ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4db09632a41d28b0c8e211e6232db4e6d85bdf5f Gerrit-Change-Number: 70051 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 04:55:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/lynxpoint: Get pch_log_state() from pmutil.h
by Kyösti Mälkki (Code Review) 27 Nov '22

27 Nov '22

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/70046 ) Change subject: sb/intel/lynxpoint: Get pch_log_state() from pmutil.h ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/70046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa9ce168225e4fe880ce6da4971cc5cff456215a Gerrit-Change-Number: 70046 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022