coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: soc/intel: Adopt new common/pmbase
by Kyösti Mälkki (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Sean Rhodes. Hello Sean Rhodes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70050 to look at the new patch set (#4). Change subject: soc/intel: Adopt new common/pmbase ...................................................................... soc/intel: Adopt new common/pmbase Change-Id: I473ebefcf8e0c929f6cbf6b5c0d7e8f5af72856d Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/acer/aspire_vn7_572g/mainboard.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/denverton_ns/include/soc/iomap.h M src/soc/intel/denverton_ns/include/soc/pm.h M src/soc/intel/denverton_ns/soc_util.c M src/soc/intel/skylake/pmc.c 9 files changed, 43 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/70050/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/70050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I473ebefcf8e0c929f6cbf6b5c0d7e8f5af72856d Gerrit-Change-Number: 70050 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: sb,soc/intel: Address TCO SECOND_TO_STS name collision
by Angel Pons (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Tarun Tuli, Sean Rhodes, Subrata Banik, Jonathan Zhang, Johnny Lin, Kapil Porwal, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70044 ) Change subject: sb,soc/intel: Address TCO SECOND_TO_STS name collision ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07cc46a9d600b2bf2f23588b26891268e9ce4de0 Gerrit-Change-Number: 70044 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 12:15:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: sb,soc/intel: Apply transitional flag TCO_SPACE_NOT_YET_SPLIT
by Angel Pons (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70043 ) Change subject: sb,soc/intel: Apply transitional flag TCO_SPACE_NOT_YET_SPLIT ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/soc/intel/broadwell/Kconfig: https://review.coreboot.org/c/coreboot/+/70043/comment/753a6102_4e4132a5 PS1, Line 15: select TCO_SPACE_NOT_YET_SPLIT This is redundant because it's also selected in `soc/intel/broadwell/pch/Kconfig` but it's most likely because you used some automatic script. But as this is a temporary Kconfig option, we don't care. -- To view, visit https://review.coreboot.org/c/coreboot/+/70043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I16213cdb13f98fccb261004b31e81a9a44cb6e3b Gerrit-Change-Number: 70043 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 12:14:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros"
by Angel Pons (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70042 ) Change subject: Revert "sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70042 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827558a0e0ef1c4d1f866756df51cd1b2abfc7a0 Gerrit-Change-Number: 70042 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 12:11:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: arch/x86: Add bitwise operations for IO space
by Angel Pons (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70041 ) Change subject: arch/x86: Add bitwise operations for IO space ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70041/comment/deb0f8b7_68151e71 PS1, Line 8: You could mention that: > One of the reasons to prefer `io_writeX()` over `outX()` is that the parameter ordering of the former is consistent with other write functions, e.g. MMIO. -- To view, visit https://review.coreboot.org/c/coreboot/+/70041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3e1146f062dced1b75195846ea65a44e2bd4482 Gerrit-Change-Number: 70041 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 27 Nov 2022 12:11:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: aopen/dxplplusu: Support SMM_ASEG and SMM_TSEG
by Angel Pons (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Kyösti Mälkki, Patrick Rudolph, Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61517 ) Change subject: aopen/dxplplusu: Support SMM_ASEG and SMM_TSEG ...................................................................... Patch Set 7: Code-Review+2 (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/61517/comment/ada0dab8_116866dc PS7, Line 13: > 'occuring' may be misspelled - perhaps 'occurring'? Please fix, it's line 11. File src/northbridge/intel/e7505/Kconfig: https://review.coreboot.org/c/coreboot/+/61517/comment/6570ae9f_5254c2b1 PS7, Line 13: #select SMM_ASEG Should this be selectable? File src/northbridge/intel/e7505/memmap.c: https://review.coreboot.org/c/coreboot/+/61517/comment/993a9802_c39e26f8 PS7, Line 42: return 512 *KiB; > need consistent spacing around '*' (ctx:WxV) Please fix. https://review.coreboot.org/c/coreboot/+/61517/comment/53060947_bbf29f58 PS7, Line 54: tolm -= northbridge_get_tseg_size(); Since most other places also use TSEG size, would it be a good idea to have a function that returns both values? Or make the `northbridge_get_tseg_base()` function take the size as parameter. File src/northbridge/intel/e7505/raminit.c: https://review.coreboot.org/c/coreboot/+/61517/comment/7b9cdbbb_0d1e42ad PS7, Line 1690: #define HOST_BRIDGE PCI_DEV(0, 0, 0) Other Intel northbridges have this define in a common header to avoid redundancy. Hmmm, maybe we should look into making SCONFIG generate these macros from devicetree aliases. -- To view, visit https://review.coreboot.org/c/coreboot/+/61517 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If20a7092117612a1a9e25eb6ac480e105acd57d7 Gerrit-Change-Number: 61517 Gerrit-PatchSet: 7 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 27 Nov 2022 12:08:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Use GitHub for downloading IASL
by Angel Pons (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Felix Singer, Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70021 ) Change subject: util/crossgcc/buildgcc: Use GitHub for downloading IASL ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 27 Nov 2022 10:45:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Use GitHub for downloading IASL
by Felix Singer (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Felix Singer, Elyes Haouas. Hello build bot (Jenkins), Angel Pons, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70021 to look at the new patch set (#7). Change subject: util/crossgcc/buildgcc: Use GitHub for downloading IASL ...................................................................... util/crossgcc/buildgcc: Use GitHub for downloading IASL The download links from acpica.org [1] are not stable, and for some reason they named the release tarballs with .tar_0.gz. Thus, use the tarballs from their GitHub repository generated out of the release tags [2]. Tested locally and also IASL patch applies. [1] https://www.acpica.org/downloads [2] https://github.com/acpica/acpica/tags Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-R10_20_22_iasl.patch A util/crossgcc/sum/R10_20_22.tar.gz.cksum D util/crossgcc/sum/acpica-unix2-20221020.tar.gz.cksum 4 files changed, 24 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/70021/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Use GitHub for downloading IASL
by Felix Singer (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), Angel Pons, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70021 to look at the new patch set (#6). Change subject: util/crossgcc/buildgcc: Use GitHub for downloading IASL ...................................................................... util/crossgcc/buildgcc: Use GitHub for downloading IASL The download links from acpica.org [1] are not stable, and for some reason they named the release tarballs with .tar_0.gz. Thus, use the tarballs from their GitHub repository generated out of the release tags [2]. Tested locally and also IASL patch applies. [1] https://www.acpica.org/downloads [2] https://github.com/acpica/acpica/tags Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-R10_20_22_iasl.patch A util/crossgcc/sum/R10_20_22.tar.gz.cksum D util/crossgcc/sum/acpica-unix2-20221020.tar.gz.cksum 4 files changed, 23 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/70021/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Use GitHub for downloading IASL
by Felix Singer (Code Review) 27 Nov '22

27 Nov '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), Angel Pons, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70021 to look at the new patch set (#5). Change subject: util/crossgcc/buildgcc: Use GitHub for downloading IASL ...................................................................... util/crossgcc/buildgcc: Use GitHub for downloading IASL The download links from acpica.org [1] are not stable, and for some reason they named the release tarballs with .tar_0.gz. Thus, use the tarballs from their GitHub repository generated out of the release tags. Tested locally and also IASL patch applies. [1] https://www.acpica.org/downloads Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-R10_20_22_iasl.patch A util/crossgcc/sum/R10_20_22.tar.gz.cksum D util/crossgcc/sum/acpica-unix2-20221020.tar.gz.cksum 4 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/70021/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022