coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: util/ifdtool/Makefile: improve cross-compilation support
by Michał Kotyla (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Maciej Pijanowski, Stefan Reinauer. Hello Maciej Pijanowski, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/70105 to review the following change. Change subject: util/ifdtool/Makefile: improve cross-compilation support ...................................................................... util/ifdtool/Makefile: improve cross-compilation support INSTALL and PREFIX variables will not be overwritten. Also, mkidir was replaced by a tool from the INSTALL variable to be compatible with other cross-compilation buildsystems (like Yocto) Signed-off-by: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Change-Id: Ia8dd67d18392e1e11d9160b187ef1a874d69ff5d --- M util/ifdtool/Makefile 1 file changed, 18 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/70105/1 diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index 83d19b8..c021069 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -2,9 +2,9 @@ # # SPDX-License-Identifier: GPL-2.0-only -CC ?= gcc -INSTALL = /usr/bin/env install -PREFIX = /usr/local +CC ?= gcc +INSTALL ?= /usr/bin/env install +PREFIX ?= /usr/local HOSTCC ?= $(CC) HOSTCFLAGS ?= $(CFLAGS) @@ -21,7 +21,7 @@ distclean: clean install: $(PROGRAM) - mkdir -p $(DESTDIR)$(PREFIX)/bin + $(INSTALL) -d $(DESTDIR)$(PREFIX)/bin $(INSTALL) $(PROGRAM) $(DESTDIR)$(PREFIX)/bin .PHONY: all clean distclean install -- To view, visit https://review.coreboot.org/c/coreboot/+/70105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8dd67d18392e1e11d9160b187ef1a874d69ff5d Gerrit-Change-Number: 70105 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/inteltool/Makefile : improve cross-compilation support
by Michał Kotyla (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: maciej.gabryelski(a)3mdeb.com, Stefan Reinauer. Hello maciej.gabryelski(a)3mdeb.com, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/70104 to review the following change. Change subject: util/inteltool/Makefile : improve cross-compilation support ...................................................................... util/inteltool/Makefile : improve cross-compilation support Use tool from INSTALL variable to create directory instead of mkdir to be compatible with other cross-compilation buildsystems (like Yocto) Signed-off-by: Maciej Gabryelski <maciej.gabryelski(a)3mdeb.com> Change-Id: I0b0949d07baae1ae1d7b22ac3d0b8913f81d89c1 --- M util/inteltool/Makefile 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/70104/1 diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile index 3b692fd..e6e122b 100644 --- a/util/inteltool/Makefile +++ b/util/inteltool/Makefile @@ -77,9 +77,9 @@ @rm -rf .test.c .test .test.dSYM install: $(PROGRAM) - mkdir -p $(DESTDIR)$(PREFIX)/sbin + $(INSTALL) -d $(DESTDIR)$(PREFIX)/sbin $(INSTALL) $(PROGRAM) $(DESTDIR)$(PREFIX)/sbin - mkdir -p $(DESTDIR)$(PREFIX)/share/man/man8 + $(INSTALL) -d $(DESTDIR)$(PREFIX)/share/man/man8 $(INSTALL) -p -m644 $(PROGRAM).8 $(DESTDIR)$(PREFIX)/share/man/man8 .PHONY: all clean distclean dep pciutils -- To view, visit https://review.coreboot.org/c/coreboot/+/70104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b0949d07baae1ae1d7b22ac3d0b8913f81d89c1 Gerrit-Change-Number: 70104 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/superiotool/Makefile : improve cross-compilation support
by Michał Kotyla (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: maciej.gabryelski(a)3mdeb.com, Felix Held. Hello maciej.gabryelski(a)3mdeb.com, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/70103 to review the following change. Change subject: util/superiotool/Makefile : improve cross-compilation support ...................................................................... util/superiotool/Makefile : improve cross-compilation support Use tool from INSTALL variable to create directory instead of mkdir to be compatible with other cross-compilation buildsystems (like Yocto) Signed-off-by: Maciej Gabryelski <maciej.gabryelski(a)3mdeb.com> Change-Id: I9d455f3d1a6d86c88b8e22da825fe14f9630e971 --- M util/superiotool/Makefile 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/70103/1 diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile index 21bd2bc..1f14d0b 100644 --- a/util/superiotool/Makefile +++ b/util/superiotool/Makefile @@ -54,9 +54,9 @@ $(CC) $(LDFLAGS) -o $(PROGRAM) $(OBJS) $(LIBS) install: $(PROGRAM) - mkdir -p $(DESTDIR)$(PREFIX)/sbin + $(INSTALL) -d $(DESTDIR)$(PREFIX)/sbin $(INSTALL) $(PROGRAM) $(DESTDIR)$(PREFIX)/sbin - mkdir -p $(DESTDIR)$(PREFIX)/share/man/man8 + $(INSTALL) -d $(DESTDIR)$(PREFIX)/share/man/man8 $(INSTALL) -p -m644 $(PROGRAM).8 $(DESTDIR)$(PREFIX)/share/man/man8 clean: -- To view, visit https://review.coreboot.org/c/coreboot/+/70103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d455f3d1a6d86c88b8e22da825fe14f9630e971 Gerrit-Change-Number: 70103 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/ectool/Makefile : improve cross-compilation support
by Michał Kotyla (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: maciej.gabryelski(a)3mdeb.com. Hello maciej.gabryelski(a)3mdeb.com, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/70102 to review the following change. Change subject: util/ectool/Makefile : improve cross-compilation support ...................................................................... util/ectool/Makefile : improve cross-compilation support Build variables like CC, INSTALL, PREFIX, and LDFLAGS should not be overwritten by the Makefile. This generates problems when we use different buildsystem like Yocto Signed-off-by: Maciej Gabryelski <maciej.gabryelski(a)3mdeb.com> Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b --- M util/ectool/Makefile 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/70102/1 diff --git a/util/ectool/Makefile b/util/ectool/Makefile index 8670def..27d3301 100644 --- a/util/ectool/Makefile +++ b/util/ectool/Makefile @@ -1,19 +1,19 @@ ## SPDX-License-Identifier: GPL-2.0-only -CC = gcc +CC ?= gcc WERROR=-Werror CFLAGS = -O2 -Wall -Wextra -Wshadow $(WERROR) PROGRAM = ectool -INSTALL = /usr/bin/env install -PREFIX = /usr/local +INSTALL ?= /usr/bin/env install +PREFIX ?= /usr/local OS_ARCH = $(shell uname) ifeq ($(shell uname -o 2>/dev/null), Cygwin) -LDFLAGS = -lioperm +LDFLAGS ?= -lioperm endif ifeq ($(OS_ARCH), $(filter $(OS_ARCH), NetBSD OpenBSD)) -LDFLAGS = -l$(shell uname -p) +LDFLAGS ?= -l$(shell uname -p) endif all: $(PROGRAM) -- To view, visit https://review.coreboot.org/c/coreboot/+/70102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b Gerrit-Change-Number: 70102 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: maciej.gabryelski(a)3mdeb.com Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: [do not merge] mb/prodrive/atlas: for testing
by Lean Sheng Tan (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Christian Walter, Angel Pons, Lean Sheng Tan. Hello build bot (Jenkins), Christian Walter, Maximilian Brune, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67415 to look at the new patch set (#12). Change subject: [do not merge] mb/prodrive/atlas: for testing ...................................................................... [do not merge] mb/prodrive/atlas: for testing Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I37c686aacea130c99e8ab2fe984b150a7ad6f82d --- M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/prodrive/atlas/devicetree.cb M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/atlas/romstage_fsp_params.c 4 files changed, 87 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/67415/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/67415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37c686aacea130c99e8ab2fe984b150a7ad6f82d Gerrit-Change-Number: 67415 Gerrit-PatchSet: 12 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/nissa/pujjo: Add new audio sku configure
by Leo Chou (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Reka Norman, Shou-Chieh Hsu. Hello Tarun Tuli, Reka Norman, Shou-Chieh Hsu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70131 to look at the new patch set (#2). Change subject: mb/google/nissa/pujjo: Add new audio sku configure ...................................................................... mb/google/nissa/pujjo: Add new audio sku configure Add new audio sku configure for Pujjo board. BUG=b:260538412 TEST=Boot to OS on pujjo and check that audio are configured based on fw_config. Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Ia9ddc683945002a0b19efd67006e1983b2eb9f2d --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/70131/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9ddc683945002a0b19efd67006e1983b2eb9f2d Gerrit-Change-Number: 70131 Gerrit-PatchSet: 2 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <Kevin3.Yang(a)lcfuturecenter.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/nissa/pujjo: Add new audio sku configure
by build bot (Jenkins) (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70131 ) Change subject: mb/google/nissa/pujjo: Add new audio sku configure ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164764): https://review.coreboot.org/c/coreboot/+/70131/comment/b02cf092_d671e19d PS1, Line 11: BUG=b:260538412 Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/70131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9ddc683945002a0b19efd67006e1983b2eb9f2d Gerrit-Change-Number: 70131 Gerrit-PatchSet: 1 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 11:15:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/pujjo: Add new audio sku configure
by Leo Chou (Code Review) 29 Nov '22

29 Nov '22

Leo Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70131 ) Change subject: mb/google/nissa/pujjo: Add new audio sku configure ...................................................................... mb/google/nissa/pujjo: Add new audio sku configure Add new audio sku configure for Pujjo board. BUG=b:260538412 TEST=Boot to OS on pujjo and check that audio are configured based on fw_config. Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Ia9ddc683945002a0b19efd67006e1983b2eb9f2d --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/70131/1 diff --git a/src/mainboard/google/brya/variants/pujjo/overridetree.cb b/src/mainboard/google/brya/variants/pujjo/overridetree.cb index e3d8acc..acba86e 100644 --- a/src/mainboard/google/brya/variants/pujjo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjo/overridetree.cb @@ -24,6 +24,7 @@ field AUDIO 12 14 option ALC1019_ALC5682IVS 0 option MAX98357_ALC5682I 1 + option MAX98357_ALC5682IVS 2 end field EXT_VR 15 option EXT_VR_PRESENT 0 @@ -480,6 +481,7 @@ register "property_list[0].integer" = "1" device i2c 1a on probe AUDIO ALC1019_ALC5682IVS + probe AUDIO MAX98357_ALC5682IVS end end chip drivers/generic/alc1015 @@ -516,6 +518,7 @@ register "sdmode_delay" = "5" device generic 0 on probe AUDIO MAX98357_ALC5682I + probe AUDIO MAX98357_ALC5682IVS end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/70131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9ddc683945002a0b19efd67006e1983b2eb9f2d Gerrit-Change-Number: 70131 Gerrit-PatchSet: 1 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/common: Update comment for cse_final_ready_to_boot()
by Sridhar Siricilla (Code Review) 29 Nov '22

29 Nov '22

Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70130 ) Change subject: soc/intel/common: Update comment for cse_final_ready_to_boot() ...................................................................... soc/intel/common: Update comment for cse_final_ready_to_boot() The patch updates the comment for cse_final_ready_to_boot() function to indicate generic implementation. TEST=Build the code for Gimble Change-Id: I8270927aaa0afad3a6779633792e316d803fb091 Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/70130/1 diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 2cb3452..b0dc896 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -1224,8 +1224,8 @@ } /* - * `cse_final_ready_to_boot` function is native implementation of equivalent events - * performed by FSP NotifyPhase(Ready To Boot) API invocations. + * `cse_final_ready_to_boot` function implements list of operations required to perform before + * loading the OS Loader or depthcharge. * * Operations are: * 1. Send EOP to CSE if not done. -- To view, visit https://review.coreboot.org/c/coreboot/+/70130 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8270927aaa0afad3a6779633792e316d803fb091 Gerrit-Change-Number: 70130 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: [do not merge] mb/prodrive/atlas: for testing
by Lean Sheng Tan (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Christian Walter, Angel Pons, Lean Sheng Tan. Hello build bot (Jenkins), Christian Walter, Maximilian Brune, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67415 to look at the new patch set (#10). Change subject: [do not merge] mb/prodrive/atlas: for testing ...................................................................... [do not merge] mb/prodrive/atlas: for testing Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I37c686aacea130c99e8ab2fe984b150a7ad6f82d --- M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/prodrive/atlas/devicetree.cb M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/atlas/romstage_fsp_params.c 4 files changed, 88 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/67415/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/67415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37c686aacea130c99e8ab2fe984b150a7ad6f82d Gerrit-Change-Number: 67415 Gerrit-PatchSet: 10 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022