coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
by Werner Zeh (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Arthur Heymans. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69510 ) Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/alderlake/acpi.c: https://review.coreboot.org/c/coreboot/+/69510/comment/f740c100_92cb8d10 PS4, Line 290: cpu_index Do you rely on cpu_index being implicit 0 here because it is static? Would it make sense to initialize it here? https://review.coreboot.org/c/coreboot/+/69510/comment/4f41140b_7f204a52 PS4, Line 298: ); Looks like a too long line!? -- To view, visit https://review.coreboot.org/c/coreboot/+/69510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c Gerrit-Change-Number: 69510 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 29 Nov 2022 09:22:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Kane Chen, Tim Wawrzynczak, Arthur Heymans. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64467 ) Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs ...................................................................... Patch Set 4: (1 comment) File src/cpu/x86/mtrr/mtrr.c: https://review.coreboot.org/c/coreboot/+/64467/comment/cb65a882_844ed9bb PS3, Line 358: lapicid > > i checked cpu_index function, there is loop inside to compare apic id. i feel it's too much. > > The apic_id here is to indicate what cpu is running the task, so i guess apic_id should be good enough? > > thanks > > CB:69509 changes that so it's fine. I agree with Arthur that, you can wait and land your CL on top of CB:69509 -- To view, visit https://review.coreboot.org/c/coreboot/+/64467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Gerrit-Change-Number: 64467 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 09:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
by Arthur Heymans (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Subrata Banik, Kane Chen, Tim Wawrzynczak. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64467 ) Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs ...................................................................... Patch Set 4: (1 comment) File src/cpu/x86/mtrr/mtrr.c: https://review.coreboot.org/c/coreboot/+/64467/comment/d51b4c92_8a1226d5 PS3, Line 358: lapicid > i checked cpu_index function, there is loop inside to compare apic id. i feel it's too much. > The apic_id here is to indicate what cpu is running the task, so i guess apic_id should be good enough? > thanks CB:69509 changes that so it's fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/64467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Gerrit-Change-Number: 64467 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 08:57:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
by Kane Chen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Subrata Banik, Kane Chen, Tim Wawrzynczak, Arthur Heymans. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64467 ) Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs ...................................................................... Patch Set 4: (2 comments) File src/cpu/x86/mtrr/mtrr.c: https://review.coreboot.org/c/coreboot/+/64467/comment/4435e0df_28a2fa42 PS3, Line 339: lapicid > Use a variable instead of calling this over and over... Done https://review.coreboot.org/c/coreboot/+/64467/comment/220efbc9_925780a9 PS3, Line 358: lapicid > why not calling into `cpu_index()` to know the CPU ID instead APIC ID, which would be difficult to k […] i checked cpu_index function, there is loop inside to compare apic id. i feel it's too much. The apic_id here is to indicate what cpu is running the task, so i guess apic_id should be good enough? thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/64467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Gerrit-Change-Number: 64467 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 29 Nov 2022 08:54:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
by Kane Chen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Kane Chen, Tim Wawrzynczak. Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Arthur Heymans, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64467 to look at the new patch set (#4). Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs ...................................................................... cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs MTRR setup will be assigned to all APs. It's hard to debug race condition without showing apic id. Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Signed-off-by: Kane Chen <kane.chen(a)intel.corp-partner.google.com> --- M src/cpu/x86/mtrr/mtrr.c 1 file changed, 20 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/64467/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/64467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Gerrit-Change-Number: 64467 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Rename method is_eom to is_manufacturing_mode
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Kapil Porwal, Paul Menzel, Rizwan Qureshi, Sridhar Siricilla, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69698 ) Change subject: soc/intel/meteorlake: Rename method is_eom to is_manufacturing_mode ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d2de3365126ba618c987c412c4e9784012f9e0b Gerrit-Change-Number: 69698 Gerrit-PatchSet: 5 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 08:39:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Log CSE RO write protection info for MTL
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69571 ) Change subject: soc/intel/meteorlake: Log CSE RO write protection info for MTL ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb072a873a8b8323532799f5fc64f995c9f0a604 Gerrit-Change-Number: 69571 Gerrit-PatchSet: 14 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 08:39:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add romstage and configure LP5 memory parts
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Ashish Kumar Mishra, Harsha B R, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar, Usha P. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69741 ) Change subject: mb/intel/mtlrvp: Add romstage and configure LP5 memory parts ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69741/comment/39d17f31_dea003f0 PS10, Line 13: FW_NAME=mtlrvp_p emerge-rex coreboot chromeos-bootimage Note: building the MTLRVP can't be a test statement, the purpose of the test is to ensure the code that you have added is actually meant to fix something or enable some feature. Adding a test statement like this would mean nothing IMO. -- To view, visit https://review.coreboot.org/c/coreboot/+/69741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15b352eb246aed23da273e56490c7094eae9d176 Gerrit-Change-Number: 69741 Gerrit-PatchSet: 10 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-CC: Harsha B R <harsha.b.r(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 08:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add romstage and configure LP5 memory parts
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Ashish Kumar Mishra, Harsha B R, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar, Usha P. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69741 ) Change subject: mb/intel/mtlrvp: Add romstage and configure LP5 memory parts ...................................................................... Patch Set 10: (1 comment) File src/mainboard/intel/mtlrvp/romstage_fsp_params.c: https://review.coreboot.org/c/coreboot/+/69741/comment/73028eed_7de79512 PS10, Line 23: spd_index = 1; https://github.com/coreboot/coreboot/blob/master/src/mainboard/intel/adlrvp… -- To view, visit https://review.coreboot.org/c/coreboot/+/69741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15b352eb246aed23da273e56490c7094eae9d176 Gerrit-Change-Number: 69741 Gerrit-PatchSet: 10 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-CC: Harsha B R <harsha.b.r(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 08:26:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cse: Allow to perform essential CSE operations post EOP
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Sridhar Siricilla, Angel Pons, Arthur Heymans, Eric Lai, Lean Sheng Tan. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69978 ) Change subject: soc/intel/cmn/cse: Allow to perform essential CSE operations post EOP ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/69978/comment/7bba2485_371865e3 PS5, Line 244: if (CONFIG(SOC_INTEL_CSE_SEND_EOP_LATE)) : cse_late_finalize(); > This code has to be decoupled or function name must be renamed to reflect new addition. Please suggest the name ? any suggestion ? Because of the below reasons, I haven't change the function name. - Unless SoC user selects SOC_INTEL_CSE_SEND_EOP_LATE, this function is still just sending the EOP alone. - If SoC user selects SOC_INTEL_CSE_SEND_EOP_LATE then this function additionally perform cse_late_finalize() (required post sending EOP) -- To view, visit https://review.coreboot.org/c/coreboot/+/69978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4c4564befcd38732368b21f1ca3e24b68c30e0c Gerrit-Change-Number: 69978 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 08:25:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022