coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
by Kyösti Mälkki (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Arthur Heymans, Werner Zeh. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69510 ) Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File src/soc/intel/alderlake/acpi.c: https://review.coreboot.org/c/coreboot/+/69510/comment/1e74815a_be80d78d PS6, Line 299: cpu_index++); How does this work for the 256th CPU? Mark resolved if not relevant question on alderlake. src/acpi/Kconfig:config ACPI_CPU_STRING src/acpi/Kconfig- string src/acpi/Kconfig- default "\\_SB.CP%02X" -- To view, visit https://review.coreboot.org/c/coreboot/+/69510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c Gerrit-Change-Number: 69510 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 10:00:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mtrr: Print cpu index number when set up MTRRs for BSP/APs
by Kane Chen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Kane Chen, Tim Wawrzynczak, Arthur Heymans. Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Arthur Heymans, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64467 to look at the new patch set (#6). Change subject: cpu/x86/mtrr: Print cpu index number when set up MTRRs for BSP/APs ...................................................................... cpu/x86/mtrr: Print cpu index number when set up MTRRs for BSP/APs MTRR setup will be assigned to all APs. It's hard to debug race condition without showing apic id. Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Signed-off-by: Kane Chen <kane.chen(a)intel.corp-partner.google.com> --- M src/cpu/x86/mtrr/mtrr.c 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/64467/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/64467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Gerrit-Change-Number: 64467 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common/block/graphics: Hook up all ADL-S IGD PCI IDs
by Michał Żygowski (Code Review) 29 Nov '22

29 Nov '22

Michał Żygowski has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/70101 ) Change subject: soc/intel/common/block/graphics: Hook up all ADL-S IGD PCI IDs ...................................................................... soc/intel/common/block/graphics: Hook up all ADL-S IGD PCI IDs Some users of MSI Z690-A board reported non-working IGD display during post using various CPUs. As not all PCI IDs were hooked, coreboot didn't detect GOP-provided framebuffer nor passed the framebuffer information to the payload, causing a black screen. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I07584e07182ee56b61b6f751100431589d1cbe83 --- M src/soc/intel/common/block/graphics/graphics.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/70101/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07584e07182ee56b61b6f751100431589d1cbe83 Gerrit-Change-Number: 70101 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common/block/graphics: Hook up all ADL-S IGD PCI IDs
by Michał Żygowski (Code Review) 29 Nov '22

29 Nov '22

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70101 ) Change subject: soc/intel/common/block/graphics: Hook up all ADL-S IGD PCI IDs ...................................................................... soc/intel/common/block/graphics: Hook up all ADL-S IGD PCI IDs Some users of MSI Z690-A baord reported non-working IGD display during post using various CPUs. As not all PCI IDs were hooked, coreboot didn't detect GOP provided framebuffer nor passed the framebuffer information to the payload, causing a black screen. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I07584e07182ee56b61b6f751100431589d1cbe83 --- M src/soc/intel/common/block/graphics/graphics.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/70101/1 diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c index dae181a..7093dd8 100644 --- a/src/soc/intel/common/block/graphics/graphics.c +++ b/src/soc/intel/common/block/graphics/graphics.c @@ -306,6 +306,10 @@ PCI_DID_INTEL_ADL_P_GT2_8, PCI_DID_INTEL_ADL_P_GT2_9, PCI_DID_INTEL_ADL_S_GT1, + PCI_DID_INTEL_ADL_S_GT1_1, + PCI_DID_INTEL_ADL_S_GT2, + PCI_DID_INTEL_ADL_S_GT2_1, + PCI_DID_INTEL_ADL_S_GT2_2, PCI_DID_INTEL_ADL_M_GT1, PCI_DID_INTEL_ADL_M_GT2, PCI_DID_INTEL_ADL_M_GT3, -- To view, visit https://review.coreboot.org/c/coreboot/+/70101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07584e07182ee56b61b6f751100431589d1cbe83 Gerrit-Change-Number: 70101 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
by Paul Menzel (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Kane Chen, Tim Wawrzynczak, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64467 ) Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/64467/comment/507de10f_712f5ce1 PS5, Line 7: in What does “in” refer to? -- To view, visit https://review.coreboot.org/c/coreboot/+/64467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Gerrit-Change-Number: 64467 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 09:49:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
by Kane Chen (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Kane Chen, Tim Wawrzynczak, Arthur Heymans. Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Arthur Heymans, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64467 to look at the new patch set (#5). Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs ...................................................................... cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs MTRR setup will be assigned to all APs. It's hard to debug race condition without showing apic id. Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Signed-off-by: Kane Chen <kane.chen(a)intel.corp-partner.google.com> --- M src/cpu/x86/mtrr/mtrr.c 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/64467/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/64467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1 Gerrit-Change-Number: 64467 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
by Arthur Heymans (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Werner Zeh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69510 ) Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/alderlake/acpi.c: https://review.coreboot.org/c/coreboot/+/69510/comment/60a88ce6_854d7606 PS4, Line 290: cpu_index > Done Moved it outside the loop to make it more clear what the intend is. -- To view, visit https://review.coreboot.org/c/coreboot/+/69510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c Gerrit-Change-Number: 69510 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 09:27:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
by Arthur Heymans (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Werner Zeh. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69510 to look at the new patch set (#6). Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index ...................................................................... soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index The coreboot CPU index for a lapic is arbitrary: it depends on which CPU obtains a spinlock first. Simply using an increasing index will result in consistent ACPI tables across each boot. Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/alderlake/acpi.c 1 file changed, 17 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/69510/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/69510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c Gerrit-Change-Number: 69510 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
by Arthur Heymans (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Werner Zeh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69510 ) Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/alderlake/acpi.c: https://review.coreboot.org/c/coreboot/+/69510/comment/66944d13_84902f40 PS4, Line 290: cpu_index > Do you rely on cpu_index being implicit 0 here because it is static? Would it make sense to initiali […] Done https://review.coreboot.org/c/coreboot/+/69510/comment/b7a94b2c_04e6d38f PS4, Line 298: ); > Looks like a too long line!? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c Gerrit-Change-Number: 69510 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 09:27:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
by Arthur Heymans (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Arthur Heymans. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69510 to look at the new patch set (#5). Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index ...................................................................... soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index The coreboot CPU index for a lapic is arbitrary: it depends on which CPU obtains a spinlock first. Simply using an increasing index will result in consistent ACPI tables across each boot. Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/alderlake/acpi.c 1 file changed, 17 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/69510/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/69510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c Gerrit-Change-Number: 69510 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022