coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: console/printk.c: Add <types.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68037 ) Change subject: console/printk.c: Add <types.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55412395071f0fccb839c40fefda998befaddebb Gerrit-Change-Number: 68037 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:11:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: console/vsprintf.c: Add <stdarg.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68038 ) Change subject: console/vsprintf.c: Add <stdarg.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68038 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c61f2a033f9630d3fa3eb5e364e6f38de5c7064 Gerrit-Change-Number: 68038 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:11:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: console/vtxprintf.c: Add <stdarg.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68039 ) Change subject: console/vtxprintf.c: Add <stdarg.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I221a2bdb19cc7d17265c69d3fe3e1dfb490e7186 Gerrit-Change-Number: 68039 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:11:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/intel/car/romstage.c: Clean up includes and add <types.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68040 ) Change subject: cpu/intel/car/romstage.c: Clean up includes and add <types.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84639389ac1066468b82bb13d684e5423b909fcb Gerrit-Change-Number: 68040 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:10:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/intel/common/fsb.c: Sorte includes and add <stdint.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68041 ) Change subject: cpu/intel/common/fsb.c: Sorte includes and add <stdint.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b85836ac21da5b885a97f05e3973fb23a052fd5 Gerrit-Change-Number: 68041 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:10:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/pae/pgtbl.c: Clean up includes and add <types.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68042 ) Change subject: cpu/x86/pae/pgtbl.c: Clean up includes and add <types.h> ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68042 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ab39ff20b0fb59026063e064e20ce901c2985fe Gerrit-Change-Number: 68042 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:05:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: device/device_const.c: Clean up includes and add <types.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68043 ) Change subject: device/device_const.c: Clean up includes and add <types.h> ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e84760566db5da7ff88dcbe9fb028ebcb390bdc Gerrit-Change-Number: 68043 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:05:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/i945/raminit.c: Clean up includes and add <types.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68044 ) Change subject: nb/intel/i945/raminit.c: Clean up includes and add <types.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94a81a30950cca6be5ba36a25f8bc6f87c2aad2f Gerrit-Change-Number: 68044 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:05:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Żygowski, Piotr Król. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 ) Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... Patch Set 7: Code-Review+1 (22 comments) File Documentation/mainboard/protectli/vp46xx.md: https://review.coreboot.org/c/coreboot/+/67940/comment/b800d3bf_92a5c8c4 PS7, Line 68: - Super I/O serial port 0 via front microUSB connector Does the board have an onboard USB-to-UART adapter? Wow. https://review.coreboot.org/c/coreboot/+/67940/comment/12e68ec1_d9c7e01a PS7, Line 90: ITE IT8786E/IT8784E Are the two chips equivalent, or is there a reason for a board to have one or the other? File src/mainboard/protectli/vault_cml/Kconfig: https://review.coreboot.org/c/coreboot/+/67940/comment/e3fa202f_54ded488 PS7, Line 13: select SOC_INTEL_COMMON_BLOCK_HDA Already selected by SoC Kconfig https://review.coreboot.org/c/coreboot/+/67940/comment/f5cc87f1_a25580f7 PS7, Line 22: config MAINBOARD_DIR : string : default "protectli/vault_cml" : : config MAINBOARD_PART_NUMBER : string : default "VP46XX" : : config MAINBOARD_FAMILY : string : default "Vault Pro" Specifying the `string` type shouldn't be needed, please drop https://review.coreboot.org/c/coreboot/+/67940/comment/7f86bf99_7b37099b PS7, Line 35: int Please drop `int` type as per CB:57258 https://review.coreboot.org/c/coreboot/+/67940/comment/02a27695_bfd40780 PS7, Line 38: config MAX_CPUS : int : default 12 Should already be the default for CML-U https://review.coreboot.org/c/coreboot/+/67940/comment/7fefb8d5_caaafac4 PS7, Line 42: config DEVICETREE : string : default "devicetree.cb" Leftover from variants? Please drop, it's redundant. File src/mainboard/protectli/vault_cml/cmos.layout: https://review.coreboot.org/c/coreboot/+/67940/comment/d0e1d591_269cc386 PS7, Line 13: 416 128 r 0 vbnv There are plans to deprecate support for VBNV in CMOS in favor of VBNV in flash, see mailing list. File src/mainboard/protectli/vault_cml/devicetree.cb: https://review.coreboot.org/c/coreboot/+/67940/comment/f9d1c417_7ad59070 PS7, Line 21: register "ScsSdCardWpPinEnabled" = "0" All "register" settings with a value of 0 can be omitted. https://review.coreboot.org/c/coreboot/+/67940/comment/228cb2b3_3c931fd9 PS7, Line 58: # Enable SERIRQ continous > 'continous' may be misspelled - perhaps 'continuous'? Please fix. https://review.coreboot.org/c/coreboot/+/67940/comment/b45059eb_d74b8913 PS7, Line 165: nit: remove one blank line https://review.coreboot.org/c/coreboot/+/67940/comment/ef14de98_8f1afe46 PS7, Line 181: # Lock Down : register "common_soc_config" = "{ : .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, : }" Please drop, `CHIPSET_LOCKDOWN_COREBOOT` is zero, and lockdown by FSP cannot be supported. https://review.coreboot.org/c/coreboot/+/67940/comment/6bcbe799_88e76388 PS7, Line 228: "M.2/E 2230 (M2_WIFI2)" "SlotDataBusWidth1X" nit: add an extra tab for visual alignment, `smbios_slot_desc ` is exactly 16 characters wide. https://review.coreboot.org/c/coreboot/+/67940/comment/63852962_cf9a15a1 PS7, Line 269: device pnp 2e.4 on # Enviroment Controller > 'Enviroment' may be misspelled - perhaps 'Environment'? Please fix. While at it, use tabs so that the LDN comments are aligned? https://review.coreboot.org/c/coreboot/+/67940/comment/3574c025_ffddf9c6 PS7, Line 287: device pci 1f.1 on end # P2SB : device pci 1f.2 on end # Power Management Controller AFAIK the P2SB should be disabled (it's not a "discoverable PCI device") and the PMC should be hidden. https://review.coreboot.org/c/coreboot/+/67940/comment/10bc0292_490ef2bc PS7, Line 291: off Please enable this so that the allocator can properly allocate resources for the "fast" SPI controller. File src/mainboard/protectli/vault_cml/dsdt.asl: https://review.coreboot.org/c/coreboot/+/67940/comment/65e8347a_6e9a63d3 PS7, Line 10: // OEM revision Is this comment true, or is it copy-pasta? File src/mainboard/protectli/vault_cml/mainboard.c: https://review.coreboot.org/c/coreboot/+/67940/comment/774dabd1_09c67c6b PS7, Line 53: | Please add spaces around `|` https://review.coreboot.org/c/coreboot/+/67940/comment/684fd96d_717b3642 PS7, Line 62: milioseconds nit: *milli*seconds Also, why not use a delay function? https://review.coreboot.org/c/coreboot/+/67940/comment/3fb1b68f_1ee71df7 PS7, Line 64: for (i = 0; i < 10000; i++) inb(0x61); > trailing statements should be on next line Please fix. https://review.coreboot.org/c/coreboot/+/67940/comment/4bb10fdc_67575d64 PS7, Line 72: beep(1500); It would be nice to make this optional as it slows down the boot process a bit. It's just a matter of adding a Kconfig option. While at it, it would be interesting to use this to beep on death, by implementing `die_notify()`. Feel free to use CB:50013 as inspiration. https://review.coreboot.org/c/coreboot/+/67940/comment/d7f8ffca_56836ae9 PS7, Line 78: * when the screen goes blank/inactive/idle in the OS */ Interesting issue. Do you have plans to address this now, or can this board port be submitted with this workaround? -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:04:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/i945/rcven.c: Sort includes and add <types.h>
by Martin L Roth (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Paul Menzel, Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68045 ) Change subject: nb/intel/i945/rcven.c: Sort includes and add <types.h> ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I360e4f8ed3b87225a09c7cbb761c570a579771cf Gerrit-Change-Number: 68045 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:04:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022