coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: Documentation/releases: Add details about edk2 updates
by Nicholas Chin (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Sean Rhodes, Matt DeVillier, Lean Sheng Tan. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66440 ) Change subject: Documentation/releases: Add details about edk2 updates ...................................................................... Patch Set 10: (1 comment) File Documentation/releases/coreboot-4.18-relnotes.md: https://review.coreboot.org/c/coreboot/+/66440/comment/bbb4ed01_b8767014 PS10, Line 27: 8th 7th? -- To view, visit https://review.coreboot.org/c/coreboot/+/66440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592f0ee971737ef271d1df9142551eb24b775a06 Gerrit-Change-Number: 66440 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:46:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/smbios.c: Fix Upgrade processor information in SMBIOS
by Elyes Haouas (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Zhixing Ma, Bora Guvendik, Jérémy Compostella, Nick Vaccaro. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68024 ) Change subject: arch/x86/smbios.c: Fix Upgrade processor information in SMBIOS ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/68024/comment/72d4a15c_0778f15b PS1, Line 391: SOC_INTEL_ALDERLAKE) > SOC_INTEL_RAPTORLAKE config flag also selects SOC_INTEL_ALDERLAKE config flag since both SoCs use th […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5796d31fa2d31b17afa5eddde0799b0f68d69909 Gerrit-Change-Number: 68024 Gerrit-PatchSet: 2 Gerrit-Owner: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:35:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Zhixing Ma <zhixing.ma(a)intel.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/intel/mtlrvp: Enable EC and building ChromeOS
by Jamie Ryu (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Paul Menzel, Kapil Porwal, Angel Pons, Nick Vaccaro, Tim Wawrzynczak, Raj Astekar. Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66101 ) Change subject: mb/intel/mtlrvp: Enable EC and building ChromeOS ...................................................................... Patch Set 8: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/66101/comment/661ae524_aba51cc5 PS4, Line 9: add > adds Thanks for the comments. This is updated by patchset#5. File src/mainboard/intel/mtlrvp/Kconfig: https://review.coreboot.org/c/coreboot/+/66101/comment/5027fd40_37d2650a PS4, Line 45: default MTL_EC_DETECT > Hmmm, `MTL_CHROME_EC` and `MTL_INTEL_EC` can be chosen manually, as they're part of a choice block. I tried the override from config file, the config override works as intended and choose the EC config by the config file. Is there anything missing from the current implmentation? https://review.coreboot.org/c/coreboot/+/66101/comment/1b2dd4dc_5c138b06 PS4, Line 58: > remove one extra line removed the extra line. thanks. File src/mainboard/intel/mtlrvp/dsdt.asl: https://review.coreboot.org/c/coreboot/+/66101/comment/e6fce256_488a36a7 PS4, Line 32: Chrome OS > ChromeOS Thanks. I removed the comments as it looks the description is redundant. -- To view, visit https://review.coreboot.org/c/coreboot/+/66101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I662d7f79050d35e152d97dc5c2118a4af56223bc Gerrit-Change-Number: 66101 Gerrit-PatchSet: 8 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:29:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/smbios.c: Fix Upgrade processor information in SMBIOS
by Zhixing Ma (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Bora Guvendik, Jérémy Compostella, Nick Vaccaro, Elyes Haouas. Zhixing Ma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68024 ) Change subject: arch/x86/smbios.c: Fix Upgrade processor information in SMBIOS ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68024/comment/fa226e3e_abbe2f03 PS1, Line 7: soc/intel/alderlake: Fix unknown upgrade in SMBIOS > arch/x86/smbios. […] Done File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/68024/comment/5bd028fc_e5f87f66 PS1, Line 391: SOC_INTEL_ALDERLAKE) > and SOC_INTEL_RAPTORLAKE ? SOC_INTEL_RAPTORLAKE config flag also selects SOC_INTEL_ALDERLAKE config flag since both SoCs use the same socket, so this one flag covers both SoCs. -- To view, visit https://review.coreboot.org/c/coreboot/+/68024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5796d31fa2d31b17afa5eddde0799b0f68d69909 Gerrit-Change-Number: 68024 Gerrit-PatchSet: 2 Gerrit-Owner: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:02:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/smbios.c: Fix Upgrade processor information in SMBIOS
by Zhixing Ma (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Zhixing Ma, Bora Guvendik, Jérémy Compostella, Nick Vaccaro. Hello Bora Guvendik, build bot (Jenkins), Jérémy Compostella, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68024 to look at the new patch set (#2). Change subject: arch/x86/smbios.c: Fix Upgrade processor information in SMBIOS ...................................................................... arch/x86/smbios.c: Fix Upgrade processor information in SMBIOS The current SMBIOS for coreboot is missing processor info for Alder Lake and Raptor Lake SoC, specifically, voltage, max speed, and upgrade (socket type). This patch implements upgrade function. Refer to SMBIOS spec sheet for documentation on cpu socket values: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.6.0.… BUG=NONE BRANCH=firmware-brya-14505.B TEST=Boot and verified that SMBIOS processor upgrade value is correct. Signed-off-by: Zhixing Ma <zhixing.ma(a)intel.com> Change-Id: I5796d31fa2d31b17afa5eddde0799b0f68d69909 --- M src/arch/x86/smbios.c 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/68024/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5796d31fa2d31b17afa5eddde0799b0f68d69909 Gerrit-Change-Number: 68024 Gerrit-PatchSet: 2 Gerrit-Owner: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: Documentation: document the new smbus console feature
by 9elements QA (Code Review) 03 Oct '22

03 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67386 ) Change subject: Documentation: document the new smbus console feature ...................................................................... Patch Set 13: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/125740 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/125739 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/125738 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/125737 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/125736 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/125735 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/125734 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/125733 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/125732 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/125731 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/125730 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/125729 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/125728 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/125727 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/125726 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/125725 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/67386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50cafbbaaea133c9ea50131e455151287c96176a Gerrit-Change-Number: 67386 Gerrit-PatchSet: 13 Gerrit-Owner: Ahamed Husni <ahamedhusni73(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 17:29:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/crb: Initialize Intel PTT control area
by Krystian Hebel (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Żygowski, Paul Menzel, Angel Pons, Arthur Heymans. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63957 ) Change subject: drivers/crb: Initialize Intel PTT control area ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8e473ecc1a520851d6d48ccad9da35c6f91005d Gerrit-Change-Number: 63957 Gerrit-PatchSet: 15 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 03 Oct 2022 17:21:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int'
by Elyes Haouas (Code Review) 03 Oct '22

03 Oct '22

Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61802 ) Change subject: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int' ...................................................................... Patch Set 5: (2 comments) File src/northbridge/intel/i945/rcven.c: https://review.coreboot.org/c/coreboot/+/61802/comment/eea52796_62de0250 PS5, Line 196: printk(BIOS_DEBUG, "Could not find low strobe\n"); : return 0 return -1;? https://review.coreboot.org/c/coreboot/+/61802/comment/240848e5_80739d5a PS5, Line 106: mchbar_write8(C0WL0REOST + channel_offset, *fine) C{0,1}WL1REOST, C{0,1}WL2REOST and C{0,1}WL3REOST are missing ? -- To view, visit https://review.coreboot.org/c/coreboot/+/61802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8f5e92fec20fe9a9c9b8615c40fc3e7378d3513 Gerrit-Change-Number: 61802 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 17:14:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/variant/brya0: Add power limits for RPL SoC
by Nick Vaccaro (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Bora Guvendik, Tarun Tuli, Subrata Banik, Tim Wawrzynczak. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67880 ) Change subject: mb/google/brya/variant/brya0: Add power limits for RPL SoC ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Ping... -- To view, visit https://review.coreboot.org/c/coreboot/+/67880 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ac067f98f1ff8f86cff0ed0e15010f454d9c91c Gerrit-Change-Number: 67880 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:38:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/skolas: sync brya0 and skolas FW_CONFIG
by build bot (Jenkins) (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Varshit Pandya, Noga Smith, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, AlanKY Lee. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67929 ) Change subject: mb/google/brya/var/skolas: sync brya0 and skolas FW_CONFIG ...................................................................... Patch Set 4: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159606): https://review.coreboot.org/c/coreboot/+/67929/comment/8c92261c_743d50aa PS4, Line 8: 'defintions' may be misspelled - perhaps 'definitions'? -- To view, visit https://review.coreboot.org/c/coreboot/+/67929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3be26e0a05f4dc08e5dc3f6ef7b71bdd8fd4f859 Gerrit-Change-Number: 67929 Gerrit-PatchSet: 4 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Noga Smith <nogasmith(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Noga Smith <nogasmith(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 16:37:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022