coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: soc/intel/cmn/gfx: Add missing CML-U IGD device IDs
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67975 ) Change subject: soc/intel/cmn/gfx: Add missing CML-U IGD device IDs ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67975/comment/ff280ea8_80cb6827 PS4, Line 11: ID > nit: IDs Done https://review.coreboot.org/c/coreboot/+/67975/comment/2117c9fa_3e280df0 PS4, Line 16: 1021U > typo: 1021*0*U Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee720a272367aead31c8c8fa712bade1b6e53948 Gerrit-Change-Number: 67975 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Oct 2022 07:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold: Enable DPTC support for Winterhold
by EricKY Cheng (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Jason Nein, Martin Roth, Eric Peers, Moises Garcia, Karthikeyan Ramasubramanian. Hello build bot (Jenkins), Raul Rangel, Jason Nien, Jason Nein, Martin Roth, Tim Van Patten, Eric Peers, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Moises Garcia, Karthikeyan Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68076 to look at the new patch set (#3). Change subject: mb/google/skyrim/var/winterhold: Enable DPTC support for Winterhold ...................................................................... mb/google/skyrim/var/winterhold: Enable DPTC support for Winterhold Enable DPTC support for Winterhold BUG=b:232946420 TEST=emerge-skyrim coreboot Signed-off-by: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Change-Id: I97c2d3ee29687cd8a9c459e90a45cef05ac4436b --- M src/mainboard/google/skyrim/Kconfig.name 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/68076/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97c2d3ee29687cd8a9c459e90a45cef05ac4436b Gerrit-Change-Number: 68076 Gerrit-PatchSet: 3 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nein <finaljason(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Jason Nein <finaljason(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Angel Pons, Piotr Król. Hello build bot (Jenkins), Angel Pons, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67940 to look at the new patch set (#10). Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... mb/protectli/vault_cml: Add Comet Lake 6 port board support Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b --- M Documentation/mainboard/index.md A Documentation/mainboard/protectli/vp46xx.md A Documentation/mainboard/protectli/vp46xx_back.jpg A Documentation/mainboard/protectli/vp46xx_flash.jpg A Documentation/mainboard/protectli/vp46xx_front.jpg A src/mainboard/protectli/vault_cml/Kconfig A src/mainboard/protectli/vault_cml/Kconfig.name A src/mainboard/protectli/vault_cml/Makefile.inc A src/mainboard/protectli/vault_cml/acpi/ec.asl A src/mainboard/protectli/vault_cml/acpi/superio.asl A src/mainboard/protectli/vault_cml/board.fmd A src/mainboard/protectli/vault_cml/board_info.txt A src/mainboard/protectli/vault_cml/bootblock.c A src/mainboard/protectli/vault_cml/cmos.default A src/mainboard/protectli/vault_cml/cmos.layout A src/mainboard/protectli/vault_cml/data.vbt A src/mainboard/protectli/vault_cml/devicetree.cb A src/mainboard/protectli/vault_cml/dsdt.asl A src/mainboard/protectli/vault_cml/gma-mainboard.ads A src/mainboard/protectli/vault_cml/gpio.c A src/mainboard/protectli/vault_cml/gpio.h A src/mainboard/protectli/vault_cml/hda_verb.c A src/mainboard/protectli/vault_cml/mainboard.c A src/mainboard/protectli/vault_cml/romstage.c A src/mainboard/protectli/vault_cml/vboot-rwa.fmd 25 files changed, 1,283 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/67940/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 10 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Angel Pons, Piotr Król. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 ) Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... Patch Set 9: (21 comments) File Documentation/mainboard/protectli/vp46xx.md: https://review.coreboot.org/c/coreboot/+/67940/comment/d119b501_51461386 PS7, Line 68: - Super I/O serial port 0 via front microUSB connector > Does the board have an onboard USB-to-UART adapter? Wow. Yes, it does. Fintek F81232. https://review.coreboot.org/c/coreboot/+/67940/comment/27b517cc_27fb9eeb PS7, Line 90: ITE IT8786E/IT8784E > Are the two chips equivalent, or is there a reason for a board to have one or the other? The configuration of the registers is the same when compared with the IT8786E datasheet. Although I don't know the differences, since there is no IT8784E public datasheet. not the first time we see such a trick, that suddenly some units have different Super I/O chip, fortunately, this time the change is compatible. File src/mainboard/protectli/vault_cml/Kconfig: https://review.coreboot.org/c/coreboot/+/67940/comment/03d42414_cf9051c2 PS7, Line 13: select SOC_INTEL_COMMON_BLOCK_HDA > Already selected by SoC Kconfig Done https://review.coreboot.org/c/coreboot/+/67940/comment/dd54b01b_03eec644 PS7, Line 22: config MAINBOARD_DIR : string : default "protectli/vault_cml" : : config MAINBOARD_PART_NUMBER : string : default "VP46XX" : : config MAINBOARD_FAMILY : string : default "Vault Pro" > Specifying the `string` type shouldn't be needed, please drop Done https://review.coreboot.org/c/coreboot/+/67940/comment/1c6a30ea_6400a5fe PS7, Line 35: int > Please drop `int` type as per CB:57258 Done https://review.coreboot.org/c/coreboot/+/67940/comment/b3fcd48a_756bb4e7 PS7, Line 38: config MAX_CPUS : int : default 12 > Should already be the default for CML-U Done https://review.coreboot.org/c/coreboot/+/67940/comment/57d0888a_0df0a1db PS7, Line 42: config DEVICETREE : string : default "devicetree.cb" > Leftover from variants? Please drop, it's redundant. Done File src/mainboard/protectli/vault_cml/cmos.layout: https://review.coreboot.org/c/coreboot/+/67940/comment/66324866_34861c9a PS7, Line 13: 416 128 r 0 vbnv > There are plans to deprecate support for VBNV in CMOS in favor of VBNV in flash, see mailing list. Removed. File src/mainboard/protectli/vault_cml/devicetree.cb: https://review.coreboot.org/c/coreboot/+/67940/comment/c95e2ffc_5e04310d PS7, Line 21: register "ScsSdCardWpPinEnabled" = "0" > All "register" settings with a value of 0 can be omitted. Done https://review.coreboot.org/c/coreboot/+/67940/comment/64da9aab_9c996ec0 PS7, Line 58: # Enable SERIRQ continous > > 'continous' may be misspelled - perhaps 'continuous'? […] Done https://review.coreboot.org/c/coreboot/+/67940/comment/3dfba3d0_f7746c1c PS7, Line 165: > nit: remove one blank line Done https://review.coreboot.org/c/coreboot/+/67940/comment/e16b5117_a2203313 PS7, Line 181: # Lock Down : register "common_soc_config" = "{ : .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, : }" > Please drop, `CHIPSET_LOCKDOWN_COREBOOT` is zero, and lockdown by FSP cannot be supported. Done https://review.coreboot.org/c/coreboot/+/67940/comment/1b994e80_353819d4 PS7, Line 269: device pnp 2e.4 on # Enviroment Controller > > 'Enviroment' may be misspelled - perhaps 'Environment'? […] Done https://review.coreboot.org/c/coreboot/+/67940/comment/c09135c1_b309bf22 PS7, Line 287: device pci 1f.1 on end # P2SB : device pci 1f.2 on end # Power Management Controller > AFAIK the P2SB should be disabled (it's not a "discoverable PCI device") and the PMC should be hidde […] Many boards keep it enabled. Skylake even unhides the device on purpose to let coreboot PCI enumerator read its resources. Is there a strong reason to not have it set to ON? Maybe hidden makes sense here? https://review.coreboot.org/c/coreboot/+/67940/comment/cb00d4c6_3dbb1e3c PS7, Line 291: off > Please enable this so that the allocator can properly allocate resources for the "fast" SPI controll […] Done File src/mainboard/protectli/vault_cml/dsdt.asl: https://review.coreboot.org/c/coreboot/+/67940/comment/d5959881_53fb3d65 PS7, Line 10: // OEM revision > Is this comment true, or is it copy-pasta? copy-pasta, removed File src/mainboard/protectli/vault_cml/mainboard.c: https://review.coreboot.org/c/coreboot/+/67940/comment/3bcba4e9_fddbbf63 PS7, Line 53: | > Please add spaces around `|` Done https://review.coreboot.org/c/coreboot/+/67940/comment/a533ff51_b8e9395f PS7, Line 62: milioseconds > nit: *milli*seconds […] Done https://review.coreboot.org/c/coreboot/+/67940/comment/8ca273aa_765ec8ac PS7, Line 64: for (i = 0; i < 10000; i++) inb(0x61); > > trailing statements should be on next line […] Done https://review.coreboot.org/c/coreboot/+/67940/comment/1ae07786_7f9ef13f PS7, Line 72: beep(1500); > It would be nice to make this optional as it slows down the boot process a bit. […] Cool, thanks! https://review.coreboot.org/c/coreboot/+/67940/comment/08ffe201_f0ba38c0 PS7, Line 78: * when the screen goes blank/inactive/idle in the OS */ > Interesting issue. […] I am still checking if the newer revisions of the boards still reproduce it. This code is already pretty old TBH, but the final hardware revision was delayed very much. The first revisions could have problems with the graphics or due to operating systems not properly supporting the IGD back then in i915 driver. -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 06:55:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Michał Żygowski, Piotr Król. Hello build bot (Jenkins), Angel Pons, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67940 to look at the new patch set (#9). Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... mb/protectli/vault_cml: Add Comet Lake 6 port board support Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b --- M Documentation/mainboard/index.md A Documentation/mainboard/protectli/vp46xx.md A Documentation/mainboard/protectli/vp46xx_back.jpg A Documentation/mainboard/protectli/vp46xx_flash.jpg A Documentation/mainboard/protectli/vp46xx_front.jpg A src/mainboard/protectli/vault_cml/Kconfig A src/mainboard/protectli/vault_cml/Kconfig.name A src/mainboard/protectli/vault_cml/Makefile.inc A src/mainboard/protectli/vault_cml/acpi/ec.asl A src/mainboard/protectli/vault_cml/acpi/superio.asl A src/mainboard/protectli/vault_cml/board.fmd A src/mainboard/protectli/vault_cml/board_info.txt A src/mainboard/protectli/vault_cml/bootblock.c A src/mainboard/protectli/vault_cml/cmos.default A src/mainboard/protectli/vault_cml/cmos.layout A src/mainboard/protectli/vault_cml/data.vbt A src/mainboard/protectli/vault_cml/devicetree.cb A src/mainboard/protectli/vault_cml/dsdt.asl A src/mainboard/protectli/vault_cml/gma-mainboard.ads A src/mainboard/protectli/vault_cml/gpio.c A src/mainboard/protectli/vault_cml/gpio.h A src/mainboard/protectli/vault_cml/hda_verb.c A src/mainboard/protectli/vault_cml/mainboard.c A src/mainboard/protectli/vault_cml/romstage.c A src/mainboard/protectli/vault_cml/vboot-rwa.fmd 25 files changed, 1,280 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/67940/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 9 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: Documentation/drivers/cbfs_smbios.md: Describe CBFS serial number
by build bot (Jenkins) (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Paul Menzel, Angel Pons, Krystian Hebel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65702 ) Change subject: Documentation/drivers/cbfs_smbios.md: Describe CBFS serial number ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/65702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f0963417c7c580f903922ac88c95569c8782bdb Gerrit-Change-Number: 65702 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 06:42:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Paul Menzel, Angel Pons, Krystian Hebel. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64639 ) Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS ...................................................................... Patch Set 11: (2 comments) File Documentation/drivers/cbfs_smbios.md: https://review.coreboot.org/c/coreboot/+/64639/comment/7712f660_56b00ef0 PS10, Line 60: 2 > `up to 2` Done File src/drivers/generic/cbfs-uuid/cbfs-uuid.c: https://review.coreboot.org/c/coreboot/+/64639/comment/b3ead1df_2bfdd728 PS10, Line 18: obsolete > I'd replace "all obsolete characters" with "any trailing whitespace". […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf Gerrit-Change-Number: 64639 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 06:41:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Michał Żygowski, Paul Menzel, Krystian Hebel. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64639 to look at the new patch set (#11). Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS ...................................................................... drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS When system_uuid CBFS file is present and contains the UUID in a string format, the driver will parse it and convert to binary format to populate the SMBIOS type 1 UUID field. TEST=Add UUID file and boot MSI PRO Z690-A DDR4 WIFI and check with dmidecode if the UUID is populated correctly. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf --- A Documentation/drivers/cbfs_smbios.md M Documentation/drivers/index.md A src/drivers/generic/cbfs-uuid/Kconfig A src/drivers/generic/cbfs-uuid/Makefile.inc A src/drivers/generic/cbfs-uuid/cbfs-uuid.c 5 files changed, 113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/64639/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/64639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf Gerrit-Change-Number: 64639 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Michał Żygowski has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68078 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence ...................................................................... mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence MSI PRO Z690-A WIFI DDR4 and MSI PRO Z690-A DDR4 are basically the same boards, except the latter has no WiFi populated. Check the CNVi WiFi presence and return correct SMBIOS product name string. TEST=Check SMBIOS product name on both WiFi and non-WiFi variants in Linux. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I5fedbce413dfb6a589a406d1e34e3e114ca6a40f Reviewed-on: https://review.coreboot.org/c/coreboot/+/68078 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/msi/ms7d25/mainboard.c 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/mainboard/msi/ms7d25/mainboard.c b/src/mainboard/msi/ms7d25/mainboard.c index 2d46887..9c3a3ae 100644 --- a/src/mainboard/msi/ms7d25/mainboard.c +++ b/src/mainboard/msi/ms7d25/mainboard.c @@ -2,6 +2,7 @@ #include <acpi/acpi.h> #include <device/device.h> +#include <soc/pci_devs.h> #include <soc/ramstage.h> #include <smbios.h> #include <string.h> @@ -32,6 +33,19 @@ return "MS-7D25"; } +const char *smbios_mainboard_product_name(void) +{ + /* Currently we support DDR4 variants, but e.g. DDR5 can be added later */ + if (CONFIG(BOARD_MSI_Z690_A_PRO_WIFI_DDR4)) { + if (is_devfn_enabled(PCH_DEVFN_CNVI_WIFI)) + return "PRO Z690-A WIFI DDR4(MS-7D25)"; + else + return "PRO Z690-A DDR4(MS-7D25)"; + } + + return CONFIG_MAINBOARD_PART_NUMBER; +} + /* Only baseboard serial number is populated */ const char *smbios_system_serial_number(void) { -- To view, visit https://review.coreboot.org/c/coreboot/+/68078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fedbce413dfb6a589a406d1e34e3e114ca6a40f Gerrit-Change-Number: 68078 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022