coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in libgfxinit[master]: hw-gfx-gma: Update BDSM register offset for TGL onwards
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Tim Wawrzynczak, Angel Pons. Hello Nico Huber, Sean Rhodes, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/65178 to look at the new patch set (#7). Change subject: hw-gfx-gma: Update BDSM register offset for TGL onwards ...................................................................... hw-gfx-gma: Update BDSM register offset for TGL onwards BDSM moved and is also 64 bits on TGL. If the register indicates that BSDM is 64-bits, then right now libgfxinit will error out. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I0a3e7a92dcb08ea33e08c9f2c5135d4269c9e0b9 --- M common/hw-gfx-gma.adb 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/78/65178/7 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I0a3e7a92dcb08ea33e08c9f2c5135d4269c9e0b9 Gerrit-Change-Number: 65178 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Arthur Heymans. Hello Nico Huber, Sean Rhodes, Angel Pons, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/65087 to look at the new patch set (#9). Change subject: common: Begin Tiger Lake integration ...................................................................... common: Begin Tiger Lake integration Tiger Lake's integrated graphics engine is built off an entirely new igfx architecture named "Iris Xe". This patch adds just enough support to compile for Tiger Lake. Fortunately, the backlight programming hasn't changed since SKL, so with a little bit of hacking, one can also have libgfxinit turn on the backlight to verify something is working and running. The first pass through the support will focus mostly on the eDP panel, then Type-C ports (both in fixed/native mode [DP/HDMI] and in Type-C DP Alt Mode). TBT will not be mostly ignored in this first pass, as it is not as widely used (yet?) as the other protocols. Tested on google/voxel, with DEBUG_ADA_CODE enabled. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f --- M common/Makefile.inc M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads A common/tigerlake/Makefile.inc A common/tigerlake/hw-gfx-gma-connectors.adb A common/tigerlake/hw-gfx-gma-plls.adb A common/tigerlake/hw-gfx-gma-plls.ads A common/tigerlake/hw-gfx-gma-port_detect.adb A common/tigerlake/hw-gfx-gma-power_and_clocks.adb A common/tigerlake/hw-gfx-gma-power_and_clocks.ads A configs/tigerlake 13 files changed, 542 insertions(+), 55 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/87/65087/9 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/chromeos/gen_test_hwid.sh: Replace usage of hexdump
by Julius Werner (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Michał Żygowski. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68133 ) Change subject: util/chromeos/gen_test_hwid.sh: Replace usage of hexdump ...................................................................... Patch Set 1: (1 comment) File util/chromeos/gen_test_hwid.sh: https://review.coreboot.org/c/coreboot/+/68133/comment/29fea5cb_4c4117e2 PS1, Line 16: xargs Not sure what the xargs is supposed to do here? Looks good otherwise. -- To view, visit https://review.coreboot.org/c/coreboot/+/68133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icad93933335b8c5ebd8fee74cc9aaed36bb56482 Gerrit-Change-Number: 68133 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 00:14:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cbfs/vboot: Adapt to new vb2_digest API
by Julius Werner (Code Review) 05 Oct '22

05 Oct '22

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66561 ) Change subject: cbfs/vboot: Adapt to new vb2_digest API ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > somehow this broke my google/vilboz. No console at all on the PSP verstage. […] Sorry, wouldn't know why. PSP verstage should print some log output before this code even runs so it doesn't sound likely that this patch alone directly caused that kind of issue. (I assume you have one of the AMD/Google-internal devices with unlocked PSP? Because my understanding is that the PSP verstage binary is normally signed by AMD and cannot be replaced on retail devices. If you tried to do that that would explain why it doesn't boot, but then it should fail with any local build of coreboot, not related to this patch.) -- To view, visit https://review.coreboot.org/c/coreboot/+/66561 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I287d8dac3c49ad7ea3e18a015874ce8d610ec67e Gerrit-Change-Number: 66561 Gerrit-PatchSet: 10 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Wed, 05 Oct 2022 23:50:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/yaviks: Support STORAGE_UNPROVISIONED fw_config
by Reka Norman (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Sam McNally, Tim Wawrzynczak. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68150 ) Change subject: mb/google/nissa/var/yaviks: Support STORAGE_UNPROVISIONED fw_config ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68150/comment/14f07c38_8d37d58c PS1, Line 13: TEST TODO: need to test -- To view, visit https://review.coreboot.org/c/coreboot/+/68150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I500d82d15e3240f1983c0bbaa6167b28bef2ab18 Gerrit-Change-Number: 68150 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Oct 2022 23:38:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/yaviks: Support STORAGE_UNPROVISIONED fw_config
by Reka Norman (Code Review) 05 Oct '22

05 Oct '22

Reka Norman has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68150 ) Change subject: mb/google/nissa/var/yaviks: Support STORAGE_UNPROVISIONED fw_config ...................................................................... mb/google/nissa/var/yaviks: Support STORAGE_UNPROVISIONED fw_config When set to STORAGE_UNPROVISIONED, coreboot will enable all storage devices. This is used for the first boot in factory. BUG=b:251055188 TEST=Boot to OS on yaviks eMMC and UFS SKUs with fw_config set to STORAGE_UNPROVISIONED. Change-Id: I500d82d15e3240f1983c0bbaa6167b28bef2ab18 Signed-off-by: Reka Norman <rekanorman(a)chromium.org> --- M src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb M src/mainboard/google/brya/variants/yaviks/overridetree.cb 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/68150/1 diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb index d002db6..5a8ce26 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb @@ -3,6 +3,7 @@ option STORAGE_EMMC 0 option STORAGE_NVME 1 option STORAGE_UFS 2 + option STORAGE_UNPROVISIONED 3 end end diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb index e30cc06..83ad4c3 100644 --- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb @@ -189,12 +189,15 @@ end device ref emmc on probe STORAGE STORAGE_EMMC + probe STORAGE STORAGE_UNPROVISIONED end device ref ish on probe STORAGE STORAGE_UFS + probe STORAGE STORAGE_UNPROVISIONED end device ref ufs on probe STORAGE STORAGE_UFS + probe STORAGE STORAGE_UNPROVISIONED end device ref pch_espi on chip ec/google/chromeec -- To view, visit https://review.coreboot.org/c/coreboot/+/68150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I500d82d15e3240f1983c0bbaa6167b28bef2ab18 Gerrit-Change-Number: 68150 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: ec/lenovo/h8/acpi: Fix wrongly used operator
by Felix Singer (Code Review) 05 Oct '22

05 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66380 ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ec/lenovo/h8/acpi: Fix wrongly used operator ...................................................................... ec/lenovo/h8/acpi: Fix wrongly used operator Commit 37a89d519d4e ("ec/lenovo/h8/acpi: Replace Not() with ASL 2.0 syntax") mixed up boolean and bit-wise operators while replacing Not() with ASL 2.0 syntax. Thus, fix that. Built dsdt.aml of lenovo/x230 and differs, but it remains the same when this commit is applied after commit 37a89d519d4e. Change-Id: Ifa848aafb5480acaac4fabffcf90a3dbf5248e43 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/66380 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/lenovo/h8/acpi/thinkpad.asl 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index 7c56106..622521a 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -91,7 +91,7 @@ } Else { - DHKN = DHKN & !Local0 + DHKN = DHKN & ~Local0 } If (EN) { -- To view, visit https://review.coreboot.org/c/coreboot/+/66380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa848aafb5480acaac4fabffcf90a3dbf5248e43 Gerrit-Change-Number: 66380 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: soc/amd/cezanne: Factor out common GPP clk req code
by Robert Zieba (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68138 to look at the new patch set (#4). Change subject: soc/amd/cezanne: Factor out common GPP clk req code ...................................................................... soc/amd/cezanne: Factor out common GPP clk req code This commit factors out the `gpp_dxio_update_clk_req_config` function as it will be useful for other AMD SoCs. BUG=b:250009974 TEST=Ran on nipperkin device, verified clk req settings match enabled devices Change-Id: I9a4c72d8e980993c76a1b128f17b65b0db972a03 Signed-off-by: Robert Zieba <robertzieba(a)google.com> --- M src/soc/amd/cezanne/Kconfig M src/soc/amd/cezanne/chip.h M src/soc/amd/cezanne/fch.c A src/soc/amd/common/block/include/amdblocks/pci_clk_req.h M src/soc/amd/common/block/pci/Kconfig M src/soc/amd/common/block/pci/Makefile.inc A src/soc/amd/common/block/pci/pcie_clk_req.c M src/soc/amd/common/block/pci/pcie_gpp.c 8 files changed, 143 insertions(+), 94 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/68138/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/68138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a4c72d8e980993c76a1b128f17b65b0db972a03 Gerrit-Change-Number: 68138 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ec/lenovo/h8/acpi: Fix wrongly used operator
by Felix Singer (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Felix Singer, Nico Huber, Sean Rhodes, Matt DeVillier, Paul Menzel, Alexander Couzens. Hello build bot (Jenkins), Nico Huber, Sean Rhodes, Paul Menzel, Angel Pons, Arthur Heymans, Alexander Couzens, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66380 to look at the new patch set (#7). Change subject: ec/lenovo/h8/acpi: Fix wrongly used operator ...................................................................... ec/lenovo/h8/acpi: Fix wrongly used operator Commit 37a89d519d4e ("ec/lenovo/h8/acpi: Replace Not() with ASL 2.0 syntax") mixed up boolean and bit-wise operators while replacing Not() with ASL 2.0 syntax. Thus, fix that. Built dsdt.aml of lenovo/x230 and differs, but it remains the same when this commit is applied after commit 37a89d519d4e. Change-Id: Ifa848aafb5480acaac4fabffcf90a3dbf5248e43 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/lenovo/h8/acpi/thinkpad.asl 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/66380/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/66380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa848aafb5480acaac4fabffcf90a3dbf5248e43 Gerrit-Change-Number: 66380 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ec/lenovo/h8/acpi: Fix wrongly used operator
by build bot (Jenkins) (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Felix Singer, Nico Huber, Sean Rhodes, Matt DeVillier, Paul Menzel, Alexander Couzens. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66380 ) Change subject: ec/lenovo/h8/acpi: Fix wrongly used operator ...................................................................... Patch Set 6: Verified-1 (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159782): https://review.coreboot.org/c/coreboot/+/66380/comment/e5e210f2_1c1fbee3 PS6, Line 8: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 37a89d519d4e ("ec/lenovo/h8/acpi: Replace Not() with ASL 2.0 syntax")' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159782): https://review.coreboot.org/c/coreboot/+/66380/comment/c62a65b2_429daf86 PS6, Line 13: Built dsdt.aml of lenovo/x230 and differs, but it remains the same when Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 37a89d519d4e ("ec/lenovo/h8/acpi: Replace Not() with ASL 2.0 syntax")' -- To view, visit https://review.coreboot.org/c/coreboot/+/66380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa848aafb5480acaac4fabffcf90a3dbf5248e43 Gerrit-Change-Number: 66380 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Oct 2022 22:16:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022