coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Felix Singer, Sean Rhodes, Nico Huber, Angel Pons, Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > oh sorry, I misread. I understood you already got one. […] Yeah nothing yet, that does look like a really cool device, I imagine they will be in demand and hard to get ... I'll take any extra machines anyone has to donate in the meantime 😜 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 06 Oct 2022 02:04:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Felix Singer (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Nico Huber, Tim Wawrzynczak, Angel Pons, Arthur Heymans. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > Just wondering, what did you get? :) oh sorry, I misread. I understood you already got one. Maybe it's worth waiting for the Framework Chromebook variant :) -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:51:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Felix Singer (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Nico Huber, Tim Wawrzynczak, Angel Pons, Arthur Heymans. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > I need to find myself a corebootable TGL laptop now that I don't have my vast array of work DUTs.... Just wondering, what did you get? :) -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:48:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Nico Huber, Angel Pons, Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 9: (1 comment) Patchset: PS8: > Tested on StarBook Mk V (i7-1165G7) and no issues found. […] Thanks I'll try to build those and see what's up -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

1 0

[M] Change in libgfxinit[master]: common/dp_aux_request: Add support for TGL
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Nico Huber, Angel Pons. Hello Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/67497 to look at the new patch set (#3). Change subject: common/dp_aux_request: Add support for TGL ...................................................................... common/dp_aux_request: Add support for TGL Just new registers for new ports. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I5f2ae7f1a5961c7a8c28e3091bab94a40000ba10 --- M common/hw-gfx-gma-connector_info.adb M common/hw-gfx-gma-dp_aux_request.adb 2 files changed, 127 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/97/67497/3 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I5f2ae7f1a5961c7a8c28e3091bab94a40000ba10 Gerrit-Change-Number: 67497 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in libgfxinit[master]: hw-gfx-gma: Update BDSM register offset for TGL onwards
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Nico Huber, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65178 ) Change subject: hw-gfx-gma: Update BDSM register offset for TGL onwards ...................................................................... Patch Set 7: (1 comment) File common/hw-gfx-gma.adb: https://review.coreboot.org/c/libgfxinit/+/65178/comment/4103401a_9053faf6 PS6, Line 861: Dev.Read32 > It's 64 bits now. Ah ok I missed that. I can't seem to find public TGL datasheets yet 😞 maybe I missed them, I assume 0xc4 is the high 32 bits? For now we could just bail if there's anything set in the high bits. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I0a3e7a92dcb08ea33e08c9f2c5135d4269c9e0b9 Gerrit-Change-Number: 65178 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:38:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common/gma-registers: Update for Tiger Lake
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Nico Huber, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67489 ) Change subject: common/gma-registers: Update for Tiger Lake ...................................................................... Patch Set 2: (5 comments) File common/hw-gfx-gma-registers.ads: https://review.coreboot.org/c/libgfxinit/+/67489/comment/3395f8bc_dabf642f PS1, Line 1787: GEN9_CHICKEN_DPCR_3 > Linux calls it GEN9_CLKGATE_DIS_3, c/p error maybe? sounds right, will fix https://review.coreboot.org/c/libgfxinit/+/67489/comment/fd7f7141_85d8ec7c PS1, Line 1987: HIP_INDEX_REG1 => 16#10_10a4# / Register_Width, > Given that the indexed registers below are (almost?) grouped […] Sure let me try something https://review.coreboot.org/c/libgfxinit/+/67489/comment/be8e99ce_7f5bcf7e PS1, Line 2030: COLD > Isn't it COLD*ST*? That's what I see in Linux and (not sure if related […] Oh yah missed the ST https://review.coreboot.org/c/libgfxinit/+/67489/comment/72dcd992_c173733c PS1, Line 2120: PLANE_COLOR_CTL_1_C => 16#07_21cc# / Register_Width, > Isn't there a fourth pipe now? Yes, I figured adding support for the 4th pipe would be in a separate patch train, since it would touch I think a bunch of different stuff https://review.coreboot.org/c/libgfxinit/+/67489/comment/2e99152a_feea67c3 PS1, Line 2134: PORT_TX_DFLEXDPPMS_FIA3 => 16#16_f890# / Register_Width, : PORT_TX_DFLEXDPMLE1_FIA3 => 16#16_f8c0# / Register_Width, > These two lines are switched compared to the respective ones above. I assume […] yeah my eyes glaze over sometimes seeing all of those similar names in a row.. 😄 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I61331746365a80c9f953e7d75749f138a2e9adac Gerrit-Change-Number: 67489 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:38:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 9: (8 comments) File common/hw-gfx-gma-config.ads.template: https://review.coreboot.org/c/libgfxinit/+/65087/comment/93a51bf1_8ccdeea9 PS8, Line 38: => > Please align up. Done https://review.coreboot.org/c/libgfxinit/+/65087/comment/f8bcc490_f8d0f0d5 PS8, Line 186: hswsklbool > I supposse this and the next are `hswskltglbool` as well then. Oops yes https://review.coreboot.org/c/libgfxinit/+/65087/comment/7f572ee4_be3d6ab9 PS8, Line 327: tglhswvar > I think this one should stay `hswvar`. Meaning, if the generation is Haswell, […] Ack https://review.coreboot.org/c/libgfxinit/+/65087/comment/b0612919_ec44af9e PS8, Line 504: function Is_Tiger_Lake (Device_Id : Word16) return Boolean is : (Is_Tiger_Lake_U (Device_Id) or Is_Tiger_Lake_H (Device_Id)); > Do we need this function? Ack https://review.coreboot.org/c/libgfxinit/+/65087/comment/d62344f4_9db2e4d0 PS8, Line 545: Is_Tiger_Lake_U (Device_Id))); > No tabs, please. Done File common/hw-gfx-gma-config_helpers.adb: https://review.coreboot.org/c/libgfxinit/+/65087/comment/3a0ef489_aad3bdcd PS8, Line 53: ???? > You couldn't test or you are unsure or... […] Leftover from when I wasn't sure File common/hw-gfx-gma.adb: https://review.coreboot.org/c/libgfxinit/+/65087/comment/b6defd66_65953e05 PS8, Line 58: > A little spurious indentation Done https://review.coreboot.org/c/libgfxinit/+/65087/comment/39612197_a0409b49 PS8, Line 59: => > Please align up Done -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:37:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common/gma-registers: Update for Tiger Lake
by Tim Wawrzynczak (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Tim Wawrzynczak, Angel Pons. Hello Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/67489 to look at the new patch set (#2). Change subject: common/gma-registers: Update for Tiger Lake ...................................................................... common/gma-registers: Update for Tiger Lake Add all of the necessary registers for TGL at once, so they do not distract from the rest of the patches. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I61331746365a80c9f953e7d75749f138a2e9adac --- M common/hw-gfx-gma-registers.ads 1 file changed, 581 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/89/67489/2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I61331746365a80c9f953e7d75749f138a2e9adac Gerrit-Change-Number: 67489 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022