coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in coreboot[master]: payloads/edk2: Separate the build target and repository
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66080 ) Change subject: payloads/edk2: Separate the build target and repository ...................................................................... Patch Set 27: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66080 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7f12423058ef69838741f384495ca766ccea083 Gerrit-Change-Number: 66080 Gerrit-PatchSet: 27 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:14:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: payloads/edk2: Separate the build target and repository
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66080 ) Change subject: payloads/edk2: Separate the build target and repository ...................................................................... Patch Set 27: (1 comment) Patchset: PS27: I like the structure of this approach, more neat and understandable, but still I will try to avoid to have another fork of edk2 repo again for UPL, as it will create extra discrepancies and maintenance burden. The main goal should be getting the fix merged into edk2 main repo and platform specific changes into forked edk2-platforms. -- To view, visit https://review.coreboot.org/c/coreboot/+/66080 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7f12423058ef69838741f384495ca766ccea083 Gerrit-Change-Number: 66080 Gerrit-PatchSet: 27 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:14:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: intel/i945: Use 'bool' for dual_channel and interleaved
by build bot (Jenkins) (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67925 ) Change subject: intel/i945: Use 'bool' for dual_channel and interleaved ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I055847c9b08795683fe2e1dfd7fcde49901fc973 Gerrit-Change-Number: 67925 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:10:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/i945: Clean up includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68211 to look at the new patch set (#2). Change subject: nb/intel/i945: Clean up includes ...................................................................... nb/intel/i945: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I0e5f102d75647c9c184cb7422af30c9196503882 --- M src/northbridge/intel/i945/errata.c M src/northbridge/intel/i945/i945.h M src/northbridge/intel/i945/romstage.c 3 files changed, 17 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/68211/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e5f102d75647c9c184cb7422af30c9196503882 Gerrit-Change-Number: 68211 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: intel/i945: Use 'bool' for dual_channel and interleaved
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67925 ) Change subject: intel/i945: Use 'bool' for dual_channel and interleaved ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/i945/raminit.h: https://review.coreboot.org/c/coreboot/+/67925/comment/02d71461_280c877c PS2, Line 52: u8 > size_t ? Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/67925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I055847c9b08795683fe2e1dfd7fcde49901fc973 Gerrit-Change-Number: 67925 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:08:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/nivviks: Enable ISH driver and firmware name
by Meera Ravindranath (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Subrata Banik, Reka Norman, Rizwan Qureshi, Tim Wawrzynczak, Divagar Mohandass. Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68164 ) Change subject: mb/google/brya/nivviks: Enable ISH driver and firmware name ...................................................................... Patch Set 1: (2 comments) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/68164/comment/a5aea246_f2b4d38f PS1, Line 2185: ADL > ADL_N? Based on the EDS the ADL-P ID is different. Done File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/68164/comment/2454b773_96a922db PS1, Line 76: select DRIVERS_INTEL_ISH > nit: please keep them in alphabetical order Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89782b0b7dde1fca0130472a38628e72dfd5c26c Gerrit-Change-Number: 68164 Gerrit-PatchSet: 1 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Daniil Lunev <dlunev(a)google.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/nivviks: Enable ISH driver and firmware name
by Meera Ravindranath (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak, Meera Ravindranath, Divagar Mohandass. Hello build bot (Jenkins), Subrata Banik, Rizwan Qureshi, Reka Norman, Daniil Lunev, Divagar Mohandass, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68164 to look at the new patch set (#2). Change subject: mb/google/brya/nivviks: Enable ISH driver and firmware name ...................................................................... mb/google/brya/nivviks: Enable ISH driver and firmware name BRANCH=none BUG=b:234776154 TEST=build and boot Nirwen UFS, copy ISH firmware to host file system /lib/firmware/intel/adln_ish.bin check "dmesg |grep ish", it should show: ish-loader: ISH firmware intel/adlnrvp_ish.bin loaded Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com> Change-Id: I89782b0b7dde1fca0130472a38628e72dfd5c26c --- M src/drivers/intel/ish/ish.c M src/include/device/pci_ids.h M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/nivviks/overridetree.cb 4 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/68164/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89782b0b7dde1fca0130472a38628e72dfd5c26c Gerrit-Change-Number: 68164 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Daniil Lunev <dlunev(a)google.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: spd/lp5: Add new memory configuration of H58G66BK7BX067 and H58G56BK7...
by EricKY Cheng (Code Review) 07 Oct '22

07 Oct '22

EricKY Cheng has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/68212 ) Change subject: spd/lp5: Add new memory configuration of H58G66BK7BX067 and H58G56BK7BX068 ...................................................................... spd/lp5: Add new memory configuration of H58G66BK7BX067 and H58G56BK7BX068 Add Hynix H58G66BK7BX067 and H58G56BK7BX068 in the memory_parts.json and re-generate the SPD. BUG=b:243337816 BRANCH=None TEST=util/spd_tools/bin/spd_gen spd/lp5/memory_parts.json lp5 Signed-off-by: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Change-Id: I8d6aac3ecec36b126e7e41d6c9475695aa7a26b2 --- M spd/lp5/memory_parts.json M spd/lp5/set-0/parts_spd_manifest.generated.txt M spd/lp5/set-1/parts_spd_manifest.generated.txt M spd/lp5/set-1/spd-7.hex M spd/lp5/set-1/spd-8.hex 5 files changed, 45 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/68212/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68212 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d6aac3ecec36b126e7e41d6c9475695aa7a26b2 Gerrit-Change-Number: 68212 Gerrit-PatchSet: 2 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: spd/lp5: Add new memory configuration of H58G66BK7BX067 and H58G56BK7...
by build bot (Jenkins) (Code Review) 07 Oct '22

07 Oct '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68212 ) Change subject: spd/lp5: Add new memory configuration of H58G66BK7BX067 and H58G56BK7BX068 ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159973): https://review.coreboot.org/c/coreboot/+/68212/comment/441c0529_0004c54b PS1, Line 9: Add Hynix H58G66BK7BX067 and H58G56BK7BX068 in the memory_parts.json and re-generate Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/68212 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d6aac3ecec36b126e7e41d6c9475695aa7a26b2 Gerrit-Change-Number: 68212 Gerrit-PatchSet: 1 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 08:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: spd/lp5: Add new memory configuration of H58G66BK7BX067 and H58G56BK7...
by EricKY Cheng (Code Review) 07 Oct '22

07 Oct '22

EricKY Cheng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68212 ) Change subject: spd/lp5: Add new memory configuration of H58G66BK7BX067 and H58G56BK7BX068 ...................................................................... spd/lp5: Add new memory configuration of H58G66BK7BX067 and H58G56BK7BX068 Add Hynix H58G66BK7BX067 and H58G56BK7BX068 in the memory_parts.json and re-generate the SPD. BUG=b:243337816 BRANCH=None TEST=util/spd_tools/bin/spd_gen spd/lp5/memory_parts.json lp5 Signed-off-by: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Change-Id: I8d6aac3ecec36b126e7e41d6c9475695aa7a26b2 --- M spd/lp5/memory_parts.json M spd/lp5/set-0/parts_spd_manifest.generated.txt M spd/lp5/set-1/parts_spd_manifest.generated.txt M spd/lp5/set-1/spd-7.hex M spd/lp5/set-1/spd-8.hex 5 files changed, 45 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/68212/1 diff --git a/spd/lp5/memory_parts.json b/spd/lp5/memory_parts.json index 9f527c3..eed8027 100644 --- a/spd/lp5/memory_parts.json +++ b/spd/lp5/memory_parts.json @@ -153,6 +153,28 @@ "speedMbps": 7500, "lp5x": true } + }, + { + "name": "H58G66BK7BX067", + "attribs": { + "densityPerDieGb": 16, + "diesPerPackage": 4, + "bitWidthPerChannel": 16, + "ranksPerChannel": 2, + "speedMbps": 7500, + "lp5x": true + } + }, + { + "name": "H58G56BK7BX068", + "attribs": { + "densityPerDieGb": 16, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 7500, + "lp5x": true + } } ] } diff --git a/spd/lp5/set-0/parts_spd_manifest.generated.txt b/spd/lp5/set-0/parts_spd_manifest.generated.txt index 8ddb733..248c913 100644 --- a/spd/lp5/set-0/parts_spd_manifest.generated.txt +++ b/spd/lp5/set-0/parts_spd_manifest.generated.txt @@ -16,3 +16,5 @@ MT62F2G32D4DS-026 WT:B,spd-8.hex K3KL8L80CM-MGCT,spd-7.hex K3KL9L90CM-MGCT,spd-8.hex +H58G66BK7BX067,spd-8.hex +H58G56BK7BX068,spd-7.hex diff --git a/spd/lp5/set-1/parts_spd_manifest.generated.txt b/spd/lp5/set-1/parts_spd_manifest.generated.txt index 8ddb733..248c913 100644 --- a/spd/lp5/set-1/parts_spd_manifest.generated.txt +++ b/spd/lp5/set-1/parts_spd_manifest.generated.txt @@ -16,3 +16,5 @@ MT62F2G32D4DS-026 WT:B,spd-8.hex K3KL8L80CM-MGCT,spd-7.hex K3KL9L90CM-MGCT,spd-8.hex +H58G66BK7BX067,spd-8.hex +H58G56BK7BX068,spd-7.hex diff --git a/spd/lp5/set-1/spd-7.hex b/spd/lp5/set-1/spd-7.hex index a38dbbd..8b18d49 100644 --- a/spd/lp5/set-1/spd-7.hex +++ b/spd/lp5/set-1/spd-7.hex @@ -1,4 +1,4 @@ -23 11 13 0E 86 21 95 18 00 40 00 00 02 02 00 00 +23 11 15 0E 86 21 95 18 00 40 00 00 02 02 00 00 00 00 03 00 00 00 00 00 2B 00 90 A8 90 C0 08 60 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/spd/lp5/set-1/spd-8.hex b/spd/lp5/set-1/spd-8.hex index e08c695..0602fef 100644 --- a/spd/lp5/set-1/spd-8.hex +++ b/spd/lp5/set-1/spd-8.hex @@ -1,4 +1,4 @@ -23 11 13 0E 86 21 B5 18 00 40 00 00 0A 02 00 00 +23 11 15 0E 86 21 B5 18 00 40 00 00 0A 02 00 00 00 00 03 00 00 00 00 00 2B 00 90 A8 90 C0 08 60 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/c/coreboot/+/68212 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d6aac3ecec36b126e7e41d6c9475695aa7a26b2 Gerrit-Change-Number: 68212 Gerrit-PatchSet: 1 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022