coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: src/include/{post.h,console/cbmem_console.h}: Sorte includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68207 ) Change subject: src/include/{post.h,console/cbmem_console.h}: Sorte includes ...................................................................... src/include/{post.h,console/cbmem_console.h}: Sorte includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Ic467e6c5795f94d052b70117c63e7b57a3435d5c --- M src/include/console/cbmem_console.h M src/include/post.h 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/68207/1 diff --git a/src/include/console/cbmem_console.h b/src/include/console/cbmem_console.h index 9a814b9..5224c4e 100644 --- a/src/include/console/cbmem_console.h +++ b/src/include/console/cbmem_console.h @@ -2,8 +2,8 @@ #ifndef _CONSOLE_CBMEM_CONSOLE_H_ #define _CONSOLE_CBMEM_CONSOLE_H_ -#include <stdint.h> #include <stddef.h> +#include <stdint.h> void cbmemc_init(void); void cbmemc_tx_byte(unsigned char data); diff --git a/src/include/post.h b/src/include/post.h index 0eb2c3a..fce5dea 100644 --- a/src/include/post.h +++ b/src/include/post.h @@ -3,8 +3,8 @@ #ifndef __POST_H__ #define __POST_H__ -#include <stdint.h> #include <device/device.h> +#include <stdint.h> void cmos_post_init(void); void cmos_post_code(u8 value); -- To view, visit https://review.coreboot.org/c/coreboot/+/68207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic467e6c5795f94d052b70117c63e7b57a3435d5c Gerrit-Change-Number: 68207 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: src/drivers: Clean up includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68206 ) Change subject: src/drivers: Clean up includes ...................................................................... src/drivers: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Ia40678019b2a54deb246dbfbf33ec37a8c3839e4 --- M src/drivers/intel/gma/edid.h M src/drivers/mipi/panel.c M src/drivers/pc80/pc/i8259.c M src/drivers/pc80/rtc/mc146818rtc_boot.c M src/drivers/spi/bitbang.c M src/drivers/uart/uart8250io.c 6 files changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/68206/1 diff --git a/src/drivers/intel/gma/edid.h b/src/drivers/intel/gma/edid.h index 90d4c01..ee4906b 100644 --- a/src/drivers/intel/gma/edid.h +++ b/src/drivers/intel/gma/edid.h @@ -1,4 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <stdint.h> + void intel_gmbus_read_edid(u8 *gmbus_mmio, u8 bus, u8 slave, u8 *edid, u32 edid_size); void intel_gmbus_stop(u8 *gmbus_mmio); diff --git a/src/drivers/mipi/panel.c b/src/drivers/mipi/panel.c index 9646eca..7279d17 100644 --- a/src/drivers/mipi/panel.c +++ b/src/drivers/mipi/panel.c @@ -3,6 +3,7 @@ #include <console/console.h> #include <delay.h> #include <mipi/panel.h> +#include <types.h> enum cb_err mipi_panel_parse_init_commands(const void *buf, mipi_cmd_func_t cmd_func) { diff --git a/src/drivers/pc80/pc/i8259.c b/src/drivers/pc80/pc/i8259.c index c6aaef3..450f174 100644 --- a/src/drivers/pc80/pc/i8259.c +++ b/src/drivers/pc80/pc/i8259.c @@ -3,6 +3,7 @@ #include <arch/io.h> #include <pc80/i8259.h> #include <console/console.h> +#include <stdint.h> /* Read the current PIC IRQ mask */ u16 pic_read_irq_mask(void) diff --git a/src/drivers/pc80/rtc/mc146818rtc_boot.c b/src/drivers/pc80/rtc/mc146818rtc_boot.c index 550a602..6780c3a 100644 --- a/src/drivers/pc80/rtc/mc146818rtc_boot.c +++ b/src/drivers/pc80/rtc/mc146818rtc_boot.c @@ -1,9 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stdint.h> #include <console/console.h> -#include <pc80/mc146818rtc.h> #include <fallback.h> +#include <pc80/mc146818rtc.h> +#include <stdint.h> #if CONFIG_MAX_REBOOT_CNT > 15 #error "CONFIG_MAX_REBOOT_CNT too high" diff --git a/src/drivers/spi/bitbang.c b/src/drivers/spi/bitbang.c index 168ec64..8cb4b86 100644 --- a/src/drivers/spi/bitbang.c +++ b/src/drivers/spi/bitbang.c @@ -3,6 +3,7 @@ #include <console/console.h> #include <delay.h> #include <spi_bitbang.h> +#include <types.h> /* Set to 1 to dump all SPI transfers to the UART. */ #define TRACE 0 diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c index aa8c969..78f8cd8 100644 --- a/src/drivers/uart/uart8250io.c +++ b/src/drivers/uart/uart8250io.c @@ -2,7 +2,10 @@ #include <arch/io.h> #include <boot/coreboot_tables.h> +#include <commonlib/bsd/helpers.h> #include <console/uart.h> +#include <stdint.h> + #include "uart8250reg.h" /* Should support 8250, 16450, 16550, 16550A type UARTs */ -- To view, visit https://review.coreboot.org/c/coreboot/+/68206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia40678019b2a54deb246dbfbf33ec37a8c3839e4 Gerrit-Change-Number: 68206 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: src/device: Clean up includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68205 ) Change subject: src/device: Clean up includes ...................................................................... src/device: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Idd78271f2158bdc29ce9ac8d81f46ad8cbe84c5e --- M src/device/cardbus_device.c M src/device/cpu_device.c M src/device/device_util.c M src/device/dram/spd.c M src/device/gpio.c M src/device/i2c_bus.c M src/device/mmio.c M src/device/oprom/realmode/x86.h M src/device/pci_class.c M src/device/pcix_device.c M src/device/pnp_device.c M src/device/resource_allocator_common.c M src/device/resource_allocator_v4.c 13 files changed, 30 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/68205/1 diff --git a/src/device/cardbus_device.c b/src/device/cardbus_device.c index b014946..23f24dd 100644 --- a/src/device/cardbus_device.c +++ b/src/device/cardbus_device.c @@ -5,6 +5,7 @@ #include <device/pci.h> #include <device/pci_ops.h> #include <device/cardbus.h> +#include <types.h> /* * I don't think this code is quite correct but it is close. diff --git a/src/device/cpu_device.c b/src/device/cpu_device.c index 4ca5f97..51a1994 100644 --- a/src/device/cpu_device.c +++ b/src/device/cpu_device.c @@ -2,6 +2,7 @@ #include <device/device.h> #include <console/console.h> +#include <stddef.h> struct device *add_cpu_device(struct bus *cpu_bus, unsigned int apic_id, int enabled) diff --git a/src/device/device_util.c b/src/device/device_util.c index 6919f4b..9beb2ce 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -1,13 +1,14 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <commonlib/bsd/helpers.h> #include <console/console.h> #include <device/device.h> #include <device/path.h> #include <device/pci_def.h> #include <device/resource.h> -#include <stdbool.h> #include <stdlib.h> #include <string.h> +#include <types.h> /** * Given a Local APIC ID, find the device structure. diff --git a/src/device/dram/spd.c b/src/device/dram/spd.c index b6246ae..deff674 100644 --- a/src/device/dram/spd.c +++ b/src/device/dram/spd.c @@ -2,6 +2,7 @@ #include <device/dram/spd.h> #include <spd.h> +#include <stddef.h> const char *spd_manufacturer_name(const uint16_t mod_id) { diff --git a/src/device/gpio.c b/src/device/gpio.c index 5e71497..96cedda 100644 --- a/src/device/gpio.c +++ b/src/device/gpio.c @@ -3,6 +3,7 @@ #include <console/console.h> #include <device/device.h> #include <device/gpio.h> +#include <stddef.h> const struct gpio_operations *dev_get_gpio_ops(struct device *dev) { diff --git a/src/device/i2c_bus.c b/src/device/i2c_bus.c index f0d7dd1..361bb67 100644 --- a/src/device/i2c_bus.c +++ b/src/device/i2c_bus.c @@ -1,10 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stdint.h> +#include <commonlib/bsd/helpers.h> #include <console/console.h> +#include <device/device.h> #include <device/smbus.h> #include <device/i2c_bus.h> #include <commonlib/endian.h> +#include <types.h> bool i2c_dev_detect(struct device *dev, unsigned int addr) { diff --git a/src/device/mmio.c b/src/device/mmio.c index de8c8d3..b62805a 100644 --- a/src/device/mmio.c +++ b/src/device/mmio.c @@ -1,7 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <assert.h> +#include <commonlib/bsd/helpers.h> #include <device/mmio.h> +#include <types.h> /* Helper functions for various MMIO access patterns. */ diff --git a/src/device/oprom/realmode/x86.h b/src/device/oprom/realmode/x86.h index 36a28af..b0efe90 100644 --- a/src/device/oprom/realmode/x86.h +++ b/src/device/oprom/realmode/x86.h @@ -4,6 +4,7 @@ #define __DEVICE_OPROM_REALMODE_X86_H__ #include <arch/cpu.h> +#include <stdint.h> #define REALMODE_BASE ((void *)0x600) diff --git a/src/device/pci_class.c b/src/device/pci_class.c index 460d853..c5630f7 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -1,8 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <commonlib/bsd/helpers.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> +#include <stddef.h> typedef struct { const unsigned char subclass_id; diff --git a/src/device/pcix_device.c b/src/device/pcix_device.c index 8bf5225..5593357f 100644 --- a/src/device/pcix_device.c +++ b/src/device/pcix_device.c @@ -5,6 +5,7 @@ #include <device/pci.h> #include <device/pci_ops.h> #include <device/pcix.h> +#include <stdint.h> static void pcix_tune_dev(struct device *dev) { diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index 85daec7..9405d88 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> -#include <stdint.h> #include <arch/io.h> +#include <console/console.h> #include <device/device.h> #include <device/pnp.h> +#include <stdint.h> /* PNP config mode wrappers */ diff --git a/src/device/resource_allocator_common.c b/src/device/resource_allocator_common.c index 1cb1895..fe1aae3 100644 --- a/src/device/resource_allocator_common.c +++ b/src/device/resource_allocator_common.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> +#include <stddef.h> struct pick_largest_state { struct resource *last; diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c index 222f1e9..6e4aa5e 100644 --- a/src/device/resource_allocator_v4.c +++ b/src/device/resource_allocator_v4.c @@ -1,9 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <commonlib/bsd/helpers.h> #include <console/console.h> #include <device/device.h> #include <memrange.h> #include <post.h> +#include <types.h> static const char *resource2str(const struct resource *res) { -- To view, visit https://review.coreboot.org/c/coreboot/+/68205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd78271f2158bdc29ce9ac8d81f46ad8cbe84c5e Gerrit-Change-Number: 68205 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: cpu/x86: Clean up includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68204 ) Change subject: cpu/x86: Clean up includes ...................................................................... cpu/x86: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I01c6651079333686cb0eb68e89e56d7907868124 --- M src/cpu/x86/backup_default_smm.c M src/cpu/x86/lapic/boot_cpu.c M src/cpu/x86/lapic/lapic.c M src/cpu/x86/lapic/lapic_cpu_stop.c M src/cpu/x86/mtrr/debug.c M src/cpu/x86/mtrr/earlymtrr.c M src/cpu/x86/smi_trigger.c M src/cpu/x86/smm/save_state.c M src/cpu/x86/smm/smm_module_handler.c M src/cpu/x86/tsc/delay_tsc.c 10 files changed, 28 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/68204/1 diff --git a/src/cpu/x86/backup_default_smm.c b/src/cpu/x86/backup_default_smm.c index 1672e0b..a574237 100644 --- a/src/cpu/x86/backup_default_smm.c +++ b/src/cpu/x86/backup_default_smm.c @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <string.h> #include <acpi/acpi.h> -#include <console/console.h> #include <cbmem.h> +#include <console/console.h> #include <cpu/x86/smm.h> +#include <string.h> void *backup_default_smm_area(void) { diff --git a/src/cpu/x86/lapic/boot_cpu.c b/src/cpu/x86/lapic/boot_cpu.c index cf220d5..fd70870 100644 --- a/src/cpu/x86/lapic/boot_cpu.c +++ b/src/cpu/x86/lapic/boot_cpu.c @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <smp/node.h> -#include <cpu/x86/msr.h> #include <cpu/x86/lapic_def.h> +#include <cpu/x86/msr.h> +#include <smp/node.h> #if CONFIG(SMP) int boot_cpu(void) diff --git a/src/cpu/x86/lapic/lapic.c b/src/cpu/x86/lapic/lapic.c index 2d04fb3..24d2e37 100644 --- a/src/cpu/x86/lapic/lapic.c +++ b/src/cpu/x86/lapic/lapic.c @@ -1,13 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <assert.h> +#include <console/console.h> #include <cpu/cpu.h> #include <cpu/x86/lapic.h> #include <cpu/x86/lapic_def.h> #include <cpu/x86/msr.h> -#include <console/console.h> #include <smp/node.h> -#include <stdint.h> +#include <types.h> void enable_lapic_mode(bool try_set_x2apic) { diff --git a/src/cpu/x86/lapic/lapic_cpu_stop.c b/src/cpu/x86/lapic/lapic_cpu_stop.c index 1affe15..6eacba6 100644 --- a/src/cpu/x86/lapic/lapic_cpu_stop.c +++ b/src/cpu/x86/lapic/lapic_cpu_stop.c @@ -4,6 +4,7 @@ #include <cpu/x86/lapic.h> #include <delay.h> #include <halt.h> +#include <stdint.h> /** * Sending INIT IPI to self is equivalent of asserting #INIT with a bit of diff --git a/src/cpu/x86/mtrr/debug.c b/src/cpu/x86/mtrr/debug.c index 4ecae06..2725b77 100644 --- a/src/cpu/x86/mtrr/debug.c +++ b/src/cpu/x86/mtrr/debug.c @@ -2,6 +2,7 @@ #include <console/console.h> #include <cpu/cpu.h> +#include <cpu/x86/msr.h #include <cpu/x86/mtrr.h> #include <stdint.h> diff --git a/src/cpu/x86/mtrr/earlymtrr.c b/src/cpu/x86/mtrr/earlymtrr.c index 2c14a70..aa430d5 100644 --- a/src/cpu/x86/mtrr/earlymtrr.c +++ b/src/cpu/x86/mtrr/earlymtrr.c @@ -5,7 +5,7 @@ #include <cpu/x86/msr.h> #include <console/console.h> #include <commonlib/bsd/helpers.h> -#include <stdint.h> +#include <types.h> /* Get first available variable MTRR. * Returns var# if available, else returns -1. diff --git a/src/cpu/x86/smi_trigger.c b/src/cpu/x86/smi_trigger.c index e4c6dc9..470ecde 100644 --- a/src/cpu/x86/smi_trigger.c +++ b/src/cpu/x86/smi_trigger.c @@ -3,6 +3,7 @@ #include <arch/io.h> #include <console/console.h> #include <cpu/x86/smm.h> +#include <stdint.h> static void apmc_log(const char *fn, u8 cmd) { diff --git a/src/cpu/x86/smm/save_state.c b/src/cpu/x86/smm/save_state.c index bb08f86..d8c44a8 100644 --- a/src/cpu/x86/smm/save_state.c +++ b/src/cpu/x86/smm/save_state.c @@ -1,7 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <cpu/x86/smm.h> +#include <commonlib/bsd/helpers.h> #include <cpu/x86/save_state.h> +#include <cpu/x86/smm.h> +#include <types.h> /* These are weakly linked such that platforms can link only the save state ops they actually require. */ diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index e18a26a..e813f78 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -1,11 +1,14 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/io.h> +#include <commonlib/bsd/compiler.h> +#include <commonlib/region.h> #include <console/cbmem_console.h> #include <console/console.h> -#include <commonlib/region.h> +#include <cpu/cpu.h> #include <cpu/x86/smm.h> #include <rmodule.h> +#include <types.h> #if CONFIG(SPI_FLASH_SMM) #include <spi-generic.h> diff --git a/src/cpu/x86/tsc/delay_tsc.c b/src/cpu/x86/tsc/delay_tsc.c index 9607c2c..978a6ee 100644 --- a/src/cpu/x86/tsc/delay_tsc.c +++ b/src/cpu/x86/tsc/delay_tsc.c @@ -3,6 +3,7 @@ #include <arch/cpu.h> #include <cpu/x86/tsc.h> #include <delay.h> +#include <stdint.h> #include <thread.h> void init_timer(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/68204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01c6651079333686cb0eb68e89e56d7907868124 Gerrit-Change-Number: 68204 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: cpu/intel: Clean up includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68203 ) Change subject: cpu/intel: Clean up includes ...................................................................... cpu/intel: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Ie760711916c49d275ca49d94b9597fd24b5e7628 --- M src/cpu/intel/car/bootblock.c M src/cpu/intel/common/common_init.c M src/cpu/intel/microcode/microcode.c M src/cpu/intel/model_f3x/model_f3x_init.c 4 files changed, 22 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/68203/1 diff --git a/src/cpu/intel/car/bootblock.c b/src/cpu/intel/car/bootblock.c index dd9a772..c53379b 100644 --- a/src/cpu/intel/car/bootblock.c +++ b/src/cpu/intel/car/bootblock.c @@ -1,8 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <bootblock_common.h> #include <arch/bootblock.h> +#include <bootblock_common.h> #include <cpu/x86/bist.h> +#include <stdint.h> static uint32_t saved_bist; diff --git a/src/cpu/intel/common/common_init.c b/src/cpu/intel/common/common_init.c index 4d6df84..3a06281 100644 --- a/src/cpu/intel/common/common_init.c +++ b/src/cpu/intel/common/common_init.c @@ -4,8 +4,10 @@ #include <arch/cpu.h> #include <console/console.h> #include <cpu/intel/msr.h> -#include <cpu/x86/msr.h> #include <cpu/intel/turbo.h> +#include <cpu/x86/msr.h> +#include <types.h> + #include "common.h" #define CPUID_6_ECX_EPB (1 << 3) diff --git a/src/cpu/intel/microcode/microcode.c b/src/cpu/intel/microcode/microcode.c index bb2edfa..ac9453f 100644 --- a/src/cpu/intel/microcode/microcode.c +++ b/src/cpu/intel/microcode/microcode.c @@ -2,14 +2,13 @@ /* Microcode update for Intel PIII and later CPUs */ -#include <stdint.h> -#include <stddef.h> -#include <cbfs.h> #include <arch/cpu.h> +#include <cbfs.h> #include <console/console.h> -#include <cpu/x86/msr.h> #include <cpu/intel/microcode.h> +#include <cpu/x86/msr.h> #include <smp/spinlock.h> +#include <types.h> DECLARE_SPIN_LOCK(microcode_lock) diff --git a/src/cpu/intel/model_f3x/model_f3x_init.c b/src/cpu/intel/model_f3x/model_f3x_init.c index fdc5a1e..198490f 100644 --- a/src/cpu/intel/model_f3x/model_f3x_init.c +++ b/src/cpu/intel/model_f3x/model_f3x_init.c @@ -1,12 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <device/device.h> #include <cpu/cpu.h> -#include <cpu/x86/mtrr.h> -#include <cpu/intel/microcode.h> -#include <cpu/intel/hyperthreading.h> #include <cpu/intel/common/common.h> +#include <cpu/intel/hyperthreading.h> +#include <cpu/intel/microcode.h> #include <cpu/x86/cache.h> +#include <cpu/x86/mtrr.h> +#include <device/device.h> static void model_f3x_init(struct device *cpu) { -- To view, visit https://review.coreboot.org/c/coreboot/+/68203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie760711916c49d275ca49d94b9597fd24b5e7628 Gerrit-Change-Number: 68203 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: console/post.c: Sorte includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68202 ) Change subject: console/post.c: Sorte includes ...................................................................... console/post.c: Sorte includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I3faa1baf41ff8f0447d18b131a9c9c225e9fc8a4 --- M src/console/post.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/68202/1 diff --git a/src/console/post.c b/src/console/post.c index 1d99a2e..a86feb5 100644 --- a/src/console/post.c +++ b/src/console/post.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stdint.h> #include <console/console.h> +#include <stdint.h> /* Write POST information */ void __weak arch_post_code(uint8_t value) { } -- To view, visit https://review.coreboot.org/c/coreboot/+/68202 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3faa1baf41ff8f0447d18b131a9c9c225e9fc8a4 Gerrit-Change-Number: 68202 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: src/commonlib: Clean up includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68201 ) Change subject: src/commonlib: Clean up includes ...................................................................... src/commonlib: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Ieba5a5291209e50dc8b3816efb25bb5b2515fa6a --- M src/commonlib/iobuf.c M src/commonlib/region.c 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/68201/1 diff --git a/src/commonlib/iobuf.c b/src/commonlib/iobuf.c index 042e8dd..378793e 100644 --- a/src/commonlib/iobuf.c +++ b/src/commonlib/iobuf.c @@ -3,6 +3,7 @@ #include <commonlib/endian.h> #include <commonlib/iobuf.h> #include <string.h> +#include <stdint.h> static int ibuf_check_size(const struct ibuf *ib, size_t sz) { diff --git a/src/commonlib/region.c b/src/commonlib/region.c index 252f6fa..4153f0a 100644 --- a/src/commonlib/region.c +++ b/src/commonlib/region.c @@ -2,6 +2,7 @@ #include <commonlib/helpers.h> #include <commonlib/region.h> +#include <stdint.h> #include <string.h> int region_is_subregion(const struct region *p, const struct region *c) -- To view, visit https://review.coreboot.org/c/coreboot/+/68201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieba5a5291209e50dc8b3816efb25bb5b2515fa6a Gerrit-Change-Number: 68201 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: arch/x86: Clean up includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68200 ) Change subject: arch/x86: Clean up includes ...................................................................... arch/x86: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Id2db229dec2ed44333faaa8c53f3a2f9d66d52e0 --- M src/arch/x86/cpu_common.c M src/arch/x86/ebda.c M src/arch/x86/mpspec.c M src/arch/x86/null_breakpoint.c M src/arch/x86/post.c M src/arch/x86/postcar_loader.c M src/arch/x86/rdrand.c 7 files changed, 26 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/68200/1 diff --git a/src/arch/x86/cpu_common.c b/src/arch/x86/cpu_common.c index 302a14e..e674afa 100644 --- a/src/arch/x86/cpu_common.c +++ b/src/arch/x86/cpu_common.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <cpu/cpu.h> +#include <types.h> #if ENV_X86_32 /* Standard macro to see if a specific flag is changeable */ diff --git a/src/arch/x86/ebda.c b/src/arch/x86/ebda.c index e576a14..e835fce 100644 --- a/src/arch/x86/ebda.c +++ b/src/arch/x86/ebda.c @@ -3,7 +3,7 @@ #include <acpi/acpi.h> #include <bootstate.h> #include <commonlib/endian.h> -#include <stdint.h> +#include <types.h> #define X86_BDA_SIZE 0x200 #define X86_BDA_BASE ((void *)0x400) diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index 739d185..d94308e 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -1,14 +1,17 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> -#include <device/path.h> -#include <device/pci_ids.h> +#include <acpi/acpi.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <string.h> +#include <console/console.h> #include <cpu/cpu.h> #include <cpu/x86/lapic.h> +#include <device/device.h> +#include <device/path.h> +#include <device/pci_ids.h> #include <drivers/generic/ioapic/chip.h> +#include <stdint.h> +#include <string.h> /* Initialize the specified "mc" struct with initial values. */ void mptable_init(struct mp_config_table *mc) diff --git a/src/arch/x86/null_breakpoint.c b/src/arch/x86/null_breakpoint.c index 70b94b6..43e3727 100644 --- a/src/arch/x86/null_breakpoint.c +++ b/src/arch/x86/null_breakpoint.c @@ -1,9 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include <arch/breakpoint.h> #include <arch/null_breakpoint.h> #include <bootstate.h> #include <console/console.h> -#include <stdint.h> +#include <types.h> static struct breakpoint_handle null_deref_bp; static struct breakpoint_handle null_fetch_bp; diff --git a/src/arch/x86/post.c b/src/arch/x86/post.c index 3c1ca43..908cc3b 100644 --- a/src/arch/x86/post.c +++ b/src/arch/x86/post.c @@ -1,9 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <arch/io.h> +#include <console/console.h> #include <post.h> #include <stdint.h> -#include <console/console.h> -#include <arch/io.h> void arch_post_code(uint8_t value) { diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c index c6a128b..be4a235 100644 --- a/src/arch/x86/postcar_loader.c +++ b/src/arch/x86/postcar_loader.c @@ -9,9 +9,10 @@ #include <program_loading.h> #include <reset.h> #include <rmodule.h> +#include <security/vboot/vboot_common.h> #include <stage_cache.h> #include <timestamp.h> -#include <security/vboot/vboot_common.h> +#include <types.h> static size_t var_mtrr_ctx_size(void) { diff --git a/src/arch/x86/rdrand.c b/src/arch/x86/rdrand.c index 5374933..985aeba 100644 --- a/src/arch/x86/rdrand.c +++ b/src/arch/x86/rdrand.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <random.h> +#include <stdint.h> /* * Intel recommends that applications attempt 10 retries in a tight loop -- To view, visit https://review.coreboot.org/c/coreboot/+/68200 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id2db229dec2ed44333faaa8c53f3a2f9d66d52e0 Gerrit-Change-Number: 68200 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: src/acpi: Clean up includes
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68199 ) Change subject: src/acpi: Clean up includes ...................................................................... src/acpi: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Ia0ba40a671dfb804231419450036c15f480f1749 --- M src/acpi/acpi_pm.c M src/acpi/acpigen.c M src/acpi/acpigen_dsm.c M src/acpi/acpigen_ps2_keybd.c M src/acpi/device.c M src/acpi/sata.c 6 files changed, 21 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/68199/1 diff --git a/src/acpi/acpi_pm.c b/src/acpi/acpi_pm.c index 40a3fbd..627ab3e0 100644 --- a/src/acpi/acpi_pm.c +++ b/src/acpi/acpi_pm.c @@ -6,6 +6,7 @@ #include <cbmem.h> #include <console/console.h> #include <smbios.h> +#include <stdint.h> static const char *pm_fetch_failure_msg[PS_CLAIMER_MAX] = { [PS_CLAIMER_ELOG] = "no event recorded in ELOG.", diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index acef34d..466253f 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -10,14 +10,15 @@ #define ACPIGEN_MAXLEN 0xfffff -#include <lib.h> -#include <string.h> +#include <acpi/acpi.h> #include <acpi/acpigen.h> #include <assert.h> #include <commonlib/helpers.h> #include <console/console.h> #include <device/device.h> #include <device/soundwire.h> +#include <lib.h> +#include <string.h> #include <types.h> static char *gencurrent; diff --git a/src/acpi/acpigen_dsm.c b/src/acpi/acpigen_dsm.c index 734fbd5..1989696 100644 --- a/src/acpi/acpigen_dsm.c +++ b/src/acpi/acpigen_dsm.c @@ -2,6 +2,7 @@ #include <acpi/acpigen.h> #include <acpi/acpigen_dsm.h> +#include <commonlib/bsd/helpers.h> /* ------------------- I2C HID DSM ---------------------------- */ diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index 7928dad..98c4baa 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -4,8 +4,7 @@ #include <acpi/acpigen_ps2_keybd.h> #include <console/console.h> #include <input-event-codes.h> -#include <stdbool.h> -#include <stdint.h> +#include <types.h> #define KEYMAP(scancode, keycode) (((uint32_t)(scancode) << 16) | (keycode & 0xFFFF)) #define SCANCODE(keymap) ((keymap >> 16) & 0xFFFF) diff --git a/src/acpi/device.c b/src/acpi/device.c index 2b085b6..0c43c0d 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -1,19 +1,17 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <assert.h> -#include <string.h> #include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <acpi/acpigen_pci.h> +#include <assert.h> +#include <commonlib/bsd/helpers.h> +#include <crc_byte.h> #include <device/device.h> #include <device/path.h> #include <stdlib.h> +#include <string.h> #include <types.h> -#include <crc_byte.h> - -#if CONFIG(GENERIC_GPIO_LIB) -#include <gpio.h> #endif #define ACPI_DP_UUID "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" diff --git a/src/acpi/sata.c b/src/acpi/sata.c index 282d366..fc7ced0 100644 --- a/src/acpi/sata.c +++ b/src/acpi/sata.c @@ -2,6 +2,7 @@ #include <acpi/acpigen.h> #include <acpi/acpi_sata.h> +#include <stdint.h> /* e.g. * generate_sata_ssdt_ports("\_SB.PCI0.SATA", 0x3); -- To view, visit https://review.coreboot.org/c/coreboot/+/68199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0ba40a671dfb804231419450036c15f480f1749 Gerrit-Change-Number: 68199 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by Iman Bingi (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph. Iman Bingi has uploaded a new patch set (#67) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... payloads/cbui: Add new payload CBUI Depends on libpayload and nuklear. Features: * Graphical menus with scrolling. * Text rendering engine (atm only bitmap font) * Support for keyboard and mouse * Support for USB and PS/2 devices * Ported coreinfo and nvramcui * Allows to modify NVRAM and RTC * Works as ELF payload * Works as Seabios secondary payload * Basic support for multiple languages * Hacky support for BIOS calls (depends on NASM) * Runs in qemu and on real hardware * Use linker script to allocate low memory Shortcomings: * Doesn't work in VGA text mode * Untested on UEFI * int32 relocates itself to low memory Licenses: * GPLv2 (CBUI + libpayload) * BSD (libpayload) * MIT (nuklear) TODO: * Test on as much platforms as possible * Link int32 into low memory This is Patrick Rudolph's original patch, updated by Ben Adu-Boahen to: * Add Read/Write module * This module allows read/write to any hardware component that is readable/writeable Note: This is work in progress Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com> --- M payloads/Kconfig M payloads/Makefile.inc A payloads/cbui/.gitignore A payloads/cbui/Kconfig A payloads/cbui/Makefile A payloads/cbui/NuklearUI/NuklearCombo.c A payloads/cbui/NuklearUI/NuklearCombo.h A payloads/cbui/NuklearUI/NuklearCommon.h A payloads/cbui/NuklearUI/NuklearDataGrid.c A payloads/cbui/NuklearUI/NuklearDataGrid.h A payloads/cbui/NuklearUI/NuklearDatePicker.c A payloads/cbui/NuklearUI/NuklearDatePicker.h A payloads/cbui/NuklearUI/NuklearFieldFile.c A payloads/cbui/NuklearUI/NuklearFieldFile.h A payloads/cbui/NuklearUI/NuklearFieldHex.c A payloads/cbui/NuklearUI/NuklearFieldHex.h A payloads/cbui/NuklearUI/NuklearFileChooser.c A payloads/cbui/NuklearUI/NuklearFileChooser.h A payloads/cbui/NuklearUI/NuklearGroup.c A payloads/cbui/NuklearUI/NuklearGroup.h A payloads/cbui/NuklearUI/NuklearHex.c A payloads/cbui/NuklearUI/NuklearHex.h A payloads/cbui/NuklearUI/NuklearIntegerRange.c A payloads/cbui/NuklearUI/NuklearIntegerRange.h A payloads/cbui/NuklearUI/NuklearLabel.c A payloads/cbui/NuklearUI/NuklearLabel.h A payloads/cbui/NuklearUI/NuklearObject.c A payloads/cbui/NuklearUI/NuklearObject.h A payloads/cbui/NuklearUI/NuklearPciHeader.c A payloads/cbui/NuklearUI/NuklearPciHeader.h A payloads/cbui/NuklearUI/NuklearRW.c A payloads/cbui/NuklearUI/NuklearRW.h A payloads/cbui/NuklearUI/NuklearRoot.c A payloads/cbui/NuklearUI/NuklearRwAcpi.c A payloads/cbui/NuklearUI/NuklearRwAcpi.h A payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c A payloads/cbui/NuklearUI/NuklearRwAtaAtapi.h A payloads/cbui/NuklearUI/NuklearRwClock.c A payloads/cbui/NuklearUI/NuklearRwClock.h A payloads/cbui/NuklearUI/NuklearRwCpuMsr.c A payloads/cbui/NuklearUI/NuklearRwCpuMsr.h A payloads/cbui/NuklearUI/NuklearRwDimmSpd.c A payloads/cbui/NuklearUI/NuklearRwDimmSpd.h A payloads/cbui/NuklearUI/NuklearRwE820.c A payloads/cbui/NuklearUI/NuklearRwE820.h A payloads/cbui/NuklearUI/NuklearRwEc.c A payloads/cbui/NuklearUI/NuklearRwEc.h A payloads/cbui/NuklearUI/NuklearRwIo.c A payloads/cbui/NuklearUI/NuklearRwIo.h A payloads/cbui/NuklearUI/NuklearRwIoIndexData.c A payloads/cbui/NuklearUI/NuklearRwIoIndexData.h A payloads/cbui/NuklearUI/NuklearRwMemory.c A payloads/cbui/NuklearUI/NuklearRwMemory.h A payloads/cbui/NuklearUI/NuklearRwMemoryIndexData.c A payloads/cbui/NuklearUI/NuklearRwMemoryIndexData.h A payloads/cbui/NuklearUI/NuklearRwNvram.c A payloads/cbui/NuklearUI/NuklearRwNvram.h A payloads/cbui/NuklearUI/NuklearRwPci.c A payloads/cbui/NuklearUI/NuklearRwPci.h A payloads/cbui/NuklearUI/NuklearRwPciIndexData.c A payloads/cbui/NuklearUI/NuklearRwPciIndexData.h A payloads/cbui/NuklearUI/NuklearRwPciOptionRom.c A payloads/cbui/NuklearUI/NuklearRwPciOptionRom.h A payloads/cbui/NuklearUI/NuklearRwSmbios.c A payloads/cbui/NuklearUI/NuklearRwSmbios.h A payloads/cbui/NuklearUI/NuklearRwSmbus.c A payloads/cbui/NuklearUI/NuklearRwSmbus.h A payloads/cbui/NuklearUI/NuklearRwSuperIo.c A payloads/cbui/NuklearUI/NuklearRwSuperIo.h A payloads/cbui/NuklearUI/NuklearStyle.c A payloads/cbui/NuklearUI/NuklearStyle.h A payloads/cbui/NuklearUI/NuklearTabView.c A payloads/cbui/NuklearUI/NuklearTextView.c A payloads/cbui/NuklearUI/NuklearTextView.h A payloads/cbui/NuklearUI/NuklearTextfield.c A payloads/cbui/NuklearUI/NuklearTextfield.h A payloads/cbui/NuklearUI/NuklearTimePicker.c A payloads/cbui/NuklearUI/NuklearTimePicker.h A payloads/cbui/NuklearUI/NuklearUI.h A payloads/cbui/NuklearUI/NuklearVector.c A payloads/cbui/NuklearUI/NuklearVector.h A payloads/cbui/arch/x86/cpuid.c A payloads/cbui/arch/x86/cpuid.h A payloads/cbui/arch/x86/int32.h A payloads/cbui/arch/x86/int32.ld A payloads/cbui/arch/x86/int32.nasm A payloads/cbui/arch/x86/memcpy.c A payloads/cbui/arch/x86/memcpy.h A payloads/cbui/arch/x86/vga.c A payloads/cbui/arch/x86/vga.h A payloads/cbui/cbui.c A payloads/cbui/cbui.h A payloads/cbui/fsys/usbstorage.c A payloads/cbui/fsys/usbstorage.h A payloads/cbui/gfx/coreboot.c A payloads/cbui/gfx/coreboot.h A payloads/cbui/gfx/gfx.c A payloads/cbui/gfx/gfx.h A payloads/cbui/gfx/splash.c A payloads/cbui/gfx/splash.h A payloads/cbui/gfx/vbe.c A payloads/cbui/gfx/vbe.h A payloads/cbui/lang/de.c A payloads/cbui/lang/en.c A payloads/cbui/lang/lang.c A payloads/cbui/lang/lang.h A payloads/cbui/logo/cbui.png A payloads/cbui/lp.config A payloads/cbui/modules/bootlog_module.c A payloads/cbui/modules/cbfs_module.c A payloads/cbui/modules/cmos_module.c A payloads/cbui/modules/coreboot_module.c A payloads/cbui/modules/cpuinfo_module.c A payloads/cbui/modules/license_module.c A payloads/cbui/modules/modules.c A payloads/cbui/modules/modules.h A payloads/cbui/modules/nvram_module.c A payloads/cbui/modules/pci_module.c A payloads/cbui/modules/reboot_module.c A payloads/cbui/modules/rtc_module.c A payloads/cbui/modules/rw_module.c A payloads/cbui/modules/timestamps_module.c A payloads/cbui/modules/usb_module.c A payloads/libpayload/configs/defconfig-cbui 124 files changed, 15,236 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23586/67 -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 67 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022