coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: payloads/edk2: Add a recipe to build UniversalPayload.elf
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68183 ) Change subject: payloads/edk2: Add a recipe to build UniversalPayload.elf ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2aa318513244f576e07e72713fad3b4f7bd7c22e Gerrit-Change-Number: 68183 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:29:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Guard the build target
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68182 ) Change subject: payloads/edk2: Guard the build target ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68182/comment/4b5cf339_ba7dc178 PS2, Line 9: against a tiny fix needed -- To view, visit https://review.coreboot.org/c/coreboot/+/68182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4597b5ed76616e39cec45f8a69be9f1ccd72d4c Gerrit-Change-Number: 68182 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:29:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/i945/raminit: Use 'size_t' for banksize[]
by build bot (Jenkins) (Code Review) 07 Oct '22

07 Oct '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68213 ) Change subject: nb/intel/i945/raminit: Use 'size_t' for banksize[] ...................................................................... Patch Set 1: (1 comment) File src/northbridge/intel/i945/raminit.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159978): https://review.coreboot.org/c/coreboot/+/68213/comment/2df4dd89_af538b9b PS1, Line 428: printk(BIOS_DEBUG, "DIMM %d side 0 = %ld MB\n", i, sysinfo->banksize[i * 2] * 32); line length of 98 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/68213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4fb845bb4145d47aea39d7e5493d854d00e289aa Gerrit-Change-Number: 68213 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:27:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add note that upstream edk2 does not work
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67780 ) Change subject: payloads/edk2: Add note that upstream edk2 does not work ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ec9f4746640baa030762650ab7b83d85ab8c1e1 Gerrit-Change-Number: 67780 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:27:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/i945/raminit: Use 'size_t' for banksize[]
by Elyes Haouas (Code Review) 07 Oct '22

07 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68213 ) Change subject: nb/intel/i945/raminit: Use 'size_t' for banksize[] ...................................................................... nb/intel/i945/raminit: Use 'size_t' for banksize[] Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I4fb845bb4145d47aea39d7e5493d854d00e289aa --- M src/northbridge/intel/i945/raminit.c M src/northbridge/intel/i945/raminit.h 2 files changed, 16 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/68213/1 diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index 585d562..d249b75 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -425,11 +425,11 @@ die("DDR-II rank size smaller than 128MB is not supported.\n"); sysinfo->banksize[i * 2] = dimm_info.ranksize_mb / 32; - printk(BIOS_DEBUG, "DIMM %d side 0 = %d MB\n", i, sysinfo->banksize[i * 2] * 32); + printk(BIOS_DEBUG, "DIMM %d side 0 = %ld MB\n", i, sysinfo->banksize[i * 2] * 32); if (dimm_info.ranks == 2) { sysinfo->banksize[(i * 2) + 1] = dimm_info.ranksize_mb / 32; - printk(BIOS_DEBUG, "DIMM %d side 1 = %d MB\n", + printk(BIOS_DEBUG, "DIMM %d side 1 = %ld MB\n", i, sysinfo->banksize[(i * 2) + 1] * 32); } @@ -1141,7 +1141,7 @@ static int sdram_program_row_boundaries(struct sys_info *sysinfo) { int i; - int cum0, cum1, tolud, tom, pci_mmio_size; + size_t cum0, cum1, tolud, tom, pci_mmio_size; const struct device *dev; const struct northbridge_intel_i945_config *cfg = NULL; @@ -2042,8 +2042,8 @@ sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED); chan1_populated = (sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED || sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED); - chan0_dualsided = (sysinfo->banksize[1] || sysinfo->banksize[3]); - chan1_dualsided = (sysinfo->banksize[5] || sysinfo->banksize[7]); + chan0_dualsided = (sysinfo->banksize[1] != 0 || sysinfo->banksize[3] != 0); + chan1_dualsided = (sysinfo->banksize[5] != 0 || sysinfo->banksize[7] != 0); if (sdram_capabilities_enhanced_addressing_xor()) { if (!sysinfo->interleaved) { diff --git a/src/northbridge/intel/i945/raminit.h b/src/northbridge/intel/i945/raminit.h index d69110e..efaedf4 100644 --- a/src/northbridge/intel/i945/raminit.h +++ b/src/northbridge/intel/i945/raminit.h @@ -49,7 +49,7 @@ #define SYSINFO_DIMM_NOT_POPULATED 0x04 u8 banks[2 * DIMM_SOCKETS]; - u8 banksize[2 * 2 * DIMM_SOCKETS]; + size_t banksize[2 * 2 * DIMM_SOCKETS]; const u8 *spd_addresses; } __packed; -- To view, visit https://review.coreboot.org/c/coreboot/+/68213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4fb845bb4145d47aea39d7e5493d854d00e289aa Gerrit-Change-Number: 68213 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: payloads/edk2: Separate the build target and repository
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66080 ) Change subject: payloads/edk2: Separate the build target and repository ...................................................................... Patch Set 27: (1 comment) Patchset: PS27: > Gua said they'll merge the patches as soon as this is merged, then can scrap the fork. That's nice, thanks Sean! -- To view, visit https://review.coreboot.org/c/coreboot/+/66080 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7f12423058ef69838741f384495ca766ccea083 Gerrit-Change-Number: 66080 Gerrit-PatchSet: 27 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:26:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/ehl: Support maximum memory frequency selection
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Christian Gmeiner, Werner Zeh. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68097 ) Change subject: soc/intel/ehl: Support maximum memory frequency selection ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hi Chris, can you fix the Jenkins error? -- To view, visit https://review.coreboot.org/c/coreboot/+/68097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e0c7225e2141e675a20b8e3f0dbe8c0b3a29b28 Gerrit-Change-Number: 68097 Gerrit-PatchSet: 2 Gerrit-Owner: Christian Gmeiner <christian.gmeiner(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Gmeiner <christian.gmeiner(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/prodrive/hermes: Make board settings less error-prone
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67381 ) Change subject: mb/prodrive/hermes: Make board settings less error-prone ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: do you want to decouple this from the relation chain since it is not related to Gfx? -- To view, visit https://review.coreboot.org/c/coreboot/+/67381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f009b21ef0850a2af6edef1818c770171358314 Gerrit-Change-Number: 67381 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:24:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/ehl: Set Ethernet controller to D0 power state
by Lean Sheng Tan (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Mario Scheithauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67976 ) Change subject: soc/intel/ehl: Set Ethernet controller to D0 power state ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4002d58eb4332ba45c35d07820900dfd2c637f21 Gerrit-Change-Number: 67976 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:21:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: payloads/edk2: Separate the build target and repository
by Sean Rhodes (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66080 ) Change subject: payloads/edk2: Separate the build target and repository ...................................................................... Patch Set 27: (1 comment) Patchset: PS27: > I like the structure of this approach, more neat and understandable, but still I will try to avoid t […] Gua said they'll merge the patches as soon as this is merged, then can scrap the fork. -- To view, visit https://review.coreboot.org/c/coreboot/+/66080 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7f12423058ef69838741f384495ca766ccea083 Gerrit-Change-Number: 66080 Gerrit-PatchSet: 27 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Oct 2022 09:17:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022