coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: util/amdfwread: Fix cookie error message
by Angel Pons (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Arthur Heymans, Karthik Ramasubramanian, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68234 ) Change subject: util/amdfwread: Fix cookie error message ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File util/amdfwtool/amdfwread.c: https://review.coreboot.org/c/coreboot/+/68234/comment/cbee4b93_6650fd7b PS1, Line 84: ERR("Invalid PSP header cookie value found: 0x%x, expected: 0x%x\n", The usual ordering is "expected foo, got bar instead". But this is now correct, which is more important. -- To view, visit https://review.coreboot.org/c/coreboot/+/68234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I580675fcbf8c5058ade371c6b9edb7b7070a78a3 Gerrit-Change-Number: 68234 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 10:03:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/gigabyte/ga-h61m-series: Add GA-H61M-DS2
by Arthur Heymans (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Patrick Rudolph, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61541 ) Change subject: mb/gigabyte/ga-h61m-series: Add GA-H61M-DS2 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d8df483e5573f77782b7d18b1410b391bfe387d Gerrit-Change-Number: 61541 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 10:01:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/amdfwread: Fix cookie error message
by Arthur Heymans (Code Review) 08 Oct '22

08 Oct '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68234 ) Change subject: util/amdfwread: Fix cookie error message ...................................................................... util/amdfwread: Fix cookie error message Change-Id: I580675fcbf8c5058ade371c6b9edb7b7070a78a3 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/amdfwtool/amdfwread.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/68234/1 diff --git a/util/amdfwtool/amdfwread.c b/util/amdfwtool/amdfwread.c index c9da3d8..d6dc1e2 100644 --- a/util/amdfwtool/amdfwread.c +++ b/util/amdfwtool/amdfwread.c @@ -82,7 +82,7 @@ /* Ensure that we have a PSP directory */ if (header->cookie != expected_cookie) { ERR("Invalid PSP header cookie value found: 0x%x, expected: 0x%x\n", - expected_cookie, header->cookie); + header->cookie, expected_cookie); return 1; } -- To view, visit https://review.coreboot.org/c/coreboot/+/68234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I580675fcbf8c5058ade371c6b9edb7b7070a78a3 Gerrit-Change-Number: 68234 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Add first BIOS block in coreboot.pre
by Arthur Heymans (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Julius Werner, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66943 ) Change subject: Add first BIOS block in coreboot.pre ...................................................................... Patch Set 7: (1 comment) File Makefile.inc: https://review.coreboot.org/c/coreboot/+/66943/comment/c30ef9a4_17346c98 PS7, Line 1112: FIRST_BIOS_BLOCK=$(objcbfs)/bootblock.bin : ifeq ($(CONFIG_AMDFW_CONTAINS_FIRST_BIOS_BLOCK),y) : FIRST_BIOS_BLOCK=$(obj)/amdfw.rom : add_firstbiosblock = \ : $(CBFSTOOL) $(1) add -f $(2) -n apu/amdfw -t amdfw \ : -b $(call int-add, \ : $(call int-subtract, 0xffffffff \ : $(call int-shift-left, \ : 0x80000 $(CONFIG_AMD_FWM_POSITION_INDEX))) 0x20000 1) : endif # ifeq ($(CONFIG_AMDFW_CONTAINS_FIRST_BIOS_BLOCK),y) Add this somewhere in soc/amd ? -- To view, visit https://review.coreboot.org/c/coreboot/+/66943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4d1a2d8b145cbbbf2da27aa73b296c9c8a65209 Gerrit-Change-Number: 66943 Gerrit-PatchSet: 7 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 09:46:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: xcompile: Add Zen compiler flag for AMD family 17h
by Bao Zheng (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Marshall Dawson, Matt DeVillier, Paul Menzel, Julius Werner, Zheng Bao, Arthur Heymans, Martin Roth, Fred Reitberger, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65224 ) Change subject: xcompile: Add Zen compiler flag for AMD family 17h ...................................................................... Patch Set 15: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/65224/comment/0a3cb599_55dff3b6 PS14, Line 18: Time Stamp flag=i686 znver1(1st time)znver1(2nd time) : --------------------------------------------------------------------- : 1st timestamp 2156447 2156855 2156640 : start of bootblock 2156567(120) 2156974(119) 2156757(117) : end of bootblock 2157239(672) 2157645(671) 2157424(667) : starting to load rom 2157239(0) 2157645(0) 2157424(0) : finished loading rom 2177833(20594) 2178303(20658) 2178050(20626) : start of romstage 2177886(53) 2178355(52) 2178102(52) : loading FSP-M 2177946(60) 2178415(60) 2178168(66) : starting LZMA decomp 2177956(10) 2178425(10) 2178178(10) : finished LZMA decomp 2240419(62463) 2240972(62547) 2240726(62548) : before RAM initializ 2241001(582) 2241557(585) 2241314(588) : calling FspMemoryIni 2245520(4519) 2246083(4526) 2245830(4516) : returning from FspMe 2477918(232398) 2478800(232717) 2477950(232120) : after RAM initializa 2477989(71) 2478871(71) 2478021(71) : end of romstage 2477994(5) 2478876(5) 2478025(4) : starting to load ram 2477994(0) 2478876(0) 2478026(1) : starting LZMA decomp 2477999(5) 2478881(5) 2478031(5) : finished LZMA decomp 2498285(20286) 2499310(20429) 2498506(20475) : finished loading ram 2498799(514) 2499830(520) 2499024(518) : start of ramstage 2498864(65) 2499894(64) 2499088(64) : device enumeration 2498889(25) 2499920(26) 2499114(26) : loading FSP-S 2498889(0) 2499920(0) 2499114(0) : starting LZ4 decompr 2498898(9) 2499929(9) 2499123(9) : finished LZ4 decompr 2508072(9174) 2509163(9234) 2508378(9255) : calling FspSiliconIn 2508414(342) 2509506(343) 2508721(343) : returning from FspSi 2667199(158785) 2669022(159516) 2667146(158425) : device configuration 2667651(452) 2669465(443) 2667599(453) : calling FspNotify(Af 2668162(511) 2669976(511) 2668111(512) : returning from FspNo)2668397(235) 2670216(240) 2668350(239) : device enable 2668865(468) 2670685(469) 2668819(469) : device initializatio 2668931(66) 2670751(66) 2668886(67) : started reading uCod 2669869(938) 2671687(936) 2669775(889) : finished reading uCo 2669876(7) 2671694(7) 2669782(7) : Option ROM initializ 2698518(28642) 2699082(27388) 2696620(26838) : device setup done 2698643(125) 2699207(125) 2696746(126) : starting APOB read 2698646(3) 2699210(3) 2696750(4) : starting APOB erase 2698678(32) 2699247(37) 2696786(36) : starting APOB write 3169709(471031) 3150216(450969) 3155995(459209) : finished APOB 3378156(208447) 3358271(208055) 3364198(208203) : cbmem post 3378164(8) 3358278(7) 3364206(8) : write tables 3378198(34) 3358313(35) 3364240(34) : finalize chips 3379737(1539) 3359873(1560) 3365803(1563) : starting to load pay 3379744(7) 3359880(7) 3365809(6) : starting LZMA decomp 3379771(27) 3359906(26) 3365835(26) : finished LZMA decomp 3389693(9922) 3369872(9966) 3375807(9972) : calling FspNotify(Re 3389699(6) 3369884(12) 3375819(12) : returning from FspNo 3389956(257) 3370144(260) 3376079(260) : calling FspNotify(En 3389967(11) 3370154(10) 3376088(9) : returning from FspNo 3389982(15) 3370174(20) 3376104(16) : selfboot jump 3390558(576) 3370761(587) 3376679(575) > So what's the summary here? Can we close the bug as unsuccessful or is it worth continuing? I think it is worth continuing. -- To view, visit https://review.coreboot.org/c/coreboot/+/65224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc308c65d5239fe66062ec651e975c6c0fc9fb9b Gerrit-Change-Number: 65224 Gerrit-PatchSet: 15 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 09:30:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/gigabyte/ga-h61m-series: Add GA-H61M-DS2
by Angel Pons (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Arthur Heymans, Patrick Rudolph, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61541 ) Change subject: mb/gigabyte/ga-h61m-series: Add GA-H61M-DS2 ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/61541/comment/8e30fee1_71404144 PS2, Line 11: TianoCore > Which version? No idea, sorry. https://review.coreboot.org/c/coreboot/+/61541/comment/72a31d5b_a83b3084 PS2, Line 14: > What memory modules did you use? No idea either. -- To view, visit https://review.coreboot.org/c/coreboot/+/61541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d8df483e5573f77782b7d18b1410b391bfe387d Gerrit-Change-Number: 61541 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 08 Oct 2022 08:48:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: util/docker/coreboot.org-status: Rewrite parser
by Patrick Georgi (Code Review) 08 Oct '22

08 Oct '22

Attention is currently required from: Patrick Georgi, Martin L Roth, Maxim Polyakov, ron minnich. Hello build bot (Jenkins), Martin L Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59958 to look at the new patch set (#15). Change subject: util/docker/coreboot.org-status: Rewrite parser ...................................................................... util/docker/coreboot.org-status: Rewrite parser The current tool is a shell script that mixes data collection and HTML generation and is generally a pain to work with. It takes 15 minutes to run. The new tool is written in go, collects all data first, then generates the output HTML from the data and a single template, and finishes in 10 seconds. The goal in this version is to produce output as similar as possible to the output of the shell script. Some difference will remain because the shell script returns some trash data whose reproduction would require more effort than is worth. Change-Id: I4fab86d24088e4f9eff434c21ce9caa077f3f9e2 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- A util/docker/coreboot.org-status/board-status.html/.gitignore A util/docker/coreboot.org-status/board-status.html/boards.go A util/docker/coreboot.org-status/board-status.html/go.mod A util/docker/coreboot.org-status/board-status.html/go.sum A util/docker/coreboot.org-status/board-status.html/logs.go A util/docker/coreboot.org-status/board-status.html/status-to-html.go A util/docker/coreboot.org-status/board-status.html/templates/board-status.html A util/docker/coreboot.org-status/board-status.html/types.go 8 files changed, 1,060 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/59958/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/59958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4fab86d24088e4f9eff434c21ce9caa077f3f9e2 Gerrit-Change-Number: 59958 Gerrit-PatchSet: 15 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/rex: Add initial fw config
by Subrata Banik (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Tarun Tuli, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68220 ) Change subject: mb/google/rex: Add initial fw config ...................................................................... Patch Set 3: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68220/comment/8c3b79ee_3da5dc84 PS3, Line 13: affter after File src/mainboard/google/rex/variants/rex0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/68220/comment/9642646c_f6715e63 PS3, Line 25: USB3 USB3_PS8815 https://review.coreboot.org/c/coreboot/+/68220/comment/94d81f1a_6ea17f0d PS3, Line 156: probe DB_USB USB3 : probe DB_USB USB4 i don't think it's needed https://review.coreboot.org/c/coreboot/+/68220/comment/c0093700_53caac2b PS3, Line 192: device ref usb2_port4 on : probe DB_USB USB3 : probe DB_USB USB4 : end same https://review.coreboot.org/c/coreboot/+/68220/comment/237e6942_8ee00940 PS3, Line 233: probe DB_USB USB3 : probe DB_USB USB4 same -- To view, visit https://review.coreboot.org/c/coreboot/+/68220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66f8b3e4ab414c03b8d63fdd31e0f3f424619340 Gerrit-Change-Number: 68220 Gerrit-PatchSet: 3 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 08 Oct 2022 05:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/alderlake: Support Raptor Lake VR Fast VMODE
by Subrata Banik (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Jérémy Compostella. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66917 ) Change subject: soc/intel/alderlake: Support Raptor Lake VR Fast VMODE ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/alderlake/vr_config.c: https://review.coreboot.org/c/coreboot/+/66917/comment/8c6def91_81da6300 PS8, Line 261: EnableFastVmode wondering if this UPD is only exclusive to RPL FSP? if not, then I do prefer to keep this UPD assignment without any #if guard and guard `fill_vr_fast_vmode()` function call against if (CONFIG(SOC_INTEL_RAPTORLAKE)) -- To view, visit https://review.coreboot.org/c/coreboot/+/66917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I313acf01c534d0d32620a9dedba7cf3b304ed2ee Gerrit-Change-Number: 66917 Gerrit-PatchSet: 8 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Sat, 08 Oct 2022 05:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Tim Wawrzynczak (Code Review) 07 Oct '22

07 Oct '22

Attention is currently required from: Felix Singer, Sean Rhodes, Nico Huber, Angel Pons, Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > Get a Clevo laptop and port it? 😄 Now there's an idea..... -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 08 Oct 2022 02:30:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022