coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: nb/intel/gm45/raminit.c: Fix indent for 'if' statement
by Felix Held (Code Review) 31 Jan '22

31 Jan '22

Attention is currently required from: Patrick Rudolph, HAOUAS Elyes. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61474 ) Change subject: nb/intel/gm45/raminit.c: Fix indent for 'if' statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I316ae56321da1183caefeac3163b8909d1a554b1 Gerrit-Change-Number: 61474 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 31 Jan 2022 13:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: superio/smsc/lpc47n207/early_serial.c: Fix indent for 'if' statement
by Felix Held (Code Review) 31 Jan '22

31 Jan '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61473 ) Change subject: superio/smsc/lpc47n207/early_serial.c: Fix indent for 'if' statement ...................................................................... superio/smsc/lpc47n207/early_serial.c: Fix indent for 'if' statement Change-Id: I0342e25747458239c1ad8c0f70f91f700ae8325d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61473 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/superio/smsc/lpc47n207/early_serial.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/superio/smsc/lpc47n207/early_serial.c b/src/superio/smsc/lpc47n207/early_serial.c index 36f3b36..41d7860 100644 --- a/src/superio/smsc/lpc47n207/early_serial.c +++ b/src/superio/smsc/lpc47n207/early_serial.c @@ -57,7 +57,7 @@ outb(0x12, lpc_port); reg_value = inb(lpc_port + 1); if (reg_value != (lpc_port & 0xff)) - break; + break; outb(0x13, lpc_port); reg_value = inb(lpc_port + 1); -- To view, visit https://review.coreboot.org/c/coreboot/+/61473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0342e25747458239c1ad8c0f70f91f700ae8325d Gerrit-Change-Number: 61473 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: superio/smsc/lpc47n207/early_serial.c: Fix indent for 'if' statement
by Felix Held (Code Review) 31 Jan '22

31 Jan '22

Attention is currently required from: HAOUAS Elyes. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61473 ) Change subject: superio/smsc/lpc47n207/early_serial.c: Fix indent for 'if' statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0342e25747458239c1ad8c0f70f91f700ae8325d Gerrit-Change-Number: 61473 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 31 Jan 2022 13:56:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/psp: Add platform secure boot support
by Felix Held (Code Review) 31 Jan '22

31 Jan '22

Attention is currently required from: Jason Glenesk, Raul Rangel, ritul guru, Marshall Dawson, Paul Menzel, Angel Pons, Aamir Bohra. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60968 ) Change subject: soc/amd/common/block/psp: Add platform secure boot support ...................................................................... Patch Set 8: (2 comments) File src/soc/amd/common/block/psp/psb.c: https://review.coreboot.org/c/coreboot/+/60968/comment/06667c5a_ffba1d21 PS8, Line 221: printk(BIOS_NOTICE, "PSB is not Enabled.\n"); would "Enabling PSB failed.\n" be more precise? File src/soc/amd/common/block/psp/psp_def.h: https://review.coreboot.org/c/coreboot/+/60968/comment/d63f0ab8_5728f25f PS8, Line 25: #define MBOX_BIOS_CMD_PSB_AUTO_FUSING 0x21 this needs to be moved up above line 20, since this isn't a v1 psp mailbox command -- To view, visit https://review.coreboot.org/c/coreboot/+/60968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30aac29a22a5800d5995a78c50fdecd660a3d4eb Gerrit-Change-Number: 60968 Gerrit-PatchSet: 8 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-Reviewer: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Comment-Date: Mon, 31 Jan 2022 13:55:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/psp: add PSP command
by Felix Held (Code Review) 31 Jan '22

31 Jan '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Name of user not set #1004133, Al Hirani, Rob Barnes, Fred Reitberger. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61462 ) Change subject: soc/amd/common/block/psp: add PSP command ...................................................................... Patch Set 4: (3 comments) File src/soc/amd/common/block/psp/psp.c: PS4: this is psp gen 2 specific, so it needs to be moved to psp_gen2.c File src/soc/amd/common/block/psp/psp_def.h: https://review.coreboot.org/c/coreboot/+/61462/comment/07227d85_3152a89a PS4, Line 21: #define MBOX_BIOS_CMD_SET_SPL_FUSE 0x2d : #define MBOX_BIOS_CMD_QUERY_SPL_FUSE 0x47 those two should be above MBOX_BIOS_CMD_ABORT so that those are in ascending order https://review.coreboot.org/c/coreboot/+/61462/comment/53c7a4f5_9aa2e0ce PS4, Line 29: 10998 should this be 0x10998? -- To view, visit https://review.coreboot.org/c/coreboot/+/61462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0575356a7c6172e2e0f2eaf9d1a6706468fe92d Gerrit-Change-Number: 61462 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <fred.reitberger(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Name of user not set #1004133 Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Name of user not set #1004133 Gerrit-Attention: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Fred Reitberger <fred.reitberger(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 31 Jan 2022 13:52:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: psp_verstage: add new svc for cezanne
by Rob Barnes (Code Review) 31 Jan '22

31 Jan '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kangheui Won, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61368 ) Change subject: psp_verstage: add new svc for cezanne ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/vendorcode/amd/fsp/cezanne/include/bl_uapp/bl_syscall_public.h: https://review.coreboot.org/c/coreboot/+/61368/comment/be7dbdc4_22a8bdbb PS1, Line 53: #define SVC_SET_PLATFORM_BOOT_MODE 0x6C > 0x6B was allocated for svc_set_fw_hash_table (CB:60289). […] Ack https://review.coreboot.org/c/coreboot/+/61368/comment/cc32e120_26cac15c PS1, Line 144: CHROME_BOOK_BOOT_MODE_TYPE_MAX_LIMIT = 0x4, // used for boundary check > These types and enums come from header file in the PSP release. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/61368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6bcc9e49a2b73d486cfecd7b240bf989cad94630 Gerrit-Change-Number: 61368 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 31 Jan 2022 13:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org> Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/i82801dx: Add call i8259_setup()
by Kyösti Mälkki (Code Review) 31 Jan '22

31 Jan '22

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61465 ) Change subject: sb/intel/i82801dx: Add call i8259_setup() ...................................................................... sb/intel/i82801dx: Add call i8259_setup() Observed with aopen/dxplplusu that without SeaBIOS (using GRUB2 payload) Linux kernel panics. < [ 0.000000] Using NULL legacy PIC < [ 0.000000] NR_IRQS: 2304, nr_irqs: 1024, preallocated irqs: 0 ... < [ 0.000000] unexpected #NM exception: ffff [#1] SMP PTI versus > [ 0.000000] NR_IRQS: 2304, nr_irqs: 1024, preallocated irqs: 16 ... > [ 0.004000] Enabling APIC mode: Flat. Using 3 I/O APICs > [ 0.008000] ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=0 pin2=0 > [ 0.028000] tsc: Fast TSC calibration using PIT > [ 0.032000] tsc: Detected 3198.436 MHz processor Change-Id: I1beb93a8fd04697f259aefddfd369aa79e3359b7 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61465 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/southbridge/intel/i82801dx/lpc.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved diff --git a/src/southbridge/intel/i82801dx/lpc.c b/src/southbridge/intel/i82801dx/lpc.c index 34d93c4..bb38e1a 100644 --- a/src/southbridge/intel/i82801dx/lpc.c +++ b/src/southbridge/intel/i82801dx/lpc.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <arch/io.h> +#include <arch/ioapic.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> @@ -8,8 +10,7 @@ #include <option.h> #include <pc80/mc146818rtc.h> #include <pc80/isa-dma.h> -#include <arch/io.h> -#include <arch/ioapic.h> +#include <pc80/i8259.h> #include "chip.h" #include "i82801dx.h" @@ -273,6 +274,8 @@ /* Initialize the High Precision Event Timers */ enable_hpet(dev); + setup_i8259(); + /* Don't allow evil boot loaders, kernels, or * userspace applications to deceive us: */ -- To view, visit https://review.coreboot.org/c/coreboot/+/61465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1beb93a8fd04697f259aefddfd369aa79e3359b7 Gerrit-Change-Number: 61465 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: sb/intel/i82801dx: Add call i8259_setup()
by Werner Zeh (Code Review) 31 Jan '22

31 Jan '22

Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61465 ) Change subject: sb/intel/i82801dx: Add call i8259_setup() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1beb93a8fd04697f259aefddfd369aa79e3359b7 Gerrit-Change-Number: 61465 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 31 Jan 2022 10:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/**/Kconfig: Properly override `DISABLE_HECI1_AT_PRE_BOOT`
by Felix Held (Code Review) 31 Jan '22

31 Jan '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61478 ) Change subject: mb/**/Kconfig: Properly override `DISABLE_HECI1_AT_PRE_BOOT` ...................................................................... mb/**/Kconfig: Properly override `DISABLE_HECI1_AT_PRE_BOOT` Don't unconditionally override `DISABLE_HECI1_AT_PRE_BOOT`. Change-Id: I7d447e73f672877c76eecea1eb8b8f41f89ce686 Fixes: commit a0d9ad322fe603d4d4cbccda9c7edcfbf0b13409 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61478 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/fizz/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/kontron/bsl6/Kconfig 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index d9b73bb..3e2b8c1 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -23,9 +23,6 @@ select RT8168_SUPPORT_LEGACY_VPD_MAC select RT8168_SET_LED_MODE -config DISABLE_HECI1_AT_PRE_BOOT - default y - config BOARD_GOOGLE_FIZZ select BOARD_GOOGLE_BASEBOARD_FIZZ @@ -40,6 +37,9 @@ if BOARD_GOOGLE_BASEBOARD_FIZZ +config DISABLE_HECI1_AT_PRE_BOOT + default y + config IGNORE_IASL_MISSING_DEPENDENCY def_bool y diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index f87f8fd..68e4f71 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -21,9 +21,6 @@ select SOC_INTEL_SKYLAKE select SYSTEM_TYPE_LAPTOP -config DISABLE_HECI1_AT_PRE_BOOT - default y - config BOARD_GOOGLE_ASUKA select BOARD_GOOGLE_BASEBOARD_GLADOS select DRIVERS_GENERIC_MAX98357A @@ -78,6 +75,9 @@ if BOARD_GOOGLE_BASEBOARD_GLADOS +config DISABLE_HECI1_AT_PRE_BOOT + default y + config IGNORE_IASL_MISSING_DEPENDENCY def_bool y diff --git a/src/mainboard/kontron/bsl6/Kconfig b/src/mainboard/kontron/bsl6/Kconfig index 78e81c4..782f560 100644 --- a/src/mainboard/kontron/bsl6/Kconfig +++ b/src/mainboard/kontron/bsl6/Kconfig @@ -15,9 +15,6 @@ select MAINBOARD_HAS_LIBGFXINIT select DRIVERS_I2C_NCT7802Y -config DISABLE_HECI1_AT_PRE_BOOT - default y - config BOARD_KONTRON_BSL6 select BOARD_KONTRON_BSL6_COMMON select HAVE_ACPI_RESUME @@ -29,6 +26,9 @@ if BOARD_KONTRON_BSL6_COMMON +config DISABLE_HECI1_AT_PRE_BOOT + default y + config MAINBOARD_DIR default "kontron/bsl6" -- To view, visit https://review.coreboot.org/c/coreboot/+/61478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d447e73f672877c76eecea1eb8b8f41f89ce686 Gerrit-Change-Number: 61478 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/**/Kconfig: Properly override `IGNORE_IASL_MISSING_DEPENDENCY`
by Felix Held (Code Review) 31 Jan '22

31 Jan '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61477 ) Change subject: mb/**/Kconfig: Properly override `IGNORE_IASL_MISSING_DEPENDENCY` ...................................................................... mb/**/Kconfig: Properly override `IGNORE_IASL_MISSING_DEPENDENCY` Don't unconditionally override `IGNORE_IASL_MISSING_DEPENDENCY`. Change-Id: I02081d0f04be4af9cd765aa3b29295af40f9ca99 Fixes: commit 28fa297901ffd158631cfc9f562f38119eff628e Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61477 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/asus/h61-series/Kconfig M src/mainboard/google/auron/Kconfig M src/mainboard/google/beltino/Kconfig M src/mainboard/google/brya/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/dedede/Kconfig M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/drallion/Kconfig M src/mainboard/google/fizz/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/hatch/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/octopus/Kconfig M src/mainboard/google/poppy/Kconfig M src/mainboard/google/rambi/Kconfig M src/mainboard/google/reef/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/google/slippy/Kconfig M src/mainboard/google/volteer/Kconfig M src/mainboard/google/zork/Kconfig M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/jasperlake_rvp/Kconfig M src/mainboard/intel/kblrvp/Kconfig 26 files changed, 78 insertions(+), 97 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/asus/h61-series/Kconfig b/src/mainboard/asus/h61-series/Kconfig index 75dfe3c..48e4220 100644 --- a/src/mainboard/asus/h61-series/Kconfig +++ b/src/mainboard/asus/h61-series/Kconfig @@ -1,8 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_ASUS_H61_SERIES bool select HAVE_ACPI_RESUME @@ -17,6 +14,9 @@ if BOARD_ASUS_H61_SERIES +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config MAINBOARD_DIR default "asus/h61-series" diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index db52706..ead4c3b 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_AURON def_bool n select BOARD_ROMSIZE_KB_8192 @@ -48,6 +44,9 @@ if BOARD_GOOGLE_BASEBOARD_AURON +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index 15cc2c2..d6da71c 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_BELTINO def_bool n select BOARD_ROMSIZE_KB_8192 @@ -35,6 +31,9 @@ if BOARD_GOOGLE_BASEBOARD_BELTINO +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config VBOOT select VBOOT_VBNV_CMOS diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index e585f9f..34d9cba 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -1,6 +1,3 @@ -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BRYA_COMMON def_bool n select ALDERLAKE_A0_CONFIGURE_PMC_DESCRIPTOR @@ -65,6 +62,9 @@ if BOARD_GOOGLE_BRYA_COMMON +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config BASEBOARD_DIR string default "brya" if BOARD_GOOGLE_BASEBOARD_BRYA diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 19627d0..5feecf6 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_CYAN def_bool n select BOARD_ROMSIZE_KB_8192 @@ -58,6 +54,9 @@ if BOARD_GOOGLE_BASEBOARD_CYAN +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 61cb034..07b7bf1 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_DEDEDE def_bool n select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768 @@ -51,6 +47,9 @@ if BOARD_GOOGLE_BASEBOARD_DEDEDE +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config BASEBOARD_DEDEDE_LAPTOP def_bool n select SYSTEM_TYPE_LAPTOP diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index bd28c4e..492bcbb 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_DELTAUR def_bool n select BOARD_ROMSIZE_KB_32768 @@ -31,6 +27,9 @@ if BOARD_GOOGLE_BASEBOARD_DELTAUR +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config CHROMEOS select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select GBB_FLAG_FORCE_DEV_BOOT_ALTFW diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 3c2f484..5b33ed6 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_DRALLION def_bool n select BOARD_ROMSIZE_KB_32768 @@ -32,6 +28,9 @@ if BOARD_GOOGLE_BASEBOARD_DRALLION +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config CHROMEOS select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index 3abb1a6..d9b73bb 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_FIZZ def_bool n select BOARD_ROMSIZE_KB_16384 @@ -44,6 +40,9 @@ if BOARD_GOOGLE_BASEBOARD_FIZZ +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config DEVICETREE default "variants/baseboard/devicetree.cb" diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index a73b4b2..f87f8fd 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_GLADOS def_bool n select BOARD_ROMSIZE_KB_16384 @@ -82,6 +78,9 @@ if BOARD_GOOGLE_BASEBOARD_GLADOS +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index bc9d832..b2ce989 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -1,13 +1,13 @@ # SPDX-License-Identifier: GPL-2.0-or-later -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_GUYBRUSH def_bool n if BOARD_GOOGLE_BASEBOARD_GUYBRUSH +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config BOARD_SPECIFIC_OPTIONS def_bool y select AMD_SOC_CONSOLE_UART diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index d98882b..00376be 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -1,6 +1,3 @@ -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_HATCH_COMMON def_bool n select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768 @@ -153,6 +150,9 @@ if BOARD_GOOGLE_HATCH_COMMON +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config CHROMEOS select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if !ROMSTAGE_SPD_SMBUS select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index c05cb62..0724466 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_JECHT def_bool n select BOARD_ROMSIZE_KB_8192 @@ -30,6 +26,9 @@ if BOARD_GOOGLE_BASEBOARD_JECHT +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config VBOOT select VBOOT_VBNV_CMOS diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 12b6247..0f536b4 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -1,8 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_KAHLEE bool select SOC_AMD_STONEYRIDGE @@ -40,6 +37,9 @@ if BOARD_GOOGLE_BASEBOARD_KAHLEE +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config MAINBOARD_DIR default "google/kahlee" diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 9a677bc..840ce8e 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_OCTOPUS def_bool n select BOARD_ROMSIZE_KB_16384 @@ -101,6 +97,9 @@ if BOARD_GOOGLE_BASEBOARD_OCTOPUS +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config CHROMEOS_WIFI_SAR bool default y if CHROMEOS diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 4a1249a..e650628 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_POPPY def_bool n select BOARD_ROMSIZE_KB_16384 @@ -102,6 +98,9 @@ if BOARD_GOOGLE_BASEBOARD_POPPY +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config DISABLE_HECI1_AT_PRE_BOOT default y diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 6b83bf9..dfd66c0 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_RAMBI def_bool n select BOARD_ROMSIZE_KB_8192 @@ -96,6 +92,9 @@ if BOARD_GOOGLE_BASEBOARD_RAMBI +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index fce9c31..7b65f71 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_REEF def_bool n select BOARD_ROMSIZE_KB_16384 @@ -46,6 +42,9 @@ if BOARD_GOOGLE_BASEBOARD_REEF +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config DRIVER_TPM_I2C_BUS hex default 0x2 diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 6aaa7fd..81f1072 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -1,6 +1,3 @@ -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_SARIEN def_bool n select BOARD_ROMSIZE_KB_32768 @@ -39,6 +36,9 @@ if BOARD_GOOGLE_BASEBOARD_SARIEN +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config CHROMEOS select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index fb8ecff..0d0902c 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_SLIPPY def_bool n select BOARD_ROMSIZE_KB_8192 @@ -37,6 +33,9 @@ if BOARD_GOOGLE_BASEBOARD_SLIPPY +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select VBOOT_LID_SWITCH diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 6811926..eb8f176 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_VOLTEER def_bool n select BOARD_ROMSIZE_KB_32768 @@ -125,6 +121,9 @@ if BOARD_GOOGLE_BASEBOARD_VOLTEER +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config CHROMEOS select CHROMEOS_CSE_BOARD_RESET_OVERRIDE select CHROMEOS_DRAM_PART_NUMBER_IN_CBI diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index ac8a58a..96f40e4 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -1,8 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-or-later -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_GOOGLE_BASEBOARD_TREMBYLE def_bool n @@ -11,6 +8,9 @@ if BOARD_GOOGLE_BASEBOARD_TREMBYLE || BOARD_GOOGLE_BASEBOARD_DALBOZ +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config BOARD_SPECIFIC_OPTIONS def_bool y select SOC_AMD_COMMON_BLOCK_USE_ESPI diff --git a/src/mainboard/intel/adlrvp/Kconfig b/src/mainboard/intel/adlrvp/Kconfig index dfc63ef..1a9ed9e 100644 --- a/src/mainboard/intel/adlrvp/Kconfig +++ b/src/mainboard/intel/adlrvp/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_INTEL_ADLRVP_COMMON def_bool n select ALDERLAKE_A0_CONFIGURE_PMC_DESCRIPTOR @@ -77,6 +73,9 @@ if BOARD_INTEL_ADLRVP_COMMON +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config CHROMEOS select GBB_FLAG_FORCE_DEV_SWITCH_ON select GBB_FLAG_FORCE_DEV_BOOT_USB diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index 0005de3..a7a262f 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_INTEL_BASEBOARD_GLKRVP def_bool n select SOC_INTEL_GEMINILAKE @@ -19,6 +15,9 @@ if BOARD_INTEL_BASEBOARD_GLKRVP +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config BASEBOARD_GLKRVP_LAPTOP def_bool n select SYSTEM_TYPE_LAPTOP diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index 60cb824..6ae3566 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_INTEL_JASPERLAKE_RVP_COMMON def_bool n select BOARD_ROMSIZE_KB_16384 @@ -37,6 +33,9 @@ if BOARD_INTEL_JASPERLAKE_RVP_COMMON +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config DISABLE_HECI1_AT_PRE_BOOT default y diff --git a/src/mainboard/intel/kblrvp/Kconfig b/src/mainboard/intel/kblrvp/Kconfig index 69f49bf..11d1319 100644 --- a/src/mainboard/intel/kblrvp/Kconfig +++ b/src/mainboard/intel/kblrvp/Kconfig @@ -1,7 +1,3 @@ - -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_INTEL_KBLRVP_COMMON def_bool n select BOARD_ROMSIZE_KB_16384 @@ -35,6 +31,9 @@ if BOARD_INTEL_KBLRVP_COMMON +config IGNORE_IASL_MISSING_DEPENDENCY + def_bool y + config DISABLE_HECI1_AT_PRE_BOOT default y -- To view, visit https://review.coreboot.org/c/coreboot/+/61477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02081d0f04be4af9cd765aa3b29295af40f9ca99 Gerrit-Change-Number: 61477 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022