coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: soc/intel/common/cse: Implement HECI notify
by Subrata Banik (Code Review) 30 Jan '22

30 Jan '22

Attention is currently required from: Arthur Heymans, Felix Singer, Tim Wawrzynczak, Sridhar Siricilla, Angel Pons, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60405 ) Change subject: soc/intel/common/cse: Implement HECI notify ...................................................................... Patch Set 15: (1 comment) File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/60405/comment/ce8dd192_ce4ebae2 PS15, Line 246: send_end_of_post_to_cse > As per ME BWG, BIOS should avoid sending EOP command during S3 resume. We should have check here to skip sending the EOP command. We can address it in separate CL. @Sridhar, Please note two things 1. This CL doesn't change the behaviour of sending EOP. It just add additional operations for lock config and D0i3. 2. Please take a look into https://github.com/coreboot/coreboot/blob/master/src/lib/hardwaremain.c#L195, ramstage boot state machine. BS_PAYLOAD_BOOT and BS_PAYLOAD_LOAD states are not in scope of S3 resume. Upon S3 resume, the control will transfer to payload from BS_OS_RESUME /bs_os_resume () https://github.com/coreboot/coreboot/blob/master/src/lib/hardwaremain.c#L174 which is prior to BS_PAYLOAD_BOOT and BS_PAYLOAD_LOAD. Hopefully, I'm able to clarify the basics of coreboot. -- To view, visit https://review.coreboot.org/c/coreboot/+/60405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70bde33f77026e8be165ff082defe3cab6686ec7 Gerrit-Change-Number: 60405 Gerrit-PatchSet: 15 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sun, 30 Jan 2022 12:51:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/cse: Implement HECI notify
by Sridhar Siricilla (Code Review) 30 Jan '22

30 Jan '22

Attention is currently required from: Arthur Heymans, Felix Singer, Subrata Banik, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60405 ) Change subject: soc/intel/common/cse: Implement HECI notify ...................................................................... Patch Set 15: (1 comment) File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/60405/comment/eb7e2064_6d44b550 PS15, Line 246: send_end_of_post_to_cse As per ME BWG, BIOS should avoid sending EOP command during S3 resume. We should have check here to skip sending the EOP command. We can address it in separate CL. -- To view, visit https://review.coreboot.org/c/coreboot/+/60405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70bde33f77026e8be165ff082defe3cab6686ec7 Gerrit-Change-Number: 60405 Gerrit-PatchSet: 15 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sun, 30 Jan 2022 12:19:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake: Drop unnecessary guard for HECI1 disable FSP UPD
by Sridhar Siricilla (Code Review) 30 Jan '22

30 Jan '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph, EricR Lai. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61455 ) Change subject: soc/intel/cannonlake: Drop unnecessary guard for HECI1 disable FSP UPD ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/cannonlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/61455/comment/93f4f52f_4c8a07ff PS3, Line 589: Heci1 > > Writing Heci1 in the code should be ok, but comment should be HECI1! WDYT? […] >Don't know about any rule thats support this argument "Writing Heci1 in the code should be ok, but comment should be HECI1!". If you are specific about following the acronym then why not adhere the same all across in my point. Agree with you, we should maintain consistency across all places to avoid confusion. As you know coding rules applicable when choosing a identifier name, hence heci1 (but I mentioned Heci1 😞 ) usage should be fine in the code. IMO, heci or HECI (good to refer) should be fine in the comments, but Heci1 is something not preferable over others! >Also, if I just look for your recommendation then also there are ample conflicts. I would prefer to have action that unifies those as well. Once your patches are landed in the upstream, I will push CL to update the references to words "Heci" and "heci". -- To view, visit https://review.coreboot.org/c/coreboot/+/61455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8908c080ca9991e7a71e795ccb8fc76d99514f8 Gerrit-Change-Number: 61455 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sun, 30 Jan 2022 12:14:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/samsung/exynos5420: Remove unuseful 'return' in void function
by HAOUAS Elyes (Code Review) 30 Jan '22

30 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61491 ) Change subject: soc/samsung/exynos5420: Remove unuseful 'return' in void function ...................................................................... soc/samsung/exynos5420: Remove unuseful 'return' in void function Change-Id: I6c093e8326733a079ab3c41dfd2c77fe1883a9d4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/samsung/exynos5420/dp_lowlevel.c 1 file changed, 0 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/61491/1 diff --git a/src/soc/samsung/exynos5420/dp_lowlevel.c b/src/soc/samsung/exynos5420/dp_lowlevel.c index b6d9e0b..6144544 100644 --- a/src/soc/samsung/exynos5420/dp_lowlevel.c +++ b/src/soc/samsung/exynos5420/dp_lowlevel.c @@ -49,8 +49,6 @@ reg |= VIDEO_EN_MASK; lwrite32(reg, &dp_regs->video_ctl1); - - return; } void exynos_dp_disable_video_bist(void) @@ -71,8 +69,6 @@ reg |= VIDEO_MUTE_MASK; lwrite32(reg, &dp_regs->video_ctl1); - - return; } static void exynos_dp_init_analog_param(void) @@ -174,8 +170,6 @@ exynos_dp_init_analog_param(); exynos_dp_init_interrupt(); - - return; } void exynos_dp_enable_sw_func(unsigned int enable) @@ -189,8 +183,6 @@ reg |= SW_FUNC_EN_N; lwrite32(reg, &dp_regs->func_en1); - - return; } unsigned int exynos_dp_set_analog_power_down(unsigned int block, u32 enable) @@ -336,8 +328,6 @@ reg = lread32(&dp_regs->sys_ctl3); reg &= ~(F_HPD | HPD_CTRL); lwrite32(reg, &dp_regs->sys_ctl3); - - return; } static inline void exynos_dp_reset_aux(void) @@ -348,8 +338,6 @@ reg = lread32(&dp_regs->func_en2); reg |= AUX_FUNC_EN_N; lwrite32(reg, &dp_regs->func_en2); - - return; } void exynos_dp_init_aux(void) @@ -375,8 +363,6 @@ reg = lread32(&dp_regs->func_en2); reg &= ~AUX_FUNC_EN_N; lwrite32(reg, &dp_regs->func_en2); - - return; } void exynos_dp_config_interrupt(void) @@ -398,8 +384,6 @@ reg = INT_STA_MASK; lwrite32(reg, &dp_regs->int_sta_mask); - - return; } unsigned int exynos_dp_get_plug_in_status(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/61491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c093e8326733a079ab3c41dfd2c77fe1883a9d4 Gerrit-Change-Number: 61491 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/nvidia/tegra124/sor.c: Remove unuseful 'return' in void function
by HAOUAS Elyes (Code Review) 30 Jan '22

30 Jan '22

Attention is currently required from: Julius Werner. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61490 ) Change subject: soc/nvidia/tegra124/sor.c: Remove unuseful 'return' in void function ...................................................................... soc/nvidia/tegra124/sor.c: Remove unuseful 'return' in void function Change-Id: I8539eb9028f3141dfbeb926a1e19e3ad94be3edf Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/nvidia/tegra124/sor.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/61490/1 diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c index 2cf16b0..9e56c68 100644 --- a/src/soc/nvidia/tegra124/sor.c +++ b/src/soc/nvidia/tegra124/sor.c @@ -581,8 +581,6 @@ DUMP_REG(NV_SOR_DP_SPARE(0)); DUMP_REG(NV_SOR_DP_SPARE(1)); DUMP_REG(NV_SOR_DP_TPG); - - return; } #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/61490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8539eb9028f3141dfbeb926a1e19e3ad94be3edf Gerrit-Change-Number: 61490 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/nvidia/tegra210/sor.c: Remove unuseful 'return' in void function
by HAOUAS Elyes (Code Review) 30 Jan '22

30 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61489 ) Change subject: soc/nvidia/tegra210/sor.c: Remove unuseful 'return' in void function ...................................................................... soc/nvidia/tegra210/sor.c: Remove unuseful 'return' in void function Change-Id: Ifaaf8a240436758a83216037994493255935f158 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/nvidia/tegra210/sor.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/61489/1 diff --git a/src/soc/nvidia/tegra210/sor.c b/src/soc/nvidia/tegra210/sor.c index 9b50d93..fe89d14 100644 --- a/src/soc/nvidia/tegra210/sor.c +++ b/src/soc/nvidia/tegra210/sor.c @@ -579,8 +579,6 @@ DUMP_REG(NV_SOR_DP_SPARE(0)); DUMP_REG(NV_SOR_DP_SPARE(1)); DUMP_REG(NV_SOR_DP_TPG); - - return; } #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/61489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifaaf8a240436758a83216037994493255935f158 Gerrit-Change-Number: 61489 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/rockchip/rk3399/display.c: Remove unuseful 'return' in void function
by HAOUAS Elyes (Code Review) 30 Jan '22

30 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61488 ) Change subject: soc/rockchip/rk3399/display.c: Remove unuseful 'return' in void function ...................................................................... soc/rockchip/rk3399/display.c: Remove unuseful 'return' in void function Change-Id: I8b5537bb6d0cb934aadb0eba8ba4f51dd53026c2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/rockchip/rk3399/display.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/61488/1 diff --git a/src/soc/rockchip/rk3399/display.c b/src/soc/rockchip/rk3399/display.c index 1d263ef..c300726 100644 --- a/src/soc/rockchip/rk3399/display.c +++ b/src/soc/rockchip/rk3399/display.c @@ -162,6 +162,4 @@ } mainboard_power_on_backlight(); fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)0); - - return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/61488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5537bb6d0cb934aadb0eba8ba4f51dd53026c2 Gerrit-Change-Number: 61488 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/qualcomm/ipq40xx/spi.c: Remove unuseful 'return' in void function
by HAOUAS Elyes (Code Review) 30 Jan '22

30 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61487 ) Change subject: soc/qualcomm/ipq40xx/spi.c: Remove unuseful 'return' in void function ...................................................................... soc/qualcomm/ipq40xx/spi.c: Remove unuseful 'return' in void function Change-Id: I0ca7cbbf6c4884b58b4ec8a8e3cbc77f118a42f2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/qualcomm/ipq40xx/spi.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/61487/1 diff --git a/src/soc/qualcomm/ipq40xx/spi.c b/src/soc/qualcomm/ipq40xx/spi.c index 31677e4..0893dfc 100644 --- a/src/soc/qualcomm/ipq40xx/spi.c +++ b/src/soc/qualcomm/ipq40xx/spi.c @@ -298,7 +298,6 @@ clrsetbits32(ds->regs->io_control, SPI_IO_CTRL_FORCE_CS_MSK, SPI_IO_CTRL_FORCE_CS_DIS); - return; } /* @@ -372,7 +371,6 @@ QUP_CONF_INPUT_MSK, QUP_CONF_NO_INPUT); } - return; } /* -- To view, visit https://review.coreboot.org/c/coreboot/+/61487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ca7cbbf6c4884b58b4ec8a8e3cbc77f118a42f2 Gerrit-Change-Number: 61487 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/xeon_sp/acpi.c: Remove unuseful 'return' in void function
by HAOUAS Elyes (Code Review) 30 Jan '22

30 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61486 ) Change subject: soc/intel/xeon_sp/acpi.c: Remove unuseful 'return' in void function ...................................................................... soc/intel/xeon_sp/acpi.c: Remove unuseful 'return' in void function Change-Id: Ib964939468ebb8cd0a537d514060ee5b8b13e320 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/xeon_sp/acpi.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/61486/1 diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index de9db88..0e7f6a5 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -93,7 +93,6 @@ printk(BIOS_DEBUG, "Adding MADT IOAPIC for socket: %d, stack: %d, ioapic_id: 0x%x, " "ioapic_base: 0x%x, gsi_base: 0x%x\n", socket, stack, ioapic_id, ioapic_base, gsi_base); - return; } const struct madt_ioapic_info *soc_get_ioapic_info(size_t *entries) -- To view, visit https://review.coreboot.org/c/coreboot/+/61486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib964939468ebb8cd0a537d514060ee5b8b13e320 Gerrit-Change-Number: 61486 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: sb/amd/cimx/sb800/fan.c: Remove unuseful 'return' in void function
by HAOUAS Elyes (Code Review) 30 Jan '22

30 Jan '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61485 ) Change subject: sb/amd/cimx/sb800/fan.c: Remove unuseful 'return' in void function ...................................................................... sb/amd/cimx/sb800/fan.c: Remove unuseful 'return' in void function Change-Id: I458ff53bb9ae3a6c1003ee857b61fb350152cc86 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/amd/cimx/sb800/fan.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/61485/1 diff --git a/src/southbridge/amd/cimx/sb800/fan.c b/src/southbridge/amd/cimx/sb800/fan.c index bbba3fa..f5e0a48 100644 --- a/src/southbridge/amd/cimx/sb800/fan.c +++ b/src/southbridge/amd/cimx/sb800/fan.c @@ -280,6 +280,4 @@ sb_config.StdHeader.Func = SB_EC_FANCONTROL; AmdSbDispatcher(&sb_config); - - return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/61485 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I458ff53bb9ae3a6c1003ee857b61fb350152cc86 Gerrit-Change-Number: 61485 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022