Attention is currently required from: Tristan Corrick, Idwer Vollering.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61476 )
Change subject: isolate leaking config directive from src/mainboard/asus/h61-series/Kconfig
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
> This isn't the only board affected by this, I'll make a patch to fix the problem for all boards.
See CB:61477
--
To view, visit https://review.coreboot.org/c/coreboot/+/61476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6fd24923dd8d36adbe861515ce6c903697ef90d
Gerrit-Change-Number: 61476
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 17:23:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Tristan Corrick, Idwer Vollering.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61476 )
Change subject: isolate leaking config directive from src/mainboard/asus/h61-series/Kconfig
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This isn't the only board affected by this, I'll make a patch to fix the problem for all boards.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6fd24923dd8d36adbe861515ce6c903697ef90d
Gerrit-Change-Number: 61476
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 17:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61476 )
Change subject: isolate leaking config directive from src/mainboard/asus/h61-series/Kconfig
......................................................................
isolate leaking config directive from src/mainboard/asus/h61-series/Kconfig
While building coreboot for asus/f2a85-m, the build system shows IASL warnings that have been already taken care of.
The error was: '*** WARNING: The ASL code for this platform is incomplete. Please fix it. ***'
Change-Id: Ie6fd24923dd8d36adbe861515ce6c903697ef90d
Signed-off-by: Idwer Vollering <vidwer(a)gmail.com>
---
M src/mainboard/asus/h61-series/Kconfig
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/61476/1
diff --git a/src/mainboard/asus/h61-series/Kconfig b/src/mainboard/asus/h61-series/Kconfig
index 75dfe3c..48e4220 100644
--- a/src/mainboard/asus/h61-series/Kconfig
+++ b/src/mainboard/asus/h61-series/Kconfig
@@ -1,8 +1,5 @@
## SPDX-License-Identifier: GPL-2.0-only
-config IGNORE_IASL_MISSING_DEPENDENCY
- def_bool y
-
config BOARD_ASUS_H61_SERIES
bool
select HAVE_ACPI_RESUME
@@ -17,6 +14,9 @@
if BOARD_ASUS_H61_SERIES
+config IGNORE_IASL_MISSING_DEPENDENCY
+ def_bool y
+
config MAINBOARD_DIR
default "asus/h61-series"
--
To view, visit https://review.coreboot.org/c/coreboot/+/61476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6fd24923dd8d36adbe861515ce6c903697ef90d
Gerrit-Change-Number: 61476
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: HAOUAS Elyes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59880 )
Change subject: IASL: Ignore IASL's "Missing dependency" warning
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9:
Idwer mentioned a spurious warning for asus/f2a85-m.
File src/mainboard/asus/h61-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/59880/comment/b798ec3d_c2cced81
PS9, Line 4: def_bool y
This leaks to all Asus boards, I guess?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59880
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28b437194f08232727623009372327fec15215dd
Gerrit-Change-Number: 59880
Gerrit-PatchSet: 9
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 29 Jan 2022 15:14:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Sridhar Siricilla, Angel Pons, Nick Vaccaro, Werner Zeh, Patrick Rudolph, EricR Lai.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61453 )
Change subject: soc/intel/elkhartlake: Use SBI msg to disable HECI1
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61453
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ef7ff7aa234ce411092d70bcb2c9141609be90e
Gerrit-Change-Number: 61453
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 15:08:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment