coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: soc/intel/alderlake: Clear RTC_BATTERY_DEAD
by Tim Wawrzynczak (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Angel Pons, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56617 ) Change subject: soc/intel/alderlake: Clear RTC_BATTERY_DEAD ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: ping -- To view, visit https://review.coreboot.org/c/coreboot/+/56617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc21c19ea8ce561e9655e189ec26aba7a07967e Gerrit-Change-Number: 56617 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:26:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel: Add new Kconfig INTEL_ALLOW_SOC_DEBUG_HOOKS
by Tim Wawrzynczak (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Julius Werner, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56726 ) Change subject: soc/intel: Add new Kconfig INTEL_ALLOW_SOC_DEBUG_HOOKS ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: ping -- To view, visit https://review.coreboot.org/c/coreboot/+/56726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0e7f076bb7e3b630c3ab9d28071312d3e21e927 Gerrit-Change-Number: 56726 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:25:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/taeko: Add initial fw config for taeko
by Tim Wawrzynczak (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Joey Peng, Paul Menzel, YH Lin. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57332 ) Change subject: mb/google/brya/variants/taeko: Add initial fw config for taeko ...................................................................... Patch Set 7: (5 comments) File src/mainboard/google/brya/variants/taeko/overridetree.cb: https://review.coreboot.org/c/coreboot/+/57332/comment/b7b6df3d_cb022236 PS7, Line 1: fw_config : field KB_BL 4 4 : option KB_BL_ABSENT 0 : option KB_BL_PRESENT 1 : end : field AUDIO 5 7 : option AUDIO_UNKNOWN 0 : option MAX98357_ALC5682I_I2S 1 : end : field BOOT_DEVICE_EMMC 12 12 : option BOOT_EMMC_DISABLED 0 : option BOOT_EMMC_ENABLED 1 : end : field BOOT_DEVICE_NVME 13 13 : option BOOT_NVME_DISABLED 0 : option BOOT_NVME_ENABLED 1 : end : end From config.star, I think the fw_config section should look like this: ``` fw_config field DB_USB 0 1 option DB_USB_ABSENT 0 option DB_USB3_NO_A 1 end field DB_SD 2 3 option DB_SD_ABSENT 0 option DB_SD_OZ711LV2LN 1 end field KB_BL 4 option KB_BL_ABSENT 0 option KB_BL_PRESENT 1 end field AUDIO 5 7 option AUDIO_UNKNOWN 0 option AUDIO_MAX98357_ALC5682I_I2S 1 end field KB_LAYOUT 8 9 option KB_LAYOUT_DEFAULT 0 end field WIFI_SAR_ID 10 11 option WIFI_SAR_ID_0 0 option WIFI_SAR_ID_1 1 option WIFI_SAR_ID_2 2 option WIFI_SAR_ID_3 3 end field BOOT_NVME_MASK 12 option BOOT_NVME_DISABLED 0 option BOOT_NVME_ENABLED 1 end field BOOT_EMMC_MASK 13 option BOOT_EMMC_DISABLED 0 option BOOT_EMMC_ENABLED 1 end end ``` https://review.coreboot.org/c/coreboot/+/57332/comment/609a6fc4_8c7a153f PS7, Line 172: end Looks like you'll also need a soundwire FW_CONFIG option for AUDIO https://review.coreboot.org/c/coreboot/+/57332/comment/d3f21299_0613723a PS7, Line 193: `probe DB_SD DB_SD_PRESENT` https://review.coreboot.org/c/coreboot/+/57332/comment/bd3cd4c0_a33ee5c0 PS7, Line 247: chip drivers/usb/acpi : register "desc" = ""USB3 Type-C Port C1 (DB)"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(3, 1)" : device ref tcss_usb3_port3 on end You need a FW_CONFIG DB_USB for this one as well (is it the same one that has the Type-A port ?) https://review.coreboot.org/c/coreboot/+/57332/comment/ec8cde01_6b0ba16a PS7, Line 294: This would seem to depend on a probe for options that don't exist yet... the only DB_USB options are ABSENT and NO_A, so I think you need a DB_USB option for the DB that has the Type-A port. -- To view, visit https://review.coreboot.org/c/coreboot/+/57332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifef750338d777b76e9710d6bca9a166120db6a0a Gerrit-Change-Number: 57332 Gerrit-PatchSet: 7 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:22:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Update debug message to callout the reason for failure
by Tim Wawrzynczak (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Subrata Banik, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57337 ) Change subject: arch/x86: Update debug message to callout the reason for failure ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/57337/comment/821a5357_cfbb55f4 PS1, Line 770: \ just remove this character, the two strings being next to each other will automatically be concatenated by the compiler -- To view, visit https://review.coreboot.org/c/coreboot/+/57337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I288593b3f78ab858bf66c689e7cfb6ba2ff746d0 Gerrit-Change-Number: 57337 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:11:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Skip returning default leaf value as `0`
by Tim Wawrzynczak (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Subrata Banik, Angel Pons, Kyösti Mälkki. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57305 ) Change subject: arch/x86: Skip returning default leaf value as `0` ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Gerrit-Change-Number: 57305 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:10:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/gooey: Add MT53E512M32D1NP-046 as supported mem ...
by Paul Fagerburg (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Henry Sun, Stanley Wu, Karthik Ramasubramanian. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57310 ) Change subject: mb/google/dedede/var/gooey: Add MT53E512M32D1NP-046 as supported mem module ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b83126a2bf98bb9d0ca05d397c288e0d99ed781 Gerrit-Change-Number: 57310 Gerrit-PatchSet: 2 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:09:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/adlrvp: Add new ADL P board variant for MCHP1727
by Tim Wawrzynczak (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Brandon Breitenstein. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56839 ) Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727 ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169 Gerrit-Change-Number: 56839 Gerrit-PatchSet: 8 Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:07:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: wifi: Add support for wifi time average SAR config
by Tim Wawrzynczak (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57061 ) Change subject: wifi: Add support for wifi time average SAR config ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/57061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42cf3cba7974e6db0e05de30846ef103a15fd584 Gerrit-Change-Number: 57061 Gerrit-PatchSet: 9 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:05:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/abuild: don't select ADD_FSP_BINARIES
by Felix Held (Code Review) 02 Sep '21

02 Sep '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57344 ) Change subject: util/abuild: don't select ADD_FSP_BINARIES ...................................................................... util/abuild: don't select ADD_FSP_BINARIES Selecting ADD_FSP_BINARIES breaks the build for chipsets that rely on FSP for parts of the hardware initialization, but don't have the FSP binaries available yet. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I60c426d759ec36aac554f4e7bdbda0de0c462d97 --- M util/abuild/abuild 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/57344/1 diff --git a/util/abuild/abuild b/util/abuild/abuild index 407c3f1..92bb255 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -731,7 +731,7 @@ shift;; -B|--blobs) shift customizing="${customizing}, blobs" - configoptions="${configoptions}CONFIG_USE_AMD_BLOBS=y\nCONFIG_USE_QC_BLOBS=y\nCONFIG_ADD_FSP_BINARIES=y\n" + configoptions="${configoptions}CONFIG_USE_AMD_BLOBS=y\nCONFIG_USE_QC_BLOBS=y\n" ;; -A|--any-toolchain) shift customizing="${customizing}, any-toolchain" -- To view, visit https://review.coreboot.org/c/coreboot/+/57344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60c426d759ec36aac554f4e7bdbda0de0c462d97 Gerrit-Change-Number: 57344 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/fsp2_0/Makefile: add condition for FSP-T CBFS file
by Felix Held (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Andrey Petrov, Patrick Rudolph. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57220 ) Change subject: drivers/intel/fsp2_0/Makefile: add condition for FSP-T CBFS file ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: rebased this one onto current top of tree and will put the rest of the patch series on top of this one once i've had a closer look what caused the jenkins build to break after the other patch -- To view, visit https://review.coreboot.org/c/coreboot/+/57220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id347336f2751c6d871f31d89c30a1222037c2d69 Gerrit-Change-Number: 57220 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 02 Sep 2021 15:54:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021