Attention is currently required from: Raul Rangel, Marshall Dawson, Paul Menzel, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56814 )
Change subject: soc/amd/common/block/spi: introduce SOC_AMD_COMMON_BLOCK_SPI_4DW_BURST
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56814/comment/6d49cd70_4adb2448
PS1, Line 13: On Stoneyridge this
: feature is broken
> Is that documented in some Errata document?
It's documented in the stoney ridge BKDG that this bit should be set to 0.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56814
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id754fa8d5f9554ed25cf9f3341bfdd1968693788
Gerrit-Change-Number: 56814
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 05 Aug 2021 22:58:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Marshall Dawson, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56814 )
Change subject: soc/amd/common/block/spi: introduce SOC_AMD_COMMON_BLOCK_SPI_4DW_BURST
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56814/comment/18d92713_2c0074a7
PS1, Line 13: On Stoneyridge this
: feature is broken
> Is that documented in some Errata document?
reworded that part of the commit message and added a reference to public documentation
--
To view, visit https://review.coreboot.org/c/coreboot/+/56814
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id754fa8d5f9554ed25cf9f3341bfdd1968693788
Gerrit-Change-Number: 56814
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 22:49:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Marshall Dawson, Felix Held.
Hello Jason Glenesk, build bot (Jenkins), Raul Rangel, Marshall Dawson, Paul Menzel, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56814
to look at the new patch set (#2).
Change subject: soc/amd/common/block/spi: introduce SOC_AMD_COMMON_BLOCK_SPI_4DW_BURST
......................................................................
soc/amd/common/block/spi: introduce SOC_AMD_COMMON_BLOCK_SPI_4DW_BURST
Add a new Kconfig option to enable or disable the 4 DWORD burst support
of the SPI controller and use this setting to determine if the
corresponding feature bit in SPI100_HOST_PREF_CONFIG will be set or
cleared. Since fch_spi_disable_4dw_burst can now enable or disable the
feature, rename it to fch_spi_configure_4dw_burst. On Stoneyridge the
SPI_RD4DW_EN_HOST bit needs to be cleared (see the Rd4dw_en_host bit
definition in the SPIx2C SPI100 Host Prefetch Config register in the
public BKDG #55072 Rev 3.09), so add a SoC dependency to the Kconfig
option.
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Id754fa8d5f9554ed25cf9f3341bfdd1968693788
---
M src/soc/amd/common/block/spi/Kconfig
M src/soc/amd/common/block/spi/fch_spi.c
2 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/56814/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56814
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id754fa8d5f9554ed25cf9f3341bfdd1968693788
Gerrit-Change-Number: 56814
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: zanxi chen, Bob Moragues.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56384 )
Change subject: mb/google/trogdor: Add new variant Wormdingler
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3d9662e8725e30e1308d77b05545efbee29f846
Gerrit-Change-Number: 56384
Gerrit-PatchSet: 7
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Bob Moragues <moragues(a)chromium.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 22:42:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Diana Zigterman, Jason Glenesk, Nikolai Vyssotski, Rob Barnes.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55434 )
Change subject: mb/google/guybrush: Enable STT in device tree
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I'll defer to Diana or Rob.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37b5da1b56586ef75ad17f6766cd00ddac87aa5a
Gerrit-Change-Number: 55434
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Diana Zigterman <dzigterman(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Diana Zigterman <dzigterman(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 22:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56759 )
Change subject: mb/*/jslrvp/dedede: Remove hardcoding of BSP APIC ID
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
chipset.cb would be a nice place to put the `cpu_cluster` device for JSL
--
To view, visit https://review.coreboot.org/c/coreboot/+/56759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I726d70b4ffc35a28a654abbd20c866f1410e1aee
Gerrit-Change-Number: 56759
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 22:24:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56758 )
Change subject: soc/intel/common/cpu: Handle non-zero BSP APIC ID in init_cpus
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56758
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib14a5c31b3afb0d773284c684bd1994a78b94445
Gerrit-Change-Number: 56758
Gerrit-PatchSet: 9
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 22:23:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Michael Büchler has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56838 )
Change subject: mb/acer/g43t-am3: Add documentation
......................................................................
mb/acer/g43t-am3: Add documentation
Signed-off-by: Michael Büchler <michael.buechler(a)posteo.net>
Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53
---
A Documentation/mainboard/acer/g43t-am3.md
M Documentation/mainboard/index.md
2 files changed, 133 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/56838/1
diff --git a/Documentation/mainboard/acer/g43t-am3.md b/Documentation/mainboard/acer/g43t-am3.md
new file mode 100644
index 0000000..a6b20b2
--- /dev/null
+++ b/Documentation/mainboard/acer/g43t-am3.md
@@ -0,0 +1,129 @@
+# Acer G43T-AM3
+
+The Acer G43T-AM3 is a microATX-sized desktop board. It was used for the Acer models Aspire M3800, Aspire M5800 and possibly more.
+
+## Technology
+
+```eval_rst
++------------------+--------------------------------------------------+
+| Northbridge | Intel G43 (called x4x in coreboot code) |
++------------------+--------------------------------------------------+
+| Southbridge | Intel ICH10R (called i82801jx in coreboot code) |
++------------------+--------------------------------------------------+
+| CPU socket | LGA 775 |
++------------------+--------------------------------------------------+
+| RAM | 4 x DDR3-1066 |
++------------------+--------------------------------------------------+
+| SuperIO | ITE IT8720F |
++------------------+--------------------------------------------------+
+| Audio | Realtek ALC888S |
++------------------+--------------------------------------------------+
+| Network | Intel 82567V-2 Gigabit Ethernet |
++------------------+--------------------------------------------------+
+```
+
+There is no serial port. Serial console output is possible by soldering to a point at the corresponding Super I/O pin and patching the mainboard-specific code accordingly.
+
+## Status
+
+### Working
+
++ Intel Core 2 processors at up to FSB 1333
++ All four DIMM slots at 1066 MHz (tested 2x2GB + 2x4GB)
++ Integrated graphics (libgfxinit)
++ HDMI and VGA ports
++ Both PCI slots
++ Both PCI-e slots
++ USB (8 internal, 4 external)
++ All six SATA ports
++ Onboard Ethernet
++ Onboard sound card with output on the rear stereo connector
++ PS/2 mouse and keyboard (needs CONFIG_SEABIOS_PS2_TIMEOUT, tested: 500)
++ Temperature readings from the Super I/O (including the CPU temperature via PECI)
++ Super I/O EC automatic fan control
++ S3 suspend/resume
++ Poweroff
+
+### Not working
+
++ DDR3 memory with 512Mx8 chips (G43 limitation)
++ 4x4GB of DDR3 memory (works, but showed a single bit error within one pass of Memtest86+ 5.01)
++ Super I/O voltage reading conversions
+
+### Untested
+
++ Other audio jacks or the front panel header
++ S/PDIF output
++ On-board Firewire
++ Wake-on-LAN
+
+## Flashing coreboot
+
+```eval_rst
++-------------------+---------------------+
+| Type | Value |
++===================+=====================+
+| Socketed flash | No |
++-------------------+---------------------+
+| Model | Macronix MX25L1605D |
++-------------------+---------------------+
+| Size | 2 MiB |
++-------------------+---------------------+
+| Package | 8-Pin SOP |
++-------------------+---------------------+
+| Write protection | No |
++-------------------+---------------------+
+| Dual BIOS feature | No |
++-------------------+---------------------+
+| Internal flashing | Yes |
++-------------------+---------------------+
+```
+
+The flash is divided into the following regions, as obtained with `ifdtool -f rom.layout backup.rom`:
+```
+00000000:00001fff fd
+00100000:001fffff bios
+00006000:000fffff me
+00002000:00005fff gbe
+```
+
+### Internal flashing
+
+It should be possible to flash the firmware internally. Do a full backup first. Only flash the BIOS region by specifying `--ifd` and `-i` parameters when calling flashrom. You might have to specify the chip type; both `-c MX25L1605D/MX25L1608D/MX25L1673E` and `-c MX25L1605` should work.
+
+```bash
+flashrom -p internal -r backup.rom
+flashrom -p internal --ifd -i bios -w coreboot.rom
+```
+
+```eval_rst
+In addition to the information here, please see the
+:doc:`../../flash_tutorial/index`.
+```
+
+### External flashing
+
+The SPI flash chip on this board can be flashed externally through the SPI_ROM1 header while the board is off and disconnected from power. There seems to be a diode that prevents you from powering the whole board with your external programmer.
+
+The signal assigment on the header is identical to the pinout of the flash chip. The pinout diagram below is valid when the PCI slots are on the left and the CPU is on the right. Note that HOLD# and WP# must be pulled high (to VCC) to be able to flash the chip.
+
+```
+ +---+---+
+ SPI_CSn <- | x | x | -> VCC
+ +---+---+
+ SPI_MISO <- | x | x | -> HOLDn
+ +---+---+
+ WPn <- | x | x | -> SPI_CLK
+ +---+---+
+ GND <- | x | x | -> SPI_MOSI
+ +---+---+
+```
+
+## Fan control
+
+There are two fan connectors that can be controlled individually. CPU_FAN can be controlled only by PWM and SYS_FAN only by voltage. See the mainboard's `devicetree.cb` file for how coreboot configures the Super I/O to control the fans.
+
+## Variants
+
+Various similar mainboards exist, like the Acer Q45T-AM.
+During a discussion in #coreboot on IRC, ECS was suspected to be the original designer of this series of mainboards. They have similar models such as the ECS G43T-WM.
diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md
index 2e1d294..96a2ec4 100644
--- a/Documentation/mainboard/index.md
+++ b/Documentation/mainboard/index.md
@@ -6,6 +6,10 @@
- [X210](51nb/x210.md)
+## Acer
+
+- [G43T-AM3](acer/g43t-am3.md)
+
## AMD
- [padmelon](amd/padmelon/padmelon.md)
--
To view, visit https://review.coreboot.org/c/coreboot/+/56838
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53
Gerrit-Change-Number: 56838
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-MessageType: newchange